[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureCoreDxe: fix Redfish event issue.

RedfishFeatureDriverStartup is callback function at TPL_CALLBACK level. In this function, Redfish events are signaled. However, Redfish events are created in TPL_CALLBACK level too. As the result, Redfish events cannot be invoked in desired sequence. Decrease the TPL to TPL_APPLICATION level inside

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureCoreDxe: fix Redfish event issue.

Hi Abner, > If we use PCD here, then we have to also update CreateEventEx in the > RedfishFeatureCoreEntryPoint. Create the event using > REDFISH_FEATURE_CORE_TPL. Yes, I also modify RedfishFeatureCoreEntryPoint in below together. > } > > /** > @@ -670,7 +682,7 @@ RedfishFeatureCoreEntryPo

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 8:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH 1/4] RedfishClien

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 8:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH 2/4] RedfishClien

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg: fix access to unitialized variable.

Thanks for catching this issue. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 8:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

Hi Mike, Per Redfish specification 7.9 POST(create) "The POST request is submitted to the resource collection to which the new resource will belong." If this is not a collection resource, we cannot use POST method. And /redfish/v1/Systems/SYS_ID/Bios is not a collection resource. The allowed

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: Add debug messages

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, December 19, 2023 12:33 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; > Mike Maslenkin > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: Add debu

Re: [edk2-devel] [edk2-redfish-client][PATCH v3 0/3] change method for provisioning + minor fixes

I merged this patch series. Thanks, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, December 23, 2023 6:41 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH v3 0/3] change me

[edk2-devel] [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. An enhanced Redfish HTTP driver is under development and it will r

[edk2-devel] [edk2-redfish-client][PATCH 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy

[edk2-devel] [edk2-redfish-client][PATCH 02/10] RedfishClientPkg: use HTTP cache lib

Add RedfishHttpCacheLib header file for feature driver to use RedfishHttpCacheLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/Include/RedfishCollectionCommon.h | 4 +++- RedfishClientPkg/Include/RedfishResourceCommon.h | 3 ++- 2 fi

[edk2-devel] [edk2-redfish-client][PATCH 03/10] RedfishClientPkg/ComputerSystemCollectionDxe: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../ComputerSystemCollectionDxe.inf | 2 ++ .../ComputerSystemCollectionDxe.c | 24 +-- 2 files changed, 14 inse

[edk2-devel] [edk2-redfish-client][PATCH 04/10] RedfishClientPkg/ComputerSystem: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +- .../v1_5_0/Dxe/ComputerSystemDxe.c| 70 +++ 2 files changed, 57 inse

[edk2-devel] [edk2-redfish-client][PATCH 05/10] RedfishClientPkg/MemoryCollectionDxe: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../MemoryCollectionDxe.inf | 2 ++ .../MemoryCollectionDxe/MemoryCollectionDxe.c | 24 +-- 2 files changed, 14 inse

[edk2-devel] [edk2-redfish-client][PATCH 07/10] RedfishClientPkg/Bios: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 80 --- 2 files changed, 37 inse

[edk2-devel] [edk2-redfish-client][PATCH 06/10] RedfishClientPkg/Memory: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 70 +++ 2 files changed, 57 inse

[edk2-devel] [edk2-redfish-client][PATCH 08/10] RedfishClientPkg/EdkIIRedfishResourceConfigLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../EdkIIRedfishResourceConfigLib.inf | 2 ++ .../EdkIIRedfishResourceConfigLib.c | 6 -- 2 files cha

[edk2-devel] [edk2-redfish-client][PATCH 10/10] RedfishClientPkg/RedfishFeatureUtilityLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishFeatureUtilityLib.inf | 3 +- .../Library/RedfishFeatureUtilityLib.h| 21 +- .../RedfishFeatureUtilityInternal.h

[edk2-devel] [edk2-redfish-client][PATCH 09/10] RedfishClientPkg/RedfishVersionLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishVersionLib/RedfishVersionLib.inf | 3 ++ .../RedfishVersionLib/RedfishVersionLib.c | 30 ++- 2 files changed, 25 inse

[edk2-devel] [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. An enhanced Redfish HTTP driver is under development and it will r

[edk2-devel] [edk2-redfish-client][PATCH v2 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy

[edk2-devel] [edk2-redfish-client][PATCH v2 00/10] RedfishClientPkg: introduce Redfish HTTP cache library

v2: Replace "BMC" with "Redfish service" in this patch series. v1: Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish feature drivers. Feature drivers often query same Redfish resource multiple times for different purpose. Add HTTP cache mechanism to improve the performance.

[edk2-devel] [edk2-redfish-client][PATCH v2 02/10] RedfishClientPkg: use HTTP cache lib

Add RedfishHttpCacheLib header file for feature driver to use RedfishHttpCacheLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/Include/RedfishCollectionCommon.h | 4 +++- RedfishClientPkg/Include/RedfishResourceCommon.h | 3 ++- 2 fi

[edk2-devel] [edk2-redfish-client][PATCH v2 03/10] RedfishClientPkg/ComputerSystemCollectionDxe: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../ComputerSystemCollectionDxe.inf | 2 ++ .../ComputerSystemCollectionDxe.c | 26 +-- 2 files changed, 15 inse

[edk2-devel] [edk2-redfish-client][PATCH v2 04/10] RedfishClientPkg/ComputerSystem: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +- .../v1_5_0/Dxe/ComputerSystemDxe.c| 70 +++ 2 files changed, 57 inse

[edk2-devel] [edk2-redfish-client][PATCH v2 05/10] RedfishClientPkg/MemoryCollectionDxe: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../MemoryCollectionDxe.inf | 2 ++ .../MemoryCollectionDxe/MemoryCollectionDxe.c | 26 +-- 2 files changed, 15 inse

[edk2-devel] [edk2-redfish-client][PATCH v2 06/10] RedfishClientPkg/Memory: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 70 +++ 2 files changed, 57 inse

[edk2-devel] [edk2-redfish-client][PATCH v2 07/10] RedfishClientPkg/Bios: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 82 --- 2 files changed, 38 inse

[edk2-devel] [edk2-redfish-client][PATCH v2 08/10] RedfishClientPkg/EdkIIRedfishResourceConfigLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../EdkIIRedfishResourceConfigLib.inf | 2 ++ .../EdkIIRedfishResourceConfigLib.c | 6 -- 2 files cha

[edk2-devel] [edk2-redfish-client][PATCH v2 09/10] RedfishClientPkg/RedfishVersionLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishVersionLib/RedfishVersionLib.inf | 3 ++ .../Include/Library/RedfishVersionLib.h | 5 +-- .../RedfishVersionLib/RedfishVersionLib.

[edk2-devel] [edk2-redfish-client][PATCH v2 10/10] RedfishClientPkg/RedfishFeatureUtilityLib: use HTTP cache lib

Use Redfish Http cache library to query Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishFeatureUtilityLib.inf | 3 +- .../Library/RedfishFeatureUtilityLib.h| 21 +- .../RedfishFeatureUtilityInternal.h

Re: [edk2-devel] [edk2-redfish-client][PATCH 01/10] RedfishClientPkg: introduce Redfish HTTP cache library

Thanks Abner. Version 2 patch series is sent for review. Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Wednesday, January 3, 2024 9:02 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez

[edk2-devel] [edk2-redfish-client][PATCH 0/4] Introduce Redfish boot option drivers

Introduction Redfish boot option collection and boot option drivers to support Redfish resource at /redfish/v1/Systems/SYSTEM_ID/BootOptions. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (4): RedfishClientPkg: add ETag to Redfish resource che

[edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add ETag to Redfish resource check function

Add ETag parameter to RedfishCheckResourceCommon(). When the ETag from Redfish resource is not changed, feature driver can skip the check function. This helps to improve the feature driver performance. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- Redfis

[edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg/ConverterLib: fix GCC build error

Address below GCC build error: variable 'CsParentJson' set but not used [-Werror=unused-but-set-variable] Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../BootOption.V1_0_4/BootOption.V1_0_4.c | 1005 - .../BootOptionCollection.c

[edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg/Features: introduce boot option collection

Introduce Redfish boot option collection driver and library. This is to support Redfish resource at: /redfish/v1/Systems/SYSTEM_ID/BootOptions Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishClientComponents.dsc.inc | 4 +- RedfishCl

[edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg/Features: introduce boot option

- Introduce Redfish boot option driver and library. This is to support Redfish resource at: /redfish/v1/Systems/SYSTEM_ID/BootOptions - Make ETag parameter as optional parameter in CreatePayloadToPatchResource function. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ra

Re: [edk2-devel] [PATCH] RedfishClientPkg: fix uninitialized variable build error

Reviewed-by: Nickle Wang mailto:nick...@nvidia.com>> Regards, Nickle From: Mike Maslenkin Sent: Thursday, January 4, 2024 7:56 PM To: devel@edk2.groups.io Cc: Mike Maslenkin ; Abner Chang ; Nickle Wang ; Igor Kulchytskyy Subject: [PATCH] RedfishClientPkg:

Re: [edk2-devel] [PATCH V2 4/6] RedfishPkg/RedfishRestExDxe: Implement EDKII_HTTP_CALLBACK_PROTOCOL

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Sunday, January 7, 2024 9:27 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 4/6] RedfishPkg/RedfishRestExDxe: Implement > EDKII_HTTP_CALLBACK_PR

Re: [edk2-devel] [PATCH V2 5/6] RedfishPkg/RedfishRestExDxe: Uncrustify RedfishRestExDriver.h

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Sunday, January 7, 2024 9:27 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 5/6] RedfishPkg/RedfishRestExDxe: Uncrustify > RedfishRestExDriver.h

Re: [edk2-devel] [PATCH V2 6/6] RedfishPkg/RedfishRestExDxe: Update Supported function

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Sunday, January 7, 2024 9:27 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 6/6] RedfishPkg/RedfishRestExDxe: Update Supported > function > > E

[edk2-devel] [PATCH] RedfishPkg/RedfishDebugLib: add function to print buffer.

Introduce DumpBuffer function to print the buffer content. This helps developer to debug Redfish issue. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/RedfishDebugLib.h | 20 - .../Library/RedfishDebugLib/RedfishDebugLi

[edk2-devel] [PATCH v2] RedfishPkg/RedfishDebugLib: add function to print buffer.

Introduce DumpBuffer function to print the buffer content. This helps developer to debug Redfish issue. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/RedfishDebugLib.h | 20 - .../Library/RedfishDebugLib/RedfishDebugLi

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDebugLib: add function to print buffer.

Thanks for your review, @Chang, Abner! Version 2 patch is sent for review here: https://edk2.groups.io/g/devel/message/113439 Regards, Nickle > -Original Message- > From: Chang, Abner > Sent: Tuesday, January 9, 2024 4:00 PM > To: Nickle Wang ; devel

[edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: handle floating point number in JSON

When the value type is defined as number in Redfish schema, floating point number is allowed. RedfishCrtLib raises assert without handling this case now. Follow the way in EDK2 to call AsciiStrDecimalToUintnS and handle the floating point number. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Ig

[edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: handle floating point number in JSON

When the value type is defined as number in Redfish schema, floating point number is allowed. RedfishCrtLib raises assert without handling this case now. Follow the way in EDK2 to call AsciiStrDecimalToUintnS and handle the floating point number. Only the integer value is returned. Signed-off-by:

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: handle floating point number in JSON

Thanks Abner. I found an issue in this patch and resolved it in version 2 here: https://edk2.groups.io/g/devel/message/113780 Could you please help me to review it again? Regards, Nickle > -Original Message- > From: Chang, Abner > Sent: Saturday, January 13, 2024 10:19 PM > To: Nickle

Re: [edk2-devel] [RESEND PATCH] RedfishPkg/JsonLib: Add JSON delete object function

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:24 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [RESEND PATCH] RedfishPkg/JsonLib: Add JSON delete object function > > Exte

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/jansson: Define json_object_del

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:26 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/jansson: Define > json_obj

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishFeatureUtilityLib: Add two helper functions

Please see my comments below. Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:26 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 2/3] > RedfishClientPkg/RedfishFeatureUtilityLi

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

I found typos. Please see below. Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, January 12, 2024 11:26 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: > Functi

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

> I didn't choose ReadOnly is because at BIOS perspective as a provider, we > still > update the read only property defined in schema such as BootOptions. Thus I > thought to use ReadOnly is not quite accurate. How do you think? I see. Thanks for your explanation. Please fix the typos and keep th

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: fix wrong parameter issue

Third parameter of AsciiStrToUnicodeStrS is the number of character in destination buffer, not the size in byte of destination buffer. This creates failure of converting ASCII string to Unicode string in Redfish application while getting Location field in HTTP header. Signed-off-by: Nickle Wang C

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/FeatureDriver: ComputerSystem_1_5_0 driver

Hi Abner, I found one minor issue: > if (ConfigLangList.Count == 0) { > + DEBUG ((DEBUG_MANAGEABILITY, " No platform Redfish ConfigureLang > + found for %s\n", __func__, Private->Uri)); >return EFI_SUCCESS; "%a:" is missing above. Regards, Nickle > -Original Message

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver

Hi Abner, Same minor issue as 1_5_0. Please add "%a:" to below DEBUG call. > + DEBUG ((DEBUG_MANAGEABILITY, " No platform Redfish ConfigureLang > found for %s\n", __func__, Private->Uri)); Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner

[edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout

Introduce PCD PcdRedfishSendReceiveTimeout to RedfishDiscoverDxe driver. The SendReceiveTimeout is hard-code value in Redfish discover driver. With this PCD, platform owner can configure timeout value easily. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishPkg/Redfis

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update maintainers list

Acked-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Thursday, October 19, 2023 1:43 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; > Michael D Kinney ; Abdul Lateef Attar > ; Nickle Wang ; Jian J > Wang ; Liming Gao ; > Zhigu

[edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions.

There are two definitions for below functions in RedfishCrtLib.h. Create this change to remote duplicated functions. Function list: strcmp(), strncmp(), strncpy(), strcat(), strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy() and memchr(). Signed-off-by: Nickle Wang Cc: Abner Chang Cc

[edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: remove Redfish false alarm

- It is expected that caller receives EFI_NO_MAPPING status when call issues Configure() to unconfigured network interface. Remove this false alarm in GetSubnetInfo() function. - Fix typos Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishDiscover

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: add debug message.

Add debug prints to show HII option name when assert happens. This helps developer to debug assert issue easily while Redfish failed to convert HII value to Redfish value. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe.c

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: multiple definitions of strncpy.

Hi Mike, Sorry for the delay. I remove all duplicated definitions in RedfishCrtLib.h. Please check new patch file here: https://edk2.groups.io/g/devel/message/109925 Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.

Re: [edk2-devel] [PATCH v2 08/12] RedfishPkg: CI: Add PrEval entry

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Joey Vagedes > Sent: Tuesday, October 24, 2023 1:52 AM > To: devel@edk2.groups.io > Cc: Abner Chang ; Nickle Wang ; > Igor Kulchytskyy > Subject: [PATCH v2 08/12] RedfishPkg: CI: Add PrEval entry > > External emai

[edk2-devel] [PATCH 0/3] RedfishPkg/RedfishLib: Return HTTP headers to caller

The purpose of this patch series is to add new interfaces in RedfishLib to return HTTP headers to caller. I also fix typos and compile error in RedfishLib. PR is opened here: https://github.com/tianocore/edk2/pull/4944 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ram

[edk2-devel] [PATCH 1/3] RedfishPkg/RedfishLib: introduce new interfaces.

Add two new interface: RedfishServiceInPayload() and RedfishPutToUri() for Redfish HTTP protocol implementation. Fix several typos and add missing JsonLib in INF file. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../PrivateLibrary/RedfishLib/RedfishLib

[edk2-devel] [PATCH 2/3] RedfishPkg/libredfish: introduce new interfaces.

- Add new interfaces to return HTTP headers back to caller. New interfaces are: getUriFromServiceEx(), patchUriFromServiceEx(), postUriFromServiceEx() and putUriFromServiceEx(). - Fix compile error in payload.c Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --

[edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

Call Ex interface to get HTTP headers and return to caller. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/PrivateL

[edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions.

There are two definitions for below functions in RedfishCrtLib.h. Create this change to remote duplicated functions. Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(), strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy() and memchr(). Signed-off-by: Nickle Wang Cc: Abner

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions.

> double declaration of 'strcpy' is still there. Thanks for catching this, Mike. Version 2 patch file was sent. Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Mike > Maslenkin via groups.io > Sent: Tuesday, October 24, 2023 4:23 AM > To: Nickle Wang > Cc

Re: [edk2-devel] [PATCH 0/9] RedfishClientPkg: various minor fixes

Reviewed this patch series. Hi Mike, Could you please address Abner's comment on "[PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments"? This patch series can be merged after Abner gives reviewed-by to patch 9/9. Thanks, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Satu

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishLib: align with edk2 RedfishLib

Update RedfishLib to align with RedfishLib in edk2 repository. RedfishLib commits on edk2: cf68ff61 RedfishPkg/RedfishLib: introduce new interfaces. 1cbdd6e9 RedfishPkg/libredfish: introduce new interfaces. 8765f3eb RedfishPkg/RedfishLib: return HTTP headers to caller. Signed-off-by: Nickle Wang

[edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg/RedfishLib: align with edk2 RedfishLib

Update RedfishLib to align with RedfishLib in edk2 repository. RedfishLib commits on edk2: cf68ff61 RedfishPkg/RedfishLib: introduce new interfaces. 1cbdd6e9 RedfishPkg/libredfish: introduce new interfaces. 8765f3eb RedfishPkg/RedfishLib: return HTTP headers to caller. Signed-off-by: Nickle Wang

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface Capabilities

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, October 10, 2023 4:36 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Jian J Wang > ; Liming Gao > Subject: [e

Re: [edk2-devel] [PATCH 1/2] MdePkg/Include: Definitions of IPMI Get System Interface Capabilities

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, October 10, 2023 4:36 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Michael D > Kinney ; Liming Gao ; > Zhigu

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

Hi Igor, If the DELETE request to BMC is handled by Redfish task, we need to return HTTP header to caller so caller can get Task URI. But from BIOS Redfish perspective, I don't see this use case yet. Thanks, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, Octobe

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

According to my experience, BIOS Redfish is usually the owner to handle Redfish task request, not the user to create task. So, I think that BIOS has no chance to read HTTP header in DELETE request/response. But from specification perspective, Redfish task URI can be returned in HTTP header in

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg/Ipmi: Remove IpmiCommandLib.h from ManageabilityPkg

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Wednesday, October 18, 2023 12:51 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaac Oram > ; Nickle Wang > Subject:

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/11] RedfishClientPkg: various minor fixes

Reviewed this patch series. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Friday, October 27, 2023 7:54 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Uncrustify on C source files

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Laszlo Ersek > Sent: Thursday, October 26, 2023 5:50 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Attar, AbdulLateef (Abdul Lateef) ; Nickle > Wang ; Konstantin Aladyshev > Subject: Re: [edk2-devel] [edk2-plat

[edk2-devel] [edk2-redfish-client][PATCH 0/3] Fix various issues and enhancement.

Fix various issues and add enhancement to RedfishClientPkg. PR is opened here: https://github.com/tianocore/edk2-redfish-client/pull/55 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (3): RedfishClientPkg/RedfishETagDxe: fix uninitialized varia

[edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/RedfishETagDxe: fix uninitialized variable issue

Status variable is not initialized. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c b/R

[edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishConfigLangMapDxe: uninitialized variable issue

-RedfishConfigLangMapDxe relies on variable arch protocol. -Status variable is not initialized. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf | 4 ++-- .../RedfishConfigLangMapDxe/RedfishConfi

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/RedfishFeatureUtilityLib: fix issues and enhancement

-Add RedfishDebugLib to print Redfish request and response details when PATCH and POST request return error. -Use "%a:" in debug print to align with the style in EDK2. -Enhance GetConfigureLang() to handle pending resource URI. Pending resource share ths same schema as its active resource. So we ca

[edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.

There are two definitions for below functions in RedfishCrtLib.h. Create this change to remote duplicated functions. Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(), strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy(), memchr(), memcmp() and memmove(). Signed

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions.

Thanks Mike! By following the logic, strlen() can be removed too. Version 3 patch is here: https://edk2.groups.io/g/devel/message/110408 I removed memcmp, memmove, and strlen. Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Sunday, October 29, 2023 9:58 PM > To: Nic

Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.

chments > > > On Tue, Oct 31, 2023 at 3:56 PM Nickle Wang via groups.io > mailto:nicklew=nvidia@groups.io>> wrote: > > > > There are two definitions for below functions in RedfishCrtLib.h. > > Create this change to remote duplicated functions. >

Re: [edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

This change looks good to me. Just minor comments: > DEBUG ((DEBUG_INFO, "%a: all required protocols are found on this controller > handle: %p.\n", __func__, ControllerHandle)); Could we use DEBUG_MANAGEABILITY to replace DEBUG_INFO in Redfish driver? This gives us the way to show manageability

[edk2-devel] [edk2-redfish-client][PATCH 1/2] RedfishClientPkg: introduce Redfish override protocol

Introduce Redfish override protocol to notify platform that the Redfish changes system settings and about to perform system reboot. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/RedfishClientPkg.dec | 2 + .../Protocol/EdkIIRedf

[edk2-devel] [edk2-redfish-client][PATCH 0/2] introduce Redfish override protocol

Introduce Redfish override protocol. If platform likes to do specific operation before system reboot, platform implement this protocol and Redfish feature core driver will call it to notify platform that system is going to reboot. Platform can reject system reboot by returning error status based on

[edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg/RedfishFeatureCoreDxe: notify platform before reboot.

Call Redfish override protocol to notify platform that the Redfish changes system settings and about to perform system reboot. Platform firmware can do platform specific operation before system rebooted. To follow platform policy, platform can reject system reboot by returning error status and Redf

Re: [edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Thanks for fixing this issue. This version looks good to me. I test it on my system and it works well. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Tuesday, November 7, 2023 8:06 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Nickle

Re: [edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Hi @Liming Gao, @Kinney, Michael D > If the patch is sent before Soft Feature Freeze, and plans to catch this > stable tag, the patch contributor need reply to his patch and notify edk2 > community We would like to include

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array

- Add function to validate Redfish request for string array type. There is case that user request invalid string array and feature driver can not find corresponding HII option. - Fix typo. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Library/Redfish

Re: [edk2-devel] [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib

Thanks for fixing memory leak issue. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com > Subject: [PATCH v2 1/3] RedfishPkg

Re: [edk2-devel] [PATCH v2 2/3] RedfishPkg: add explicit variable initialization

Yes, it is an issue. Thanks! Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com > Subject: [PATCH v2 2/3] RedfishPkg: add ex

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/ComputerSystemCollectionDxe: handle more scenarios

This change defines two more error returns and allow feature driver to handle the scenarios while 1) the resource is not owned by feature driver. 2) feature driver owns this resource but there is nothing to manage on this resource now. Detail changes are: - Use "%a:" instead of "%a," in debug macro

[edk2-devel] [edk2-redfish-client][PATCH 0/6] Feature driver fix and

There are several bug fix and enhancement to Redfish feature driver. I also fix typo in comments, variable and function name. A pull request is created here for ease of review: https://github.com/tianocore/edk2-redfish-client/pull/60 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytsk

[edk2-devel] [edk2-redfish-client][PATCH 1/6] RedfishClientPkg/RedfishETagDxe: fix issue and enhancement.

-Fix typo (replace Listheader to ListHeader). -Replace "%a," to "%a:". -Add more debug message. -Remove the exit-boot-service event and use after-provisioning event to save ETag data. Variable may not be writable during exit-boot-service callback. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: I

[edk2-devel] [edk2-redfish-client][PATCH 2/6] RedfishClientPkg/RedfishConfigLangMapDxe: fix issue and enhancement.

-Fix typo (replace Listheader to ListHeader). -Replace "%a," to "%a:". -Add more debug message. -Fix issue of assigning ASCII character to Unicode string pointer. -Remove the exit-boot-service callback since data is saved at after-provisioning event. There is no need to save data to variable again.

[edk2-devel] [edk2-redfish-client][PATCH 3/6] RedfishClientPkg: feature driver enhancement.

-Fix typo (include function RedfisSetRedfishUri and parameter MaxLengthConfigLang) -Add more debug message. -Do not save ETag to variable every time when new ETag is created in SetEtagWithUri(). -Introduce SetEtagFromUri() to get ETag from BMC and save it in variable. -Introduce GetPendingSettings(

  1   2   3   4   5   6   >