Thanks Mike! By following the logic, strlen() can be removed too. Version 3 patch is here: https://edk2.groups.io/g/devel/message/110408 I removed memcmp, memmove, and strlen.
Regards, Nickle > -----Original Message----- > From: Mike Maslenkin <mike.maslen...@gmail.com> > Sent: Sunday, October 29, 2023 9:58 PM > To: Nickle Wang <nick...@nvidia.com> > Cc: devel@edk2.groups.io; Abner Chang <abner.ch...@amd.com>; Igor > Kulchytskyy <ig...@ami.com>; Nick Ramirez <nrami...@nvidia.com> > Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple > definitions. > > External email: Use caution opening links or attachments > > > On Wed, Oct 25, 2023 at 3:40 PM Nickle Wang <nick...@nvidia.com> wrote: > > > > > double declaration of 'strcpy' is still there. > > > > Thanks for catching this, Mike. Version 2 patch file was sent. > > > > Regards, > > Nickle > > Hello, Nickle > > v2 is good enough, but it can be improved a bit. > > Since the definitions in this header file have become clearer and simpler, It > now > appears that memcmp and memmove declarations can also be removed. > > The logic is that we don't need to declare function prototypes for those that > are > overridden at the bottom of this header file. > If there were such functions in the code, the linking process would fail, but > there > should not be such functions, since their names are replaced by the > preprocessor > according to the definitions. > > Regards, > Mike. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110409): https://edk2.groups.io/g/devel/message/110409 Mute This Topic: https://groups.io/mt/102136148/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
