* Add SMRAM Memory Reserve GUID to QuarkSocPkg
* Add SMM ICHN Dispatch Protocol to QuarkSocPkg
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Ray Ni
Cc: Kelly Steele
Signed-off-by: Michael D Kinney
---
.../Include/Guid/SmramMemoryReserve.h | 54 ++
.../Include/Protocol/SmmIchnDispatch.h
-by: Michael D Kinney
Michael D Kinney (4):
QuarkPlatformPkg: Update network library mappings
QuarkSocPkg: Remove Intel Framework dependencies
QuarkPlatformPkg: Remove Intel Framework dependencies
QuarkPkatformPkg: Update MemoryTypeInformation to reduce reboots
Adjust size of bins in Memory Type Information HOB to eliminate
extra reboot after first boot.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Ray Ni
Cc: Kelly Steele
Signed-off-by: Michael D Kinney
---
.../Platform/Pei/PlatformInit/MrcWrapper.h | 9 -
1 file changed, 4 insertions
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Ray Ni
Cc: Kelly Steele
Signed-off-by: Michael D Kinney
---
Platform/Intel/QuarkPlatformPkg/Quark.dsc| 8
Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/Platform/Intel
s
>
> On Sun, Jun 30, 2019 at 07:55:39PM -0700, Michael D
> Kinney wrote:
> > The following changes remove all dependencies on the
> IntelFrameworkPkg
> > and IntelFrameworkModulePkg from the Vlv2TbltDevicePkg
> platform
> > builds. These changes do depend on
gt;
> Cc: Qian, Yi ; Sun, Zailiang
>
> Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> Vlv2TbltDevicePkg: Remove Intel Framework dependencies
>
> On Mon, Jul 01, 2019 at 11:07:11PM +, Michael D
> Kinney wrote:
> > Hi Gary,
> >
> > I reco
h 00/14]
> > Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> >
> > On Mon, Jul 01, 2019 at 11:07:11PM +, Michael D
> Kinney wrote:
> > > Hi Gary,
> > >
> > > I recommend you rebase on top of this series.
> > >
> > >
ing that now.
> > >
> > > Mike
> > >
> > > > -Original Message-
> > > > From: Gary Lin [mailto:g...@suse.com]
> > > > Sent: Tuesday, July 2, 2019 2:48 AM
> > > > To: devel@edk2.groups.io; Kinney, Michael D
> &
pendencies
>
> On Tue, Jul 09, 2019 at 03:52:37AM +, Michael D
> Kinney wrote:
> > Hi Gary,
> >
> Hi Mike,
>
> > I picked up the changes on your branch. I re-enabled
> the BIOS ID
> > Feature and added support for IA32 GCC builds, so the
> builds ava
t;
> Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> Vlv2TbltDevicePkg: Remove Intel Framework dependencies
>
> On Wed, Jul 10, 2019 at 03:38:01AM +, Michael D
> Kinney wrote:
> > Hi Gary,
> >
> > I have pushed 2 more patches to my branch. One
module policy in
> > edk2 repo. Git commands are also added to show the
> correct way to
> > clone submodule repos, in which '--recursive' is
> removed because it's
> > not needed but recommended in other document.
> >
> > Related commits:
> >
clarify the
> > > submodule policy in
> > > > edk2 repo. Git commands are also added to show the
> > > correct way to
> > > > clone submodule repos, in which '--recursive' is
> > > removed because it's
> > > > not needed bu
From: Gary Lin
For the gcc build, we should use PlatformCapsuleGcc.dsc instead of
PlatformCapsule.dsc.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Gary Lin
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
mode change 100644 => 100755 Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
diff --git a/Platf
From: Gary Lin
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
b/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
From: Gary Lin
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
b/Platform/Intel
From: Gary Lin
TableVersion in AcpiPlatformEntryPoint() is not used anymore.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/Platform/Intel
ize of the ACPI table so
InstallAcpiTable() returned EFI_INVALID_PARAMETER.
Use the 'Length' from the header to avoid the crash.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 2 +-
1 file
* Export TARGET and TOOL_CHAIN_TAG so that the GenerateCapsule scripts
can use those variables
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 57 -
1 file changed, 33 insertions(+), 24 deletion
Only build capsules for X64 builds. More changes are
required to build IA32 capsules.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat | 6 +-
Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 6 +-
2 files
Remove redundant declaration of gEfiSpiProtocolGuid
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
Silicon/Intel/Vlv2DeviceRefCodePkg/Vlv2DeviceRefCodePkg.dec | 1 -
1 file changed, 1 deletion(-)
diff --git a/Silicon/Intel/Vlv2DeviceRefCodePkg
Remove redundant declaration of gEfiSpiProtocolGuid.
This protocol is defined in Vlv2DeviceRefCodePkg.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.dec | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform
Add back BIOSID feature using GenBiosId.py script and
BiosIdLib from the BoardModulePkg. Remove the VLV2
specific BiosIdLib implementation.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
.../Include/Library/BiosIdLib.h | 86
Handle case where no Simple Network Protocols are found.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
.../MiscBaseBoardManufacturerFunction.c| 14 +-
.../SmBiosMiscDxe/MiscSystemManufacturerFunction.c | 14 +-
2 files
From: Gary Lin
Fix the indentation of MiscSystemManufacturerFunction.c to improve the
readability.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
.../MiscSystemManufacturerFunction.c | 51 +--
1 file changed, 24 insertions(+), 27
From: Gary Lin
Adjust the paths to fit the current directory structure
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
.../Capsule/GenerateCapsule/GenCapsuleAll.sh | 37 +++
.../GenerateCapsule/GenCapsuleMinnowMax.sh| 24
From: Gary Lin
Borrow the logic from OvmfPkg/build.sh
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/Platform/Intel
* Do not change WORKSPACE env var.
Assume it is set before running script.
* Access Conf dir relative to WORKSPACE
* Run Build_IFWI.sh from the Vlv2Tbl2DevicePkg dir
* run bld_vlv.sh from same dir as Build_IFWI.sh
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Gary Lin
Signed-off-by: Michael D Kinney
From: Gary Lin
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
index
From: Gary Lin
Import the SD card/MMC drivers from MdeModulePkg
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 7 +++
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf| 7 +++
Platform
From: Gary Lin
Also make Build_IFWI.sh executable
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
mode change 100644 => 100755 Platform/In
From: Gary Lin
Some headers files are not listed in the inf files.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
.../Library/FlashDeviceLib/FlashDeviceLib.inf | 2 +-
.../Vlv2TbltDevicePkg/Library/PchSmmLib/PchSmmLib.inf | 8
From: Gary Lin
The scripts for PlatformCapsuleGcc.dsc need Vlv.ROM.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh
b
From: Gary Lin
When setting NETWORK_TLS_ENABLE to TRUE, we need TlsLib.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 3 +++
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 3 +++
Platform
From: Gary Lin
Check WORKSPACE before running the script and notify the user to export
the variable if the variable doesn't exist
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 14 +-
1 file ch
* Vlv2TbltDevicePkg/AcpiPlatform: Fix the error from InstallAcpiTable and
remove unused local variable.
Cc: Zailiang Sun
Cc: Yi Qian
Signed-off-by: Michael D Kinney
Signed-off-by: Gary Lin
Gary Lin (18):
Vlv2TbltDevicePkg/Build_IFWI.sh: Add "set -e" to exit on error
Vlv2TbltDevicePkg/Bui
* Remove unused references to gEfiPlatformCpuInfoGuid
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
.../AcpiPlatform/AcpiPlatform.c | 1 -
.../Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 4 +
.../Include/Guid/PlatformCpuInfo.h| 16
and cannot be accessed ^ (\_SB.PCI0.GFX0.MCHK.DCFE)
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
.../AcpiTablesPCAT/IgdOGBDA.ASL| 14 --
.../AcpiTablesPCAT/IgdOpRn.ASL | 18 +-
2 files
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
.../Vlv2TbltDevicePkg/PlatformPkgGccIA32.dsc | 45 +++--
.../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 48 +++
.../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 45 +++--
.../Vlv2TbltDevicePkg/PlatformPkgX64
Update Readme.md with instructions to clone content from
the edk2, edk2-platforms, and edk2-non-osi repositories
and build Vlv2TbltDevicePkg for Windows and Linux.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
Platform/Intel/Vlv2TbltDevicePkg/Readme.md | 145
anymore
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
Platform/Intel/Vlv2TbltDevicePkg/.gitignore | 5 -
.../Intel/Vlv2TbltDevicePkg/Build_IFWI.bat| 75 ++---
.../Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 57 +++
.../Include
Yi ; Sun, Zailiang
>
> Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> Vlv2TbltDevicePkg: Remove Intel Framework dependencies
>
> On Wed, Jul 10, 2019 at 05:01:32AM +, Michael D
> Kinney wrote:
> > Hi Gary,
> >
> > I have added 2 more patches. One to di
LA57 bit
added to IA32_CR4 matches the documentation in the white paper
referenced in the series.
Reviewed-by: Michael D Kinney
Thanks,
Mike
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, July 10, 2019 10:17 AM
> To: devel@edk2.gro
Hi Ray,
I noticed a Linux/GCC build issue with this patch when using GCC version:
gcc version 8.2.1 20181215 (Red Hat 8.2.1-6) (GCC)
edk2/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c: In function 'ReclaimPages':
edk2/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c:574:89: error: ?: using integer
constan
Liming,
I agree that edk2-staging is a good place to work on cleaning
these tools up.
Please revert the commit of these tools today so GCC builds
are not broken.
Thanks,
Mike
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, July 10, 2019 6:43 AM
> To: devel@edk2.groups.io; l
https://bugzilla.tianocore.org/show_bug.cgi?id=1970
Update local variable in ParseAcpiSlot() to be UINT32
instead of UINT64 to avoid 64-bit multiply operation
in the SLIT_ELEMENT() macro.
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Michael D Kinney
Ard,
Resend to devel@edk2.groups.io
One comment below on a logic issue that would be exposed
if multiple emulators are present.
Mike
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Sunday, March 31, 2019 8:27 PM
> To: edk2-de...@lists.01.org
> Cc:
cies that depend on the device where the
> driver originated
> * allow the emulator to supersede the native loading
> of the image - this
> permits things like X86 on X86 emulators for
> security sandboxing or debug
>
> Changes since v1:
> - subsume the EBC handli
ion Agreement 1.1?
>
> Thanks
> Liming
> >-Original Message-
> >From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of
> >Michael D Kinney
> >Sent: Friday, April 05, 2019 6:43 AM
> >To: devel@edk2.groups.io
> >Cc: Justen, Jordan L
Ard,
A could small comments below on use of sizeof().
Mike
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, April 11, 2019 11:58 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Zimmer,
> Vincent ; Richardson, Brian
> ; Kinney, Michael
Ard,
Comment below on a VS2015x86 build issue.
Mike
> -Original Message-
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of Ard
> Biesheuvel
> Sent: Thursday, April 11, 2019 11:58 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Zimmer,
> Vincent ; Richardson,
Ard,
We have verified that the build failures are resolved.
Series Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, April 11, 2019 1:58 PM
> To: edk2-devel-groups-io ; Ard
> Biesheuve
n the tianocore wiki.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
Commit-Message-Format.md | 3 ---
Commit-Signature-Format.md | 1 -
...-unkempt-git-guide-for-edk2-contributor
ff-by: Michael D Kinney
---
BSD-License.md | 2 +-
BSD-Patent-License.md| 18 ++
Code-Contributions.mediawiki | 4 +---
EDK-II.md| 2 +-
Edk2-buildtools.mediawiki| 2 +-
Legalese.md | 9 +
OVMF-F
https://bugzilla.tianocore.org/show_bug.cgi?id=1656
* Change preferred license of EDK II to BSD+Patent
* Remove references to the TianoCore Contributor's Agreement
* Remove use of Contributed-under tags
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Signed-off-by: Michael D K
Hi Leif,
This is not a macro that is to be used by C code. It is a technique
to prevent recursive includes on a .h file. As a result, we do not want
to use the C Coding Standard macro style.
Are there other techniques to prevent recursive includes?
I agree that macros/symbols that start with s
Wei Xu,
Thanks for providing this request for a new edk2-staging branch.
Please add the branch maintainers to the Readme along with the criteria that
must be met for the feature to be considered a candidate for edk2/master.
With those updates, Reviewed-by: Michael D Kinney
michael.d.kin
https://bugzilla.tianocore.org/show_bug.cgi?id=1656
Change the web page documentation to state that the preferred license
of the EDK II is the BSD+Patent License.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
edk2/index.md | 3 +--
legalese.md | 3
https://bugzilla.tianocore.org/show_bug.cgi?id=1656
Change the EDK II C Coding Standards Specification to state that
the preferred license of the EDK II is the BSD+Patent License and
that file headers should use SPDX license identifiers.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Contr
Leif,
How about using the following pragma instead if include guards?
#pragma once
https://en.wikipedia.org/wiki/Pragma_once
This appears to be supports by GCC 3.4 and higher, clang, and VS.
Might even speed up builds a bit.
Mike
> -Original Message-
> From: Kinney, M
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jin, Eric
> Sent: Monday, April 15, 2019 8:02 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject:
> [Staging/Bug_1525_FmpDevicePkg_MultipleControllers][PAT
> CH] MdeModulePkg
> devel@edk2.groups.io
> Cc: Andrew Fish ; Leif Lindholm
>
> Subject: Re: [edk2-CCodingStandardsSpecification Patch]
> Change preferred license of EDK II to BSD+Patent
>
> On 04/15/19 22:57, Michael D Kinney wrote:
> > https://bugzilla.tianocore.org/show_bug.cgi?id=
between
the copyright statement and the SPDX identifier. This rule is not
consistently followed.
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
---
5_source_files/52_spacing.md | 28
it by accessing
> the array elements
> individually.
>
> (We can't use a union here, unfortunately, as easily as
> with
> "EFI_COMMON_SECTION_HEADER", given the fields in
> "EFI_FFS_FILE_HEADER".)
>
> Cc: Liming Gao
> Cc: Michael D Kin
19 4:31 PM
> > To: edk2-devel-groups-io
> > Cc: Gao, Liming ; Kinney,
> Michael
> > D
> > Subject: [edk2-devel] [PATCH 04/10]
> > MdePkg/PiFirmwareFile: fix undefined behavior in
> > FFS_FILE_SIZE
> >
> > Accessing "EFI_FFS_FILE_HEADER.S
& 0x00ff;
I ran the clang static analyzer and runtime ubsan on the above code and it did
not complain (I force strict aliasing via -fstrict-aliasing, and I'm using the
Sys V ABI since this is just the command line compiler on my Mac).
Thanks,
Andrew Fish
On Apr 17, 2
BSD+Patent
>
> Hi Mike,
>
> On 04/15/19 22:38, Michael D Kinney wrote:
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1656
> >
> > Change the web page documentation to state that the
> preferred license
> > of the EDK II is the BSD+Patent License.
> >
&
edk2-devel] [PATCH 04/10]
> MdePkg/PiFirmwareFile: fix undefined behavior in
> FFS_FILE_SIZE
>
> Hi Michael,
>
> On 4/17/19 7:52 PM, Michael D Kinney wrote:
> > Laszlo,
> >
> > I have been following this thread. I think the style
> > used here to access
Series Reviewed-by: Michael D Kinney
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, April 18, 2019 10:47 AM
> To: edk2-devel-groups-io
> Cc: Ard Biesheuvel ; Feng,
> Bob C ; Justen, Jordan L
> ; Gao, Liming
> ; Kinney, Mic
dk2.groups.io] On Behalf Of Laszlo
> Ersek
> >> Sent: Tuesday, April 16, 2019 5:47 AM
> >> To: Kinney, Michael D ;
> >> devel@edk2.groups.io
> >> Cc: Andrew Fish ; Leif Lindholm
> >>
> >> Subject: Re: [edk2-devel] [WebSite Patch] Change
&
Hi Ard,
The UEFI Specification Section 23.3 says:
"The ESRT shall be stored in memory of type EfiBootServicesData."
If an RT driver needs ESRT info after ExitBootServices(), then the
RT driver should collect that information before ExitBootServices().
Best regards,
Mike
> -Origina
On Fri, 19 Apr 2019 at 19:42, Ard Biesheuvel
> wrote:
> >
> > On Fri, 19 Apr 2019 at 19:36, Michael D Kinney
> > wrote:
> > >
> > > Hi Ard,
> > >
> > > The UEFI Specification Section 23.3 says:
> > >
> > > "The ESRT s
naro.org; Wu, Hao A
> > > ; Wang, Jian J
> > >
> > > Subject: Re: [edk2-devel] [PATCH resend]
> > > MdeModulePkg/EsrtDxe: allocate ESRT table from
> > > RtServicesData memory
> > >
> > > On Fri, 19 Apr 2019 at 19:42, Ard Biesheuve
Ard,
I think skipping the nested check at runtime is a good
idea. No need for ESRT at RT and no need to cache GUIDs
at EBS.
Mike
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, April 19, 2019 11:43 AM
> To: Kinney, Michael D
> Cc: devel@ed
Ard,
Saw your patch to cache the GUID table. The ESRT Table
is not that much bigger, so the algorithm may be simpler
if you just make a copy of the ESRT table with the
active entries.
* 16+24 bytes per ESRT entry.
* 16 bytes/entry for just the GUID.
The only advantage of checking against the
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README b/README
index b640a482f9..60f14a654a 100644
--- a/README
+++ b/README
@@ -27,7 +27,7 @@ Process for creating, using, and
Hello,
There were no objections to the following RFC to add
a new edk2-libc repository.
https://edk2.groups.io/g/devel/message/35211
I have entered the following Feature Request Bugzilla
https://bugzilla.tianocore.org/show_bug.cgi?id=1734
I have posted a version of the edk2-libc reposi
https://bugzilla.tianocore.org/show_bug.cgi?id=1734
Remove the following packages and move them to the new
edk2-libc repository
* AppPkg
* StdLib
* StdLibPrivateInternalFiles
Cc: Jaben Carsey
Cc: Daryl McDaniel
Signed-off-by: Michael D Kinney
---
AppPkg
Maintainers.txt
gt; Thus, in order to please the static checker, this
> commit will add an
> ASSERT right before the false-positive NULL pointer
> dereference report.
>
> Cc: Ard Biesheuvel
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Jian J Wang
> Signed-off-by: Hao Wu
> ---
> M
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jin, Eric
> Sent: Sunday, April 21, 2019 10:48 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject:
> [Staging/Bug_1525_FmpDevicePkg_MultipleControllers][PAT
> CH] MdeModulePkg/EsrtFmpDxe:
Ard,
This seems to be a common limitation seen in some
static analyzers. We have not found a workaround
that does not involve code changes to quiet the
false positives.
For this specific case, I think the code change I
suggest is correct.
Best regards,
Mike
> -Original Message-
> F
the two changes above:
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of Ard
> Biesheuvel
> Sent: Monday, April 22, 2019 3:03 PM
> To: Wu, Hao A
> Cc: devel@edk2.groups.io; Wang, Jian J
iesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, April 22, 2019 3:40 PM
> To: edk2-devel-groups-io ; Kinney,
> Michael D
> Cc: Wu, Hao A ; Wang, Jian J
>
> Subject: Re: [edk2-devel] [PATCH v2]
> MdeModulePkg/DxeCapsuleLibFmp: avoid ESRT accesses at
> runtime
>
> On Tue,
Hi Laszlo,
Many topics in here. Please let me know if I missed anything.
1) I did use git filter-branch to extract the history of these
packages. The script I ran is shown below. It results in
a local repo in the directory edk2-filter that contains
the 3 packages with complete histor
One issue I see is using a FeatureFlag PCD.
These PCDs can only be TRUE or FALSE, so they can not be
extended later. A FixedAtBuild PCD of type BOOL has the
same issue.
It would be better to use a UINTx FixedAtBuild PCD, and
define a bit or a value for 32-bit access. That way, if
there is a de
lined.
>
> On Wed, 2019-04-24 at 03:45 +, Michael D Kinney
> wrote:
> > One issue I see is using a FeatureFlag PCD.
> > These PCDs can only be TRUE or FALSE, so they can not
> be
> > extended later. A FixedAtBuild PCD of type BOOL has
> the
> > same issue
ollisions
>
> On Wed, 24 Apr 2019 at 06:59, Gao, Zhichao
> wrote:
> >
> > REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1740
> >
> > Add a 'static' descriptor to the global variables that
> only
> > used in a single file to minimiz
Ard,
Using edk2 and edk2-non-osi as submodules in the edk2-platforms
repo does have some advantages. Each branch in edk2-platforms
can decide which release/tag/sha is required from dependent repos.
This provides a platform focused view of the EDK II project.
If using a release/tag/sha for the
gt; Sent: Wednesday, April 24, 2019 1:07 AM
> > > To: edk2-devel-groups-io ; Gao,
> > > Zhichao
> > > Cc: Laszlo Ersek ; Kinney, Michael
> D
> > > ; Gao, Liming
> > > ; Bi, Dandan
>
> > > Subject: Re: [edk2-devel] [PATCH V2 3/8]
> >
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Gao, Zhichao
> Sent: Tuesday, April 16, 2019 11:27 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> Steele, Kelly ; Gao, Liming
>
Change function name from ResetSystem() to PlatformResetSystem()
to resolve name collision with ResetSystemLib.
Cc: Kelly Steele
Signed-off-by: Michael D Kinney
---
QuarkPlatformPkg/Platform/Pei/PlatformInit/MemoryCallback.c | 6 +++---
.../Platform/Pei/PlatformInit/PlatformEarlyInit.h
Use CPUID in IA32 implementation of AsmLfence() to verify
that SSE2 is supported before using the LFENCE instruction.
Cc: Liming Gao
Signed-off-by: Michael D Kinney
---
MdePkg/Library/BaseLib/Ia32/Lfence.nasm | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a
setting into the Quark specific SMM Access Protocol
when the Close() service is called.
Cc: Kelly Steele
Signed-off-by: Michael D Kinney
---
.../Smm/Dxe/SmmAccessDxe/SmmAccess.inf | 3 ++-
.../Smm/Dxe/SmmAccessDxe/SmmAccessDriver.c | 18 +-
.../Smm/Dxe/SmmAccessDxe
: Kelly Steele
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Michael D Kinney
Michael D Kinney (4):
MdePkg/BaseLib: Verify SSE2 support in IA32 AsmLfence()
UefiCpuPkg/MpInitLib: Avoid MSR_IA32_APIC_BASE for single core
QuarkSocPkg/SmmAccessDxe: Set region to UC on
Avoid access to MSR_IA32_APIC_BASE that may not be supported
on single core CPUs. If PcdCpuMaxLogicalProcessorNumber is 1,
then there is only one CPU that must be the BSP.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Michael D Kinney
---
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
Ray,
I prefer to keep the Quark packages active in edk2-platforms for a while longer.
Mike
From: Ni, Ray
Sent: Monday, April 8, 2019 7:49 AM
To: Kinney, Michael D ; 'devel@edk2.groups.io'
Cc: Steele, Kelly
Subject: RE: [RFC] Propose to remove QuarkPlatformPkg and QuarkSocPkg
Mike,
This RFC i
Ray,
Yes. I am working on a patch to do that move. I have been discussing with
edk2-platforms maintainers.
Mike
From: Ni, Ray
Sent: Thursday, April 25, 2019 11:23 AM
To: Kinney, Michael D ; 'devel@edk2.groups.io'
Cc: Steele, Kelly
Subject: RE: [RFC] Propose to remove QuarkPlatformPkg and Q
Resolve a few warnings from the latest iASL compilers.
Cc: Kelly Steele
Signed-off-by: Michael D Kinney
---
QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi | 4 ++--
QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff
Hi Laszlo,
Thanks for all your feedback. Responses included below.
Mike
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, April 24, 2019 2:51 AM
> To: Kinney, Michael D ;
> devel@edk2.groups.io
> Cc: Carsey, Jaben ; Daryl
> McDaniel (edk2-li...@mc2r
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, April 24, 2019 8:37 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao,
> Liming ; Dong, Eric
>
> Subject: [patch] MdeModulePkg/HiiDB: Minimize memory
> allocat
901 - 1000 of 2711 matches
Mail list logo
