Re: [edk2-devel] [PATCH v4 1/1] MdePkg:Add NVME Sanitize command support to Nvme.h

2023-12-05 Thread Michael D Kinney
higuang ; Sean Brogan > ; Kinney, Michael D > Subject: RE: [PATCH v4 1/1] MdePkg:Add NVME Sanitize command support to > Nvme.h > > Reviewed-by: Michael D Kinney > > > -Original Message- > > From: Chen, Tina > > Sent: Wednesday, November 8, 2023 11:5

[edk2-devel] TianoCore Community Meeting call for topics

2023-12-05 Thread Michael D Kinney
Are there any topics for the TianoCore Community Meeting this week? Thanks, Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112083): https://edk2.groups.io/g/devel/message/112083 Mute This Topic: https://groups.io/mt/103002996/21656

Re: [edk2-devel] [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message

2023-12-06 Thread Michael D Kinney
Hi Jake, PR opened with Rb tag added: https://github.com/tianocore/edk2/pull/5113 Mike From: Jake Garver Sent: Wednesday, December 6, 2023 8:37 AM To: Gao, Liming ; devel@edk2.groups.io Cc: Kinney, Michael D ; Liu, Zhiguang Subject: Re: [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message A

Re: [edk2-devel] [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message

2023-12-06 Thread Michael D Kinney
Merged Mike From: Kinney, Michael D Sent: Wednesday, December 6, 2023 8:47 AM To: Jake Garver ; Gao, Liming ; devel@edk2.groups.io Cc: Liu, Zhiguang ; Kinney, Michael D Subject: RE: [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message Hi Jake, PR opened with Rb tag added: https://github.co

Re: [edk2-devel] TianoCore Community Meeting call for topics

2023-12-06 Thread Michael D Kinney
No topics. Meeting canceled. Mike From: Kinney, Michael D Sent: Tuesday, December 5, 2023 3:11 PM To: devel@edk2.groups.io Cc: Kinney, Michael D Subject: TianoCore Community Meeting call for topics Are there any topics for the TianoCore Community Meeting this week? Thanks, Mike -=-=-=-=-=

Re: [edk2-devel] [PATCH v3] MdePkg: Add a new memory type definition

2023-12-08 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Srinivasan, ManickamX > Sent: Thursday, December 7, 2023 9:37 PM > To: devel@edk2.groups.io > Cc: Srinivasan, ManickamX ; Kinney, > Michael D ; Gao, Liming > ; Liu, Zhiguang ; T V, > Krishnamoorthy >

Re: [edk2-devel] [PATCH v2] MdePkg: Define the DevicePath argument from LoadImage as optional

2023-12-08 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Srinivasan, ManickamX > Sent: Thursday, December 7, 2023 9:41 PM > To: devel@edk2.groups.io > Cc: Srinivasan, ManickamX ; Kinney, > Michael D ; Gao, Liming > ; Liu, Zhiguang ; T V, > Krishnamoorthy >

Re: [edk2-devel] [PATCH v2] MdePkg: Define the DevicePath argument from LoadImage as optional

2023-12-08 Thread Michael D Kinney
, Michael D > > Subject: RE: [PATCH v2] MdePkg: Define the DevicePath argument from > LoadImage as optional > > Reviewed-by: Michael D Kinney > > > -Original Message- > > From: Srinivasan, ManickamX > > Sent: Thursday, December 7, 2023 9:41 PM > &g

Re: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments

2023-12-08 Thread Michael D Kinney
Series Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran via groups.io > Sent: Friday, December 8, 2023 4:20 PM > To: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Ard > Biesheuvel ; Laszlo Ersek >

Re: [edk2-devel] [PATCH v3] MdePkg: Add a new memory type definition

2023-12-08 Thread Michael D Kinney
, Michael D > > Subject: RE: [PATCH v3] MdePkg: Add a new memory type definition > > Reviewed-by: Michael D Kinney > > > -Original Message- > > From: Srinivasan, ManickamX > > Sent: Thursday, December 7, 2023 9:37 PM > > To: devel@edk2.groups

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: writeio function in edk2module.c not working as expected

2023-12-09 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Jayaprakash, N > Sent: Saturday, December 9, 2023 9:43 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D > Subject: [edk2-libc Patch 1/1] ek2-libc: writeio function

Re: [edk2-devel] [PATCH 2/2] MdePkg:simplify Fifo API in BaseIoLibIntrinsic

2023-12-11 Thread Michael D Kinney
Acked-by: Michael D Kinney Mike > -Original Message- > From: Tan, Dun > Sent: Wednesday, December 6, 2023 1:26 AM > To: devel@edk2.groups.io; Tan, Dun > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Ni, > Ray > Subject: RE: [edk2-devel] [PATCH 2/2]

Re: [edk2-devel] [PATCH 2/2] MdePkg:simplify Fifo API in BaseIoLibIntrinsic

2023-12-11 Thread Michael D Kinney
[edk2-devel] [PATCH 2/2] MdePkg:simplify Fifo API in > BaseIoLibIntrinsic > > Acked-by: Michael D Kinney > > Mike > > > -Original Message- > > From: Tan, Dun > > Sent: Wednesday, December 6, 2023 1:26 AM > > To: devel@edk2.groups.io; Tan, Dun

Re: [edk2-devel] [PATCH v1 1/1] FatPkg/FatPei: Check array offset before use

2023-12-12 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, December 12, 2023 11:24 AM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [edk2-devel] [PATCH v1 1/1] FatPkg/FatPei: Check arra

Re: [edk2-devel] [PATCH v4 3/8] MdePkg/MdeLibs.dsc.inc: Add SafeIntLib instance

2023-12-15 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Wu, Jiaxin > Sent: Friday, December 15, 2023 1:55 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Laszlo Ersek ; Ni, Ray ; Zeng, Star > > Subject: [PATCH v4

Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

2023-12-15 Thread Michael D Kinney
There are several advantages for this direction: * Current VFR compiler in C has dependencies on very old libs that have not been updated. * The movement to python will remove the pre-build step that requires some of the build tools to be built using host C compiler before running edk2 bui

[edk2-devel] TianoCore Community Meeting - call for topics

2024-01-10 Thread Michael D Kinney
Any topics for the TianoCore Community meeting this week? Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113539): https://edk2.groups.io/g/devel/message/113539 Mute This Topic: https://groups.io/mt/103646667/21656 Group Owner: devel

Re: [edk2-devel] TianoCore Community Meeting - call for topics

2024-01-10 Thread Michael D Kinney
Meeting canceled. Mike > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, January 10, 2024 10:37 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: TianoCore Community Meeting - call for topics > > Any topics for the TianoCore Community meeting this week?

Re: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest

2024-01-11 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Joey Vagedes > Sent: Thursday, January 11, 2024 1:35 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; > Kinney, Michael D > Subject: [PATCH v1 1/1] pip-requirements.txt: Update to la

Re: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest

2024-01-11 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/5256 From: Joey Vagedes via groups.io Sent: Thursday, January 11, 2024 3:16 PM To: Kinney, Michael D ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest Thanks Mike, I've updated the PR / branch w

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Michael D Kinney
Hi Pedro, Thank you for evaluating this idea change from linked list to improve performance of the handle database. The concept of using integers for an EFI_HANDLE has been considered before. One advantage over pointers is that a guarantee can be made that an EFI_HANDLE value can be guaranteed to

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Michael D Kinney
D Cc: pedro.falc...@gmail.com; Laszlo Ersek ; n...@os.amperecomputing.com; ardb+tianoc...@kernel.org Subject: Re: [edk2-devel] Memory Attribute for depex section On Jan 12, 2024, at 8:37 AM, Michael D Kinney mailto:michael.d.kin...@intel.com>> wrote: Hi Pedro, Thank you for evaluatin

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

2024-01-15 Thread Michael D Kinney
Hi Ray, I think nesting may be possible in physical platforms, but very hard to induce. One option is to consolidate to a single LocalApicTimerDxe implementation in the UefiCpuPkg, but allow the platform DSC to either specify a Null NestedInterruptTplLib for physical platforms or the full one fro

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver

2024-01-16 Thread Michael D Kinney
Unit tests for the math calculations would help with reviews too. Mike > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, January 16, 2024 2:03 AM > To: Kinney, Michael D ; Pedro Falcato > ; devel@edk2.groups.io; Ni, Ray > > Cc: Desimone, Nathaniel L ; Kumar, Rahul > R ; Gerd Ho

Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-18 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Pethaiyan, Madhan > Sent: Thursday, January 18, 2024 12:57 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Xu, Wei6 ; Tan, Ming > ; S, Ashraf Ali > Subject: RE: [PATCH V2] Fm

Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-18 Thread Michael D Kinney
D > Subject: RE: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition > > Reviewed-by: Michael D Kinney > > > > > -Original Message- > > From: Pethaiyan, Madhan > > Sent: Thursday, January 18, 2024 12:57 AM > > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-18 Thread Michael D Kinney
; > From: Kinney, Michael D > > Sent: Thursday, January 18, 2024 12:03 PM > > To: Pethaiyan, Madhan ; > devel@edk2.groups.io > > Cc: Gao, Liming ; Xu, Wei6 > > ; Tan, Ming ; S, Ashraf Ali > > ; Kinney, Michael D > > > Subject: RE: [PATCH V2] FmpDevicePk

Re: [edk2-devel] [PATCH RESEND v2 1/2] MdePkg: Adds AMD Extended CPU topology CPUID

2024-01-18 Thread Michael D Kinney
Acked-by: Michael D Kinney > -Original Message- > From: Abdul Lateef Attar > Sent: Wednesday, January 17, 2024 7:54 PM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Kinney, Michael D > ; Liming Gao ; > Liu, Zhiguang ; Ni, Ray ; > Kumar, Rahul R ; Ge

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf

2024-01-18 Thread Michael D Kinney
Hi Tom, I do not see any harm in zeroing ECX in AsmCpuid(). If it is not zeroed, then it would have an undefined value. However, calling AsmCpuid() for any Index that evaluates ECX (including a check for 0) should never be done. If ECX is evaluated for a given Index, then AsmCpuIdEx() must be u

Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error

2024-01-18 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Xu, Wei6 > Sent: Wednesday, January 17, 2024 10:12 AM > To: devel@edk2.groups.io > Cc: Xu, Wei6 ; Abner Chang ; > Desimone, Nathaniel L > Subject: [edk2-devel] [PAT

Re: [edk2-devel] [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default

2024-01-18 Thread Michael D Kinney
Acked-by: Michael D Kinney I will prepare PR for merge From: Kasbekar, Saloni Sent: Wednesday, January 17, 2024 9:27 AM To: Ashish Singhal ; devel@edk2.groups.io; Clark-williams, Zachary ; Jeff Brasen ; Kinney, Michael D ; Gao, Liming Subject: RE: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset

Re: [edk2-devel] [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default

2024-01-18 Thread Michael D Kinney
s.io>>; Clark-williams, Zachary mailto:zachary.clark-willi...@intel.com>>; Jeff Brasen mailto:jbra...@nvidia.com>>; Gao, Liming mailto:gaolim...@byosoft.com.cn>> Cc: Kinney, Michael D mailto:michael.d.kin...@intel.com>> Subject: RE: [PATCH] NetworkPkg/Ip4Dxe: Fix R

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf

2024-01-19 Thread Michael D Kinney
Hi Ray, It is about having deterministic behavior if a call if made for a CPUID EAX value that does depend on ECX. If ECX is not zeroed, then it will have a random value that may return different information. The problem statement from Tom is not about zeroing ECX. It is about avoiding code bug

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf

2024-01-19 Thread Michael D Kinney
The issue is if AsmCpuid() is called for an Index value that does depend on ECX. That would be a bug on the caller's part and would not have deterministic behavior because ECX on input is not deterministic. That is the condition that would be good to catch. Mike From: Ni, Ray Sent: Friday,

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Optimize CoreConnectSingleController

2024-01-19 Thread Michael D Kinney
I agree that this implements the similar check as other optional protocols to adjust driver binding order to skip checks for which where are no instances of the optional protocol. Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Z

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Remove the handle validation check in CoreGetProtocolInterface

2024-01-19 Thread Michael D Kinney
Hi Zhi, Some comments below. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhi Jin > Sent: Tuesday, January 16, 2024 10:45 PM > To: devel@edk2.groups.io > Cc: Jin, Zhi ; Liming Gao ; > Ni, Ray > Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg: Remove the handle > v

Re: [edk2-devel] [PATCH] BaseTools: Optimize GenerateByteArrayValue and CollectPlatformGuids APIs

2024-01-19 Thread Michael D Kinney
Hi Ashraf, What is captured in the file? What PCD/VPD changes will invalidate the cache? Just the number and type of PCD/VPD elements or their default values/sizes? How was this tested? Were all conditions that invalidate the cache tested? I ask because incremental build is a very important

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig

2024-01-19 Thread Michael D Kinney
10:10 AM > To: devel@edk2.groups.io; Ren, SuqiangX > Cc: Kinney, Michael D ; Liu, Zhiguang > ; Li, Yi1 > Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of > HiiConfigAccess ExtractConfig > > Reviewed-by: Liming Gao > > > -----邮件原件- >

Re: [edk2-devel] [PATCH] MdePkg: fix the types of casting for TD MMIO read

2024-01-19 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Please include Cc tags in commit message with the maintainers of the patch for review. Otherwise, the maintainers may miss the email patches. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhiquan > Li > Se

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions

2024-01-19 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/5277 From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Tuesday, January 16, 2024 6:18 AM To: devel@edk2.groups.io; sami.muja...@arm.com; 'PierreGondois' Subject: 回复: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _P

Re: [edk2-devel] [PATCH] MdePkg: fix the types of casting for TD MMIO read

2024-01-19 Thread Michael D Kinney
f casting for > TD MMIO read > > Reviewed-by: Michael D Kinney > > Please include Cc tags in commit message with the maintainers of > the patch for review. Otherwise, the maintainers may miss the > email patches. > > Thanks, > > Mike > > > >

Re: [edk2-devel] EFI_SYSTEM_TABLE allocated by AllocateRuntimeCopyPool isn't aligned to 4KB

2024-01-22 Thread Michael D Kinney
Hi Rebecca, I do not recall any statements in the EFI Spec that require 4KB alignment of the UEFI System Table, Boot Services Table, or Runtime Services Table. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran > Sent: Monday, January 22, 2024 11:53 AM >

Re: [edk2-devel] [PATCH 1/1] MdePkg:Updated the comments of EFI_FIRMWARE_MANAGEMENT_PROTOCOL

2024-01-22 Thread Michael D Kinney
ImageSize is not too small and Image is NULL." > > > > 2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo(): > > Add the following sentence at the end of the ImageInfo parameter > > description."May be NULL with a zero ImageInfoSize in order to > > determine the size of t

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin: UncrustifyCheck: use stat instead of os.stat

2024-01-22 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Joey Vagedes > Sent: Monday, January 22, 2024 3:21 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Kinney, Michael D > ; Sean Brogan > Subject: [PATCH v1 1/1] .pytool/Plugin: UncrustifyCheck: use stat

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-22 Thread Michael D Kinney
Hi Ray, +Andrew Fish That optimization was imported into git history 17 years ago, so it has effectively always been there. I do not recall the performance improvement at the time the optimization was originally implemented. The difference in behavior is that caching the result may miss an unin

Re: [edk2-devel] [PATCH 1/1] MdePkg: Add EFI_UNSUPPORTED return for some Runtime Service functions

2024-01-22 Thread Michael D Kinney
S_TABLE configuration table should be published > describing which runtime services are supported at runtime. So need to > add EFI_UNSUPPORTED return for some Runtime Service functions. > > REF: UEFI spec 2.10 section 8 Services — Runtime Services > > Signed-off-by: Suqiang Ren &

Re: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO

2024-01-22 Thread Michael D Kinney
dk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of > FileName on EFI_FILE_INFO > > Add the description of FileName to align with UEFI spec 2.10. > > REF: UEFI spec 2.10 Table 13.5.16 > > Signed-off-by: Suqiang Ren > Cc: Michael D Kinney > Cc: Liming Gao >

Re: [edk2-devel] [PATCH] BaseTools: Optimize GenerateByteArrayValue and CollectPlatformGuids APIs

2024-01-22 Thread Michael D Kinney
Hi Ashraf, The PcdValueInit feature is not limited to only PCDs of type VPD. It is for any structured PCDs. Did you test PCDs with all types (e.g. PcdsFixedAtBuild PcdsPactahbleInModule, PcdsDynamicHii, PcdsDynamicDatabase, PcdsDynamicVpd, PcdsDynamicExHii, PcdsDynamicExDatabase, PcdsDynamicExV

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig

2024-01-22 Thread Michael D Kinney
such BlockToConfig return failed, then > ignore the detail reason, but return EFI_DEVICE_ERROR in function > XxxExtractConfig? > > BR/Tan Ming. > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Saturday, January 20, 2024

[edk2-devel] [Patch 1/1] MdeModulePkg/Core/Dxe: Set MemoryTypeInfo bin range from HOB

2024-01-22 Thread Michael D Kinney
: Aaron Li Cc: Liu Yun Cc: Andrew Fish Signed-off-by: Michael D Kinney --- MdeModulePkg/Core/Dxe/DxeMain.h | 6 ++ MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 23 +++--- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 65 +++- MdeModulePkg/Core/Dxe/Mem/Page.c| 99

Re: [edk2-devel] [PATCH V3 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO

2024-01-23 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Ren, SuqiangX > Sent: Monday, January 22, 2024 11:03 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang > Subject: [PATCH V3 1/1] MdePkg: Update the definition of FileNa

Re: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance

2024-01-23 Thread Michael D Kinney
Hi Qing, Thank you for this update to add the missing API to BaseCpuLibNull. There are a few very minor comments below. I will make those updates in the PR for merge. With those changes: Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On

[edk2-devel] [Patch v2 1/1] MdeModulePkg/Core/Dxe: Set MemoryTypeInfo bin range from HOB

2024-01-23 Thread Michael D Kinney
: Aaron Li Cc: Liu Yun Cc: Andrew Fish Signed-off-by: Michael D Kinney --- MdeModulePkg/Core/Dxe/DxeMain.h | 6 ++ MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 23 +++--- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 72 - MdeModulePkg/Core/Dxe/Mem/Page.c| 101

Re: [edk2-devel] [PATCH V3 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO

2024-01-23 Thread Michael D Kinney
1] MdePkg: Update the definition of FileName on > EFI_FILE_INFO > > Reviewed-by: Michael D Kinney > > > -Original Message- > > From: Ren, SuqiangX > > Sent: Monday, January 22, 2024 11:03 PM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael

Re: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance

2024-01-23 Thread Michael D Kinney
dd stub > function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance > > Hi Qing, > > Thank you for this update to add the missing API to BaseCpuLibNull. > > There are a few very minor comments below. I will make those updates > in the PR for merge. With

Re: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard functions

2024-01-23 Thread Michael D Kinney
Hi Jeff, One comment below. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jeff > Brasen via groups.io > Sent: Monday, December 11, 2023 7:40 AM > To: devel@edk2.groups.io > Cc: Jeff Brasen > Subject: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard > functi

Re: [edk2-devel] [PATCH] MdePkg: Add FdtLib gmock support

2024-01-23 Thread Michael D Kinney
Hi Jeff, Thanks for this mock lib contribution. I few comments below. Thanks, Mike > -Original Message- > From: Jeff Brasen > Sent: Monday, December 11, 2023 7:43 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Liu, Zhiguang ; > Jeff Brasen > Subject: [PATCH

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: Remove the handle validation check in CoreGetProtocolInterface

2024-01-23 Thread Michael D Kinney
Hi Zhi, Thanks for the update. One minor comment on 'STATIC' should be 'static'. We no longer depend on macros to redefine 'STATIC' and it is better to just used the standard C 'static' form. With that change: Reviewed-by: Michael D Kinney Mike

Re: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance

2024-01-23 Thread Michael D Kinney
Hi Laszlo, Thanks for the feedback. Sorry I missed this email this morning. I will prepare a 2nd patch with these additional updates. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Tuesday, January 23, 2024 5:57 AM > To: devel@edk2.groups.io

[edk2-devel] [Patch 1/1] MdePkg/Library/BaseCpuLibNull: Add missing X86 specific services

2024-01-23 Thread Michael D Kinney
Cc: Laszlo Ersek Cc: Qing Huang Signed-off-by: Michael D Kinney --- .../Library/BaseCpuLibNull/BaseCpuLibNull.c | 17 + .../Library/BaseCpuLibNull/BaseCpuLibNull.inf | 3 + .../BaseCpuLibNull/X86BaseCpuLibNull.c| 64 +++ 3 files changed, 69 insertions(+), 15

Re: [edk2-devel] Resources for Creating Packages

2024-01-23 Thread Michael D Kinney
> -Original Message- > From: devel@edk2.groups.io On Behalf Of ryderkeys > via groups.io > Sent: Monday, January 22, 2024 10:25 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] Resources for Creating Packages > > Hello, > > (Originally sent to edk2 discuss but it looks like my mes

Re: [edk2-devel] [PATCH] MdePkg: Update ReceiveData and SendData function description

2024-01-23 Thread Michael D Kinney
on 13.14, update the parameter 'MediaId' > description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function > ReceiveData > and SendData. > > Signed-off-by: Qingyu Shang > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > --- > MdePkg/Include/Proto

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add FdtLib gmock support

2024-01-23 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Jeff Brasen > Sent: Tuesday, January 23, 2024 3:13 PM > To: devel@edk2.groups.io > Cc: gaolim...@byosoft.com.cn; Kinney, Michael D > ; Liu, Zhiguang ; > Jeff Brasen > Subject: [PATCH v2 1/1] MdePkg:

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseFdtLib: Rename standard functions

2024-01-23 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jeff > Brasen via groups.io > Sent: Tuesday, January 23, 2024 3:16 PM > To: devel@edk2.groups.io > Cc: gaolim...@byosoft.com.cn; Kinney, Michael D > ; Liu, Zhiguang ; >

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add FdtLib gmock support

2024-01-23 Thread Michael D Kinney
bject: RE: [PATCH v2 1/1] MdePkg: Add FdtLib gmock support > > Reviewed-by: Michael D Kinney > > > -Original Message- > > From: Jeff Brasen > > Sent: Tuesday, January 23, 2024 3:13 PM > > To: devel@edk2.groups.io > > Cc: gaolim...@byosoft.com.cn; Kinney,

Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset

2024-01-23 Thread Michael D Kinney
Hi Christine, I did not see this merged yet. Is this change also in edk2-basetools repo? I do not see it there. I thought the process was to do changed in edk2-basetools repo first where there are a large set of CI checks and then make the same change in the edk2 repo. Mike > -Original M

Re: [edk2-devel] [PATCH v4 1/1] MdeModulePkg/AcpiTableDxe: Prefer xDSDT over DSDT when installing tables

2024-01-23 Thread Michael D Kinney
Hi Liming, I do not see any reviews of this patch. What is the status? Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dhaval > Sharma > Sent: Monday, January 8, 2024 7:00 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Bi, Dandan ; Pedro > Falca

Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add FdtLib gmock support

2024-01-23 Thread Michael D Kinney
Reviewed-by: Michael D Kinney I also see you opened a PR to run EDK II CI and it passed. I will merge V3 Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jeff > Brasen via groups.io > Sent: Tuesday, January 23, 2024 7:08 PM > To: devel@edk2

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseFdtLib: Rename standard functions

2024-01-23 Thread Michael D Kinney
ject: RE: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseFdtLib: Rename > standard functions > > Reviewed-by: Michael D Kinney > > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Jeff > > Brasen via groups.io > > Sent: Tuesday, January

Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add FdtLib gmock support

2024-01-24 Thread Michael D Kinney
ject: RE: [edk2-devel] [PATCH v3 1/1] MdePkg: Add FdtLib gmock > support > > Reviewed-by: Michael D Kinney > > I also see you opened a PR to run EDK II CI and it passed. > > I will merge V3 > > Thanks, > > Mike > > > -Original Message- > > F

Re: [edk2-devel] [Patch v2 1/1] MdeModulePkg/Core/Dxe: Set MemoryTypeInfo bin range from HOB

2024-01-24 Thread Michael D Kinney
tch v2 1/1] MdeModulePkg/Core/Dxe: Set > MemoryTypeInfo bin range from HOB > > On 1/23/24 21:24, Michael D Kinney wrote: > > Provide an optional method for PEI to declare a specific address > > range to use for the Memory Type Information bins. The current > > algorithm

Re: [edk2-devel] [Patch v2 1/1] MdeModulePkg/Core/Dxe: Set MemoryTypeInfo bin range from HOB

2024-01-24 Thread Michael D Kinney
, Aaron > ; Liu, Yun Y ; Andrew Fish > > Subject: Re: [edk2-devel] [Patch v2 1/1] MdeModulePkg/Core/Dxe: Set > MemoryTypeInfo bin range from HOB > > On 1/23/24 21:24, Michael D Kinney wrote: > > Provide an optional method for PEI to declare a specific address > > rang

Re: [edk2-devel] 回复: [Patch v2 1/1] MdeModulePkg/Core/Dxe: Set MemoryTypeInfo bin range from HOB

2024-01-24 Thread Michael D Kinney
> that they should point their new HOB to the top of RAM? > > Thanks > Laszlo > > > > > Thanks > > Liming > >> -邮件原件- > >> 发件人: Michael D Kinney > >> 发送时间: 2024年1月24日 4:24 > >> 收件人: devel@edk2.groups.io > >&

Re: [edk2-devel] [PATCH 11/14] MdePkg: Test: Add gRT_GetTime Google Test Mock

2024-01-24 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Douglas Flick [MSFT] > Sent: Tuesday, January 23, 2024 7:34 PM > To: devel@edk2.groups.io > Cc: Douglas Flick [MSFT] ; Kinney, Michael D > ; Liming Gao ; > Liu, Zhiguang > Subject: [PATCH 11/14] MdePk

Re: [edk2-devel] 回复: [Patch v2 1/1] MdeModulePkg/Core/Dxe: Set MemoryTypeInfo bin range from HOB

2024-01-24 Thread Michael D Kinney
gt; > > > If the platform uses new way to describe the memory range, should > we > > > > suggest the rule to still > > > > use the top memory resource hob for the memory type bin range? > > > > > > How would that work, technically? If the platf

Re: [edk2-devel] [PATCH v2 3/4] UefiCpuPkg/MtrrLib.h: use cache type #defines from ArchitecturalMsr.h

2024-01-25 Thread Michael D Kinney
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, January 25, 2024 12:23 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Laszlo Ersek > ; Aktas, Erdem ; Michael Roth > ; Xu, Min M ; Gerd Hoffmann > ; Yao, Jiewen ; Tom Lendacky > ; Oliv

Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg: Support customized FV Migration Information

2023-10-16 Thread Michael D Kinney
change, PeiCore will check > ToMigrateFvInfo > hob before migration. If ToMigrateFvInfo hobs exists, only migrate FVs > recorded by hobs. If ToMigrateFvInfo hobs not exists, migrate all FVs > to > permanent memory. > > Cc: Michael D Kinney > Cc: Liming Gao

Re: [edk2-devel] [PATCHv2 2/2] MdePkg/Test: Add DevicePathLib host test module

2023-10-19 Thread Michael D Kinney
RE: [PATCHv2 2/2] MdePkg/Test: Add DevicePathLib host test > module > > Reviewed-by: Michael D Kinney > > > -Original Message- > > From: Albecki, Mateusz > > Sent: Wednesday, September 27, 2023 8:51 AM > > To: devel@edk2.groups.io > > Cc:

Re: [edk2-devel] [PATCH V2] Maintainers.txt: Stop to be reviewer of several modules

2023-10-19 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Monday, June 12, 2023 11:36 PM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Wu, Hao A > ; Liu, Zhiguang ; Guo, Gua > > Subject: [edk2-devel] [P

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Enhance StdLib for supporting Aarch64 and ARM

2023-10-20 Thread Michael D Kinney
getopt_long parser from OpenBSD to provide long and > short option parsing capability with getopt. > > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Tyler Erickson > --- > StdLib/Include/Aarch64/machine/int_fmtio.h | 211 + &g

Re: [edk2-devel] [PATCH v3 0/7] Use CodeQL CLI

2023-10-23 Thread Michael D Kinney
Acked-by: Michael D Kinney > -Original Message- > From: Michael Kubacki > Sent: Monday, October 23, 2023 11:13 AM > To: devel@edk2.groups.io; Feng, Bob C ; Gao, > Liming ; Kinney, Michael D > ; Rebecca Cran ; Sean > Brogan ; Chen, Christine > > Subject: Re:

Re: [edk2-devel] [PATCH v4 02/14] ArmVirtPkg: Add ImagePropertiesRecordLib Instance

2023-10-23 Thread Michael D Kinney
Hi Taylor, I see there have been no reviews from the package maintainers for this small update to some DSC files. You can use my Rb for this patch as a steward. Reviewed-by: Michael D Kinney Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Taylor &

Re: [edk2-devel] [PATCH v4 03/14] EmulatorPkg: Add ImagePropertiesRecordLib Instance

2023-10-23 Thread Michael D Kinney
Hi Taylor, I see there have been no reviews from the package maintainers for this small update to some DSC files. You can use my Rb for this patch as a steward. Reviewed-by: Michael D Kinney Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Taylor &

Re: [edk2-devel] [PATCH v4 04/14] OvmfPkg: Add ImagePropertiesRecordLib Instance

2023-10-23 Thread Michael D Kinney
Hi Taylor, I see there have been no reviews from the package maintainers for this small update to some DSC files. You can use my Rb for this patch as a steward. Reviewed-by: Michael D Kinney Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Taylor &

Re: [edk2-devel] [PATCH v4 05/14] UefiPayloadPkg: Add ImagePropertiesRecordLib Instance

2023-10-23 Thread Michael D Kinney
Hi Taylor, I see there have been no reviews from the package maintainers for this small update to some DSC files. You can use my Rb for this patch as a steward. Reviewed-by: Michael D Kinney Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Taylor &

Re: 回复: 回复: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs

2023-10-23 Thread Michael D Kinney
Hi Taylor, I did notice that the Signed-off-by tags in some of the commit messages do not look right. Signed-off-by: Taylor Beebe mailto:t...@taylorbeebe.com>> Please make sure those are updated. Thanks, Mike From: Taylor Beebe Sent: Friday, October 13, 2023 3:43 PM To: 'Ard Biesheuvel'

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Add .pytool maintainers to BaseTools/Plugin

2023-10-23 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Monday, October 23, 2023 5:15 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Kinney, Michael D > ; Rebecca Cran ; Sean > Brogan ; Chen, Christine &

Re: [edk2-devel] [PATCH v1 3/3] OvmfPkg: Add varpolicy shell command

2023-10-23 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Monday, October 23, 2023 5:44 PM > To: mikub...@linux.microsoft.com; devel@edk2.groups.io > Cc: Anatol Belski ; Anthony Perard > ; Gerd Hoffmann ; &

Re: [edk2-devel] [edk2-platforms PATCH] Maintainers.txt: remove Isaac Oram's email address

2023-10-25 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Wednesday, October 25, 2023 1:36 AM > To: edk2-devel-groups-io > Cc: Abdul Lateef Attar ; Abner Chang > ; S, Ashraf Ali ; Chiu, > Chasel ; Do

Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-10-25 Thread Michael D Kinney
12:43 PM, Vivian Nowka-Keane wrote: > > Hi Mike, > > > > Can you help merge this? Looks like it has all of the reviews. > > > > Thank you! > > - Vivian > > > > On 9/12/2023 7:42 AM, Michael D Kinney wrote: > >> Series Reviewed-by: Michael D Kin

Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-10-25 Thread Michael D Kinney
date on this. > > > > Thanks for your help, > > > > - Vivian > > > > On 9/27/2023 12:43 PM, Vivian Nowka-Keane wrote: > > > Hi Mike, > > > > > > Can you help merge this? Looks like it has all of the reviews. > > > > > > Thank

Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-10-26 Thread Michael D Kinney
; > Yes the sign-off is supposed to be the same, thanks for catching that. > And I'll update my git config for the future! > > The PR looks good > > Thanks, > - Vivian > > On 10/25/2023 11:08 AM, Michael D Kinney wrote: > > I also noticed that the Author was n

Re: [edk2-devel] [PATCH] Maintainers.txt: update Gary's email address

2023-10-28 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/4973 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110250): https://edk2.groups.io/g/devel/message/110250 Mute This Topic: https://groups.io/mt/93267348/21656 Group Owner: devel+ow...@edk2.g

[edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

2023-10-28 Thread Michael D Kinney
: Ray Han Lim Ng Cc: Stefan Berger Cc: Wenxing Hou Cc: Xiaoyu Lu Signed-off-by: Michael D Kinney --- Maintainers.txt | 53 ++--- 1 file changed, 2 insertions(+), 51 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 3f40cdeb5554

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

2023-10-29 Thread Michael D Kinney
This is the Wiki page where TianoCore documents the TianoCore community member roles. https://github.com/tianocore/tianocore.github.io/wiki/TianoCore-Who-we-are We can update/edit as needed to accurately reflect what all the Maintainers and Reviewers agree are their roles and responsibilities as

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

2023-10-29 Thread Michael D Kinney
Jordan L ; Julien Grall > ; > > Peter Grehan ; Zhang, Qi1 ; > Ng, > > Ray Han Lim ; Stefan Berger > > ; Hou, Wenxing ; Lu, > Xiaoyu1 > > > > Subject: Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based > on active > > community members > > >

Re: [edk2-devel] [PATCH v1 1/1] .azurepipelines: Fix Python version (to 3.12)

2023-10-30 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Joey Vagedes > Sent: Monday, October 30, 2023 9:42 AM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Michael Kubacki > ; Kinney, Michael D > ; Gao, Liming > Subject: [PATCH v1 1/1] .azurepipelines: Fix

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

2023-10-30 Thread Michael D Kinney
Hi Laszlo, I do not support orphaned categories and that option should be removed from Maintainer.txt. One of the motivations to get Maintainers.txt updated is to work on the set of tasks related to using GitHub PRs for code review. If a component is orphaned, then nobody would be assigned to a

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-10-30 Thread Michael D Kinney
Re: [edk2-devel] CpuDeadLoop() is optimized by compiler Mike, Sorry static was just to scope the name to the file since it is a lib, not to make it work. That is a cool site. I learned about it complaining about stuff to the compiler team on our internal clang Slack channel as they us

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows: Add Stale Check

2023-10-30 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Monday, October 30, 2023 6:41 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Michael Kubacki > ; Kinney, Michael D > ; Laszlo Ersek > Subject: [PATCH v1 1/1

  1   2   3   4   5   6   7   8   9   10   >