Hi Christine, I did not see this merged yet.
Is this change also in edk2-basetools repo? I do not see it there. I thought the process was to do changed in edk2-basetools repo first where there are a large set of CI checks and then make the same change in the edk2 repo. Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei > Chen > Sent: Sunday, January 7, 2024 4:29 PM > To: S, Ashraf Ali <ashraf.al...@intel.com>; devel@edk2.groups.io > Cc: Rebecca Cran <rebe...@bsdio.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Feng, Bob C <bob.c.f...@intel.com>; Chan, > Amy <amy.c...@intel.com>; Chaganty, Rangasai V > <rangasai.v.chaga...@intel.com> > Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of > SkuName and SkuId from allskuset > > Reviewed-by: Yuwei Chen <yuwei.c...@intel.com> > > > -----Original Message----- > > From: S, Ashraf Ali <ashraf.al...@intel.com> > > Sent: Monday, December 25, 2023 11:28 PM > > To: devel@edk2.groups.io > > Cc: S, Ashraf Ali <ashraf.al...@intel.com>; Chen, Christine > > <yuwei.c...@intel.com>; Rebecca Cran <rebe...@bsdio.com>; Gao, Liming > > <gaolim...@byosoft.com.cn>; Feng, Bob C <bob.c.f...@intel.com>; Chan, > > Amy <amy.c...@intel.com>; Chaganty, Rangasai V > > <rangasai.v.chaga...@intel.com> > > Subject: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId > > from allskuset > > > > Currently when the platform has many SKUs then allskuset will be > having so > > many duplicate. and while parsing the allskuset will take longer time > while > > assing Pcd.SkuInfoList. > > This patch is to eliminate those duplicate entires to reduce the build > time > > > > Cc: Yuwei Chen <yuwei.c...@intel.com> > > Cc: Rebecca Cran <rebe...@bsdio.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Bob Feng <bob.c.f...@intel.com> > > Cc: Amy Chan <amy.c...@intel.com> > > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > > Signed-off-by: Ashraf Ali S <ashraf.al...@intel.com> > > --- > > BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > index 592d4824a4..dac81454a9 100644 > > --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): > > self._DynamicPcdList.extend(list(OtherPcdArray)) > > self._DynamicPcdList.sort() > > allskuset = [(SkuName, Sku.SkuId) for pcd in > self._DynamicPcdList for > > (SkuName, Sku) in pcd.SkuInfoList.items()] > > + # Remove duplicate sets in the list > > + allskuset = list(set(allskuset)) > > for pcd in self._DynamicPcdList: > > if len(pcd.SkuInfoList) == 1: > > for (SkuName, SkuId) in allskuset: > > -- > > 2.39.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114245): https://edk2.groups.io/g/devel/message/114245 Mute This Topic: https://groups.io/mt/103360241/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
