Merged: https://github.com/tianocore/edk2/pull/4957
> -----Original Message----- > From: Vivian Nowka-Keane <vnowkake...@linux.microsoft.com> > Sent: Thursday, October 26, 2023 2:08 PM > To: devel@edk2.groups.io; Kinney, Michael D > <michael.d.kin...@intel.com> > Subject: Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update > > Yes the sign-off is supposed to be the same, thanks for catching that. > And I'll update my git config for the future! > > The PR looks good > > Thanks, > - Vivian > > On 10/25/2023 11:08 AM, Michael D Kinney wrote: > > I also noticed that the Author was not set correctly on > > these patches. I updated using the same name/email from > > your Signed-off-by tag. > > > > Please review your git config to match for future patches. > > > > I have started EDK II CI with the following PR: > > > > https://github.com/tianocore/edk2/pull/4957 > > > > Thanks, > > > > Mike > > > >> -----Original Message----- > >> From: Kinney, Michael D <michael.d.kin...@intel.com> > >> Sent: Wednesday, October 25, 2023 10:11 AM > >> To: Vivian Nowka-Keane <vnowkake...@linux.microsoft.com>; > >> devel@edk2.groups.io > >> Cc: Kinney, Michael D <michael.d.kin...@intel.com> > >> Subject: RE: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest > update > >> > >> Hi Vivian, > >> > >> I am working on this. However, I noticed that Patch 6/7 was > >> missing Signed-off-by tag. Is that supposed to be the same > >> as the other 6 patches? > >> > >> Signed-off-by: Vivian Nowka-Keane <vnowkake...@linux.microsoft.com> > >> > >> Thanks, > >> > >> Mike > >> > >>> -----Original Message----- > >>> From: Vivian Nowka-Keane <vnowkake...@linux.microsoft.com> > >>> Sent: Tuesday, October 24, 2023 1:35 PM > >>> To: devel@edk2.groups.io; Kinney, Michael D > >>> <michael.d.kin...@intel.com> > >>> Subject: Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest > >> update > >>> Hi, following up to see if there's any update on this. > >>> > >>> Thanks for your help, > >>> > >>> - Vivian > >>> > >>> On 9/27/2023 12:43 PM, Vivian Nowka-Keane wrote: > >>>> Hi Mike, > >>>> > >>>> Can you help merge this? Looks like it has all of the reviews. > >>>> > >>>> Thank you! > >>>> - Vivian > >>>> > >>>> On 9/12/2023 7:42 AM, Michael D Kinney wrote: > >>>>> Series Reviewed-by: Michael D Kinney<michael.d.kin...@intel.com> > >>>>> > >>>>>> -----Original Message----- > >>>>>> From:devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > >>>>>> VivianNK > >>>>>> Sent: Wednesday, August 16, 2023 2:15 PM > >>>>>> To:devel@edk2.groups.io > >>>>>> Subject: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest > >> update > >>>>>> v1 -> v2: > >>>>>> - Update commit message to explain the audit only mode > change > >> is > >>>>>> temporary to prevent intermediate CI failures. > >>>>>> - Format patch Cc's correctly > >>>>>> > >>>>>> v1 archive:https://edk2.groups.io/g/devel/message/107665 > >>>>>> > >>>>>> VivianNK (7): > >>>>>> .pytool: Set uncrustify check to audit only (temporary) > >>>>>> .pytool: Add cpp support to uncrustify plugin > >>>>>> MdeModulePkg: Apply uncrustify formatting to relevant > files. > >>>>>> MdePkg: Apply uncrustify formatting to relevant files > >>>>>> SecurityPkg: Apply uncrustify formatting to relevant files > >>>>>> UnitTestFrameworkPkg: Apply uncrustify formatting to > relevant > >>> files > >>>>>> .pytool: Undo uncrustify check change > >>>>>> > >>>>>> .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > >>>>>> | 2 +- > >>>>>> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg > >>>>>> | 4 +- > >>>>>> > >> > MdeModulePkg/Library/UefiSortLib/GoogleTest/UefiSortLibGoogleTest.cpp > >>>>>> | 37 +- > >>>>>> > >> > MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib > >>> .h > >>>>>> | 4 +- > >>>>>> > >>>>>> > >> > MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockPci > >>> HostBri > >>>>>> dgeLib.cpp | 8 +- > >>>>>> > >>>>>> > >> > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitT > >>> ests32. > >>>>>> cpp | 114 ++-- > >>>>>> > >>>>>> > >> > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitT > >>> ests64. > >>>>>> cpp | 114 ++-- > >>>>>> > >>> > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp > >>>>>> | 563 ++++++++++---------- > >>>>>> MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h > >>>>>> | 6 +- > >>>>>> > MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h > >>>>>> | 6 +- > >>>>>> MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h > >>>>>> | 4 +- > >>>>>> > >>>>>> > >> > MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiRuntimeServicesTab > >>> leLib.h > >>>>>> | 4 +- > >>>>>> MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp > >>>>>> | 40 +- > >>>>>> > >>>>>> > >> > MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServices > >>> Lib.cpp > >>>>>> | 52 +- > >>>>>> MdePkg/Test/Mock/Library/GoogleTest/MockUefiLib/MockUefiLib.cpp > >>>>>> | 6 +- > >>>>>> > >>>>>> > >> > MdePkg/Test/Mock/Library/GoogleTest/MockUefiRuntimeServicesTableLib/Mo > >>> ckUefiR > >>>>>> untimeServicesTableLib.cpp | 12 +- > >>>>>> > >>>>>> > >> > SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariabl > >>> eLibGoo > >>>>>> gleTest.cpp | 205 ++++--- > >>>>>> > >>>>>> > >> > SecurityPkg/Test/Mock/Include/GoogleTest/Library/MockPlatformPKProtect > >>> ionLib. > >>>>>> h | 4 +- > >>>>>> > >>>>>> > >> > SecurityPkg/Test/Mock/Library/GoogleTest/MockPlatformPKProtectionLib/M > >>> ockPlat > >>>>>> formPKProtectionLib.cpp | 4 +- > >>>>>> UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h > >>>>>> | 2 +- > >>>>>> > >>>>>> > >> > UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoo > >>> gleTest > >>>>>> .cpp | 76 +-- > >>>>>> 21 files changed, 664 insertions(+), 603 deletions(-) > >>>>>> > >>>>>> -- > >>>>>> 2.41.0.windows.3 > >>>>>> > >>>>>> > >>>>>> > >>>>>> -=-=-=-=-=-= > >>>>>> Groups.io Links: You receive all messages sent to this group. > >>>>>> View/Reply Online > >>>>>> (#107809):https://edk2.groups.io/g/devel/message/107809 > >>>>>> Mute This Topic:https://groups.io/mt/100788665/1643496 > >>>>>> Group Owner:devel+ow...@edk2.groups.io > >>>>>> Unsubscribe:https://edk2.groups.io/g/devel/unsub > >>>>>> [michael.d.kin...@intel.com] > >>>>>> -=-=-=-=-=-= > >>>>>> > >>>>> > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110170): https://edk2.groups.io/g/devel/message/110170 Mute This Topic: https://groups.io/mt/100788665/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
