Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

(snipping liberally) On 09/25/19 10:13, Marvin Häuser wrote: > Am 24.09.2019 um 22:26 schrieb Laszlo Ersek: >> I'm opposed to enforcing the strict aliasing rules, even though in >> all code that I write, I either try to conform to them, or at least I >> seek to be f

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Enable/Disable S3BootScript dynamically.

nternal platform and S3BootScript > functions can be skipped by PCD during boot time. > > Cc: Hao A Wu > Cc: Eric Dong > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Laszlo Ersek > Signed-off-by: Chasel Chiu > --- > MdeModulePkg/Library/PiDxeS3BootScriptLib/BootS

Re: [edk2-devel] [RFC PATCH v2 08/44] OvmfPkg: Create GHCB pages for use during Pei and Dxe phase

e address, and then we clear the GHCB, but that seems to be it. Do we write anything non-zero to that block, ever? Thanks Laszlo > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Tom Lendacky > --- > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ >

Re: [edk2-devel] [RFC PATCH v2 10/44] OvmfPkg: A per-CPU variable area for #VC usage

ared (and > that is done), but DXE is not as easy. There needs to be a way to change > the pagetables created for DXE using CreateIdentityMappingPageTables() > before switching to them. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by:

Re: [edk2-devel] [PATCH 29/35] ShellPkg: stop using EFI_HANDLE in place of EFI_HII_HANDLE

On 09/25/19 20:04, Philippe Mathieu-Daudé wrote: > On 9/17/19 9:49 PM, Laszlo Ersek wrote: >> 25 files changed, 33 insertions(+), 33 deletions(-) > I checked every case, entertaining. > Reviewed-by: Philippe Mathieu-Daude Many thanks for the ef

Re: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE

On 09/26/19 04:53, Gao, Zhichao wrote: > > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Wednesday, September 18, 2019 3:50 AM >> To: edk2-devel-groups-io >> Cc:

Re: [edk2-devel] [PATCH 09/35] MdeModulePkg: stop abusing EFI_EVENT for protocol notify registration

On 09/25/19 18:02, Philippe Mathieu-Daudé wrote: > On 9/17/19 9:49 PM, Laszlo Ersek wrote: >> EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration", >> similarly to gBS->RegisterProtocolNotify(). We should pass the address of >> an actual pointer-

Re: [edk2-devel] [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call

Leif, Ard, On 09/17/19 21:49, Laszlo Ersek wrote: > - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: > > IN OUT EFI_HANDLE *ChildHandle > > - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: > > IN EFI_HANDLE ChildHandle > > Fix

Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()

Jiaxin, Siyuan, can you please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*). > NetLibGetMacAddress() only uses the return value ("SnpHandle") for a > NULL-check. Fix the type of &qu

Re: [edk2-devel] [PATCH 19/35] NetworkPkg: fix CloseProtocol & UninstallMultipleProtocolInterfaces calls

Jiaxin, Siyuan, can you please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > Both the "ControllerHandle" parameter of CloseProtocol() and the "Handle" > parameter of UninstallMultipleProtocolInterfaces() have type EFI_HANDLE, > not (

Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call

Jiaxin, Siyuan, can you please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD > take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*). > > This patch fix

Re: [edk2-devel] [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeFoo() parameter list

Jiaxin, Siyuan, can you please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > The SockFreeFoo() callback function for NetbufFromExt() has to match the > NET_VECTOR_EXT_FREE prototype, which takes a (VOID*) as callback argument > (Arg). EFI_EVENT has noth

Re: [edk2-devel] [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call

Jordan, Ard, may I please get an R-b for this patch? It's quite simple. (Sorry if it's already in your queue.) Thank you, Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). > Fix the call in the notifica

Re: [edk2-devel] [PATCH 25/35] OvmfPkg/VideoDxe: document EFI_EDID_OVERRIDE_PROTOCOL.GetEdid() call

On 09/23/19 17:59, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 9/17/19 9:49 PM, Laszlo Ersek wrote: >> According to the UEFI spec -- and to the edk2 header >> "MdePkg/Include/Protocol/EdidOverride.h" too --, >> EFI_EDID_OVERRIDE_PROTOCOL_GET_ED

Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration

Chao, Jian, Jiewen, can you please review this patch? Thanks, Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration", > similarly to gBS->RegisterProtocolNotify(). We should pass the address of > an actual pointe

Re: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls

Chao, Jian, Jiewen, can you please review this patch? Thanks, Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > Unlike the InstallMultipleProtocolInterfaces() boot service, which takes > an (EFI_HANDLE*) as first parameter, the > UninstallMultipleProtocolInterfaces() boot service

Re: [edk2-devel] [PATCH 32/35] ShellPkg/UefiShellLib: clarify workaround for unfixable EdkShell bug

Jaben, Ray, Zhichao, can one of you guys please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > The EDK 1 Shell (available at <https://github.com/tianocore/edk-Shell>) > has a bug in its EFI_SHELL_ENVIRONMENT2.Execute() implementation that > edk2's

Re: [edk2-devel] [PATCH 33/35] StandaloneMmPkg/Core: stop abusing EFI_HANDLE for FwVolHeader tracking

Achin, Jiewen, Supreeth, can one of you guys please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > The FvHasBeenProcessed() and FvIsBeingProcesssed() functions make sure > that every firmware volume is processed only once (every driver in every > firmwa

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Enable/Disable S3BootScript dynamically.

On 09/26/19 03:52, Chiu, Chasel wrote: > > Thanks Laszlo for your time on detail reviewing and very good feedbacks! > Please see my reply inline below. > >> -Original Message----- >> From: Laszlo Ersek >> Sent: Thursday, September 26, 2019 2:58 AM >> To

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

ddressRangeMemory; > ); > > If we want to support this feature in legacy BIOS, we also need reserve the > black hole here. > > Thank you > Yao Jiewen > > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >> Sen

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/PiSmmCpu: Remove hard code when getting physical line size

Hi Ray, On 09/26/19 02:09, Ray Ni wrote: > The code replaces the hard code with macros defined in > MdePkg\Include\Register\Intel\CpuId.h. > > No functionality impact. > > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > --- > UefiCpuPkg/PiS

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxe: Honor the physical address size in CpuInfo HOB

havior of > existing code that builds the page table. > > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > --- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 39 - > 1 file changed, 12 insertions(+), 27 deletions(-) > > diff --

Re: [edk2-devel] [PATCH V1 0/5] UEFI Variable SMI Reduction

CachePendingLength to > RuntimeCache > 3. Clear the RuntimeCachePendingUpdate flag > > Proposed SMM Write Flow > > 1. Perform variable authentication and non-volatile write. If either fail, > return an error to the caller. > 2. If RuntimeCach

Re: [edk2-devel] [PATCH 0/4] trivial: Fix typos in "processing/processed"

StandaloneMmPkg/Core/FwVol.c | 4 ++-- > 5 files changed, 9 insertions(+), 9 deletions(-) > series Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48127): https://edk2.groups.io/g/devel/m

Re: [edk2-devel] Problem with decompression on EDK2

On 09/26/19 11:27, Loh, Tien Hock wrote: > Hi > > I have an issue while porting a new platform to EDK2. After porting the > Stratix 10 platform (ARM) to EDK2 it works correctly. However, when I tried > to add more INF to the FDF file, it failed to decompress the image during > boot time, log as

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0

On 09/25/19 17:50, Pete Batard wrote: > The existing loop is set to call PlatformBootManagerWaitCallback every > second except the last one. We believe this is a mistake as it prevents > the called code from performing timeout expiration tasks such as, for > instance, ensuring that the last segment

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

Hi Igor, On 09/24/19 13:19, Igor Mammedov wrote: > On Mon, 23 Sep 2019 20:35:02 +0200 > "Laszlo Ersek" wrote: >> I've got good results. For this (1/2) QEMU patch: >> >> Tested-by: Laszlo Ersek >> >> I tested the following scenarios. In every c

Re: [edk2-devel] [RFC PATCH v2 08/44] OvmfPkg: Create GHCB pages for use during Pei and Dxe phase

On 09/26/19 16:00, Lendacky, Thomas wrote: > On 9/26/19 3:00 AM, Laszlo Ersek wrote: >> Hi Tom, >> >> On 09/19/19 21:52, Lendacky, Thomas wrote: >>> From: Tom Lendacky >>> >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >&

Re: [edk2-devel] [RFC PATCH v2 08/44] OvmfPkg: Create GHCB pages for use during Pei and Dxe phase

On 09/26/19 16:00, Lendacky, Thomas wrote: > On 9/26/19 3:00 AM, Laszlo Ersek wrote: >> Hi Tom, >> >> On 09/19/19 21:52, Lendacky, Thomas wrote: >>> From: Tom Lendacky >>> >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >&

Re: [edk2-devel] [RFC PATCH v2 10/44] OvmfPkg: A per-CPU variable area for #VC usage

On 09/26/19 16:46, Lendacky, Thomas wrote: > On 9/26/19 3:17 AM, Laszlo Ersek wrote: >> On 09/19/19 21:52, Lendacky, Thomas wrote: >>> From: Tom Lendacky >>> >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >>> >>> A per-CPU im

Re: [edk2-devel] [RFC PATCH v2 04/44] OvmfPkg/ResetVector: Add support for a 32-bit SEV check

On 09/24/19 20:57, Lendacky, Thomas wrote: > On 9/24/19 8:42 AM, Laszlo Ersek wrote: >> On 09/19/19 21:52, Lendacky, Thomas wrote: >>> +; Issue VMGEXIT (rep; vmmcall) >>> +db 0xf3 >>> +db 0x0f >>> +db 0x01 >>>

Re: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE

uckily, that's what the patch uses anyway. > > Back to the patch, it is OK to me now. Reviewed-by: Zhichao Gao > Thank you! Laszlo > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >>

Re: [edk2-devel] [PATCH 19/35] NetworkPkg: fix CloseProtocol & UninstallMultipleProtocolInterfaces calls

Hi Phil, On 09/26/19 14:42, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 9/17/19 9:49 PM, Laszlo Ersek wrote: >> Both the "ControllerHandle" parameter of CloseProtocol() > > Maybe worth adding "of type EFI_CLOSE_PROTOCOL&quo

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

Hi Liming, On 09/27/19 09:46, Liming Gao wrote: > __inline__ attribute will make the functions not be exposed as the > library interface. It will cause CLANG9 compiler fail. > > Signed-off-by: Liming Gao > --- > MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 -- > 1 file changed, 6 deleti

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

Hi Liming, On 09/27/19 09:46, Liming Gao wrote: > 1. Apply CLANG9 Linker option. I'm confused by this, in two regards. - Why do we refer to CLANG9 first as being in the GCC toolchain family (see near mmx/sse), and then under a totally different family name (CLANGPE?) - Regarding the CLANGPE opt

Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

+ Jordan On 09/27/19 09:46, Liming Gao wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2024 > > Signed-off-by: Liming Gao > --- > OvmfPkg/Sec/SecMain.inf | 4 > 1 file changed, 4 insertions(+) > > diff --git a/OvmfPkg/Sec/SecMain.inf b/OvmfPkg/Sec/SecMain.inf > index 63ba4cb555.

Re: [edk2-devel] NVDIMM with QEMU+OVMF

On 09/29/19 11:01, Tiger Liu(BJ-RD) wrote: > Hi, Laszlo: > Ask a question about NVDIMM support within Qemu+OVMF environment. > > It seems QEMU support NVDIMM type. > > Does current OVMF code support emulated NVDIMM controller init? No, not to my knowledge. Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=

Re: [edk2-devel] [Patch v2] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

On 09/27/19 02:23, Liming Gao wrote: > ShellBinPkg is generated for each edk2 stable tag release. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Signed-off-by: Liming Gao > --- > In v2, use real URL for edk2 rele

Re: [edk2-devel] [PATCH 1/1] BaseTools: use stdint.h for GCC ProcessorBind.h typedefs

idea than hardcoding >> them. So copy the pattern from X64/ProcesorBind.h. > > Typo: X64/ProcessorBind.h ('s' missing). > >> >> Cc: Ard Biesheuvel >> Cc: Bob Feng >> Cc: Liming Gao >> Cc: Laszlo Ersek >> Signed-off-by: Leif Lindholm

Re: [edk2-devel] [PATCH V1 0/5] UEFI Variable SMI Reduction

>> From: Kubacki, Michael A >> Sent: Thursday, September 26, 2019 1:29 PM >> To: Laszlo Ersek ; devel@edk2.groups.io >> Cc: Bi, Dandan ; Ard Biesheuvel >> ; Dong, Eric ; Gao, Liming >> ; Kinney, Michael D ; >> Ni, Ray ; Wang, Jian J ; Wu, Hao >> A ; Y

Re: [edk2-devel] [PATCH V1 0/5] UEFI Variable SMI Reduction

On 10/01/19 00:43, Laszlo Ersek wrote: > On 09/27/19 00:35, Kubacki, Michael A wrote: >> After thinking a bit more, this test is based on a side effect of >> implementation. I'd prefer to avoid this being the sole cause of additional >> complexity in an already comple

Re: [edk2-devel] [PATCH v3] MdeModulePkg: Enable/Disable S3BootScript dynamically.

tions can be skipped by PCD during boot time. > > Cc: Hao A Wu > Cc: Eric Dong > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Laszlo Ersek > Signed-off-by: Chasel Chiu > --- > MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptSave.c | 17 > - >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0

On 09/30/19 03:24, Ni, Ray wrote: > Existing close source platform BDS only updates UI in this function. > Reviewed-by: Ray Ni Thanks, Ray! Can you please push this patch for Pete? Thanks Laszlo > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Pete Batard >> Sent: We

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

atches, we add the new data type named "EfiTlsVerifyHost" and >> the EFI_TLS_VERIFY_HOST_FLAG for the TLS protocol consumer (HTTP) to >> enable the host name check so as to avoid the potential >> Man-In-The-Middle attack. >> >> Contributed-under: TianoCore Contri

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

ith the commit message change, the series reviewed-by: jiewen@intel.com Thank you Jiewen -- it's possible that I'll post a v2, based on David's answer, and then I'll pick up your R-b for unchanged patches from v1. Thanks Laszlo > >> -Original Message

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

On 09/27/19 13:35, Igor Mammedov wrote: > On Tue, 24 Sep 2019 13:34:55 +0200 > "Laszlo Ersek" wrote: >> Going forward, if I understand correctly, the plan is to populate the >> new SMRAM with the hotplug SMI handler. (This would likely be put in >> place by Ovm

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

On 09/30/19 16:22, Yao, Jiewen wrote: > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Igor >> Mammedov >> Sent: Monday, September 30, 2019 8:37 PM >> To: Laszlo Ersek >>> To me it looks like we need to figure out how QEMU can

Re: [edk2-devel] [RFC PATCH v2 08/44] OvmfPkg: Create GHCB pages for use during Pei and Dxe phase

e GHCB PCDs (PcdGhcbBase and PcdGhcbSize). > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Tom Lendacky > --- > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > OvmfPkg/OvmfPkg

Re: [edk2-devel] [RFC PATCH v2 10/44] OvmfPkg: A per-CPU variable area for #VC usage

y the GHCB pages as shared (and > that is done), but DXE is not as easy. There needs to be a way to change > the pagetables created for DXE using CreateIdentityMappingPageTables() > before switching to them. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel

Re: [edk2-devel] [RFC PATCH v2 11/44] OvmfPkg/PlatformPei: Move early GDT into ram when SEV-ES is enabled

> will be read as un-encrypted even though it is encrypted. This will result > in a failure to be able to handle the exception. > > Move the GDT into RAM so it can be accessed without error when running as > an SEV-ES guest. > > Cc: Jordan Justen > Cc: Laszlo Ersek

Re: [edk2-devel] [RFC PATCH v2 16/44] OvmfPkg/MemEncryptSevLib: Make MemEncryptSevLib available during SEC

On 09/19/19 21:52, Lendacky, Thomas wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > The SEC phase of OVMF will need access to the MemEncryptSevLib library, > so make the library available during SEC. > > Cc: Jordan Justen

Re: [edk2-devel] [RFC PATCH v2 16/44] OvmfPkg/MemEncryptSevLib: Make MemEncryptSevLib available during SEC

On 10/02/19 14:24, Laszlo Ersek wrote: > On 09/19/19 21:52, Lendacky, Thomas wrote: >> From: Tom Lendacky >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >> >> The SEC phase of OVMF will need access to the MemEncryptSevLib library, >> s

Re: [edk2-devel] [RFC PATCH v2 18/44] OvmfPkg/Sec: Enable cache early to speed up booting

> with SEV-ES, the hypervisor is not allowed to change the CR0 register > to enable caching. > > Update the OVMF Sec support to enable caching in order to improve the > boot speed when running as an SEV-ES guest. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc:

Re: [edk2-devel] [RFC PATCH v2 39/44] OvmfPkg: Move the GHCB allocations into reserved memory

or write. > > Change the GHCB allocation from the default boot services memory to > reserved memory. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Tom Lendacky > --- > OvmfPkg/PlatformPei/AmdSev.c | 4 +++- > 1 file changed, 3 ins

Re: [edk2-devel] [RFC PATCH v2 37/44] OvmfPkg: Add support for SEV-ES AP reset vector re-directing

n after having been started. This is required for only the > very first AP reset. (1) In the commit message, can you mention the build mechanism by which this file overrides the original in UefiCpuPkg? Is it due to include path order? > > Cc: Jordan Justen > Cc: Laszlo Ersek >

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

Adding Phil. I'm looking at this patch only because one thing caught my attention in the previous one, "OvmfPkg: Add support for SEV-ES AP reset vector re-directing": On 09/19/19 21:53, Lendacky, Thomas wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > >

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

On 10/02/19 17:15, Laszlo Ersek wrote: > Adding Phil. > > I'm looking at this patch only because one thing caught my attention in > the previous one, "OvmfPkg: Add support for SEV-ES AP reset vector > re-directing": > > On 09/19/19 21:53, Lendacky, Thomas wr

Re: [edk2-devel] [RFC PATCH v2 08/44] OvmfPkg: Create GHCB pages for use during Pei and Dxe phase

On 10/02/19 16:43, Lendacky, Thomas wrote: > On 10/2/19 5:23 AM, Laszlo Ersek wrote: >> On 09/19/19 21:52, Lendacky, Thomas wrote: >>> @@ -38,6 +44,34 @@ AmdSevEsInitialize ( >>> >>>PcdStatus = PcdSetBoolS (PcdSevEsActive, 1); &

Re: [edk2-devel] [RFC PATCH v2 10/44] OvmfPkg: A per-CPU variable area for #VC usage

On 10/02/19 18:06, Lendacky, Thomas wrote: > On 10/2/19 6:51 AM, Laszlo Ersek wrote: >> ... Side question: actually, do we support S3 with SEV enabled, at the >> moment? Last week or so I tried to test it, and it didn't work. I don't >> remember if we *intended* to

Re: [edk2-devel] [RFC PATCH v2 37/44] OvmfPkg: Add support for SEV-ES AP reset vector re-directing

On 10/02/19 19:33, Lendacky, Thomas wrote: > On 10/2/19 9:54 AM, Laszlo Ersek wrote: >> On 09/19/19 21:53, Lendacky, Thomas wrote: >>> From: Tom Lendacky >>> >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >>> >>> A hypervisor is

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

On 10/02/19 19:58, Lendacky, Thomas wrote: > On 10/2/19 10:15 AM, Laszlo Ersek via Groups.Io wrote: >> Adding Phil. >> >> I'm looking at this patch only because one thing caught my attention in >> the previous one, "OvmfPkg: Add support for SEV-ES AP reset ve

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

On 10/02/19 20:07, Lendacky, Thomas wrote: > On 10/2/19 10:26 AM, Laszlo Ersek wrote: >> On 10/02/19 17:15, Laszlo Ersek wrote: >>> Adding Phil. >>> >>> I'm looking at this patch only because one thing caught my attention in >>> the previous one

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

On 10/03/19 12:12, Laszlo Ersek wrote: > UINT32 ApEntryPoint; > EFI_GUID SevEsFooterGuid; > UINT16 Size; It's probably better to reverse the order of "Size" and "SevEsFooterGuid", like this: UINT32 ApEntryPoint; UINT16 Size; EFI_GUID SevEs

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

On 10/03/19 10:04, Wu, Hao A wrote: > Before any comment on the patch, since I am not experienced in the Variable > driver, I would like to ask for help from other reviewers to look into this > patch and provide feedbacks as well. Thanks in advance. > > With the above fact, some comments provided

Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()

Pinging NetworkPkg maintainers again. Please? Thanks Laszlo On 09/26/19 14:14, Laszlo Ersek wrote: > Jiaxin, Siyuan, > > can you please review this patch? > > Thanks > Laszlo > > On 09/17/19 21:49, Laszlo Ersek wrote: >> NetLibGetSnpHandle() returns an

Re: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls

Pinging SecurityPkg maintainers again, for reviewing this patch. Thanks Laszlo On 09/26/19 14:45, Laszlo Ersek wrote: > Chao, Jian, Jiewen, > > can you please review this patch? > > Thanks, > Laszlo > > On 09/17/19 21:49, Laszlo Ersek wrote: >> Unlike the Ins

Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration

Pinging SecurityPkg maintainers again, for reviewing this patch. Thanks Laszlo On 09/26/19 14:46, Laszlo Ersek wrote: > Chao, Jian, Jiewen, > > can you please review this patch? > > Thanks, > Laszlo > > > On 09/17/19 21:49, Laszlo Ersek wrote: >> EfiCreatePr

Re: [edk2-devel] [PATCH 33/35] StandaloneMmPkg/Core: stop abusing EFI_HANDLE for FwVolHeader tracking

Pinging StandaloneMmPkg maintainers again, for reviewing this patch. Thanks Laszlo On 09/26/19 14:48, Laszlo Ersek wrote: > Achin, Jiewen, Supreeth, > > can one of you guys please review this patch? > > Thanks > Laszlo > > On 09/17/19 21:49, Laszlo Ersek wrote: >>

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

On 10/03/19 23:53, Kubacki, Michael A wrote: > #1 - The plan is to remove the polling entirely in V3. > > #2 - I'd prefer to take a definitive direction and reduce validation and > maintenance > effort but you and Laszlo both requested this so I'll add a > FeaturePCD to control >

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

Michael D >> Sent: Thursday, October 3, 2019 3:01 PM >> To: Kubacki, Michael A ; Wu, Hao A >> ; devel@edk2.groups.io; Kinney, Michael D >> >> Cc: Bi, Dandan ; Ard Biesheuvel >> ; Dong, Eric ; Laszlo Ersek >> ; Gao, Liming ; Ni, Ray >> ; Wang, Jian J

Re: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls

22-2-lersek@redhat.com https://edk2.groups.io/g/devel/message/47388 Thanks, Laszlo > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 2019年10月3日 19:07 > To: Zhang, Chao B ; Wang, Jian J > ; Yao, Jiewen > Cc: edk2-devel-groups-io > Su

Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()

Ping On 10/03/19 13:05, Laszlo Ersek wrote: > Pinging NetworkPkg maintainers again. Please? > > Thanks > Laszlo > > On 09/26/19 14:14, Laszlo Ersek wrote: >> Jiaxin, Siyuan, >> >> can you please review this patch? >> >> Thanks >&

Re: [edk2-devel] [edk2-platforms: PATCH 1/1] DisplayLinkPkg: DisplayLinkGop: Added GOP driver for USB docking stations based on DisplayLink chips

Hello Andy, I've got a question about your edk2-platforms commit 9df63499ea01 (i.e., this patch): On 08/30/19 17:27, Leif Lindholm wrote: > On Mon, Aug 19, 2019 at 02:32:00PM +0100, Andy Hayes wrote: [...] >> diff --git a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Edid.c >> b/Drivers/Di

Re: [edk2-devel] [PATCH 25/35] OvmfPkg/VideoDxe: document EFI_EDID_OVERRIDE_PROTOCOL.GetEdid() call

On 09/26/19 14:43, Laszlo Ersek wrote: > On 09/23/19 17:59, Philippe Mathieu-Daudé wrote: >> Hi Laszlo, >> >> On 9/17/19 9:49 PM, Laszlo Ersek wrote: >>> According to the UEFI spec -- and to the edk2 header >>> "

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

On 10/04/19 16:09, Igor Mammedov wrote: > On Tue, 1 Oct 2019 17:31:17 +0200 > "Laszlo Ersek" wrote: >> (It does not matter if another hotplug CPU starts the relocation in SMM >> while the earlier one is left with *only* the RSM instruction in SMM, >> immediate

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

On 10/04/19 13:31, Igor Mammedov wrote: > On Tue, 1 Oct 2019 20:03:20 +0200 > "Laszlo Ersek" wrote: >> (1) What values to use. > SeaBIOS writes 0x00 into command port, but it seems that's taken by > EFI_SMM_COMMUNICATION_PROTOCOL. So we can use the next

Re: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls

ubject: RE: [edk2-devel] [PATCH 26/35] SecurityPkg: fix > UninstallMultipleProtocolInterfaces() calls > > Hi Laszlo: >Sorry for late response. The fix is good to me. I am also interested in > how you find this issue, can you share it? > > -Original Message- > From: Las

[edk2-devel] [PATCH 0/4] UefiCpuPkg, OvmfPkg: separate PCDs for boot CPU count vs. max CPU count

t patch set for QEMU) completes the VCPU hotplug feature: it allows S3 resume to work with VCPUs hot-plugged previously (at OS runtime, of course). Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Eric Dong Cc: Igor Mammedov Cc: Jordan Justen Cc: Julien Grall Cc: Ray Ni Thanks Laszlo Laszlo Ersek (4

[edk2-devel] [PATCH 3/4] OvmfPkg/IndustryStandard: define FW_CFG_X86_TOPOLOGY structure type

pc-q35-4.2+ and pc-i440fx-4.2+ machine types report CPU topology info in the "etc/x86-smp-topology" fw_cfg file. Add a structure type for parsing this blob. Cc: Ard Biesheuvel Cc: Igor Mammedov Cc: Jordan Justen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515 Signed-off-

[edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection

c Dong Cc: Igor Mammedov Cc: Ray Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515 Signed-off-by: Laszlo Ersek --- UefiCpuPkg/UefiCpuPkg.dec | 11 + UefiCpuPkg/UefiCpuPkg.uni | 4 ++ UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + UefiCpuP

[edk2-devel] [PATCH 2/4] OvmfPkg/OvmfXen.dsc: remove PcdCpu* dynamic defaults

l Cc: Igor Mammedov Cc: Jordan Justen Cc: Julien Grall Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfXen.dsc | 4 1 file changed, 4 deletions(-) diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc index 5a31f75f05d0..6deafea034c0

[edk2-devel] [PATCH 4/4] OvmfPkg/PlatformPei: rewrite MaxCpuCountInitialization() for CPU hotplug

nocore.org/show_bug.cgi?id=1515 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc | 2 +- OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- OvmfPkg/OvmfPkgX64.dsc | 2 +- OvmfPkg/PlatformPei/PlatformPei.inf | 2 +- OvmfPkg/PlatformPei/Platform.c | 83 +--

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

On 10/08/19 16:47, Gao, Liming wrote: > [Liming] I verify GCC5 tool chain. I will verify GCC48/GCC49 and > XCODE5. > > I don’t know the specific reason about __inline__. If there is no > impact on > > other GCC tool chain, I prefer to remove them. > [Liming] This seems the r

Re: [edk2-devel] [PATCH 0/4] UefiCpuPkg, OvmfPkg: separate PCDs for boot CPU count vs. max CPU count

On 10/08/19 13:35, Ard Biesheuvel wrote: > On Tue, 8 Oct 2019 at 13:27, Laszlo Ersek wrote: >> >> Repo: https://github.com/lersek/edk2.git >> Branch: max_cpus_bz_1515 >> Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=1515 >> >> UefiCpuPkg/Mp

Re: [edk2-devel] [PATCH 2/4] OvmfPkg/OvmfXen.dsc: remove PcdCpu* dynamic defaults

On 10/08/19 15:11, Philippe Mathieu-Daudé wrote: > On 10/8/19 1:27 PM, Laszlo Ersek wrote: >> PcdCpuMaxLogicalProcessorNumber and PcdCpuApInitTimeOutInMicroSeconds are >> only referenced in "OvmfPkg/PlatformPei/PlatformPei.inf", and OvmfXen >> does >>

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/PlatformPei: rewrite MaxCpuCountInitialization() for CPU hotplug

On 10/08/19 17:06, Igor Mammedov wrote: > On Tue, 8 Oct 2019 13:27:14 +0200 > Laszlo Ersek wrote: > >> MaxCpuCountInitialization() currently handles the following options: >> >> (1) QEMU does not report the boot CPU count. >> >> In this case, Platform

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

On 10/08/19 17:02, Gao, Liming wrote: > Laszlo: > >> -Original Message----- >> From: Laszlo Ersek >> Sent: Tuesday, October 1, 2019 4:42 AM >> To: devel@edk2.groups.io; Gao, Liming >> Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool c

Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()

019年9月24日 19:00 >> To: devel@edk2.groups.io; ler...@redhat.com >> Cc: Wu, Jiaxin ; Fu, Siyuan >> Subject: Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type >> typo in NetLibGetMacAddress() >> >> On 9/17/19 9:49 PM, Laszlo Ersek wrot

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

On 09/17/19 21:49, Laszlo Ersek wrote: > Repository: https://github.com/lersek/edk2.git > Branch: voidptr > > The UEFI / PI / Shell specifications define a number of standard types > as pointers to VOID. This is arguably a design mistake; those types > should have been po

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

On 10/09/19 01:49, Laszlo Ersek wrote: > On 09/17/19 21:49, Laszlo Ersek wrote: >> Repository: https://github.com/lersek/edk2.git >> Branch: voidptr >> >> The UEFI / PI / Shell specifications define a number of standard types >> as pointers to VOID. This is

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

On 10/09/19 01:08, Andrew Fish wrote: > So I guess the way to describe it is XCODE inherits GCC and only needs to > override when it is different. Thank you for the explanation! I've been trying to figure out why this inheritance bothers me so much. I guess the reason is the following: I'm a u

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/PlatformPei: rewrite MaxCpuCountInitialization() for CPU hotplug

On 10/09/19 12:23, Igor Mammedov wrote: > On Tue, 8 Oct 2019 23:12:10 +0200 > Laszlo Ersek wrote: > >> On 10/08/19 17:06, Igor Mammedov wrote: >>> On Tue, 8 Oct 2019 13:27:14 +0200 >>> Laszlo Ersek wrote: >>> >>>> MaxCpuCountIn

Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection

On 10/09/19 02:57, Dong, Eric wrote: > Hi Laszlo, > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, October 8, 2019 7:27 PM >> To: edk2-devel-groups-io >> C

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

On 10/01/19 01:21, Laszlo Ersek wrote: > On 09/29/19 08:09, Wang, Jian J wrote: >> For this patch series, >> 1. " Contributed-under: TianoCore Contribution Agreement 1.1" is not needed >> any more. >> Remove it at push time and no need to send a v2. >

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

Hi All, (multi-hour composition ahead...) On 10/09/19 09:53, David Woodhouse wrote: > On Tue, 2019-10-08 at 06:19 +, Wu, Jiaxin wrote: >> Hi David, >> >> I just realized you have the comments on Bugzilla 960: >> >>> "...given that testing is failing and code inspection shows it >>> would neve

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

On 10/08/19 18:16, Rabeda, Maciej wrote: > Patch addresses Bugzilla #1972. I think the BZ reference should be . (The cover letter has it right.) Thanks Laszlo > During ExitBootServices stage, drivers should not call any > functions known to us

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

Hi Andrew, On 10/09/19 18:22, Andrew Fish wrote: > I thought the thing we were discussing was compiler flags. > Specifically -mno-mmx -mno-sse. It seems to me if OVMF requires > -mno-mmx -mno-sse then it is a bug in the tools_def.txt definition > for those compilers? As far as I can tell -mno-im

Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection

On 10/10/19 04:52, Ni, Ray wrote: > Laszlo, > Can you add comments in the code you changed to describe the two different > behaviors? It's described in the DEC file, near the PCD: + # nonzero- PcdCpuApInitTimeOutInMicroSeconds is ignored. The initial + # AP detection

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

Data: > Version: 3 (0x2) > Serial Number: > a7:b5:04:75:6a:2f:ee:7e > Signature Algorithm: sha256WithRSAEncryption > Issuer: C=HU, ST=Pest, L=Budapest, O=Laszlo Ersek Home Office, > OU=Certificate Authority, CN=Laszlo Ersek CA/emailAdd

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

correct the Bugzilla number in patch description as Laszlo pointed > out. > > Thanks. > > Best Regards > Siyuan > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo >> Ersek >> Sent: 2019年10月10日 6:10 >> To: devel@edk2.gro

<    4   5   6   7   8   9   10   11   12   13   >