Pinging SecurityPkg maintainers again, for reviewing this patch.
Thanks
Laszlo
On 09/26/19 14:46, Laszlo Ersek wrote:
> Chao, Jian, Jiewen,
>
> can you please review this patch?
>
> Thanks,
> Laszlo
>
>
> On 09/17/19 21:49, Laszlo Ersek wrote:
>> EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration",
>> similarly to gBS->RegisterProtocolNotify(). We should pass the address of
>> an actual pointer-to-VOID, and not the address of an EFI_EVENT. EFI_EVENT
>> just happens to be specified as (VOID*), and has nothing to do with the
>> registration.
>>
>> This change is a no-op in practice; it's a semantic improvement.
>>
>> Cc: Chao Zhang <chao.b.zh...@intel.com>
>> Cc: Jian Wang <jian.j.w...@intel.com>
>> Cc: Jiewen Yao <jiewen....@intel.com>
>> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
>> ---
>>
>> Notes:
>> build-tested only
>>
>> SecurityPkg/HddPassword/HddPasswordDxe.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/SecurityPkg/HddPassword/HddPasswordDxe.c
>> b/SecurityPkg/HddPassword/HddPasswordDxe.c
>> index b0d795b6597f..051e64091d7f 100644
>> --- a/SecurityPkg/HddPassword/HddPasswordDxe.c
>> +++ b/SecurityPkg/HddPassword/HddPasswordDxe.c
>> @@ -2770,7 +2770,7 @@ HddPasswordDxeInit (
>> {
>> EFI_STATUS Status;
>> HDD_PASSWORD_DXE_PRIVATE_DATA *Private;
>> - EFI_EVENT Registration;
>> + VOID *Registration;
>> EFI_EVENT EndOfDxeEvent;
>> EDKII_VARIABLE_LOCK_PROTOCOL *VariableLock;
>>
>>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48432): https://edk2.groups.io/g/devel/message/48432
Mute This Topic: https://groups.io/mt/34180229/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
