Hi Liming,
On 09/27/19 09:46, Liming Gao wrote:
> __inline__ attribute will make the functions not be exposed as the
> library interface. It will cause CLANG9 compiler fail.
>
> Signed-off-by: Liming Gao <liming....@intel.com>
> ---
> MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 ------
> 1 file changed, 6 deletions(-)
Did you regression-test this change against GCC48 (for example)?
I can't tell why we have the __inline__'s in the first place. They date
back to historical commit e1f414b6a7d8 ("Import some basic libraries
instances for Mde Packages.", 2007-06-22). And that commit does not
explain __inline__.
If we remove __inline__ for the whole GCC toolchain *family*, then I
think we need a better justification than just "makes CLANG9 fail".
Thanks
Laszlo
> diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c
> b/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c
> index 055f0a947e..b3a1a20256 100644
> --- a/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c
> +++ b/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c
> @@ -32,7 +32,6 @@
> @return The value read.
>
> **/
> -__inline__
> UINT8
> EFIAPI
> IoRead8 (
> @@ -60,7 +59,6 @@ IoRead8 (
> @return The value written the I/O port.
>
> **/
> -__inline__
> UINT8
> EFIAPI
> IoWrite8 (
> @@ -87,7 +85,6 @@ IoWrite8 (
> @return The value read.
>
> **/
> -__inline__
> UINT16
> EFIAPI
> IoRead16 (
> @@ -117,7 +114,6 @@ IoRead16 (
> @return The value written the I/O port.
>
> **/
> -__inline__
> UINT16
> EFIAPI
> IoWrite16 (
> @@ -145,7 +141,6 @@ IoWrite16 (
> @return The value read.
>
> **/
> -__inline__
> UINT32
> EFIAPI
> IoRead32 (
> @@ -175,7 +170,6 @@ IoRead32 (
> @return The value written the I/O port.
>
> **/
> -__inline__
> UINT32
> EFIAPI
> IoWrite32 (
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48303): https://edk2.groups.io/g/devel/message/48303
Mute This Topic: https://groups.io/mt/34309058/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
