Re: [edk2-devel] [PATCH 08/10] OvmfPkg/ResetVector: wire up 5-level paging for TDX

On 2/22/24 12:54, Gerd Hoffmann wrote: > BSP workflow is quite simliar to the non-coco case. > > TDX_WORK_AREA_PGTBL_READY is used to record the paging mode: > 1 == 4-level paging > 2 == 5-level paging > > APs will look at TDX_WORK_AREA_PGTBL_READY to figure whenever > they should enable 5-le

Re: [edk2-devel] [PATCH 10/10] OvmfPkg/ResetVector: wire up 5-level paging for SEV

On 2/22/24 12:54, Gerd Hoffmann wrote: > Removes the GetSevCBitMaskAbove31 OneTimeCall because we need that twice > (for 4-level and 5-level paging). Open code the single instruction left > in that function instead. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/ResetVector/Ia32/AmdSev.asm

Re: [edk2-devel] [PATCH 09/10] OvmfPkg/ResetVector: leave SEV VC handler installed longer

On 2/22/24 12:54, Gerd Hoffmann wrote: > When running in SEV mode keep the VC handler installed. > Add a function to uninstall it later. > > This allows using the cpuid instruction in SetCr3ForPageTables64, > which is needed to check for la57 & 1G page support. > > Signed-off-by: Gerd Hoffmann >

Re: [edk2-devel] Tagging and releases of edk2-basetools

On 2/28/24 02:15, Rebecca Cran wrote: > edk2-basetools is finally fixed and releases can once again be published > to PyPI. > > However, in moving from setup.py to pyproject.toml the process has > changed, and Joey suggested the old way might have been chosen > deliberately to be different from ed

Re: [edk2-devel] [PATCH v2 2/4] MdeModulePkg/SMM: Disallow unregister SMI handler in other SMI handler

er SMI handler in other SMI handler. > > Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Zhiguang Liu > --- > MdeModulePkg/Core/PiSmmCore/Smi.c | 32 +++ > 1 file changed, 24 insertions(+), 8 deletions(-) &

Re: [edk2-devel] [PATCH v2 3/4] StandaloneMmPkg: Support to unregister MMI handler inside MMI handler

; Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Signed-off-by: Zhiguang Liu > --- > StandaloneMmPkg/Core/Mmi.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/StandaloneMmPkg/Core/Mm

Re: [edk2-devel] [PATCH v2 4/4] StandaloneMmPkg: Disallow unregister MMI handler in other MMI handler

er MMI handler in other MMI handler. > > Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > StandaloneMmPkg/Core/Mmi.c | 35 ++

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/27/24 18:15, Albecki, Mateusz wrote: > Is the idea to refactor PciSioSerialDxe to extract functions that access > the HW and wrap it in the SerialPortLib instance? That solution would > still save us some maintenance cost. However exploring the idea further > I see following problems: > > 1.

Re: [edk2-devel] [PATCH 02/10] OvmfPkg/ResetVector: add ClearOvmfPageTables macro

On 2/28/24 09:22, Gerd Hoffmann wrote: > On Wed, Feb 28, 2024 at 05:09:32AM +0100, Laszlo Ersek wrote: >> On 2/22/24 12:54, Gerd Hoffmann wrote: >>> Move code to clear the page tables to a nasm macro. >>> No functional change. >>> >>> Signed-off-by: Ge

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/28/24 17:27, Albecki, Mateusz wrote: > Sorry, I didn't want to make an impression that I expected solution to > be delivered, I was merely trying to explain some of the complexity we > are trying to handle on our side and why we didn't went for SerialDxe > and instead opted to make PciSioSeria

Re: [edk2-devel] CI: GCC13 and lcov problem

On 2/28/24 14:59, Oliver Steffen wrote: > Hi, > > I am working on switching the Linux CI jobs over to the Fedora 39 image > which comes with gcc 13. > > Unfortunately, some jobs fail due to some error related to lcov / > geninfo, see below. > > Does anybody know from the top of the head what thi

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: add struct MP_HAND_OFF_CONFIG

t;MpHandOff->ProcessorIndex = HobBase; >MpHandOff->CpuCount = CpusInHob; > - > - if (CpuMpData->ApLoopMode != ApInHltLoop) { > -MpHandOff->StartupSignalValue= MP_HAND_OFF_SIGNAL; > -MpHandOff->WaitLoopExecutionMode = sizeof (VOID *); > -

Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

Hi Nickle, On 2/29/24 09:52, Nickle Wang via groups.io wrote: > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update > RedfishClientPkg to use RedfishHttpLib. And remove the use of > RedfishHttpCacheLib. > > I also replace several functions from RedfishLib with the function > provid

Re: [edk2-devel] [PATCH v4 0/3] OvmfPkg: Add support for 5-level paging

On 2/22/24 11:54, Gerd Hoffmann wrote: > Patch #1 + #2 fix MdeModulePkg/DxeIplPeim to not assert in case a > 5-level enabled build runs in 4-level paging mode. > > Patch #3 updates PlatformInitLib for 5-level paging support (update > PhysBits calculation). > > v4: > - drop OvmfPkg/ResetVecor cha

Re: [edk2-devel] 回复: [PATCH] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

On 2/25/24 04:32, gaoliming via groups.io wrote: > Laszlo: > Thanks for your work to make sure this issue be fixed. I agree this change. > Reviewed-by: Liming Gao Thanks; merged as commit bac9c74080cf, via . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Link

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: add struct MP_HAND_OFF_CONFIG

On 2/28/24 12:48, Gerd Hoffmann wrote: > Move the WaitLoopExecutionMode and StartupSignalValue fields to a > separate HOB with the new struct. > > WaitLoopExecutionMode and StartupSignalValue are independent of > processor index ranges; they are global to MpInitLib (i.e., the entire > system). The

Re: [edk2-devel] [PATCH] BaseTools: PcdValueInit enhancement

On 3/1/24 03:10, Yuting Yang wrote: > Enhance PcdValueInit for storage saving > > Cc: Rebecca Cran rebe...@bsdio.com > Cc: Liming Gao gaolim...@byosoft.com.cn > Cc: Bob Feng bob.c.f...@intel.com > Signed-off-by: Yuting Yang > --- > .../Source/Python/Workspace/DscBuildData.py | 43 +

Re: [edk2-devel] [PATCH v8 14/37] UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg

On 3/1/24 02:26, Chao Li wrote: > Hi Ray, Lazslo, > > This library is almost complete to refactored, it refer to ARM and > RISC-V version, the API include set/get memory region attribute. > > I have one last question, in ARM and RISC-V version, even LoongArch old > and current version, they all r

Re: [edk2-devel] [v2] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

Hi Mike, can you please comment on the Build and Inf spec changes proposed in this thread? Thanks, Laszlo On 2/24/24 21:59, Laszlo Ersek wrote: > v1 posting: > > https://edk2.groups.io/g/devel/message/115193 > msgid <36593e23-d3e8-b71a-808d-ef94260b5...@redhat.com

Re: [edk2-devel] [PATCH v3 2/3] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

On 3/1/24 02:29, Tuan Phan wrote: > The GCD EFI_MEMORY_UC and EFI_MEMORY_WC memory attributes will be > supported when Svpbmt extension available. > > Cc: Gerd Hoffmann > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Ray Ni > Signed-off-by: Tuan Phan > --- >

Re: [edk2-devel] [PATCH v3 2/4] MdeModulePkg/SMM: Disallow unregister SMI handler in other SMI handler

handler in other SMI handler. > > Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Zhiguang Liu > --- > MdeModulePkg/Core/PiSmmCore/Smi.c | 29 + > 1 file changed, 21 insertions(+), 8 deletions(-) > &

Re: [edk2-devel] [PATCH v3 4/4] StandaloneMmPkg: Disallow unregister MMI handler in other MMI handler

handler in other MMI handler. > > Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > StandaloneMmPkg/Core/Mmi.c | 32 +++

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile

On 3/1/24 03:54, Zhou Jianfeng wrote: > Add volatile qualifier to page table related variable to prevent > compiler from optimizing away the variables which may lead to > unexpected result. > > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Ku

Re: [edk2-devel] [PATCH v2 06/10] OvmfPkg/ResetVector: add 5-level paging support

SetCr3ForPageTables64: > ; normal (non-CoCo) workflow > ; > ClearOvmfPageTables > +%if PG_5_LEVEL > +Check5LevelPaging Paging4Level > +CreatePageTables5Level 0 > +Enable5LevelPaging > +jmp SetCr3 > +Paging4Level: > +%endif > CreatePage

Re: [edk2-devel] [PATCH v2 08/10] OvmfPkg/ResetVector: wire up 5-level paging for TDX

_LEVEL" scope. (My proposal under v1 patch#6 was: %if PG_5_LEVEL cmp eax, TDX_AP_5_LEVEL jne CheckForSev Enable5LevelPaging jmp SetCr3 CheckForSev: %endif ) Did you place the "CheckForSev:" label intentionally outside of the %if scope? If it was i

Re: [edk2-devel] [PATCH v2 09/10] OvmfPkg/ResetVector: leave SEV VC handler installed longer

d a small, *optional*, simplification, IIUC); however, I don't understand why you didn't pick up Tom's R-b. I'm ready to merge this (adding Tom's R-b, if you, Gerd, confirm that that's what you want). Having deferred to Tom's judgement on this: Acked-by:

Re: [edk2-devel] [PATCH v2 10/10] OvmfPkg/ResetVector: wire up 5-level paging for SEV

only make the macros visible, but also rearrange how the code (the binary instructions) are laid out in the reset vector -- however, that should not be a problem. Reviewed-by: Laszlo Ersek > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/ResetVector/Ia32/AmdSev.asm | 16 ++

Re: 回复: [edk2-devel] [edk2-BuildSpecification PATCH 0/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

On 3/1/24 13:53, gaoliming via groups.io wrote: > Looks good. Reviewed-by: Liming Gao Thank you, merged as commit range db69f5661cae..7a7165a7d199. Laszlo > >> -邮件原件- >> 发件人: devel@edk2.groups.io 代表 Laszlo Ersek >> 发送时间: 2024年2月25日 5:24 >> 收件人: edk2-de

Re: 回复: [edk2-devel] [edk2-InfSpecification PATCH 0/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

On 3/1/24 13:52, gaoliming via groups.io wrote: > Looks good. Reviewed-by: Liming Gao Thank you, merged as commit range a31e3c842bee..1ea6546578fe. Laszlo > >> -邮件原件- >> 发件人: devel@edk2.groups.io 代表 Laszlo Ersek >> 发送时间: 2024年2月25日 5:29 >> 收件人: edk2-de

Re: [edk2-devel] [PATCH v2 09/10] OvmfPkg/ResetVector: leave SEV VC handler installed longer

On 3/1/24 15:52, Gerd Hoffmann wrote: > Hi, > >>> OneTimeCall CheckSevFeatures >>> +cmp byte[WORK_AREA_GUEST_TYPE], 1 >>> +jnz NoSevIa32 >>> +OneTimeCall SevClearVcHandlerAndStack >>> >>> +NoSevIa32: >>> ; >>> ; Restore initial EAX value into the EAX

Re: [edk2-devel] [PATCH v2 00/10] OvmfPkg/ResetVector: cleanup and add 5-level paging support.

On 3/1/24 08:43, Gerd Hoffmann wrote: > [...] For future patch submissions: please include the Cc: tags in the commit message bodies; PatchCheck.py (also part of CI) enforces that now. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Repl

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile

On 3/1/24 03:54, Zhou Jianfeng wrote: > Add volatile qualifier to page table related variable to prevent > compiler from optimizing away the variables which may lead to > unexpected result. > > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Ku

Re: [edk2-devel] [PATCH v3 0/4] Support to unregister SMI handler inside SMI handler

On 3/1/24 04:01, Zhiguang Liu wrote: > This patch set is to support to unregister SMI handler inside SMI handler, > also add check to not allow unregister SMI handler in other SMI handler. > This patch set also have the same logic in StandaloneMmPkg. > Because no change on the first patch, I kept t

Re: [edk2-devel] [PATCH v1] MdeModulePkg/Core/Pei: Improve the copy performance

On 3/1/24 08:11, Li, Zhihao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4697 > > EvacuateTempRam function will copy the temporary memory context to the rebased > pages and the raw pages. Migrations of rebased PEIMs is from cache to memory, > while raw PEIMs is from memory to memor

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/CpuPageTableLib: Fix IN OUT parameters marked as IN

bSetPle(): Ple > PageTableLibSetPnle(): Pnle > > Reviewed-by: Ray Ni > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > .../Library/CpuPageTableLib/CpuPageTableMap.c | 32 +-- > 1 file chan

Re: [edk2-devel] [PATCH v2 00/10] OvmfPkg/ResetVector: cleanup and add 5-level paging support.

On 3/1/24 08:43, Gerd Hoffmann wrote: > So I ran with the suggestion by Laszlo to move the page table setup into > macros and untangle the non-CoCo / TDX / SEV code paths. The first five > patches of the series are doing that (without functional changes). > > Support for 5-level paging is added b

Re: [edk2-devel] [v2] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

On 2/28/24 00:41, Rebecca Cran wrote: > edk2-basetools v0.1.50 has just been published so we're back up and > running. > > I'll work my way through the backlog of BaseTools changes in the next > few days. Thanks! Once you merge and make a new

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

his new message helps identifying this condition. > > Cc: Bob Feng > Cc: Gerd Hoffmann > Cc: Laszlo Ersek > Cc: Liming Gao > Cc: Rebecca Cran > Cc: Yuwei Chen > > Signed-off-by: Oliver Steffen > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/V

Re: [edk2-devel] [PATCH v3 2/3] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

On 3/2/24 00:20, Tuan Phan wrote: > Thanks for the detailed review. Please see my comments below. > > On Fri, Mar 1, 2024 at 4:14 AM Laszlo Ersek <mailto:ler...@redhat.com>> wrote: > > On 3/1/24 02:29, Tuan Phan wrote: > > The GCD EFI_MEMORY_UC and EFI_ME

Re: 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

>> 抄送: Oliver Steffen ; Bob Feng >> ; Liming Gao ; Rebecca >> Cran ; Yuwei Chen ; Gerd >> Hoffmann ; Laszlo Ersek >> 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space >> when writing variables >> >> Emit a DEBUG_WARN message if the

Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again

On 3/4/24 12:37, joeyli via groups.io wrote: > Hi, > > On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote: >> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote: >>> Hi Laszlo, >>> >>> First, thanks for your review! >>> &

Re: [edk2-devel] [PATCH v8 14/37] UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg

Hello Chao, On 3/4/24 04:39, Chao Li wrote: > Hi Laszlo, > > OK. > > When I discussed the CpuMmuLib API as a public API with Ray in the early > days, the API recommended by Ray should be the patch 13 in this series, > which only contains set/get memory region attribute, but in the first > versio

[edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51

Vagedes Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Sean Brogan Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Signed-off-by: Laszlo Ersek --- pip-requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pip-requirem

[edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules

Cc: Sean Brogan Cc: Sean Rhodes Cc: Star Zeng Cc: Sunil V L Cc: Susovan Mohapatra Cc: Ted Kuo Cc: Tom Lendacky Cc: Yuwei Chen Thanks, Laszlo Laszlo Ersek (10): pip-requirements.txt: require edk2-basetools version 0.1.51 OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList(

[edk2-devel] [PATCH v2 02/10] OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() decl

euvel Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Michael Roth Cc: Min Xu Cc: Tom Lendacky Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4643 Signed-off-by: Laszlo Ersek --- OvmfPkg/Sec/SecMain.inf | 2 +- OvmfPkg/Sec/SecM

[edk2-devel] [PATCH v2 03/10] OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList() decl

GCC5 Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +- OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Ov

[edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl

/SecMain.inf \ -p OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc -t GCC5 Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Sunil V L Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +- OvmfPkg

[edk2-devel] [PATCH v2 06/10] ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +- ArmVirtPkg/PrePi/PrePi.c| 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/ArmVirtPkg/PrePi

[edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl

Rely on AutoGen for declaring ProcessLibraryConstructorList(). Build-tested with: build -a X64 -b DEBUG -m EmulatorPkg/Sec/Sec.inf \ -p EmulatorPkg/EmulatorPkg.dsc -t GCC5 Cc: Andrew Fish Cc: Ray Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek

[edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl

-t GCC5 Cc: Ard Biesheuvel Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +- ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +- ArmPlatformPkg/PrePi/PeiMPCore.inf

[edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl

/IntelFsp2Pkg.dsc -t GCC5 Cc: Ashraf Ali S Cc: Chasel Chiu Cc: Duggapu Chinni B Cc: Nate DeSimone Cc: Star Zeng Cc: Susovan Mohapatra Cc: Ted Kuo Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +- IntelFsp2Pkg

[edk2-devel] [PATCH v2 09/10] UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl

: Catharine West Cc: Gerd Hoffmann Cc: Rahul Kumar Cc: Ray Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- UefiCpuPkg/SecCore/SecCore.inf | 2 +- UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +- UefiCpuPkg/SecCore/SecMain.h | 12

[edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl

/UefiPayloadPkg.dsc -t GCC5 \ -D BUILD_ARCH=X64 Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +- UefiPayloadPkg/UefiPayloadEntry

[edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules

iyuqing379 Cc: dahogn Cc: meng-cz Thanks, Laszlo Laszlo Ersek (4): BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl LoongArchQemuPkg: auto-gen & fix SEC ProcessLibraryConstructorList

[edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl

://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf | 2 +- Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h| 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/Platform/BeagleBoard

[edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl

el/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc \ -t GCC5 Cc: Nate DeSimone Cc: Sai Chaganty Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 2 +- Platform/Intel/SimicsOpenBoardPkg/SecCore/SecM

[edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl

-p Platform/Loongson/LoongArchQemuPkg/Loongson.dsc -t GCC5 Cc: Bibo Mao Cc: Chao Li Cc: Xianglai li Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf | 2 +- Platform/Loongson/LoongArchQemuPkg/Sec/SecM

[edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up ProcessLibraryConstructorList() decl

/SecMain.inf \ -p Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc -t GCC5 Cc: Sunil V L Cc: USER0FISH Cc: caiyuqing379 Cc: dahogn Cc: meng-cz Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek --- Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf | 2 +- Silicon/Sophgo

Re: [edk2-devel] [PATCH v8 14/37] UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg

In the same folder as CpuMmuLib -- no. Instances of different library classes are never placed in the same folder. Laszlo > > > Thanks, > Chao > On 2024/3/5 17:26, Laszlo Ersek wrote: >> Hello Chao, >> >> On 3/4/24 04:39, Chao Li wrote: >>> Hi Laszlo, &

Re: 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

On 3/5/24 13:44, Oliver Steffen wrote: > The root cause is of course not addressed by this, but it might also be > hard to solve. One would have to identify obsolete network/hardware > settings somehow, but there is no way to tell if a certain NIC/MAC > might come back at a later point or not. Tr

[edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

Red Hat and I have mutually and amicably agreed to separate. Remove my entries from "Maintainers.txt". Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Leif Lindholm Cc: Michael D Kinney Cc: Rahul Kumar Cc: Ray Ni Cc: Sami Mujawar Signed-off-by: La

Re: [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > The edk2-basetools commit that corresponds to edk2 commit bac9c74080cf > ("Base

Re: [edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). > > Build-tested with: > >

Re: [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). > > Build-tested with: > >

Re: [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). > > Build-tested with: > >

Re: [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 12:38, Laszlo Ersek wrote: > Rely on AutoGen for declaring ProcessLibraryConstructorList(). > > Build-tested with: > &g

Re: [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl

Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>. Thank you, Laszlo On 3/5/24 13:01, Laszlo Ersek wrote: > declares a bogus > ProcessLibraryConstructorList() for SimicsOpenBoardPkg's SEC module. Rely >

Re: [edk2-devel] [PATCH] MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler

ou think it fits your needs. I'll probably not be around to review it, though. Cheers! Laszlo > > Thanks > Zhiguang > >> -Original Message- >> From: Laszlo Ersek >> Sent: Thursday, January 25, 2024 6:48 PM >> To: devel@edk2.groups.io; Liu, Zhigu

Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again

On 3/7/24 10:04, joeyli via groups.io wrote: > Hi Laszlo, > > On Tue, Mar 05, 2024 at 09:53:33AM +0100, Laszlo Ersek wrote: >> On 3/4/24 12:37, joeyli via groups.io wrote: >>> Hi, >>> >>> On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrot

Re: [edk2-devel] [PATCH v3 2/3] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

On 3/7/24 23:00, Tuan Phan wrote: > > > On Mon, Mar 4, 2024 at 10:01 AM Laszlo Ersek <mailto:ler...@redhat.com>> wrote: > > On 3/2/24 00:20, Tuan Phan wrote: > > Thanks for the detailed review. Please see my comments below. > > > > O

Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules

On 3/5/24 12:38, Laszlo Ersek wrote: > Bugzillas: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > - https://bugzilla.tianocore.org/show_bug.cgi?id=991 > - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 > > CI: > - https://github.com/tianocore/edk2/pull/5442 >

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

On 3/6/24 23:22, Michael D Kinney wrote: > Reviewed-by: Michael D Kinney Merged as commit ccf91b518f22, via <https://github.com/tianocore/edk2/pull/5450>. Thank you all for everything, Laszlo >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of La

Re: [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules

On 3/5/24 13:01, Laszlo Ersek wrote: > Bugzilla: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > > This patch series puts the recent BaseTools feature to use in which > AutoGen generates the ProcessLibraryConstructorList() declaration in > "AutoGen.h" for

Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules

On 3/8/24 10:13, Laszlo Ersek wrote: > On 3/5/24 12:38, Laszlo Ersek wrote: >> Bugzillas: >> - https://bugzilla.tianocore.org/show_bug.cgi?id=990 >> - https://bugzilla.tianocore.org/show_bug.cgi?id=991 >> - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 >&g

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

On 3/11/24 11:29, Zeng, Star wrote: > Thank you Laszlo. > > Is ler...@redhat.com still reachable for now ? 😊 March 14th is my last day at Red Hat; my email access will be revoked on that day. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Rep

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

On 3/11/24 18:49, Pedro Falcato wrote: > On Mon, Mar 11, 2024 at 3:04 AM Ni, Ray wrote: >> >> This is a good idea to have a CREDITS file in edk2 repo. >> >> Pedro, would you mind initiating one? > > Laszlo told me (in private) that he doesn't want a CREDITS entry for > him, git log is enough. >

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

On 09/04/19 11:52, Igor Mammedov wrote: > it could be stolen RAM + black hole like TSEG, assuming fw can live without > RAM(0x3+128K) range > (in this case fwcfg interface would only work for locking down the range) > > or > > we can actually have a dedicated SMRAM (like in my earlier

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

Thursday, September 5, 2019 12:27 PM >>> To: devel@edk2.groups.io >>> Cc: Dong, Eric ; Ni, Ray ; Laszlo >>> Ersek >>> Subject: [PATCH v2] UefiCpuPkg: support single >>> EFI_PEI_CORE_FV_LOCATION_PPI in PpiList >>> >>> REF:

Re: [edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Python3 adaption

On 09/05/19 12:37, Leif Lindholm wrote: > Hi Bob, (+Laszlo, due to a question at the end) > > On Thu, Sep 05, 2019 at 05:39:05AM +, Feng, Bob C wrote: >> Would you try to install antlr4-python3-runtime on debian. >> pip install antlr4-python3-runtime > > I'd rather not. For the reasons describe

Re: [edk2-devel] [PATCH] ArmVirtPkg/PlatformBootManagerLib: unload image on EFI_SECURITY_VIOLATION

On 09/04/19 16:16, Philippe Mathieu-Daudé wrote: > On 9/3/19 6:38 PM, Laszlo Ersek wrote: >> The LoadImage() boot service is a bit unusual in that it allocates >> resources in a particular failure case; namely, it produces a valid >> "ImageHandle" when it returns

Re: [edk2-devel] [PATCH v2] OvmfPkg/EnrollDefaultKeys: clean up Base64Decode() retval handling

On 09/04/19 14:37, Ard Biesheuvel wrote: > On Wed, 4 Sep 2019 at 00:52, Laszlo Ersek wrote: >> >> Since commit 35e242b698cd ("MdePkg/BaseLib: rewrite Base64Decode()", >> 2019-07-16), Base64Decode() guarantees that DestinationSize is larger on &g

[edk2-devel] [PATCH edk2-CCSS 1/3] comments: remove "Horror Vacui" rule

by reviewers and maintainers. Remove the rule in order for the CCS to match reality. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=607 Signed-off-by: Laszlo Ersek --- 6_documenting_software/62_comments.md | 18

[edk2-devel] [PATCH edk2-CCSS 3/3] must comment: add rule for documenting spurious variable assignments

f Lindholm Cc: Michael D Kinney Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=607 Signed-off-by: Laszlo Ersek --- 6_documenting_software/64_what_you_must_comment.md | 39 README.md | 1 + 2 files changed, 40 in

[edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments

patches are cleanups for things that popped up in the discussion in <https://bugzilla.tianocore.org/show_bug.cgi?id=607>. The third patch is the one fixing the BZ. Thanks, Laszlo Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Rebecca Cran Laszlo Ersek (3): comments: remove &

[edk2-devel] [PATCH edk2-CCSS 2/3] comments: restrict and clarify applicability of "/*" comments

Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=607 Signed-off-by: Laszlo Ersek --- 6_documenting_software/62_comments.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/6_documenting_software/62_co

Re: [edk2-devel] [patch 1/3] EmbeddedPkg: Unload image on EFI_SECURITY_VIOLATION

or handling for EFI_SECURITY_VIOLATION explicitly > for the callers in EmbeddedPkg which don't have the policy to defer the > execution of the image. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1

Re: [edk2-devel] [patch 2/3] MdeModulePkg: Unload image on EFI_SECURITY_VIOLATION

just a meta comment: On 09/05/19 08:23, Dandan Bi wrote: >> -Original Message- >> From: Wu, Hao A >> Sent: Thursday, September 5, 2019 1:38 PM >> To: Bi, Dandan ; devel@edk2.groups.io >> Cc: Wang, Jian J ; Ni, Ray ; Gao, >> Liming ; Laszlo Ersek >

Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtPrePiUniCoreRelocatable: revert to PIE linking

ceGuid.PcdFvBaseAddress > > [BuildOptions] > - GCC:*_*_*_DLINK_FLAGS = -shared -Wl,-Bsymbolic > -Wl,-T,$(MODULE_DIR)/Scripts/PrePi-PIE.lds > + GCC:*_*_*_DLINK_FLAGS = > -Wl,-Bsymbolic,-pie,-T,$(MODULE_DIR)/Scripts/PrePi-PIE.lds > Sorry for being late to this patch, I can se

Re: [edk2-devel] [PATCH edk2-CCSS 3/3] must comment: add rule for documenting spurious variable assignments

On 09/06/19 10:13, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > (Cc'ing Ard) > > On 9/5/19 8:38 PM, Laszlo Ersek wrote: >> Problem statement from Ard: >> >>> Sometimes, the GCC compiler warns about variables potentially being used >>> withou

Re: [edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments

On 09/06/19 14:26, Leif Lindholm wrote: > On Thu, Sep 05, 2019 at 08:38:17PM +0200, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2-CCodingStandardsSpecification.git >> Branch: spurious_assign_bz_607 >> >> HTML-rendered views of the modified pages: >>

Re: [edk2-devel] [PATCH] ArmVirtPkg: increase FD/FV size for NOOPT builds

On 09/07/19 00:20, Ard Biesheuvel wrote: > After upgrading the CI system we use for building the ArmVirtPkg > targets, we started seeing failures due to the NOOPT build running > out of space when using the CLANG38 toolchain definition combined > with clang 7. > > We really don't want to increase t

Re: [edk2-rfc] [edk2-devel] UEFI Variable SMI Reduction

On 09/05/19 21:54, Kubacki, Michael A wrote: > Proof-of-Concept Implementation > -- > The implementation is available in the following commit - check the commit > message for some more details. > https://github.com/makubacki/edk2/commit/d812d43412a26e4

Re: [edk2-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

Hi Igor, On 09/05/19 17:49, Igor Mammedov wrote: > lpc already has SMI negotiation feature, extend it by adding > optin ICH9_LPC_SMI_F_LOCKED_SMBASE_BIT to supported features. > > Writing this bit into "etc/smi/requested-features" fw_cfg file, > tells QEMU to alias 0x3,128K RAM range into SMRA

Re: [edk2-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

On 09/09/19 21:15, Laszlo Ersek wrote: > ... I've done some testing too. Applying the QEMU patch on top of > 89ea03a7dc83, my plan was: > > - do not change OVMF, just see if it continues booting with the QEMU > patch > > - then negotiate bit#1 too, in step (1a) -- t

Re: [edk2-rfc] [edk2-devel] UEFI Variable SMI Reduction

On 09/09/19 20:03, Kubacki, Michael A wrote: > I completely understand the need for granular breakup of changes for code > review and future maintenance. I would not send this as a single patch on the > mailing list for formal code review. Due to the size of the change, the main > point here was

Re: [edk2-devel] [PATCH v3] UefiCpuPkg: Fix potential spinLock issue in SmmStartupThisAp

ove returns EFI_STATUS - EFI_NOT_READY - in new scenario returned > status is not necessary to caller. > > Signed-off-by: Damian Nikodem > Cc: Eric Dong > Cc: Ray Ni > Cc: Benjamin You > Cc: Laszlo Ersek > Cc: Krzysztof Rusocki Eric, Ray, please don't wait for

Re: [edk2-devel] [Patch] UefiCpuPkg/CpuDxe: clean up PAGE_TABLE_LIB_PAGING_CONTEXT usage.

t; the mode before using the correct one. > > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Eric Dong > --- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 52 +++- > 1 file changed, 37 insertions(+), 15 deletions(-) > > diff --git a/UefiCpuPkg

Re: [edk2-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

On 09/10/19 17:58, Igor Mammedov wrote: > On Mon, 9 Sep 2019 21:15:44 +0200 > Laszlo Ersek wrote: [...] > It looks like fwcfg smi feature negotiation isn't reusable in this case. > I'd prefer not to add another device just for another SMI feature > negotiation/activatio

Re: [edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments

On 09/10/19 17:44, Ryszard Knop wrote: > On Tue, 2019-09-10 at 16:33 +0100, Leif Lindholm wrote: >> On Mon, Sep 09, 2019 at 02:35:15PM +0200, Laszlo Ersek wrote: >>> On 09/06/19 14:26, Leif Lindholm wrote: >>>> On Thu, Sep 05, 2019 at 08:38:17PM +0200,

Re: [edk2-devel] [PATCH v2] ArmVirtPkg: increase FD/FV size for NOOPT builds

) s/for NOOPT builds/with -D FD_SIZE_3MB/ in the commit message (2) drop the above three lines (the TARGET-based conditional) With those: Reviewed-by: Laszlo Ersek and you could go ahead and push the patch (no repost needed). OTOH, if you'd really like to set 3MB for NOOPT automaticall

<    2   3   4   5   6   7   8   9   10   11   >