On 2/28/24 17:27, Albecki, Mateusz wrote:
> Sorry, I didn't want to make an impression that I expected solution to
> be delivered, I was merely trying to explain some of the complexity we
> are trying to handle on our side and why we didn't went for SerialDxe
> and instead opted to make PciSioSerialDxe work for our use case. Anyway
> thanks for the ideas, we will definitely look into implementing step h
> you mentioned in case other maintainers also disagree with this patch.

... BTW IIRC Mike recommended producing SerialIo protocol instances in
your platform driver, rather than PciIo, for your debug ports. I feel a
bit torn about that; on one hand, the uniformity of SerialIo protocols
looks flexible, on the other hand, how would you distinguish the debug
ports from the "normal" serial ports (mixing debug output with UEFI
console IO is not great; speaking from experience). Then you'd need to
get into DevicePath parsing (or call PciIo->GetLocation), and/or make
sure your ConIn/ConOut/StdErr variables wouldn't include the debug
ports... It's hard to form an opinion not knowing the platform and the
goals specifically. But, anyway, I've kind of run out of steam on this.

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116137): https://edk2.groups.io/g/devel/message/116137
Mute This Topic: https://groups.io/mt/104469297/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to