Re: [edk2-devel] [Patch V2 2/3] UefiCpuPkg/MpInitLib: Detect microcode and store MTRR when CpuCount > 1

review, with the ultimate goal of eliminating the > microcode loading functionality for the second time Mp initialization > > Cc: Ray Ni > Cc: Eric Dong > Cc: Rahul Kumar > Cc: Tom Lendacky > Cc: Laszlo Ersek > Signed-off-by: Yuanhao Xie > --- > UefiCpuPkg/Lib

Re: [edk2-devel] [Patch V2 2/3] UefiCpuPkg/MpInitLib: Detect microcode and store MTRR when CpuCount > 1

On 11/22/23 18:03, Laszlo Ersek wrote: > On 11/21/23 08:39, Yuanhao Xie wrote: >> Detect and apply Microcode on BSP, store BSP's MTRR setting only when >> CpuCount > 1. >> >> The purpose of this patch is to enhance the review process. >> The separation in t

Re: [edk2-devel] [Patch V2 2/3] UefiCpuPkg/MpInitLib: Detect microcode and store MTRR when CpuCount > 1

On 11/22/23 18:06, Laszlo Ersek wrote: > On 11/22/23 18:03, Laszlo Ersek wrote: >> On 11/21/23 08:39, Yuanhao Xie wrote: >>> Detect and apply Microcode on BSP, store BSP's MTRR setting only when >>> CpuCount > 1. >>> >>> The purpose of

Re: [edk2-devel] [Patch V2 3/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE.

ow WakeUpAp only for synchronizing MTRR settings, with > Microcode loading no longer a part of this process. > > Cc: Ray Ni > Cc: Eric Dong > Cc: Rahul Kumar > Cc: Tom Lendacky > Cc: Laszlo Ersek > Signed-off-by: Yuanhao Xie > -

Re: [edk2-devel] [PATCH v4 11/14] UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if Nonzero

fore sending to ensure the updated notes for this patch > > answer all your questions. > > On 11/8/2023 1:57 PM, Laszlo Ersek wrote: >> On 11/3/23 18:17, Taylor Beebe wrote: >>> The function EnforceMemoryMapAttribute() in the SMM MAT logic will >>> ensure t

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel/Readme.md > > Please let me know if any question. > > Thanks, > Chasel > > > > > >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, November 1

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Restart dispatcher once MmEntryPoint is registered

On 11/22/23 16:11, Ard Biesheuvel wrote: > On Wed, 22 Nov 2023 at 12:45, Laszlo Ersek wrote: >> > ... >> (3) Most importantly, speaking to a larger context, I don't understand >> how this patch can work *at all*. >> >> Namely, I can find no MM IPL inside

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Restart dispatcher once MmEntryPoint is registered

On 11/23/23 17:20, Xu, Wei6 wrote: > Thanks a lot for the review. Replied inline. > > BR, > Wei > >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, November 22, 2023 7:46 PM >> To: devel@edk2.groups.io; Xu, Wei6 >> C

Re: [edk2-devel] [PATCH v3 09/39] MdePkg: Add a new library named PeiServicesTablePointerLibReg

On 11/22/23 02:47, Chao Li wrote: > Hi Laszlo, > > > Thanks, > Chao > On 2023/11/21 22:37, Laszlo Ersek wrote: >> On 11/17/23 10:59, Chao Li wrote: >>> Since some ARCH or platform not require execute code on memory during >>> PEI phase, som

[edk2-devel] mail-archive.com (secondary archive) feed resumed

Hi, you may have noticed that the secondary archive at stopped receiving messages after 28 Jan 2024. The reason is described here: https://groups.io/static/reverifyfaq A message about the reverification ("Update on Groups.io Reverification P

Re: [edk2-devel] The API in BaseCryptLib can't seed the pseudorandom number generator properly

console or standard error devices, respectively. hth Laszlo > Laszlo Ersek mailto:ler...@redhat.com>> 於 2024年2月 > 8日 週四 上午5:03寫道： > > On 2/6/24 08:00, eddie wang wrote: > > Hi all, > > We had an UEFI application that used the EDK2(2023/12/05), and we >

Re: [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

the draft (= latest unreleased) spec. Thanks! Laszlo >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, February 14, 2024 11:58 PM >> To: devel@edk2.groups.io; Kinney, Michael D >> >> Cc: Abdul Lateef Attar ; Abner Chang >> ; Warkentin, A

Re: [edk2-devel] mail-archive.com (secondary archive) feed resumed

On 2/15/24 14:45, Rebecca Cran wrote: > On 2/15/2024 4:28 AM, Laszlo Ersek wrote: >> mail-archive.com is an important secondary archive because it offers >> message-id-based lookup. "git am --message-id" captures patch email >> message IDs in the commit messages,

Re: [edk2-devel] [PATCH v2 02/12] OvmfPkg: add ShellLibs.dsc.inc

| 4 +--- > 2 files changed, 11 insertions(+), 3 deletions(-) > create mode 100644 OvmfPkg/Include/Dsc/ShellLibs.dsc.inc Reviewed-by: Laszlo Ersek > > diff --git a/OvmfPkg/Include/Dsc/ShellLibs.dsc.inc > b/OvmfPkg/Include/Dsc/ShellLibs.dsc.inc > new file mode 100644 > i

Re: [edk2-devel] [PATCH v2 04/12] OvmfPkg: Shell*.inc: allow building without network support

!if $(TOOL_CHAIN_TAG) != "XCODE5" > +!if $(NETWORK_ENABLE) == TRUE > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf > +!endif > INF > OvmfPkg/LinuxInitrdDynamicShellCommand/Linu

Re: [edk2-devel] [PATCH v2 08/12] OvmfPkg: switch AmdSevX64 to new shell include files

: Gerd Hoffmann > Acked-by: Laszlo Ersek > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 30 ++ > OvmfPkg/AmdSev/AmdSevX64.fdf | 8 ++-- > 2 files changed, 4 insertions(+), 34 deletions(-) Thanks for the update. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: Yo

Re: [edk2-devel] [PATCH v2 09/12] OvmfPkg: switch IntelTdxX64 to new shell include files

: Gerd Hoffmann > Acked-by: Laszlo Ersek > --- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 32 +++- > OvmfPkg/IntelTdx/IntelTdxX64.fdf | 9 ++--- > 2 files changed, 5 insertions(+), 36 deletions(-) Thanks for the commit message update here too. -=-=-=-=-

Re: [edk2-devel] [PATCH v2 11/12] OvmfPkg/CI: copy shell to virtual drive

ch will exclude the shell from > secure boot enabled builds. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/PlatformCI/PlatformBuildLib.py | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) Thanks for the commit message update. Acked-by: Laszlo Ersek -

Re: [edk2-devel] [PATCH v2 12/12] OvmfPkg: only add shell to FV in case secure boot is disabled

TRUE > +!if $(BUILD_SHELL) == TRUE && $(SECURE_BOOT_ENABLE) == FALSE > > !if $(TOOL_CHAIN_TAG) != "XCODE5" > !if $(NETWORK_ENABLE) == TRUE This does the job: Reviewed-by: Laszlo Ersek An alternative could be (perhaps informing the user better): !if $(BUILD_SHEL

Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetBspNumber()

On 2/15/24 10:31, Gerd Hoffmann wrote: > Remove the MpHandOff parameter. This is not useful in case multiple > HOBs are present in the system. The function will use GetMpHandOffHob() > to loop over all HOBs instead. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c

Re: [edk2-devel] [PATCH 1/5] UefiCpuPkg/MpInitLib: Add ProcessorIndex argument to GetMpHandOffHob()

(); > + MpHandOff = GetMpHandOffHob (0); >if (MpHandOff == NULL) { > MaxLogicalProcessorNumber = PcdGet32 (PcdCpuMaxLogicalProcessorNumber); >} else { Seems to do what it says on the tin; not sure what it's going to be good for, though. Reviewed-by: Laszlo Ersek

Re: [edk2-devel] [PATCH 3/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SwitchApContext()

On 2/15/24 10:31, Gerd Hoffmann wrote: > Remove the MpHandOff parameter. This is not useful in case multiple > HOBs are present in the system. The function will use GetMpHandOffHob() > to loop over all HOBs instead. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpLib.h

Re: [edk2-devel] [PATCH 4/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize

On 2/15/24 10:31, Gerd Hoffmann wrote: > Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB > covering all CPUs in the system. > > Add a new HaveMpHandOff variable to track whenever MP_HAND_OFF HOBs are > present, using the MpHandOff pointer for that does not work because the > varia

Re: [edk2-devel] [PATCH 5/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

On 2/15/24 10:31, Gerd Hoffmann wrote: > Add support for splitting Hand-Off data into multiple HOBs. This is > required for VMs with thousands of CPUs. The actual CPU count per HOB > is much smaller (128) for better test coverage. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpIn

Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetBspNumber()

On 2/19/24 12:37, Gerd Hoffmann wrote: > Hi, > >> (I'm missing the larger picture here -- is this related to the problem >> -- too many CPUs to fit their infos into a single HOB -- that Pawel >> worked on for a while? > > Different HOB, but similar underlying problem. > > At least the HOB stru

Re: [edk2-devel] [PATCH v2 12/12] OvmfPkg: only add shell to FV in case secure boot is disabled

On 2/19/24 11:21, Gerd Hoffmann wrote: >>> -!if $(BUILD_SHELL) == TRUE >>> +!if $(BUILD_SHELL) == TRUE && $(SECURE_BOOT_ENABLE) == FALSE >>> >>> !if $(TOOL_CHAIN_TAG) != "XCODE5" >>> !if $(NETWORK_ENABLE) == TRUE >> >&g

Re: [edk2-devel] [edk2-platforms PATCH 5/6] LoongArchQemuPkg: fix SEC ProcessLibraryConstructorList() prototype

;ve already used a LoongArch toolchain in a Fedora VM, with a virtio filesystem. Laszlo > > > Thanks, > Chao > On 2024/2/7 09:09, Laszlo Ersek wrote: >> The current declaration of, and call to, SEC >> ProcessLibraryConstructorList() in LoongArchQemuPkg matches the PEIM ent

Re: [edk2-devel] The API in BaseCryptLib can't seed the pseudorandom number generator properly

, from 1.1.1u.) Attaching the source code of the small repro application to the ticket would likely be helpful. Laszlo > Laszlo Ersek mailto:ler...@redhat.com>> 於 2024年2月 > 15日 週四 下午7:48寫道： > > On 2/15/24 12:09, eddie wang wrote: > > Hi Laszlo, > > Thank

Re: [edk2-devel] [PATCH edk2-libc 1/1] StdLib: Remove the 'register' keyword from public interfaces

/4/93"; > */ > char * > strsep( > - register char **stringp, > - register const char *delim > + char **stringp, > + const char *delim >) > { > - register char *s; > - register const char *spanp; > - register int c, sc; > + char *s; > + const

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/NvmExpressDxe: use format "0x%lx" for UINT64 values.

ata->Ncap)); > +DEBUG ((DEBUG_INFO, "NUSE: 0x%lx\n", NamespaceData->Nuse)); > DEBUG ((DEBUG_INFO, "LBAF0.LBADS : 0x%x\n", > (NamespaceData->LbaFormat[0].Lbads))); > > // series Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GVT-g VM takes a long time before OVMF splash shown - bisected

Hi, On 2/19/24 19:18, chriscjsus via groups.io wrote: > Sorry if this is a duplicate post.  I sent an email to > devel@edk2.groups.io before creating an > account on groups.io. > > This started with edk2-stable202311.  I bisected this to > > first bad commit: [e8aa4

Re: [edk2-devel] [PATCH v1 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Check BspIndex first before lock cmpxchg

On 2/20/24 04:41, Wu, Jiaxin wrote: >> From C11 "5.1.2.4 Multi-threaded executions and data races": >> >> - paragraph 4: "Two expression evaluations conflict if one of them >> modifies a memory location and the other one reads or modifies the same >> memory location." >> >> - paragraph 25: "The exe

Re: [edk2-devel] [PATCH v3 4/6] OvmfPkg/ResetVector: SEV: keep #vc handler installed longer

is needed to check for la57 & 1G page support. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/ResetVector/Ia32/AmdSev.asm | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) I'll let Tom review this :) Acked-by: Laszlo Ersek > > diff --git a/

Re: [edk2-devel] [PATCH v3 5/6] OvmfPkg/ResetVector: add 5-level paging support

On 2/20/24 10:06, Gerd Hoffmann wrote: > Compile the OVMF ResetVector with 5-level paging support in case > PcdUse5LevelPageTable is TRUE. > > When enabled the ResetVector will check at runtime whenever support for > 5-level paging and gigabyte pages is available. In case both features > are supp

Re: [edk2-devel] [PATCH v3 5/6] OvmfPkg/ResetVector: add 5-level paging support

On 2/20/24 18:45, Laszlo Ersek wrote: > (I'm using quotes around "subroutines" and "call" because we don't have > a stack at this point yet, IIUC, so all our "one time calls" are > actually just normal jumps, with some NASM macro magic. That&#

Re: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

--- > *From:* Ding, Feng (Sunnyvale) > *Sent:* Thursday, February 8, 2024 5:09 PM > *To:* Laszlo Ersek ; devel@edk2.groups.io > ; Hsueh, Hong-Chih (Neo) > *Cc:* He, Jiangang ; Chang, Abner > ; ray...@intel.com ; > gaolim...@byosoft.com.

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix IN OUT parameters marked as IN

M >> To: devel@edk2.groups.io >> Cc: Zhou, Jianfeng ; Ni, Ray ; >> Laszlo Ersek ; Kumar, Rahul R >> ; Gerd Hoffmann >> Subject: [PATCH] UefiCpuPkg: Fix IN OUT parameters marked as IN >> >> Some IN OUT parameters in CpuPageTableMap.c were mistakenl

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix IN OUT parameters marked as IN

On 2/21/24 21:06, Laszlo Ersek wrote: > On 2/21/24 06:46, Ni, Ray wrote: >> Reviewed-by: Ray Ni > > Thank you Ray for reviewing this; I'm happy if this goes in with your > review. small suggestion: I think we could improve the subject line as follows: UefiCpuPkg/CpuP

Re: [edk2-devel] [PATCH] UefiCpuPkg: add volatile qualifier to page table related variable

On 2/21/24 02:25, Zhou Jianfeng wrote: > Add volatile qualifier to page table related variable to prevent > compiler from optimizing away the variables which may lead to > unexpected result. > > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Ku

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/21/24 18:15, Borzeszkowski, Alan wrote: >> It does not make sense to have a UEFI Driver active in early DXE because it >> will not be connected yet and has dependencies on other UEFI drivers that >> will not be connected yet. > > With suggested change, we connect to this driver successfully

Re: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present

On 2/20/24 15:48, Ard Biesheuvel wrote: > Hello Mike, > > I understand the desire to be pedantic about cc'ing the right > maintainers, but I'm not convinced this is the way. > > - the presence of a cc: tag does not guarantee that the person was > cc'ed - only git send-email will take CC:s in the

Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue

On 2/21/24 18:15, Santhosh Kumar V via groups.io wrote: > The customer has a server environment where PXE and HTTP service run in same > Linux Server. In this environment a SUT trying to boot to SLES 15 OS via PXE > from the Boot Menu. After PXE Boot file downloaded and grub Loaded without > con

Re: [edk2-devel] Peims are not gettting Dispatched in EagleStream Platform

On 2/21/24 07:59, memristor2 via groups.io wrote: > Hi, > I am trying to build edk2-platforms for EagleStream Platform. The > problem I am facing now is that the Peims are not getting dispatched > when The PeiMain routine calls PeiDispatcher(). > After digging deeper into it it seems that the Depex

Re: [edk2-devel] [PATCH v2 1/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetMpHandOffHob

On 2/21/24 04:35, Ni, Ray wrote: >> -Original Message- >> From: Gerd Hoffmann >> Sent: Wednesday, February 21, 2024 1:50 AM >> To: devel@edk2.groups.io >> Cc: Oliver Steffen ; Laszlo Ersek >> ; Kumar, Rahul R ; Ni, Ray >> ; Gerd Hoffmann >&

Re: [edk2-devel] [PATCH v2 2/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetBspNumber()

[Index].ApicId == ApicId) { > +BspNumber = MpHandOff->ProcessorIndex + Index; > + } > } >} > It's strange that the pre-patch code keeps looking even after finding the BSP by APIC-ID; now it's stranger yet, because we even go to further HOBs. In the

Re: [edk2-devel] [PATCH v2 2/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetBspNumber()

On 2/20/24 18:49, Gerd Hoffmann wrote: > Rename the MpHandOff parameter to FirstMpHandOff. Add a loop so the > function inspects all HOBs present in the system. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 23 +++ > 1 file changed, 15 inser

Re: [edk2-devel] [PATCH v2 3/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SwitchApContext()

n of >memory and continue its loop there. > > - @param[in] MpHandOff Pointer to MP hand-off data structure. > + @param[in] FirstMpHandOff Pointer to first MP hand-off HOB. comment should say sth like "Pointer to first MP hand-off HOB body". Reviewed-by: Laszlo Ersek

Re: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize

On 2/20/24 18:49, Gerd Hoffmann wrote: > Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB > covering all CPUs in the system. > > Add a new HaveMpHandOff variable to track whenever MP_HAND_OFF HOBs are > present, using the MpHandOff pointer for that does not work because the > varia

Re: [edk2-devel] [PATCH v2 5/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

On 2/21/24 11:24, Gerd Hoffmann wrote: > On Wed, Feb 21, 2024 at 03:48:25AM +, Ni, Ray wrote: >>> >>> + MaxCpusPerHob = (MAX_UINT16 - sizeof (EFI_HOB_GUID_TYPE) - sizeof >>> (MP_HAND_OFF)) / sizeof (PROCESSOR_HAND_OFF); >> >> Above formula assumes the maximum HOB length could be 0x. > > W

Re: [edk2-devel] [PATCH v2 5/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

(commenting once more, to explain the actual reason:) On 2/21/24 11:24, Gerd Hoffmann wrote: > On Wed, Feb 21, 2024 at 03:48:25AM +, Ni, Ray wrote: >>> >>> + MaxCpusPerHob = (MAX_UINT16 - sizeof (EFI_HOB_GUID_TYPE) - sizeof >>> (MP_HAND_OFF)) / sizeof (PROCESSOR_HAND_OFF); >> >> Above formula

Re: [edk2-devel] [PATCH v2 5/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

On 2/20/24 18:49, Gerd Hoffmann wrote: > Add support for splitting Hand-Off data into multiple HOBs. This is > required for VMs with thousands of CPUs. The actual CPU count per HOB > is much smaller (128) for better test coverage. (1) The mention of the count 128 now seems stale for the code. >

Re: [edk2-devel] [PATCH v2 5/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

On 2/22/24 02:49, Laszlo Ersek wrote: > (commenting once more, to explain the actual reason:) > > On 2/21/24 11:24, Gerd Hoffmann wrote: >> On Wed, Feb 21, 2024 at 03:48:25AM +, Ni, Ray wrote: >>>> >>>> + MaxCpusPerHob = (MAX_UINT16 - sizeof (EFI_HO

Re: [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

? Or are you wanting > to jump from 1.2x to 1.3x to indicate a behavior change? > > Thanks, > > Mike > > >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, February 14, 2024 11:58 PM >> To: devel@edk2.groups.io; Kinney, Michael D >>

Re: [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

On 2/15/24 18:29, Michael D Kinney wrote: > The current INF Spec uses INF_VERSION of 1.27. Side topic: the build spec says in 8.7: https://tianocore-docs.github.io/edk2-BuildSpecification/draft/8_pre-build_autogen_stage/87_generated_asbuilt_inf_files.html that the build tool will *downgrade

[edk2-devel] [v2] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

v1 posting: https://edk2.groups.io/g/devel/message/115193 msgid <36593e23-d3e8-b71a-808d-ef94260b5...@redhat.com> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=991 In version 2, the feature is structured differently. Following Mike's advice, for compatibility, the ProcessLibrar

[edk2-devel] [PATCH] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Suggested-by: Liming Gao Suggested-by: Michael D Kinney Signed-off-by: Laszlo Ersek --- Notes: v2: - CI run: <https://github.com/tianocore/edk2/pull/5

[edk2-devel] [edk2-BuildSpecification PATCH 0/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

tbook-action.yml Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Thanks Laszlo Laszlo Ersek (3): README.md: fix revision history whitespace AutoGen.c: list the SEC module type for / (VOID) AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

[edk2-devel] [edk2-BuildSpecification PATCH 1/3] README.md: fix revision history whitespace

Fix the right-hand-side whitespace in the revision history table. Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Signed-off-by: Laszlo Ersek --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] [edk2-BuildSpecification PATCH 3/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Suggested-by: Liming Gao Suggested-by: Michael D Kinney Signed-off-by: Laszlo Ersek --- 8_pre-build_autogen_stage/83_auto-generated_code.md | 26

[edk2-devel] [edk2-BuildSpecification PATCH 2/3] AutoGen.c: list the SEC module type for / (VOID)

The build spec only lists BASE thus far; cover SEC now. This patch is best viewed with "git show -W". Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Signed-off-by: Laszlo Ersek --- 8_pre

[edk2-devel] [edk2-InfSpecification PATCH 0/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Thanks Laszlo Laszlo Ersek (2): README.md: fix revision history whitespace README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules README.md | 5 +++-- 1 file changed, 3 insertions(+)

[edk2-devel] [edk2-InfSpecification PATCH 2/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

https://bugzilla.tianocore.org/show_bug.cgi?id=991 Suggested-by: Liming Gao Suggested-by: Michael D Kinney Signed-off-by: Laszlo Ersek --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index ea7bf9b9dc43..d077ab1ceaad 100644 --- a/README.md +++ b/README.md @@

[edk2-devel] [edk2-InfSpecification PATCH 1/2] README.md: fix revision history whitespace

Fix the right-hand-side whitespace in the revision history table. Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Signed-off-by: Laszlo Ersek --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [edk2-devel] [edk2-BuildSpecification PATCH 0/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

On 2/24/24 22:23, Laszlo Ersek wrote: > The first two patches are cleanups, the new feature is documented in the > third patch. > > I managed to render these updates to public HTML, following > > (a) Mike's note from October 2020: > > https://edk2.groups.io/g/

Re: [edk2-devel] [edk2-InfSpecification PATCH 0/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

On 2/24/24 22:28, Laszlo Ersek wrote: > The first patch is a minor cleanup, the new feature is documented in the > second patch. > > Rendered version: > > > https://lersek.github.io/edk2-InfSpecification/ProcessLibraryConstructorList-SEC-991/ > > htt

Re: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize

d Hoffmann >> Sent: Thursday, February 22, 2024 8:29 PM >> To: Laszlo Ersek >> Cc: devel@edk2.groups.io; Oliver Steffen ; Kumar, >> Rahul R ; Ni, Ray >> Subject: Re: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add support >> for multiple HOBs to MpInit

Re: [edk2-devel] [PATCH] UefiCpuPkg: add volatile qualifier to page table related variable

On 2/22/24 11:23, Ni, Ray wrote: >>> I agree with the idea (I think it's a necessary change, or put >>> differently, an improvement, even though I may not be convinced that it >>> is a *sufficient* improvement; but let's not rehash all that here >>> again); however, I think the implementation is no

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile

On 2/23/24 16:51, Michael Brown wrote: > On 23/02/2024 15:12, Zhou, Jianfeng wrote: >>> While it may well cause the compiler to generate less optimised code, >>> there is absolutely no way that this volatile declaration on a local >>> stack variable can possibly change the outcome of the code. >>>

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

usDxe internals (resource management in particular) to confidently approve this patch. I can give an Acked-by: Laszlo Ersek but the patch should not be merged until Ray provides an R-b. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/CpuPageTableLib: Fix IN OUT parameters marked as IN

bSetPle(): Ple > PageTableLibSetPnle(): Pnle > > Reviewed-by: Ray Ni > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > .../Library/CpuPageTableLib/CpuPageTableMap.c | 32 +-- > 1 file

Re: [edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c

Hello Charles, On 2/24/24 17:01, Charles Hyde wrote: > There is a bug in the following source file: > > uefi-sct\ > SctPkg\ > TestCase\ > UEFI\ >EFI\ > Protocol\ > DevicePathFromText\ > BlackBoxTest\ >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/23/24 16:50, Albecki, Mateusz wrote: > Hi, > > I was originally responsible for suggesting this change > internally(more specifically - to switch from Intel specific LPSS UART > driver to EDK2 driver which on inspection seemed to cover all relevant > modes of operations of LPSS UART). > > Firs

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/25/24 17:18, Laszlo Ersek wrote: > ... Ah, okay! This is the point where I re-read your steps, and now I > see the actual breakage. > > It is your step #2. > > Placing the PciSioSerialDxe driver -- which is a UEFI driver that > follows the UEFI driver model, a

Re: [edk2-devel] [PATCH v3 00/12] OvmfPkg: tweak shell builds

On 2/22/24 11:13, Gerd Hoffmann wrote: > - Create include files to reduce duplication. > - Fix varpolicy command. > - Little CI tweak. > > v3: > - pick up review and ack tags. > - no functional changes. > v2: > - do not move ShellCEntryLib to include file. > - refine network config conditional

Re: [edk2-devel] [PATCH] ArmVirtPkg/XenAcpiPlatformDxe: Install FACS table from DT

On 2/13/24 11:50, David Woodhouse wrote: > From: David Woodhouse > > The FACS may still exist when the reduced hardware flag is set in FADT; > it is optional. Since it contains the hardware signature field which > indicates that a hibernated system should boot cleanly instead of > attempting to r

Re: [edk2-devel] [PATCH v3 1/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetMpHandOffHob

ain, it's valid English. (E.g., we also don't try to enforce American vs. British English spelling in comments, even though the American one is much more common in the codebase.) Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this grou

Re: [edk2-devel] [PATCH v3 4/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize

--- > 1 file changed, 47 insertions(+), 21 deletions(-) Based on comparison against v2 (commit message update, plus plan to extract WaitLoopExecutionMode and StartupSignalValue to a new, library-internal, HOB): Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Re: [edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

uMpData->ApLoopMode != ApInHltLoop) { > - MpHandOff->Info[Index].StartupSignalAddress= > (UINT64)(UINTN)CpuMpData->CpuData[Index].StartupApSignal; > - MpHandOff->Info[Index].StartupProcedureAddress = > (UINT64)(UINTN)&CpuMpData->CpuData[Index].ApFunction; &

Re: [edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

On 2/23/24 03:16, Ni, Ray wrote: > > > Thanks, > Ray >> -Original Message- >> From: Gerd Hoffmann >> Sent: Friday, February 23, 2024 12:01 AM >> To: devel@edk2.groups.io >> Cc: Laszlo Ersek ; Ni, Ray ; Kumar, >> Rahul R ; Oliver Steff

Re: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber()

On 2/23/24 03:33, Ni, Ray wrote: >> + ASSERT (FALSE); > > How about ASSERT (EFI_NOT_FOUND)? Which is more meaningful than FALSE. I'll edit the patch -- assuming you mean ASSERT_EFI_ERROR (EFI_NOT_FOUND); Laszlo > > No matter you change or not, Reviewed-by: Ray Ni > >> + return 0; >> }

Re: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber()

On 2/22/24 17:01, Gerd Hoffmann wrote: > After finding the BSP Number return the result instead of > continuing to loop over the remaining processors. > > Suggested-by: Laszlo Ersek > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 11

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

On 2/22/24 17:01, Gerd Hoffmann wrote: > Needed to boot guests with thousands of vcpus. > > v3: > - refine comments and commit messages. > - fix MaxCpusPerHob calculation. > - pick up review tags. > - add patch to speed up GetBspNumber a bit. > v2: > - rework HOB loops for better performance:

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

! 1: ecd6c4bb3396 UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetMpHandOffHob @@ Commit message Signed-off-by: Gerd Hoffmann Message-Id: <20240222160106.686484-2-kra...@redhat.com> +Reviewed-by: Ray Ni +Reviewed-by: Laszlo Ersek ## Uef

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

On 2/26/24 16:13, Albecki, Mateusz wrote: > 1. Using SerialDxe instead of PciSioSerialDxe - from our perspective > the main idea is to avoid maintaining our own implementation of > functions that actually communicate with UART controller. To use > SerialDxe we would have to still maintain our own S

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

On 2/26/24 16:41, Joey Vagedes via groups.io wrote: > Taking a look at all the runners > (https://dev.azure.com/tianocore/edk2-ci/_settings/buildqueue?_a=concurrentJobs > [Click "Microsoft Hosted", "View in-progress jobs"]), I don't see any > runners that are frozen, which is why it appears it's j

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

Hi Joey, On 2/26/24 16:41, Joey Vagedes wrote: > Hi Lazlo, > > I just looked at the pipelines - Looks like everything is fine, there is just > currently a backup of runners of jobs in the runners. It is common for jobs > that end in CODE_COVERAGE to appear frozen in queued status, but this is >

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

On 2/26/24 16:19, Laszlo Ersek wrote: > On 2/22/24 17:01, Gerd Hoffmann wrote: >> Needed to boot guests with thousands of vcpus. >> >> v3: >> - refine comments and commit messages. >> - fix MaxCpusPerHob calculation. >> - pick up review tags. >>

Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue

velopment (CC'd), so I figure bug analysis and bugfix posting should occur on their normal development mailing list. Laszlo > -Original Message- > From: Sivaraman Nainar > Sent: Monday, February 26, 2024 4:01 PM > To: devel@edk2.groups.io; Sivaraman Nainar ; Laszlo Erse

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

out to be merged. Laszlo > > Thanks, > Ray >> -Original Message----- >> From: devel@edk2.groups.io On Behalf Of Laszlo >> Ersek >> Sent: Monday, February 26, 2024 11:20 PM >> To: devel@edk2.groups.io; kra...@redhat.com >> Cc: Ni, Ray ; Kumar,

Re: [edk2-devel] [PATCH v4 0/3] OvmfPkg: Add support for 5-level paging

Hi Liming, can you please check the first two patches in the series? They should be easy to review. Thanks! Laszlo On 2/22/24 11:54, Gerd Hoffmann wrote: > Patch #1 + #2 fix MdeModulePkg/DxeIplPeim to not assert in case a > 5-level enabled build runs in 4-level paging mode. > > Patch #3 updates

Re: [edk2-devel] [PATCH v3 4/4] OvmfPkg/PlatformPei: log pei memory cap details

On 2/27/24 09:44, Gerd Hoffmann wrote: > On Thu, Feb 15, 2024 at 09:24:41AM +0100, Laszlo Ersek wrote: >> >> Reviewed-by: Laszlo Ersek >> >> This series is now ready for merging, as far as I'm concerned (thanks >> for the updates in the other patches too, I

Re: [edk2-devel] CodeQL Analysis in edk2

On 2/27/24 17:04, Michael Kubacki wrote: > Hi Gerd, > > There is a way to suppress results explained here: > https://github.com/tianocore/edk2/tree/master/BaseTools/Plugin/CodeQL#filter-patterns > > A real-world example is here: > https://github.com/microsoft/mu_basecore/blob/release/202311/CodeQ

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: add struct MP_HAND_OFF_CONFIG

So, in connection to the other subthread Re: [edk2-devel] CodeQL Analysis in edk2 msgid: <80abb140-9a9c-43b8-ba0b-d8ea631d9...@linux.microsoft.com> https://edk2.groups.io/g/devel/message/116054 I suggest replacing this with: if (MpHandOffConfig == NULL) { DEBUG (( DEBU

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: add struct MP_HAND_OFF_CONFIG

On 2/27/24 12:41, Gerd Hoffmann wrote: > Move the WaitLoopExecutionMode and StartupSignalValue fields to a > separate HOB with the new struct. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 13 ++-- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +- > Ue

Re: [edk2-devel] [PATCH 02/10] OvmfPkg/ResetVector: add ClearOvmfPageTables macro

l the label ..@clearPageTablesMemoryLoop ? According to the documentation, that seems to be the safest / most robust label type to be used inside macros. Reviewed-by: Laszlo Ersek Thanks Laszlo > @@ -69,22 +87,7 @@ SetCr3ForPageTables64: > OneTimeCall GetSevCBitMaskAbove31 >

Re: [edk2-devel] [PATCH 03/10] OvmfPkg/ResetVector: add CreatePageTables4Level macro

ADDR (0x2000 - 8)) + 4], edx > -looppageTableEntriesLoop > +CreatePageTables4Level edx > > ; Clear the C-bit from the GHCB page if the SEV-ES is enabled. > OneTimeCall SevClearPageEncMaskForGhcbPage Nice. "--color-moved=zebra" is really useful fo

Re: [edk2-devel] [PATCH 04/10] OvmfPkg/ResetVector: split TDX BSP workflow

gt; > -; TDX will do some PostBuildPages task, such as setting > -; byte[TDX_WORK_AREA_PGTBL_READY]. > -OneTimeCall TdxPostBuildPageTables > +TdxBspInit: > +; > + ; TDX BSP workflow > +; > +ClearOvmfPageTables > +CreatePageTables4Level 0 >

Re: [edk2-devel] [PATCH 05/10] OvmfPkg/ResetVector: split SEV and non-CoCo workflows

> - > -ClearOvmfPageTables > CreatePageTables4Level edx > - > ; Clear the C-bit from the GHCB page if the SEV-ES is enabled. > OneTimeCall SevClearPageEncMaskForGhcbPage > jmp SetCr3 Nice. The patch also sneakily reorders ClearOvm

Re: [edk2-devel] [PATCH 06/10] OvmfPkg/ResetVector: add 5-level paging support

On 2/22/24 12:54, Gerd Hoffmann wrote: > Add macros to check for 5-level paging and gigabyte page support. > Enable 5-level paging for the non-confidential-computing case. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/ResetVector/ResetVector.inf | 1 + > OvmfPkg/ResetVector/Ia32/PageT

Re: [edk2-devel] [PATCH 07/10] OvmfPkg/ResetVector: print post codes for 4/5 level paging

cate 5-level paging > +debugShowPostCode 0x51 > + > ; level 5 > mov dword[PT_ADDR (0)], PT_ADDR (0x1000) + PAGE_PDE_DIRECTORY_ATTR > mov dword[PT_ADDR (4)], %1 Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sen

<    1   2   3   4   5   6   7   8   9   10   >