On 2/21/24 21:06, Laszlo Ersek wrote:
> On 2/21/24 06:46, Ni, Ray wrote:
>> Reviewed-by: Ray Ni <ray...@intel.com>
>
> Thank you Ray for reviewing this; I'm happy if this goes in with your
> review.
small suggestion: I think we could improve the subject line as follows:
UefiCpuPkg/CpuPageTableLib: Fix IN OUT parameters marked as IN
Thanks
Laszlo
>> Thanks,
>> Ray
>>> -----Original Message-----
>>> From: Zhou, Jianfeng <jianfeng.z...@intel.com>
>>> Sent: Wednesday, February 21, 2024 9:25 AM
>>> To: devel@edk2.groups.io
>>> Cc: Zhou, Jianfeng <jianfeng.z...@intel.com>; Ni, Ray <ray...@intel.com>;
>>> Laszlo Ersek <ler...@redhat.com>; Kumar, Rahul R
>>> <rahul.r.ku...@intel.com>; Gerd Hoffmann <kra...@redhat.com>
>>> Subject: [PATCH] UefiCpuPkg: Fix IN OUT parameters marked as IN
>>>
>>> Some IN OUT parameters in CpuPageTableMap.c were mistakenly marked as
>>> IN.
>>> "IN" replaced with "IN OUT" in the following interfaces:
>>>
>>> PageTableLibSetPte4K(): Pte4K
>>> PageTableLibSetPleB(): PleB
>>> PageTableLibSetPle(): Ple
>>> PageTableLibSetPnle(): Pnle
>>>
>>> Signed-off-by: Zhou Jianfeng <jianfeng.z...@intel.com>
>>> Cc: Ray Ni <ray...@intel.com>
>>> Cc: Laszlo Ersek <ler...@redhat.com>
>>> Cc: Rahul Kumar <rahul1.ku...@intel.com>
>>> Cc: Gerd Hoffmann <kra...@redhat.com>
>>> ---
>>> .../Library/CpuPageTableLib/CpuPageTableMap.c | 32 +++++++++----------
>>> 1 file changed, 16 insertions(+), 16 deletions(-)
>>>
>>> diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c
>>> b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c
>>> index ae4caf8dfe..2ea40666cc 100644
>>> --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c
>>> +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c
>>> @@ -20,10 +20,10 @@
>>> **/
>>>
>>> VOID
>>>
>>> PageTableLibSetPte4K (
>>>
>>> - IN IA32_PTE_4K *Pte4K,
>>>
>>> - IN UINT64 Offset,
>>>
>>> - IN IA32_MAP_ATTRIBUTE *Attribute,
>>>
>>> - IN IA32_MAP_ATTRIBUTE *Mask
>>>
>>> + IN OUT IA32_PTE_4K *Pte4K,
>>>
>>> + IN UINT64 Offset,
>>>
>>> + IN IA32_MAP_ATTRIBUTE *Attribute,
>>>
>>> + IN IA32_MAP_ATTRIBUTE *Mask
>>>
>>> )
>>>
>>> {
>>>
>>> IA32_PTE_4K LocalPte4K;
>>>
>>> @@ -94,10 +94,10 @@ PageTableLibSetPte4K (
>>> **/
>>>
>>> VOID
>>>
>>> PageTableLibSetPleB (
>>>
>>> - IN IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE *PleB,
>>>
>>> - IN UINT64 Offset,
>>>
>>> - IN IA32_MAP_ATTRIBUTE *Attribute,
>>>
>>> - IN IA32_MAP_ATTRIBUTE *Mask
>>>
>>> + IN OUT IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE *PleB,
>>>
>>> + IN UINT64 Offset,
>>>
>>> + IN IA32_MAP_ATTRIBUTE *Attribute,
>>>
>>> + IN IA32_MAP_ATTRIBUTE *Mask
>>>
>>> )
>>>
>>> {
>>>
>>> IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE LocalPleB;
>>>
>>> @@ -171,11 +171,11 @@ PageTableLibSetPleB (
>>> **/
>>>
>>> VOID
>>>
>>> PageTableLibSetPle (
>>>
>>> - IN UINTN Level,
>>>
>>> - IN IA32_PAGING_ENTRY *Ple,
>>>
>>> - IN UINT64 Offset,
>>>
>>> - IN IA32_MAP_ATTRIBUTE *Attribute,
>>>
>>> - IN IA32_MAP_ATTRIBUTE *Mask
>>>
>>> + IN UINTN Level,
>>>
>>> + IN OUT IA32_PAGING_ENTRY *Ple,
>>>
>>> + IN UINT64 Offset,
>>>
>>> + IN IA32_MAP_ATTRIBUTE *Attribute,
>>>
>>> + IN IA32_MAP_ATTRIBUTE *Mask
>>>
>>> )
>>>
>>> {
>>>
>>> if (Level == 1) {
>>>
>>> @@ -195,9 +195,9 @@ PageTableLibSetPle (
>>> **/
>>>
>>> VOID
>>>
>>> PageTableLibSetPnle (
>>>
>>> - IN IA32_PAGE_NON_LEAF_ENTRY *Pnle,
>>>
>>> - IN IA32_MAP_ATTRIBUTE *Attribute,
>>>
>>> - IN IA32_MAP_ATTRIBUTE *Mask
>>>
>>> + IN OUT IA32_PAGE_NON_LEAF_ENTRY *Pnle,
>>>
>>> + IN IA32_MAP_ATTRIBUTE *Attribute,
>>>
>>> + IN IA32_MAP_ATTRIBUTE *Mask
>>>
>>> )
>>>
>>> {
>>>
>>> IA32_PAGE_NON_LEAF_ENTRY LocalPnle;
>>>
>>> --
>>> 2.31.1.windows.1
>>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115740): https://edk2.groups.io/g/devel/message/115740
Mute This Topic: https://groups.io/mt/104483605/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
