Reviewed-by: Gua Guo
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, November 30, 2023 2:32 PM
To: devel@edk2.groups.io
Cc: Laszlo Ersek ; Dong, Guo ; Rhodes,
Sean ; Lu, James ; Guo, Gua
; Ni, Ray ; Zeng, Star
Subject: [PATCH v2 5/6] UefiPayloadPkg: Specifies SmmCpuSyncLib
Reviewed-by: Gua Guo
-Original Message-
From: Liu, Zhiguang
Sent: Thursday, December 7, 2023 10:40 AM
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Gao, Liming
; Wu, Jiaxin ; Ni, Ray
; Dong, Guo ; Rhodes, Sean
; Lu, James ; Guo, Gua
Subject: [PATCH 2/2] UefiPayloadPkg
Reviewed-by: Gua Guo
From: Liu, Zhiguang
Sent: Thursday, December 14, 2023 3:59:38 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Wu, Jiaxin ;
Ni, Ray ; Dong, Guo ; Rhodes, Sean
; Lu, James ; Guo, Gua
Subject: RE: [PATCH 1/2] MdeModulePkg/DxeIpl: Add 5 level
Hi @Gao, Liming and @Rebecca Cran
I may need to get your help for review it, any concern you can also share for
us.
Thanks,
Gua
-Original Message-
From: devel@edk2.groups.io On Behalf Of Yuwei Chen
Sent: Friday, December 15, 2023 5:12 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Gao,
Reviewed-by: Gua Guo
-Original Message-
From: Ma, Hua
Sent: Friday, January 5, 2024 2:19 PM
To: devel@edk2.groups.io; Guo, Gua ; Dong, Guo
; Lu, James ; Rhodes, Sean
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to enable selection
of timer
Add maintainers to help
Reviewed-by: Gua Guo
-Original Message-
From: Chen, Gang C
Sent: Monday, January 8, 2024 3:26 PM
To: devel@edk2.groups.io
Cc: Guo, Gua ; Dong, Guo ; Lu, James
; Rhodes, Sean ; Chen, Gang C
Subject: [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check
It'
From: Gua Guo
Fix Integer Overflow for CVE-2022-36765
1. UefiPayloadPkg/Hob: Integer Overflow in CreateHob()
2. StandaloneMmPkg/Hob: Integer Overflow in CreateHob()
3. EmbeddedPkg/Hob: Integer Overflow in CreateHob()
4. MdeModulePkg/Hob: Integer Overflow in CreateHob()
Gerd Hoffmann (4):
Uefi
From: Gerd Hoffmann
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7)
From: Gerd Hoffmann
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7)
From: Gerd Hoffmann
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7)
From: Gerd Hoffmann
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7)
also let me know, before merging it.
It's PR https://github.com/tianocore/edk2/pull/5252/
Thanks,
Gua
-Original Message-
From: devel@edk2.groups.io On Behalf Of Guo, Gua
Sent: Thursday, January 11, 2024 1:15 PM
To: devel@edk2.groups.io
Cc: Guo, Gua
Subject: [edk2-devel] [PATCH v1 0
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
```
From: Gua Guo
V2
1. UefiPayloadPkg/Hob: Integer : Add Reviewed-by and Authored-by
2. StandaloneMmPkg/Hob: Integer Overflow in : Add Reviewed-by and Authored-by
3. EmbeddedPkg/Hob: Integer Overflow in CreateHob() : Add Reviewed-by and
Authored-by
4. MdeModulePkg/Hob: Integer Overflow in Create
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
```
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
```
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
```
Hi @Gao, Liming
I may need to get your help to check this change when you're available.
If it's fine for you from MdeModulePkg. I think we can merge this PR.
https://github.com/tianocore/edk2/pull/5252
Thanks,
Gua
-Original Message-----
From: Guo, Gua
Sent: Thursday, January
You mean we need to add below error handle after all callers ?
Hob = CreateHob (...)
ASSERT (Hob != NULL); < Here
Thanks,
Gua
-Original Message-
From: Sami Mujawar
Sent: Thursday, January 11, 2024 10:06 PM
To: Guo, Gua ; devel@edk2.groups.io
Cc: Marc Beatove ;
> CreateHob
> return NULL
All caller chain may need to add it if we really want to prevent it on release.
Thanks,
Gua
-Original Message-
From: Sami Mujawar
Sent: Thursday, January 11, 2024 11:02 PM
To: Guo, Gua ; devel@edk2.groups.io
Cc: Marc Beatove ; Ard Biesheuvel
; Ni, Ra
From: Gua Guo
PR: https://github.com/tianocore/edk2/pull/5252
V3
1. UefiPayloadPkg/Hob: Integer : Add error handle
2. StandaloneMmPkg/Hob: Integer Overflow in : Add error handle
3. EmbeddedPkg/Hob: Integer Overflow in CreateHob() : Add error handle
V2
1. UefiPayloadPkg/Hob: Integer : Add Revi
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
```
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
```
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
```
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
Fix integer overflow in various CreateHob instances.
Fixes: CVE-2022-36765
The CreateHob() function aligns the requested size to 8
performing the following operation:
```
HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
```
Reviewed-by: Gua Guo
From: Lean Sheng Tan
Sent: Friday, January 12, 2024 7:33:00 PM
To: Rudolph, Patrick
Cc: devel@edk2.groups.io ; Rhodes, Sean
; Guo, Gua ; Lu, James
; Ni, Ray ; Dong, Guo
Subject: Re: [PATCH] UefiPayloadPkg: CbParseLib: Fix integer overflow
ently.
-Original Message-
From: Gerd Hoffmann
Sent: Tuesday, January 23, 2024 10:50 PM
To: Guo, Gua
Cc: devel@edk2.groups.io; Ard Biesheuvel ; Mathews,
John ; Zimmer, Vincent ; Sami
Mujawar ; jma...@redhat.com
Subject: Re: [PATCH v3 0/4] Bz4166: Integer Overflow in CreateHob()
On Fri, J
Reviewed-by: Gua Guo
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael D Kinney
Sent: Wednesday, January 24, 2024 7:19 AM
To: Jeff Brasen ; devel@edk2.groups.io
Cc: gaolim...@byosoft.com.cn; Liu, Zhiguang ; Kinney,
Michael D
Subject: Re: [edk2-devel] [PATCH v2 1/1] Mde
From: Gua Guo
Crypto in serveral case will use old version, treat as optional
will make customer easy to upgrade it.
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Gua Guo
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 3 +++
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
2 files
From: Gua Guo
Crypto in serveral case will use old version or latest version,
Platform may choose to only update Crypto drivers without updating
whole UPL, in this case the Crypto driver will provide by platform
payload outside the common UPL binary.
Cc: Chasel Chiu
Cc: Guo Dong
Cc: Sean Rhode
Hi @Gerd Hoffmann
It's PR https://github.com/tianocore/edk2/pull/5298 if no more concern
received, will merge it tomorrow morning.
Thanks,
Gua
-Original Message-
From: Gerd Hoffmann
Sent: Wednesday, January 24, 2024 8:48 PM
To: Guo, Gua
Cc: devel@edk2.groups.io; Ard Biesh
Reviewed-by: Gua Guo
From: Kinney, Michael D
Sent: Friday, October 20, 2023 8:56:26 AM
To: devel@edk2.groups.io ; Ni, Ray
Cc: Gao, Zhichao ; Wu, Hao A ; Liu,
Zhiguang ; Guo, Gua ; Kinney,
Michael D
Subject: RE: [edk2-devel] [PATCH V2] Maintainers.txt: Stop to
Reviewed-by: Gua Guo
From: Kinney, Michael D
Sent: Tuesday, October 24, 2023 8:09:16 AM
To: devel@edk2.groups.io ; t...@taylorbeebe.com
Cc: Dong, Guo ; Rhodes, Sean ; Lu,
James ; Guo, Gua ; Kinney, Michael D
Subject: RE: [edk2-devel] [PATCH v4 05/14
Reviewed-by: Gua Guo
-Original Message-
From: Wang, BruceX
Sent: Saturday, October 28, 2023 7:13 AM
To: devel@edk2.groups.io
Cc: Wang, BruceX ; Dong, Guo ;
Rhodes, Sean ; Lu, James ; Guo, Gua
Subject: [PATCH v2 1/1] UefiPayloadPkg: Fix incorrect code on Fit function.
From: BruceX
Reviewed-by: Gua Guo
-Original Message-
From: Wu, Jiaxin
Sent: Friday, November 3, 2023 11:30 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Rhodes, Sean ; Lu,
James ; Guo, Gua ; Ni, Ray
; Zeng, Star
Subject: [PATCH v1 6/7] UefiPayloadPkg: Specifies SmmCpuSyncLib instance
The
, James ; Guo, Gua
Subject: [PATCH] IntelFsp2WrapperPkg: Add variable initialization
From: "JasonX.Hsu"
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4595
Fix build error when remove "-Wno-sometimes-uninitialized" option, Add variable
"FspMultiPhaseApiOffset&q
Reviewed-by: Gua Guo
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Tuesday, February 20, 2024 11:26 PM
To: devel@edk2.groups.io
Cc: Liming Gao ; Guo, Gua ;
Prakashan, Krishnadas Veliyathuparambil
; K N, Karthik
Subject: [PATCH v1 1/1] MdeModulePkg/TraceHubDebugSysTLib
Series Reviewed-by: Gua Guo
From: Dhaval
Sent: Sunday, February 25, 2024 10:50:50 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Rhodes, Sean ; Lu,
James ; Guo, Gua
Subject: [PATCH v1 0/1] UefiPayloadPkg: Make Dsc accomodative of other archs
Current DSC files
From: Gua Guo
After 11ad164bcea6b0ed3628d merge,
ELF format API won't meet backward requirement.
Cc: Guo Dong
Cc: Sean Rhodes
Reviewed-by: James Lu
Cc: Gua Guo
Signed-off-by: Gua Guo
---
UefiPayloadPkg/UniversalPayloadBuild.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
Reviewed-by: Gua Guo
-Original Message-
From: Wang, BruceX
Sent: Friday, March 15, 2024 5:21 PM
To: devel@edk2.groups.io
Cc: Wang, BruceX ; Dong, Guo ;
Rhodes, Sean ; Lu, James ; Guo, Gua
Subject: [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorList()
From: Bruce
Reviewed-by: Gua Guo
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 9:57:17 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Rhodes, Sean ; Lu,
James ; Guo, Gua ; Ni, Ray
Subject: [PATCH v1 06/13] UefiPayloadPkg/UefiPayloadPkg.dsc: Include
SmmRelocationLib
From: Gua Guo
Ref to https://docs.python.org/3/whatsnew/3.12.html
utcnow() and utcfromtimestamp() are deprecated
Prevent use it cause build error.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Gua Guo
---
BaseTools/Scripts/GetUtcDateTime.py | 2 +-
1 file chang
From: Gua Guo
PR: https://github.com/tianocore/edk2/pull/5576
V1: Currently, Build FSP will be failure by python3.12 by calling
GetUtcDateTime.py
Gua Guo (1):
BaseTools/GetUtcDateTime.py: Python 3.12 support
BaseTools/Scripts/GetUtcDateTime.py | 2 +-
1 file changed, 1 insertion(+), 1 delet
Hi @Liming Gao and @Rebecca Cran
May I get one of your help for code review + 1 ?
Maybe we can merge it EOW, I think it's no harmful change.
Thanks,
Gua
-Original Message-
From: Guo, Gua
Sent: Sunday, April 21, 2024 8:51 PM
To: devel@edk2.groups.io
Cc: Guo, Gua ; Kasbekar, S
From: Gua Guo
PR: https://github.com/tianocore/edk2/pull/5577
V1: Prevent Syntax Warning after upgrade python version to 3.12
Gua Guo (2):
IntelFsp2Pkg/GenCfgOpt.py: Python 3.12 support
IntelFsp2Pkg/PatchFv.py: Python 3.12 support
IntelFsp2Pkg/Tools/GenCfgOpt.py | 96 -
From: Gua Guo
Ref to https://docs.python.org/3/whatsnew/3.12.html
A backslash-character pair that is not a valid
escape sequence now generates
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Duggapu Chinni B
Cc: Star Zeng
Cc: Ted Kuo
Cc: Ashraf Ali S
Cc: Susovan Mohapatra
Signed-off-by: Gua Guo
--
From: Gua Guo
Ref to https://docs.python.org/3/whatsnew/3.12.html
A backslash-character pair that is not a valid
escape sequence now generates
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Duggapu Chinni B
Cc: Star Zeng
Cc: Ted Kuo
Cc: Ashraf Ali S
Cc: Susovan Mohapatra
Signed-off-by: Gua Guo
--
Hi FSP folks
Need to get one of your help, to approve this PR, maybe we can merge it EOW.
Thanks
Gua
-Original Message-
From: Guo, Gua
Sent: Monday, April 22, 2024 9:37 AM
To: devel@edk2.groups.io
Cc: Guo, Gua
Subject: [PATCH v1 0/2] IntelFsp2Pkg: Python3.12 support
From: Gua Guo
From: Gua Guo
PR: https://github.com/tianocore/edk2/pull/5579
V1:
Ref to https://docs.python.org/3/whatsnew/3.12.html
A backslash-character pair that is not a valid
escape sequence now generates
Gua Guo (1):
BaseTools/Fmmt.py: Python 3.12 support
BaseTools/Source/Python/FMMT/FMMT.py |
From: Gua Guo
Ref to https://docs.python.org/3/whatsnew/3.12.html
A backslash-character pair that is not a valid
escape sequence now generates
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Gua Guo
---
BaseTools/Source/Python/FMMT/FMMT.py | 2 +-
1 file changed,
Thank @S, Ashraf Ali help for quick code review.
I've update rb message and will add push label tomorrow to make sure everyone
aware this change.
PR: https://github.com/tianocore/edk2/pull/5577
Thanks,
Gua
-Original Message-
From: Guo, Gua
Sent: Monday, April 22, 2024 9:41 AM
To:
Hi @Chiu, Chasel and @Kinney, Michael D
As you know, Intel don't have owner own basetools now, may I get your help to
reach the PR to maintainer.
Thanks,
Gua
-Original Message-
From: Guo, Gua
Sent: Monday, April 22, 2024 9:50 AM
To: devel@edk2.groups.io
Cc: Guo, Gua
Subject: [
Hi @Chiu, Chasel and @Kinney, Michael D
As you know, Intel don't have owner own basetools now, may I get your help to
reach the PR to maintainer.
Thanks,
Gua
-Original Message-
From: Guo, Gua
Sent: Monday, April 22, 2024 9:06 AM
To: devel@edk2.groups.io; Liming Gao ; Rebecca Cran
Thanks @gaoliming for the reviewed-by, I've updated the RB info into PR and add
push label.
https://github.com/tianocore/edk2/pull/5579
Thanks,
Gua
-Original Message-
From: gaoliming
Sent: Tuesday, April 23, 2024 10:42 PM
To: devel@edk2.groups.io; Guo, Gua
Cc: 'Rebecca Cr
Reviewed-by: Gua Guo
From: Wu, Jiaxin
Sent: Friday, April 26, 2024 8:17:19 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Rhodes, Sean ; Lu,
James ; Guo, Gua ; Ni, Ray
Subject: [PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include
SmmRelocationLib
This
From: Gua Guo
PR: https://github.com/tianocore/edk2/pull/5661
V1: Update swig install process into ReadMe.md
Cc: Chasel Chiu
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Gua Guo (1):
UefiPayloadPkg: Update ReadMe.md to swig install
UefiPayloadPkg/Readme.md | 4 +++-
1 file
From: Gua Guo
Update ReadMe.md for swig install process in
windows OS.
Cc: Chasel Chiu
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Gua Guo
---
UefiPayloadPkg/Readme.md | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/UefiPayloadPkg/Readme.md
Update RB info into PR, wait Edk2 202405 Hard Freeze unlock, will merge it.
-Original Message-
From: Dong, Guo
Sent: Thursday, May 16, 2024 12:03 AM
To: Guo, Gua ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Rhodes, Sean ;
Lu, James
Subject: RE: [PATCH v1 1/1] UefiPayloadPkg: Update
Please send PR also.
From: Lean Sheng Tan
Sent: Wednesday, June 5, 2024 10:18:27 PM
To: devel@edk2.groups.io ; Witt, Sebastian
; Guo, Gua ; Rhodes, Sean
; Lu, James ; Dong, Guo
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload
size
I’ve added push label, it will be merged tomorrow.
From: Lean Sheng Tan
Sent: Monday, June 10, 2024 11:28 PM
To: Witt, Sebastian
Cc: Guo, Gua ; devel@edk2.groups.io; Rhodes, Sean
; Lu, James ; Dong, Guo
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload
size
-Original Message-
From: Dhaval
Sent: Monday, June 10, 2024 11:45 PM
To: devel@edk2.groups.io
Cc: Guo, Gua ; Dong, Guo ; Lu, James
; Rhodes, Sean
Subject: [PATCH v1 1/1] UefiPayloadPkg: Enable UPL FIT build config from cmdline
Provide commandline configuration to select proper platform fil
Reviewed-by: Gua Guo
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Tuesday, September 6, 2022 4:29 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois ; Dong, Guo ;
Ni, Ray ; Rhodes, Sean
Subject: [edk2-devel] [PATCH v2 16/17] UefiPayloadPkg: Remove duplicat
From: Gua Guo
In order to collect code coverage after running executable
file, generate *.gcda and *.gcno file that require by lcov tool
to generate code coverage report.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael Kubacki
Signed-off-by: Gua Guo
---
UnitTestFramework
enhtml UnitTest.info --branch-coverage -o .Build/UnitTestReport
Step5. Open "Build/UnitTestReport/index.html"
Thanks,
Gua
-----Original Message-
From: Guo, Gua
Sent: Tuesday, September 13, 2022 9:24 PM
To: devel@edk2.groups.io
Cc: Guo, Gua ; Kinney, Michael D
; Sean Brogan ;
Ba
Sure, thanks for replying quickly, let me update readme.md file in my next
patch.
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, September 13, 2022 11:10 PM
To: Guo, Gua ; devel@edk2.groups.io; Kinney, Michael D
Cc: Sean Brogan ; Barkelew, Bret
; Michael Kubacki
Subject
From: Gua Guo
In order to collect code coverage after running executable
file, generate *.gcda and *.gcno file that require by lcov tool
to generate code coverage report.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael Kubacki
Signed-off-by: Gua Guo
---
UnitTestFramework
ool? No, currently I don’t find a
good way to generate code coverage for MSVC compiler
Thanks,
Gua
From: Kinney, Michael D
Sent: Wednesday, September 14, 2022 9:52 AM
To: Sean Brogan ; devel@edk2.groups.io; Guo, Gua
; Kinney, Michael D
Cc: Sean Brogan ; Michael Kubacki
Subject: RE: [edk2-devel]
t may give me some time to think how to modify.
edk2\.azurepipelines\Windows-VS2019.yml
It may give me some time to think how to modify.
edk2\.azurepipelines\Ubuntu-GCC5.yml
Thanks,
Gua
From: Kinney, Michael D
Sent: Thursday, September 15, 2022 12:35 AM
To: Guo, Gua ; Sean Brogan ;
devel@edk2.gro
From: Gua Guo
V1: Add coverage option for GCC
V2: Add ReadMe.md for how to generate coverage report
V3: Add VS2019 and GCC code coverage support
Gua Guo (2):
UnitTestFrameworkPkg: Add code coverage support for GCC
BaseTools/Plugin: Add coverage support for Unit Test
.../HostBasedUnitTestRu
From: Gua Guo
In order to collect code coverage after running executable
file, generate *.gcda and *.gcno file that require by lcov tool
to generate code coverage report.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael Kubacki
Signed-off-by: Gua Guo
---
UnitTestFramework
From: Gua Guo
For GCC, use lcov to generate Unit Test code coverage
report
For VS2019, use OpenCppCoverage to generate code
coverage report
Cc: Bob Feng
Cc: Liming Gao
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Sean Brogan
Signed-off-by: Gua Guo
---
.../HostBasedUnitTestRunner.py
It's PR based on the patch. Have any concern, please also share for me.
https://github.com/tianocore/edk2/pull/3349
Thanks,
Gua
-Original Message-
From: devel@edk2.groups.io On Behalf Of Guo, Gua
Sent: Thursday, September 22, 2022 3:09 PM
To: devel@edk2.groups.io
Cc: Guo, Gua
Su
dePkg CODE_COVERAGE=TRUE CC_HTML=TRUE
Thanks,
Gua
-Original Message-
From: Kinney, Michael D
Sent: Friday, September 23, 2022 12:15 AM
To: Guo, Gua ; devel@edk2.groups.io
Cc: Sean Brogan
Subject: RE: [edk2-devel] [PATCH v3 0/2] UnitTestFrameworkPkg: Add code
coverage support for GCC
From: Gua Guo
V1: Add coverage option for GCC
V2: Add ReadMe.md for how to generate coverage report
V3: Add VS2019 and GCC code coverage support
V4: Add VS2019/GCC CI/CD support
Gua Guo (3):
UnitTestFrameworkPkg: Add code coverage support for GCC
BaseTools/Plugin: Add coverage support for Un
From: Gua Guo
In order to collect code coverage after running executable
file, generate *.gcda and *.gcno file that require by lcov tool
to generate code coverage report.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael Kubacki
Signed-off-by: Gua Guo
---
UnitTestFramework
From: Gua Guo
For GCC, use lcov to generate Unit Test code coverage
report
For VS2019, use OpenCppCoverage to generate code
coverage report
Cc: Bob Feng
Cc: Liming Gao
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Sean Brogan
Signed-off-by: Gua Guo
---
BaseTools/Plugin/HostBasedUnitTestRunn
From: Gua Guo
For Windows add below tool for code coverage
1. OpenCppCoverage: parsing pdb file to generate coverage
data
2. pycobertura: show up html format data for coverage data
For Linux add below tool for code coverage
1. lcov: parsing gcda gcno file to generate coverage data
2. lcov-cobert
@Sean Brogan and @Kinney, Michael D
Thanks for comment in Patch V3.
It updated now. https://github.com/tianocore/edk2/pull/3349
Thanks,
Gua
-Original Message-
From: Guo, Gua
Sent: Tuesday, September 27, 2022 12:40 PM
To: devel@edk2.groups.io
Cc: Guo, Gua
Subject: [PATCH v4 0/3
From: Gua Guo
V1: Add coverage option for GCC
V2: Add ReadMe.md for how to generate coverage report
V3: Add VS2019 and GCC code coverage support
V4: Add VS2019 and GCC Azure CI/CD support
V5: Fix some typo and some flow issue
Gua Guo (3):
UnitTestFrameworkPkg: Add code coverage support for GCC
From: Gua Guo
In order to collect code coverage after running executable
file, generate *.gcda and *.gcno file that require by lcov tool
to generate code coverage report.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael Kubacki
Signed-off-by: Gua Guo
---
UnitTestFramework
From: Gua Guo
For GCC, use lcov to generate Unit Test code coverage
report
For VS2019, use OpenCppCoverage to generate code
coverage report
Cc: Bob Feng
Cc: Bret Barkelew
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Sean Brogan
Signed-off-by: Gua Guo
---
.../HostBasedUnitTestRunner.py
From: Gua Guo
For Windows add below tool for code coverage
1. OpenCppCoverage: parsing pdb file to generate coverage
data
2. pycobertura: show up html format data for coverage data
For Linux add below tool for code coverage
1. lcov: parsing gcda gcno file to generate coverage data
2. lcov-cobert
From: Gua Guo
V1: Add coverage option for GCC
V2: Add ReadMe.md for how to generate coverage report
V3: Add VS2019 and GCC code coverage support
V4: Add VS2019 and GCC Azure CI/CD support
V5: Fix some typo and some flow issue
Gua Guo (3):
UnitTestFrameworkPkg: Add code coverage support for GCC
From: Gua Guo
In order to collect code coverage after running executable
file, generate *.gcda and *.gcno file that require by lcov tool
to generate code coverage report.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael Kubacki
Signed-off-by: Gua Guo
---
UnitTestFramework
From: Gua Guo
For GCC, use lcov to generate Unit Test code coverage
report
For VS2019, use OpenCppCoverage to generate code
coverage report
Cc: Bob Feng
Cc: Bret Barkelew
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Sean Brogan
Signed-off-by: Gua Guo
---
.../HostBasedUnitTestRunner.py
From: Gua Guo
For Windows add below tool for code coverage
1. OpenCppCoverage: parsing pdb file to generate coverage
data
2. pycobertura: show up html format data for coverage data
For Linux add below tool for code coverage
1. lcov: parsing gcda gcno file to generate coverage data
2. lcov-cobert
share for me.
Thanks,
Gua
-Original Message-
From: devel@edk2.groups.io On Behalf Of Guo, Gua
Sent: Friday, September 30, 2022 9:56 AM
To: devel@edk2.groups.io
Cc: Guo, Gua
Subject: [edk2-devel] [PATCH v5 0/3] Add code coverage support for GCC
From: Gua Guo mailto:gua@intel.com&
From: Gua Guo
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4096
TDES and ARC4 services are deprecated so set it as disable.
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Signed-off-by: Gua Guo
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
d
From: Gua Guo
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4096
TDES and ARC4 services are deprecated so set it as disable.
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Signed-off-by: Gua Guo
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
d
From: Gua Guo
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4096
TDES and ARC4 services are deprecated so set it as disable.
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Signed-off-by: Gua Guo
---
0001-UefiPayloadPkg-Remove-deprecate-Crypto-Service.patch | 40
UefiPayl
From: Gua Guo
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4096
TDES and ARC4 services are deprecated so set it as disable.
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Signed-off-by: Gua Guo
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 --
1 file changed, 2 deletions(-)
diff --git a/UefiPay
Reviewed-by: Gua Guo
-Original Message-
From: Sean Rhodes
Sent: Friday, October 7, 2022 4:22 AM
To: devel@edk2.groups.io
Cc: Rhodes, Sean ; Dong, Guo ; Ni,
Ray ; Lu, James ; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Make UniversalPayloadBuild.sh executable
Make the wrapper
Reviewed-by: Gua Guo
-Original Message-
From: Liu, KasimX
Sent: Friday, August 25, 2023 5:28 PM
To: devel@edk2.groups.io
Cc: Liu, KasimX ; Dong, Guo ; Ni, Ray
; Lu, James ; Guo, Gua
Subject: [PATCH v2] UefiPayloadPkg:Enhance the build processing for
Universalpayload
From: KasimX
: michael.buech...@posteo.net ; Guo, Gua
; Dong, Guo ; Lu, James
; Rhodes, Sean ; Doron, Benjamin
主旨: Re: [edk2-devel] [PATCH 0/1] UefiPayloadPkg: Match BAR if framebuffer is at
an offset
Reminder: Can anyone help to review this? Thanks!
On Fri, 25 Aug 2023 at 10:33, Sheng Lean Tan via
Reviewed-by: Gua Guo
-Original Message-
From: Wang, BruceX
Sent: Friday, September 15, 2023 4:58 PM
To: devel@edk2.groups.io
Cc: Wang, BruceX ; Dong, Guo ;
Rhodes, Sean ; Lu, James ; Guo, Gua
Subject: [PATCH v2 2/2] UefiPayloadPkg: Add FIT support
From: "Brucex.Wang"
P
Reviewed-by: Gua Guo
-Original Message-
From: Wang, BruceX
Sent: Friday, September 15, 2023 4:58 PM
To: devel@edk2.groups.io
Cc: Wang, BruceX ; Lin, Benny ;
Guo, Gua ; Chiu, Chasel ; Lu, James
Subject: [PATCH v2 1/2] MdePkg/BaseFdtLib: Add Fdt function.
From: "Brucex.Wang&q
Series Reviewed-by: Gua Gua
-Original Message-
From: Wang, BruceX
Sent: Saturday, September 16, 2023 6:53 PM
To: devel@edk2.groups.io
Cc: Wang, BruceX ; Guo, Gua
Subject: [PATCH v3 0/2] UefiPayloadPkg supports Fit
From: Gua Guo
V3: Fix Lean Sheng comment in patch mail
V2: Fix Gua
Reviewed-by: Gua Guo
-Original Message-
From: Wang, BruceX
Sent: Monday, September 18, 2023 3:02 PM
To: devel@edk2.groups.io
Cc: Wang, BruceX ; Lin, Benny ;
Guo, Gua ; Chiu, Chasel ; Lu, James
Subject: [PATCH v4 1/2] MdePkg/BaseFdtLib: Add Fdt function.
From: "Brucex.Wang&q
Reviewed-by: Gua Guo
-Original Message-
From: Wang, BruceX
Sent: Monday, September 18, 2023 3:02 PM
To: devel@edk2.groups.io
Cc: Wang, BruceX ; Dong, Guo ;
Rhodes, Sean ; Lu, James ; Guo, Gua
Subject: [PATCH v4 2/2] UefiPayloadPkg: Add FIT support
From: "Brucex.Wang"
P
Series Reviewed-by: Gua Guo
-Original Message-
From: devel@edk2.groups.io On Behalf Of
brucex.w...@intel.com
Sent: Monday, September 18, 2023 3:02 PM
To: devel@edk2.groups.io
Cc: Wang, BruceX
Subject: [edk2-devel] [PATCH v4 0/2] UefiPayloadPkg: Add FIT support
From: "Brucex.Wang"
V4
1 - 100 of 286 matches
Mail list logo
