Reviewed-by: Gua Guo <gua....@intel.com> -----Original Message----- From: Wang, BruceX <brucex.w...@intel.com> Sent: Friday, March 15, 2024 5:21 PM To: devel@edk2.groups.io Cc: Wang, BruceX <brucex.w...@intel.com>; Dong, Guo <guo.d...@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james...@intel.com>; Guo, Gua <gua....@intel.com> Subject: [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorList()
From: Bruce Wang <brucex.w...@intel.com> ProcessLibraryConstructorList() no needs to be called manually after INF version greater or equal to 1.30. Cc: Guo Dong <guo.d...@intel.com> Cc: Sean Rhodes <sean@starlabs.systems> Cc: James Lu <james...@intel.com> Cc: Gua Guo <gua....@intel.com> Signed-off-by: BruceX Wang <brucex.w...@intel.com> --- UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c index eb0b325369..58a7e8190f 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c @@ -616,8 +616,6 @@ _ModuleEntryPoint ( mHobList = (VOID *)BootloaderParameter; DxeFv = NULL;- // Call constructor for all libraries- ProcessLibraryConstructorList (); DEBUG ((DEBUG_INFO, "Entering Universal Payload...\n")); DEBUG ((DEBUG_INFO, "sizeof(UINTN) = 0x%x\n", sizeof (UINTN)));diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c index 030a5baed9..7c65869563 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c @@ -434,8 +434,6 @@ _ModuleEntryPoint ( UniversalSerialPort->RegisterStride = (UINT8)SerialPortInfo.RegWidth; } - // The library constructors might depend on serial port, so call it after serial port hob- ProcessLibraryConstructorList (); DEBUG ((DEBUG_INFO, "sizeof(UINTN) = 0x%x\n", sizeof (UINTN))); // Build HOB based on information from Bootloaderdiff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c index f37c00fad7..019b6b3d8b 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c @@ -462,8 +462,6 @@ _ModuleEntryPoint ( mHobList = (VOID *)BootloaderParameter; DxeFv = NULL;- // Call constructor for all libraries- ProcessLibraryConstructorList (); DEBUG ((DEBUG_INFO, "Entering Universal Payload...\n")); DEBUG ((DEBUG_INFO, "sizeof(UINTN) = 0x%x\n", sizeof (UINTN)));-- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116791): https://edk2.groups.io/g/devel/message/116791 Mute This Topic: https://groups.io/mt/104944095/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-