Reviewed-by: Eric Dong
-Original Message-
From: Xie, Yuanhao
Sent: Thursday, October 19, 2023 11:20 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Isaac Oram ; Gao,
Liming ; Dong, Eric ; Xie,
Yuanhao
Subject: [PATCH] Remove memory cache setting for memory
Reviewed-by: Eric Dong
-Original Message-
From: Xie, Yuanhao
Sent: Saturday, October 7, 2023 2:32 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Kumar, Rahul R ;
Tom Lendacky ; Xie, Yuanhao
Subject: [PATCH] UefiCpuPkg: Correct file description for MpHandOff header file
Cc: Eric Dong
Reviewed-by: Eric Dong
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, November 7, 2023 9:25 AM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
; Gerd Hoffmann ; Kumar, Rahul R
; Laszlo Ersek
Subject: [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET
Reviewed-by: Eric Dong
> -Original Message-
> From: Chiu, Chasel
> Sent: Thursday, September 5, 2019 12:27 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek
> Subject: [PATCH v2] UefiCpuPkg: support single
> EFI_PEI_CORE_FV_LOCATION_PPI in
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, September 5, 2019 12:54 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid
>
> gEfiFormBrowserExPro
Hi John,
I'm not sure whether I understand the code correctly. If not, please correct me.
1. You change to the code to only exchange 32 bits(eax) instead of 64
bits(rax). After your change, how to handle the above 32 bits value (from bit
32 to bit 63)?
2. In this file, also have another two xch
Hi John,
Thanks for your explanation. I agree with your analysis. I think you can
submit your next version patch.
Thanks,
Eric
> -Original Message-
> From: Lofgren, John E
> Sent: Saturday, September 7, 2019 3:01 AM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray
Reviewed-by: Eric Dong
> -Original Message-
> From: Zhang, Shenglei
> Sent: Saturday, September 7, 2019 1:16 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [PATCH v2] DebugFeaturePkg: Remove white space and update the
> ending format
>
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Saturday, September 7, 2019 1:16 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-devel] [PAT
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Friday, September 6, 2019 6:19 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Dong, Eric ;
> Laszlo Ersek
> Subject: [PATCH] UefiCpuPkg/PiSmmCpu: Enable 5L paging only when phy addr
> line &g
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1039
Current implementation not checks system mode before using
PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.X64 or
PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.Ia32. This patch check
the mode before using the correct one.
Cc: Ray Ni
Cc: Laszlo Ersek
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 11, 2019 11:25 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [Patch] UefiCpuPkg/CpuDxe: clean up
> PAGE_TABLE_LIB_PAGING_CONTEXT us
V2 changes:
Avoid use type case, use different file implementation.
V1 changes:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1039
Current implementation not checks system mode before using
PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.X64 or
PAGE_TABLE_LIB_PAGING_CONTEXT.ContextData.Ia32. This
Cc other reviewers.
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of John E
> Lofgren
> Sent: Tuesday, September 10, 2019 2:41 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Fix
> #AC
Reviewed-by: Eric Dong
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Dong, Eric ; Wu, Hao A ;
> Wang, Jian J ; Ni, Ray
> Subject: [PATCH 15/35] MdeModulePkg
Reviewed-by: Eric Dong
And pushed:
SHA-1: f4c898f2b2db2819c519cdce05403d4ba0234979
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of John
> E Lofgren
> Sent: Wednesday, September 18, 2019 11:43 PM
> To: devel@edk2.groups.io
> Sub
szlo Ersek
> ; Ard Biesheuvel ; Kinney,
> Michael D ; Gao, Liming
> ; Dong, Eric ; Ni, Ray
> ; Singh, Brijesh ; You, Benjamin
> ; Bi, Dandan ; Dong, Guo
> ; Wu, Hao A ; Wang, Jian J
> ; Ma, Maurice
> Subject: Re: [edk2-devel] [RFC PATCH v2 00/44] SEV-ES guest support
>
> On 9
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu,
> Chasel
> Sent: Friday, September 27, 2019 3:51 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ;
> Desimone, Nathaniel L ; Gao, Li
Reviewed-by: Eric Dong
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 1, 2019 9:16 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-platforms][PATCH V1 2/3]
> BoardModulePkg/FirmwareBootMediaInfoLib: Add l
Reviewed-by: Eric Dong
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, October 5, 2019 1:29 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-platforms][PATCH V2 2/3]
> BoardModulePkg/FirmwareBootMediaInfoLib: Add l
Reviewed-by: Eric Dong
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, October 5, 2019 1:29 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-platforms][PATCH V2 3/3]
> BoardModulePkg/FirmwareBootMediaInfoPei: Add
Hi Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, October 8, 2019 7:27 PM
> To: edk2-devel-groups-io
> Cc: Dong, Eric ; Igor Mammedov
> ; Ni, Ray
> Subject: [edk2-devel
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, January 14, 2020 4:57 PM
> To: devel@edk2.groups.io
> Cc: Haug, Brian R ; Gao, Liming
> ; Dong, Eric
> Subject: [patch] MdeModulePkg/Setup: Update opcode number variable
> type to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2392
Current code implementation assumes BSP index is 0 at the begin.
This code change removes this assumption. It get BSP index from
the saved data structure if it existed.
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
UefiCpuPkg
Ray,
I applied this change to an internal desktop machine and did below tests:
1. boot it to shell
2. reboot the system to shell.
Thanks,
Eric
From: Ni, Ray
Sent: Wednesday, January 15, 2020 3:43 PM
To: devel@edk2.groups.io; Dong, Eric
Cc: Laszlo Ersek
Subject: RE: [edk2-devel
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, January 15, 2020 6:05 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [PATCH] UefiCpuPkg/Library/MpInitLib: Remove BSP index == 0
> Assumption
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io On Behalf Of Wu, Hao A
Sent: Monday, February 3, 2020 8:35 AM
To: devel@edk2.groups.io
Cc: Wu, Hao A ; Dong, Eric ; Ni, Ray
; Laszlo Ersek ; Fu, Siyuan
; Kinney, Michael D
Subject: [edk2-devel] [PATCH v1] UefiCpuPkg
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zeng, Star
Sent: Tuesday, February 4, 2020 3:02 PM
To: devel@edk2.groups.io
Cc: Zeng, Star ; Dong, Eric ; Ni, Ray
; Laszlo Ersek
Subject: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io On Behalf Of Wu, Hao A
Sent: Thursday, February 6, 2020 1:24 PM
To: devel@edk2.groups.io
Cc: Wu, Hao A ; Kubacki, Michael A
; Kinney, Michael D ;
Dong, Eric ; Ni, Ray ; Laszlo Ersek
Subject: [edk2-devel] [PATCH v1
Reviewed-by: Eric Dong
-Original Message-
From: Wu, Hao A
Sent: Thursday, February 6, 2020 1:24 PM
To: devel@edk2.groups.io
Cc: Wu, Hao A ; Kubacki, Michael A
; Kinney, Michael D ;
Dong, Eric ; Ni, Ray ; Laszlo Ersek
Subject: [PATCH v1 1/2] Revert UefiCpuPkg/MpInitLib: Relocate
Reviewed-by: Eric Dong
-Original Message-
From: Wu, Hao A
Sent: Thursday, February 6, 2020 9:44 AM
To: devel@edk2.groups.io
Cc: Wu, Hao A ; Dong, Eric ; Wang,
Jian J
Subject: [PATCH v1] MdeModulePkg/PiDxeS3BootScriptLib: Fix potential numeric
truncation (CVE-2019-14563)
REF:https
Reviewed-by: Eric Dong
-Original Message-
From: Ray Ni
Sent: Tuesday, November 26, 2019 2:16 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Dong, Eric ; Zeng, Star
; Kinney, Michael D
Subject: [PATCH v2 3/3] UefiCpuPkg/CpuFeature: Introduce First to indicate 1st
unit.
From: Ray Ni
REF
For the serial: Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ray Ni
Sent: Tuesday, November 26, 2019 2:16 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v2 0/3] UefiCpuPkg/CpuFeature: Introduce First to
indicate 1st unit.
Ray Ni (3):
Uef
7:01 AM
To: devel@edk2.groups.io
Cc: Justen, Jordan L ; Laszlo Ersek
; Ard Biesheuvel ; Kinney,
Michael D ; Gao, Liming ;
Dong, Eric ; Ni, Ray ; Brijesh Singh
Subject: [edk2-devel] [PATCH v4 07/40] UefiCpuPkg: Implement library support
for VMGEXIT
BZ: https://bugzilla.tianocore.org
Reviewed-by: Eric Dong
-Original Message-
From: Bi, Dandan
Sent: Thursday, February 13, 2020 12:03 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Dong, Eric ; Wang,
Jian J
Subject: [patch 1/2] MdeModulePkg/String.c: Zero memory before free
(CVE-2019-14558)
REF: https
Reviewed-by: Eric Dong
-Original Message-
From: Bi, Dandan
Sent: Thursday, February 13, 2020 12:03 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Dong, Eric ; Wang,
Jian J
Subject: [patch 2/2] MdeModulePkg/DisplayEngine: Zero memory before free
(CVE-2019-14558)
REF: https
oups.io
Cc: Leo Duran ; Dong, Eric ; Ni, Ray
; Laszlo Ersek
Subject: [PATCH 1/2] UefiCpuPkg: LocalApicLib: Export
StandardSignatureIsAuthenticAMD function
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556
The StandardSignatureIsAuthenticAMD function was introduced locally to help
divert
: Dong, Eric ; devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek
Subject: RE: [PATCH 1/2] UefiCpuPkg: LocalApicLib: Export
StandardSignatureIsAuthenticAMD function
Hi Eric,
I added EFIAPI as the function is now intended to be called externally, as a
member of "LocalApicLib".
And to that e
,
Eric
-Original Message-
From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
Sent: Thursday, February 27, 2020 6:12 AM
To: edk2-devel-groups-io
Cc: Ard Biesheuvel ; Dong, Eric
; Igor Mammedov ; Yao, Jiewen
; Justen, Jordan L ; Kinney,
Michael D ; Philippe Mathieu-Daudé
; Ni, Ray
Hi Laszlo,
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, February 27, 2020 6:12 AM
> To: edk2-devel-groups-io
> Cc: Ard Biesheuvel ; Dong, Eric
> ; Wu, Hao A ; Igor Mammedov
> ; Wang, J
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io On Behalf Of GuoMinJ
Sent: Wednesday, March 4, 2020 7:39 PM
To: devel@edk2.groups.io
Cc: GuoMinJ ; Dong, Eric ; Ni, Ray
; Laszlo Ersek
Subject: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue.
REF: https
Hi Laszlo,
Got it. Go ahead.
Thanks,
Eric
-Original Message-
From: Laszlo Ersek
Sent: Wednesday, March 4, 2020 8:23 PM
To: devel@edk2.groups.io; Dong, Eric
Cc: Ard Biesheuvel ; Igor Mammedov
; Yao, Jiewen ; Justen, Jordan L
; Kinney, Michael D ;
Philippe Mathieu-Daudé ; Ni, Ray
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Current logic allocate Token every time when need to use it. The logic
caused SMI latency raised to very high. Update logic to allocate Token
buffer at driver's entry point. Later use the token from the allocated
token buffer. Only when all
v2 changes:
Minor update based on comments.
v1 changes:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Current logic allocate Token every time when need to use it. The logic
caused SMI latency raised to very high. Update logic to allocate Token
buffer at driver's entry point. Later us
Hi Laszlo,
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
Ersek
Sent: Thursday, November 28, 2019 9:57 PM
To: Dong, Eric ; devel@edk2.groups.io
Cc: Ni, Ray ; Gao, Liming
Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate
Token every
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, November 29, 2019 3:39 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Liming
> Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid
>
Hi Philippe,
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Thursday, November 28, 2019 9:16 PM
> To: devel@edk2.groups.io; Dong, Eric
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token from
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token from
Hi all,
Please ignore this version change which based on old codebase. Will send new
change soon.
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dong, Eric
> Sent: Wednesday, December 4, 2019 4:05 PM
>
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, December 4, 2019 5:20 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token
> every time
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token from
Hi Ray,
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, December 5, 2019 1:25 PM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Laszlo Ersek
> Subject: RE: [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate
> Token every time
>
> Some comments.
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token from
Reviewed-by: Eric Dong
> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Philippe
> Mathieu-Daude
&g
Reviewed-by: Eric Dong
> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Philippe
> Mathieu-Daude
&g
Reviewed-by: Eric Dong
> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Wednesday, December 4, 2019 12:16 AM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Philippe
> Mathieu-Daude
&g
Thanks Philippe.
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: Philippe Mathieu-Daude
> Sent: Friday, December 6, 2019 7:25 PM
> To: devel@edk2.groups.io
> Cc: Philippe Mathieu-Daude ; Dong, Eric
>
> Subject: [PATCH v2 023/105] .mailmap: Add a
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2268
In current implementation, when check whether APs called by StartUpAllAPs
or StartUpThisAp, it checks the Tokens value used by other APs. Also the AP
will update the Token value for itself if its task finished. In this
case, the potential ra
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2268
In current implementation, when check whether APs called by StartUpAllAPs
or StartUpThisAp, it checks the Tokens value used by other APs. Also the AP
will update the Token value for itself if its task finished. In this
case, the potential ra
This patch serial
1. patch 1 fixed potential race condition issue for PiSmmCpuDxeSmm.
2. Patch 2 fixed a potential buffer overflow issue.
Cc: Ray Ni
Cc: Laszlo Ersek
Eric Dong (2):
UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs
UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow issue.
The size for the array of mSmmMpSyncData->CpuData[] is 0 ~
mMaxNumberOfCpus -1. But current code may use
mSmmMpSyncData->CpuData[mMaxNumberOfCpus].
This patch fixed this issue.
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 16
Hi Ray,
> -Original Message-
> From: Ni, Ray
> Sent: Friday, December 20, 2019 2:15 PM
> To: Dong, Eric mailto:eric.d...@intel.com>>;
> devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Laszlo Ersek mailto:ler...@redhat.com>>
> Subject: RE: [P
Hi Ray,
> -Original Message-
> From: Ni, Ray
> Sent: Monday, December 23, 2019 3:38 PM
> To: devel@edk2.groups.io; Dong, Eric
> Cc: Laszlo Ersek
> Subject: RE: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm:
> Remove dependence between APs
>
> >
&
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2268
In current implementation, when check whether APs called by StartUpAllAPs
or StartUpThisAp, it checks the Tokens value used by other APs. Also the AP
will update the Token value for itself if its task finished. In this
case, the potential ra
This patch serial
1. patch 1 fixed potential race condition issue for PiSmmCpuDxeSmm.
2. Patch 2 fixed a potential buffer overflow issue.
V3 change:
Minor changes based on comments.
Cc: Ray Ni
Cc: Laszlo Ersek
Eric Dong (2):
UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs
Ue
The size for the array of mSmmMpSyncData->CpuData[] is 0 ~
mMaxNumberOfCpus -1. But current code may use
mSmmMpSyncData->CpuData[mMaxNumberOfCpus].
This patch fixed this issue.
Reviewed-by: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 16 +++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token from
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token from
Reviewed-by: Eric Dong
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v
Hao,
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v4 2/6] UefiCpuPkg/MpIn
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v4 4/6] UefiCpuPkg/MpInitL
Reviewed-by: Eric Dong
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v
Reviewed-by: Eric Dong
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 27, 2019 3:32 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Tuesday, December 31, 2019 8:49 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng
Reviewed-by: Eric Dong
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, December 31, 2019 8:49 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v
Hi Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Saturday, January 4, 2020 2:11 AM
> To: devel@edk2.groups.io; Ni, Ray ; Dong, Eric
>
> Subject: Re: [edk2-devel] [PATCH v3 2/2] UefiCpuPkg/
This patch serial used to update the commit message.
Rollback the old change and resend it with new commit message.
Cc: Ray Ni
Cc: Laszlo Ersek
Eric Dong (2):
Revert "UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow issue."
UefiCpuPkg/PiSmmCpuDxeSmm: improve the coding style
UefiCpuPkg/PiSm
This reverts commit 123b720eeb371e0a31eb727bcf59255b584e355f.
The commit message for commit 123b720eeb37 is not correct.
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2434
Current code use below loops to enumerate the CPUs:
for (Index = mMaxNumberOfCpus; Index-- > 0;) {
it has no issue but not easy for the developers to read the code.
Update above code to below style,
for (Index = 0; Index < mMaxNumberOfC
Reviewed-by: Eric Dong
> -Original Message-
> From: Fu, Siyuan
> Sent: Friday, January 3, 2020 3:14 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Wu, Hao A
>
> Subject: [Patch 1/1] UefiCpuPkg: Remove redundant alignment check when
> calculate microco
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, January 6, 2020 6:48 PM
> To: Dong, Eric ; devel@edk2.groups.io; Ni, Ray
>
> Subject: Re: [edk2-devel] [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm:
> Fix buffer overflow is
Hi Siyuan,
Thanks for your patch.
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Siyuan, Fu
> Sent: Friday, January 3, 2020 2:59 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ;
Reviewed-by: Eric Dong
> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Philippe
> Mathieu-Daude
>
Mathieu-Daudé
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Philippe
> Mathieu-Daude
> Subject: [edk2-devel] [PATCH v2 77/78] UefiCpuPkg/PiSmm: Fix various
> typos
>
> From: Antoine Coeu
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Philippe Mathieu-Daudé
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek
This issue caused by below change:
SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6
* UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Siyuan, Fu
> Sent: Thursday, January 9, 2020 10:14 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Dong, Eric ; Ni, Ray
Hi Mike and Laszlo,
I agree with Mike's proposal. We can submit new bugz to remove the binary.
Thanks,
Eric
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, October 23, 2019 7:39 AM
To: Laszlo Ersek ; devel@edk2.groups.io; Kinney, Michael D
Cc: Sean Brogan ; Dong,
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, Ray
Sent: Wednesday, October 30, 2019 5:53 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek
Subject: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Set
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, Ray
Sent: Wednesday, October 30, 2019 5:53 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek
Subject: [edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Remove global
Reviewed-by: Eric Dong
-Original Message-
From: Chu, Maggie
Sent: Monday, November 4, 2019 12:04 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Zhang, Chao B ;
Yao, Jiewen
Subject: [PATCH] SecurityPkg/OpalPassword: Remove dependency on
EFI_BLOCK_IO_PROTOCOL
https
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, November 11, 2019 11:05 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek
> Subject: [PATCH 1/2] UefiCpuPkg/CpuCommonFeaturesLib: Remove XD
> enable/disable
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, November 11, 2019 11:05 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek
> Subject: [PATCH 2/2] UefiCpuPkg/RegisterCpuFeature: Remove
> CPU_FEATURE_XD macro
>
> REF: htt
Reviewed-by: Eric Dong
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, November 14, 2019 5:17 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei ; Dong, Eric
> ; Ni, Ray ; Laszlo Ersek
>
> Subject: [PATCH] UefiCpuPkg: Update the coding styles
&
Reviewed-by: Eric Dong
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, November 14, 2019 5:17 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei ; Dong, Eric
> ; Ni, Ray ; Laszlo Ersek
>
> Subject: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add m
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Friday, March 6, 2020 1:36 PM
> To: devel@edk2.groups.io
> Cc: abner.ch...@hpe.com; Leif Lindholm ; Gilbert Chen
> ; Bi, Dandan ; Gao, Liming
> ; Wang,
Thanks Liming.
Code pushed: SHA-1: 28d572fb96cd2697d903f6a3af94f6cb76948869
Thanks,
Eric
> -Original Message-
> From: Gao, Liming
> Sent: Friday, March 27, 2020 9:56 AM
> To: Luo, Heng ; devel@edk2.groups.io
> Cc: Bi, Dandan ; Dong, Eric ; Ni,
> Ray
> Subject: RE
.groups.io
Cc: Justen, Jordan L ; Laszlo Ersek
; Ard Biesheuvel ; Kinney,
Michael D ; Gao, Liming ;
Dong, Eric ; Ni, Ray ; Brijesh Singh
; You, Benjamin ; Bi, Dandan
; Dong, Guo ; Wu, Hao A
; Wang, Jian J ; Ma, Maurice
Subject: Re: [edk2-devel] [PATCH v6 00/42] SEV-ES guest support
I've gotten
1 - 100 of 488 matches
Mail list logo
