Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-08-04 Thread Dandan Bi
Hi Ray, For varstore of EFI_HII_VARSTORE_EFI_VARIABLE_BUFFER, when SetupBrowser load the value from variable, it will not call into HiiConfigAccess protocol. Before this change, it will call HiiConfigRouting protocol in HiiDatabase, and HiiDatabase will also call GetVariable directly, does not r

回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-04 Thread gaoliming via groups.io
Hi, all We are near to the soft feature freeze for the stable tag 202308. Please give your opinion for this patch set to catch 202308 release. Now, Ard, Jiewen (Crypto Package Maintainer), Yi (Patch Contributor) opinion is to merge this patch set if no other comments in one week. Leif opi

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-08-04 Thread PierreGondois
Hello Rohit, On 7/31/23 22:14, Rohit Mathew wrote: Hi Pierre, Apologies for the delay in response. ~~ + +/** + This function parses the locator field within the resource node for ACPI MPAM + table. The parsing is based on the locator type field. + + This function also performs validati

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-04 Thread Ard Biesheuvel
On Thu, 3 Aug 2023 at 23:25, Ard Biesheuvel wrote: > > On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D > wrote: > > > > Hi Ard, > > > > This is the email with the analysis and the flag > > setting required for SMP to work with SMM enabled for > > IA32/X64 QEMU. > > > > https://edk2.groups.io/g/dev

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-04 Thread Oliver Steffen
On Fri, Aug 4, 2023 at 3:17 PM Ard Biesheuvel wrote: > > On Thu, 3 Aug 2023 at 23:25, Ard Biesheuvel wrote: > > > > On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D > > wrote: > > > > > > Hi Ard, > > > > > > This is the email with the analysis and the flag > > > setting required for SMP to work wi

[edk2-devel] [PATCH v2 1/7] AlderlakeSiliconPkg: Add package and library instances

2023-08-04 Thread Saloni Kasbekar
Create the AlderlakeSiliconPkg to provide an initial package for silicon initialization code for Alder Lake (ADL) products. Add the following libraries - - BasePciSegmentMultiSegLibPci - BaseSiConfigBlockLib - PeiPostMemSiliconPolicyInitLib - PeiPreMemSiliconPolicyInitLib Cc: Sai Chaganty Cc: Nat

[edk2-devel] [PATCH v2 3/7] AlderlakeSiliconPkg/Pch: Add include headers

2023-08-04 Thread Saloni Kasbekar
Adds the following header files: * Pch/Include Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Include/ConfigBlock/PchGeneralConfig.h| 86 .../Pch/Include/Library/PchCycleDecodingLib.h | 59 ++ .../Pch/Include/Libra

[edk2-devel] [PATCH v2 4/7] AlderlakeSiliconPkg/Pch: Add libraries

2023-08-04 Thread Saloni Kasbekar
Adds the following libraries: - BasePchPciBdfLib - BaseResetSystemLib - PeiDxeSmmPchCycleDecodingLib Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../BasePchPciBdfLib/BasePchPciBdfLib.inf | 32 ++ .../Library/BasePchPciBdfLib/PchP

[edk2-devel] [PATCH v2 7/7] AlderlakeSiliconPkg/SystemAgent: Add library and driver modules

2023-08-04 Thread Saloni Kasbekar
Adds the following modules: - Library/DxeSaPolicyLib - SaInit Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Library/DxeSaPolicyLib/DxeSaPolicyLib.c | 225 ++ .../Library/DxeSaPolicyLib/DxeSaPolicyLib.inf | 46

[edk2-devel] [PATCH v2 6/7] AlderlakeSiliconPkg/SystemAgent: Add include headers

2023-08-04 Thread Saloni Kasbekar
Adds the following header files: * SystemAgent/Include Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Include/ConfigBlock/MemoryDxeConfig.h | 126 ++ .../ConfigBlock/SaMiscPeiPreMemConfig.h | 112 + .../Incl

[edk2-devel] [PATCH v2 2/7] AlderlakeSiliconPkg: Add Cpu modules

2023-08-04 Thread Saloni Kasbekar
Add Cpu/Include, Cpu/IncludePrivate and Cpu/Library Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Cpu/Include/ConfigBlock/CpuConfig.h | 86 .../ConfigBlock/CpuConfigLibPreMemConfig.h| 195 ++ .../

[edk2-devel] [PATCH v3] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

2023-08-04 Thread chitralekha ck
https://bugzilla.tianocore.org/show_bug.cgi?id=4507 AllocatePool limits to allocate memory of 64 KB at most in PEI Phase. AllocatePool() is being avoided due to its 64k allocation size limit when the library is incorporated into a PEI component. Cc: Ray Ni Cc: Zhichao Gao Cc: Ashraf Ali S Cc: C

[edk2-devel] [edk2-libc Patch 0/1] Fix documentation issue with edk2module.c

2023-08-04 Thread Vishal R
This patch contains fix for edk2 module documentation issue Vishal R (1): edk2-libc/AppPkg: Fix documentation issue with edk2module.c .../PyMod-3.6.8/Modules/edk2module.c | 28 +++ 1 file changed, 23 insertions(+), 5 deletions(-) -- 2.39.1.windows.1 -=-=-=-=-=-=-=

[edk2-devel] [PATCH v2] MedPkg/Include: Add PCI_EXPRESS_EXTENDED_CAPABILITY_DVSEC_ID

2023-08-04 Thread Foster Nong
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4515 Add PCI_EXPRESS_EXTENDED_CAPABILITY_DESIGNATED_VENDOR_SPECIFIC_ID 0x0023 in PciExpress40.h Signed-off-by: Foster Nong Cc: Michael D Kinney Cc: Liming Gao Cc: Ray Ni --- MdePkg/Include/IndustryStandard/PciExpress40.h | 2 ++ 1 file chang

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc/AppPkg: Fix documentation issue with edk2module.c

2023-08-04 Thread Vishal R
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4517 This commit fixes the API documentation issue reported via the BZ4517 Updated documentation strings for rdmsr() and wrmsr() Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Vishal R --- .../PyMod-3.6.8/Modules/edk

Re: [edk2-devel] [PATCH v2 3/6] AlderlakeOpenBoardPkg/AlderlakePRvp: Add libraries

2023-08-04 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> -Original Message- From: Kasbekar, Saloni Sent: Wednesday, August 2, 2023 6:18 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 3/6]

Re: [edk2-devel] [PATCH v2 1/6] AlderlakeOpenBoardPkg: Add package and headers

2023-08-04 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> -Original Message- From: Kasbekar, Saloni Sent: Wednesday, August 2, 2023 6:18 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 1/6] A

Re: [edk2-devel] [PATCH v2 2/6] AlderlakeOpenBoardPkg: Add modules

2023-08-04 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> -Original Message- From: Kasbekar, Saloni Sent: Wednesday, August 2, 2023 6:18 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 2/6]

Re: [edk2-devel] [PATCH v2 5/6] AlderlakeOpenBoardPkg: Adds the Policy Module

2023-08-04 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> -Original Message- From: Kasbekar, Saloni Sent: Wednesday, August 2, 2023 6:18 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 5/6]

Re: [edk2-devel] [PATCH v2 4/6] AlderlakeOpenBoardPkg: Add ACPI module

2023-08-04 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> -Original Message- From: Kasbekar, Saloni Sent: Wednesday, August 2, 2023 6:18 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 4/6]

Re: [edk2-devel] [PATCH v2 6/6] AlderlakeOpenBoardPkg: Add Library Instances

2023-08-04 Thread Chuang, Rosen
Reviewed-by: Rosen Chuang < rosen.chu...@intel.com> -Original Message- From: Kasbekar, Saloni Sent: Wednesday, August 2, 2023 6:18 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 6/6]

Re: [edk2-devel] [PATCH v3] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

2023-08-04 Thread Mike Maslenkin
Very nice, that functional changes were separated. But, as far as I remember, Pedro noticed that AllocatePages() takes number of pages, not a bytes. So, the change could be as: *GopBlt = AllocatePages (EFI_SIZE_TO_PAGES(*GopBltSize)); But I I would like you to pay special attention that this

[edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe v4: - Expose additional functions in the Library API - Add NULL checks to library functions and return a status where applicable. v3: - Refactor patch series so the transition of logic from the DXE MAT logic to the new library is more clear. - Update function headers to im

[edk2-devel] [PATCH v4 01/14] MdeModulePkg: Add ImagePropertiesRecordLib

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Create a library for manipulating image properties records. The library is currently blank and will be filled in a future patch to help with reviewer readability. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Library/ImageProper

[edk2-devel] [PATCH v4 02/14] ArmVirtPkg: Add ImagePropertiesRecordLib Instance

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann --- ArmVirtPkg/ArmVirt.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtP

[edk2-devel] [PATCH v4 04/14] OvmfPkg: Add ImagePropertiesRecordLib Instance

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.dsc| 1 + OvmfPkg/Bhyve/BhyveX64.dsc | 1 + Ovm

[edk2-devel] [PATCH v4 03/14] EmulatorPkg: Add ImagePropertiesRecordLib Instance

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Signed-off-by: Taylor Beebe Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/EmulatorPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.

[edk2-devel] [PATCH v4 05/14] UefiPayloadPkg: Add ImagePropertiesRecordLib Instance

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Signed-off-by: Taylor Beebe Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo --- UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiPayloadPkg/Uefi

[edk2-devel] [PATCH v4 06/14] MdeModulePkg: Update MemoryAttributesTable.c to Reduce Global Variable Use

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe This patch updates MemoryAttributesTable.c to reduce reliance on global variables and allow some logic to move to a library. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 102 +++--

[edk2-devel] [PATCH v4 07/14] MdeModulePkg: Move Some DXE MAT Logic to ImagePropertiesRecordLib

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Move some DXE MAT logic to ImagePropertiesRecordLib to consolidate code and enable unit testability. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 774 +---

[edk2-devel] [PATCH v4 08/14] MdeModulePkg: Add ImagePropertiesRecordLib Host-Based Unit Test

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Create a host-based unit test for the ImagePropertiesRecordLib SplitTable() logic. This test has 4 cases which tests different potential image and memory map layouts. 3/4 of these tests fail with the logic in its current state to provide proof of the bugs in the current MAT log

[edk2-devel] [PATCH v4 09/14] MdeModulePkg: Fix Bugs in MAT Logic

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Fix the bugs in the MAT logic before switching the UEFI and SMM MAT logic to use the new library. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 2 +- MdeModulePkg/L

[edk2-devel] [PATCH v4 11/14] UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if Nonzero

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe The function EnforceMemoryMapAttribute() in the SMM MAT logic will ensure that the CODE and DATA memory types have the desired attributes. The consumer of the SMM MAT should only override the Attributes field in the MAT if it is nonzero. This also allows the UEFI and SMM MAT lo

[edk2-devel] [PATCH v4 10/14] MdeModulePkg: Add NULL checks and Return Status to ImagePropertiesRecordLib

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Update function headers to clarify the contract of each function and improve readability. Add NULL checks to all functions that take a pointer as an argument. Add return status to functions that may need to return early due to invalid input. Cc: Jian J Wang Cc: Liming Gao Cc

[edk2-devel] [PATCH v4 12/14] MdeModulePkg: Transition SMM MAT Logic to Use ImagePropertiesRecordLib

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Now that the bugs are fixed in the MAT logic, we can remove the duplicate logic from PiSmmCore/MemoryAttributesTable.c and use ImagePropertiesRecordLib instead. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Jiaxin Wu Cc: Ray Ni --- MdeModu

[edk2-devel] [PATCH v4 13/14] MdeModulePkg: Add Logic to Create/Delete Image Properties Records

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Add logic to create and delete image properties records. Where applicable, redirect existing code to use the new library. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Jiaxin Wu Cc: Ray Ni --- MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c

[edk2-devel] [PATCH v4 14/14] MdeModulePkg: Update DumpImageRecord() in ImagePropertiesRecordLib

2023-08-04 Thread Taylor Beebe
From: Taylor Beebe Update DumpImageRecord() to be DumpImageRecords(), and improve the debug output. The function will output at DEBUG_INFO instead, and the function will be run in DXE and SMM MAT logic when the MAT is installed at EndOfDxe on DEBUG builds. Cc: Jian J Wang Cc: Liming Gao Cc: Da

Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-04 Thread Brian J. Johnson
Liming and Jiewen, I asked Terry Lee to give this patchset a spin, and it seemed to work well for our h/w use case. The size increase vs. OpenSSL 1.1.1n was noticeable, but workable. We're good with merging it. Brian J. Johnson HP Enterprise Misison-Critical Systems Original Messa

Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-04 Thread Michael Kubacki
Ken Lautner is helping test on some platforms. The size increase is presenting a bit of a challenge at the moment, but he should be able to share more feedback early next week. Regards, Michael On 8/4/2023 4:54 PM, Brian J. Johnson wrote: Liming and Jiewen, I asked Terry Lee to give this pat