[edk2-devel] [Patch V3 0/4] Wake up APs after power-up or RESET through SIPI.

2023-07-20 Thread Yuanhao Xie
The implementation of this new behavior aligns with the guidelines outlined in the Intel SDM. Following a power-up or RESET of an MP system, system hardware dynamically selects one of the processors on the system bus as the BSP. The remaining processors are designated as APs. The APs complete a mi

[edk2-devel] [Patch V3 1/4] UefiCpuPkg: Add SendStartupIpiAllExcludingSelf

2023-07-20 Thread Yuanhao Xie
From: Yuanhao Xie Add new API SendStartupIpiAllExcludingSelf(), and modify SendInitSipiSipiAllExcludingSelf() by let it call the new API. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Yuanhao Xie --- UefiCpuPkg/Include/Library/LocalApicLib.h

[edk2-devel] [Patch V3 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi

2023-07-20 Thread Yuanhao Xie
Add PcdFirstTimeWakeUpAPsBySipi to check if it is in the OVMF environment and necessary to wake up APs by INIT-SIPI-SIPI. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Yuanhao Xie --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + UefiCpuPkg/Library

[edk2-devel] [Patch V3 3/4] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-07-20 Thread Yuanhao Xie
Disable PcdFirstTimeWakeUpAPsBySipi for OVMF to let BSP wake up APs by INIT-SIPI-SIPI. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Yuanhao Xie --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++- OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ OvmfPkg/OvmfPkgX64.dsc | 2 ++ 3

[edk2-devel] [Patch V3 4/4] UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.

2023-07-20 Thread Yuanhao Xie
The implementation of this new behavior aligns with the guidelines outlined in the Intel SDM. Following a power-up or RESET of an MP system, system hardware dynamically selects one of the processors on the system bus as the BSP. The remaining processors are designated as APs. The APs complete a mi

Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1u

2023-07-20 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Sheng, W > Sent: Tuesday, July 18, 2023 2:20 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Lu, Xiaoyu1 ; Jiang, Guomin > Subject: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1u > > Cc: Jian J Wang > Cc:

[edk2-devel] [PATCH 1/1] OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateCommonBuffer

2023-07-20 Thread Gerd Hoffmann
IoMmuAllocateCommonBuffer has the very same allocation pattern IoMmuAllocateBounceBuffer uses, so the fix added by commit a52044a9e602 ("OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer") is needed here too. Reported-by: Michael Brown Signed-off-by: Gerd Hoffmann --- OvmfPkg/IoMmuDxe/

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer

2023-07-20 Thread Gerd Hoffmann
> > > mReservedMemBitmap &= (UINT32)(~MapInfo->ReservedMemBitmap); > > > > I'd expect modern compilers optimize that to a single instruction, > > You mean something along the lines of > > andl %reg, mReservedMemBitmap(%rip) > > right? Yes. > > but > > yes, it's not guaranteed to happen, th

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer

2023-07-20 Thread Gerd Hoffmann
Hi, > > On a quick review of the code, there appear to be other points that also > > modify mReservedMemBitmap (IoMmuAllocateCommonBuffer() and > > IoMmuFreeCommonBuffer()). I'd guess that these also need to raise to > > TPL_NOTIFY, but I'm not familiar with the code so I don't know if > > ther

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateCommonBuffer

2023-07-20 Thread Ard Biesheuvel
On Thu, 20 Jul 2023 at 10:24, Gerd Hoffmann wrote: > > IoMmuAllocateCommonBuffer has the very same allocation pattern > IoMmuAllocateBounceBuffer uses, so the fix added by commit a52044a9e602 > ("OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer") is needed > here too. > > Reported-by: Mi

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateCommonBuffer

2023-07-20 Thread Gerd Hoffmann
On Thu, Jul 20, 2023 at 10:34:31AM +0200, Ard Biesheuvel wrote: > On Thu, 20 Jul 2023 at 10:24, Gerd Hoffmann wrote: > > > > IoMmuAllocateCommonBuffer has the very same allocation pattern > > IoMmuAllocateBounceBuffer uses, so the fix added by commit a52044a9e602 > > ("OvmfPkg/IoMmuDxe: add lockin

[edk2-devel][PATCH v2] IntelFsp2Pkg: Support child FV in SplitFspBin.py

2023-07-20 Thread Kuo, Ted
https://bugzilla.tianocore.org/show_bug.cgi?id=4502 Update SplitFspBin.py to support child FV in FSP binary. Without the patch, the tool won't be able to rebase the images in child FV in FSP binary. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Cc: Chinni B Duggapu Cc: Ray

Re: [edk2-devel][PATCH v1] SplitFspBin.py cannot support FSP binary with child FV included

2023-07-20 Thread Kuo, Ted
Thanks Chasel for the feedback. I've sent patch v2 with changes according to your comment. Can you please review it again? Thanks, Ted -Original Message- From: Chiu, Chasel Sent: Thursday, July 20, 2023 2:14 AM To: Kuo, Ted ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateCommonBuffer

2023-07-20 Thread Gerd Hoffmann
Hi, > Not sure why InternalAllocateBuffer() doesn't update mReservedMemBitmap > itself. That would be needed to protect the allocation code paths with > InterlockedCompareExchange32() too. Not a straight forward conversion, current code copies around bitmap snippets, so this logic needs a rewr

[edk2-devel] Cannot list all harddisk in boot manager

2023-07-20 Thread Changqing Li
Hi, I found that ovmf build with edk2-stable202210 is not works well.  It cannot find all the harddisk, and list them in boot manager: But with edk2-stable2022008, it works well.  I think this is a bug, should I open an issue in bugzilla? *Here is my command:* qemu-system-x86_64 -net nic

[edk2-devel] Olympic Build failing at tip

2023-07-20 Thread Roshan Sivakumar
Hi, Could someone help with this error? build.py... | : error C0DE: Unknown fatal error when processing [/local/mnt/workspace/olympic_18_7/build-qti-distro-nogplv3-debug/tmp-glibc/work/sdxlemur-oe- linux-gnueabi/edk2/git-r0/edk2/QcomModulePkg/Application/LinuxLoader/LinuxLoader.inf] | | (Please

Re: [edk2-devel] Cannot list all harddisk in boot manager

2023-07-20 Thread Gerd Hoffmann
On Thu, Jul 20, 2023 at 02:06:34PM +0800, Changqing Li wrote: > Hi, > > I found that ovmf build with edk2-stable202210 is not works well.  It cannot > find all the harddisk, and list them in boot manager: > > But with edk2-stable2022008, it works well.  I think this is a bug, should I > open an i

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer

2023-07-20 Thread Ard Biesheuvel
On Thu, 20 Jul 2023 at 10:28, Gerd Hoffmann wrote: > > > > > mReservedMemBitmap &= (UINT32)(~MapInfo->ReservedMemBitmap); > > > > > > I'd expect modern compilers optimize that to a single instruction, > > > > You mean something along the lines of > > > > andl %reg, mReservedMemBitmap(%rip) > >

[edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

2023-07-20 Thread Ard Biesheuvel
Instead of relying on raising the TPL to protect the critical sections that manipulate the global bitmask that keeps track of bounce buffer allocations, use compare-and-exchange to manage the global variable, and tweak the logic to line up with that. Given that IoMmuDxe implements a singleton prot

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2023-07-20 Thread G Edhaya Chandran
The patch is upstreamed by:  https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107101): https://edk2.groups.io/g/devel/message/107101 Mute This Topic: htt

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-07-20 Thread PierreGondois
Hello Rohit, On 5/22/23 16:45, Rohit Mathew via groups.io wrote: Add a parser for the MPAM (Memory system resource partitioning and monitoring) ACPI table. This parser would parse all MPAM related structures embedded as part of the ACPI table. Necessary validations are also performed where and w

Re: [edk2-devel] [PATCH V3 2/3] ShellPkg: acpiview: Add routine to print 16 chars

2023-07-20 Thread PierreGondois
Reviewed-by: Pierre Gondois On 5/22/23 16:44, Rohit Mathew via groups.io wrote: Certain ACPI tables like MPAM has fields which are 16 bytes long. Routines similar to Dump12Chars but for 16 characters are required to print such fields. Add Dump16Chars routine to satisfy this requirement. Signed

Re: [edk2-devel] [PATCH V3 1/3] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

2023-07-20 Thread PierreGondois
Hello Rohit, On 5/22/23 16:44, Rohit Mathew via groups.io wrote: From: Rohit Mathew Add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew --- MdePkg/Include/IndustryStandard/Acpi65.h | 7 +- MdePkg/Include/IndustryStandar

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2023-07-20 Thread Ard Biesheuvel
On Thu, 20 Jul 2023 at 16:30, G Edhaya Chandran wrote: > > The patch is upstreamed by: > https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4 Checking the memory map for memory below 4G only makes sense if the system has no IOMMU and does not use translation for

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-20 Thread Ard Biesheuvel
On Thu, 20 Jul 2023 at 03:41, Michael D Kinney wrote: > > Merged: https://github.com/tianocore/edk2/pull/4666 > This commit is now merged as commit 6510dcf6f71adbe282bff0ba2b236f1d074f819f Author: devel@edk2.groups.io AuthorDate: Fri Feb 10 04:34:03 2023 -0800 Commit: mergify[bot] <379

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-20 Thread Michael D Kinney
Hi Ard, This is my mistake. I usually check the Author field when adding Rb/Ab tags because I have seen lots of cases where the Author field needs updating as well. I forgot to do this step in this one. I agree a CI check against the Author field being a valid email address and not one of the

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-07-20 Thread Ard Biesheuvel
On Thu, 20 Jul 2023 at 19:10, Michael D Kinney wrote: > > Hi Ard, > > This is my mistake. I usually check the Author field when > adding Rb/Ab tags because I have seen lots of cases where > the Author field needs updating as well. I forgot to do this > step in this one. > > I agree a CI check ag

Re: [edk2-devel] [PATCH v5 0/9] SecurityPkg/MdePkg: Update RngLib GUID identification

2023-07-20 Thread Kun Qin
Hi Pierre, Thanks for sending this update. I tested the v5 patch series and verified it booted to Windows. Tested-by: Kun Qin Regards, Kun On 7/18/2023 4:51 AM, pierre.gond...@arm.com wrote: From: Pierre Gondois v5: - Let an implementation of BaseRngLibTimer in MdePkg to give some tim

Re: [edk2-devel] [PATCH v2 0/9] Add ImagePropertiesRecordLib and Fix MAT Bugs

2023-07-20 Thread Taylor Beebe
On 7/19/23 10:19 PM, Ni, Ray wrote: Taylor, Thank you for your effort for removing the duplicated logic in Dxe/Smm Core and fixing the bugs. Two general comments: #1. Can you refactor your patch series in a way that the new lib code is like a "git move" instead of "git add"? For example, yo

[edk2-devel] [PATCH v1 0/4] Implement Delayed Dispatch per PI v1.8

2023-07-20 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4496 PI spec v1.8 has introduced some corrections and a new interface for delayed dispatch for the PPI. This patch series has ported the implementation from Project MU. Patch branch: https://github.com/kuqin12/edk2/tree/Delayed_Dispatch_V2 Cc:

[edk2-devel] [PATCH v1 1/4] MdePkg: DelayedDispatch: Correct PPI descriptions

2023-07-20 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4496 PI spec defined the `Register` function input argument `Delay` as output. However, this parameter should be used to define the minmal time delay the callback should fire. Thus it should be an input parameter. This change fixed the argument

[edk2-devel] [PATCH v1 2/4] MdePkg: DelayedDispatch: Added WaitOnEvent interface

2023-07-20 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4496 This change adds a new interface for the delayed dispatch PPI. This new addition allows functional components relying on delayed dispatch callbacks to be managed/dispatched with definitive order. The full defintion has been added into PI sp

[edk2-devel] [PATCH v1 4/4] MdeModulePkg: PeiMain: Updated dispatcher for delayed dispatch

2023-07-20 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4496 This change adds a check for PEI dispatcher to continue dispatching when there are still pending delayed dispatch requests, to be compatible with newly integrated Delayed Dispatcher PPI interface. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan

[edk2-devel] [PATCH v1 3/4] MdeModulePkg: PeiMain: Introduce implementation of delayed dispatch

2023-07-20 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4496 This change adds the implementation that fits the needs and description of PI spec defined Delayed Dispatch PPI in Pei Core. The PPI would allow minimal delay for registered callbacks. As well as allowing other functions to wait for GUIDed

Re: [edk2-devel] [PATCH v2 0/9] Add ImagePropertiesRecordLib and Fix MAT Bugs

2023-07-20 Thread Ni, Ray
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Taylor Beebe > Sent: Friday, July 21, 2023 2:40 AM > To: devel@edk2.groups.io; Ni, Ray > Cc: Andrew Fish ; Ard Biesheuvel > ; Bi, Dandan ; Dong, Eric > ; Gerd Hoffmann ; Dong, Guo > ; Guo, Gua ; Lu, James > ; Wang, Jian J ;

Re: [edk2-devel] [Patch V3 1/4] UefiCpuPkg: Add SendStartupIpiAllExcludingSelf

2023-07-20 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Xie, Yuanhao > Sent: Thursday, July 20, 2023 3:08 PM > To: devel@edk2.groups.io > Cc: Xie, Yuanhao ; Dong, Guo ; > Ni, Ray ; Rhodes, Sean ; Lu, James > ; Guo, Gua > Subject: [Patch V3 1/4] UefiCpuPkg: Add SendStartupIpiAllExcludingSelf >

Re: [edk2-devel] [Patch V3 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi

2023-07-20 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Xie, Yuanhao > Sent: Thursday, July 20, 2023 3:08 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Rhodes, Sean > ; Lu, James ; Guo, Gua > ; Xie, Yuanhao > Subject: [Patch V3 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi > >

Re: [edk2-devel] [Patch V3 4/4] UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.

2023-07-20 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Xie, Yuanhao > Sent: Thursday, July 20, 2023 3:08 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Rhodes, Sean > ; Lu, James ; Guo, Gua > ; Xie, Yuanhao > Subject: [Patch V3 4/4] UefiCpuPkg:Wake up APs after power-up or RESET >

Re: [edk2-devel] 回复: [PATCH v2 0/4] OvmfPkg/RiscVVirt: Add CLANGDWARF toolchain support

2023-07-20 Thread Sunil V L
On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote: > On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io > wrote: > > > > Sunil: > > Do you use which CLANG version is used to verify this change? > > > > For the series, > > Tested-by: Ard Biesheuvel # Debian clang version 14.0.6

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt: Check "no-map" and mark EfiReservedMemoryType

2023-07-20 Thread Sunil V L
On Tue, Jul 18, 2023 at 10:59:31PM -0700, Ranbir Singh wrote: > Better to keep the description wrt DT spec. > > otherwise, looks good to me. > > Reviewed-by: Ranbir Singh Thanks!, Ranbir. Sure, I will keep the comment about DT spec requirement. -Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

[edk2-devel] [PATCH] NetworkPkg: Increase HTTP buffer size and enable TCP window scaling

2023-07-20 Thread Li, Yi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4505 This gives something like ~3 fold throughput boost. Signed-off-by: Andrei Otcheretianski Cc: Saloni Kasbekar Cc: Zachary Clark-williams --- NetworkPkg/HttpBootDxe/HttpBootClient.h | 2 +- NetworkPkg/HttpDxe/HttpProto.c | 48 +++

Re: [edk2-devel] Cannot list all harddisk in boot manager

2023-07-20 Thread Changqing Li
Thanks. //Changqing On 7/20/23 19:06, Gerd Hoffmann wrote: CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. On Thu, Jul 20, 2023 at 02:06:34PM +0800, Changqing Li wrote: Hi, I