IoMmuAllocateCommonBuffer has the very same allocation pattern
IoMmuAllocateBounceBuffer uses, so the fix added by commit a52044a9e602
("OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer") is needed
here too.
Reported-by: Michael Brown <mc...@ipxe.org>
Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
---
OvmfPkg/IoMmuDxe/IoMmuBuffer.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
index 103003cae376..6fcf88b50ce1 100644
--- a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
+++ b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
@@ -442,7 +442,9 @@ IoMmuAllocateCommonBuffer (
)
{
EFI_STATUS Status;
+ EFI_TPL OldTpl;
+ OldTpl = gBS->RaiseTPL (TPL_NOTIFY);
Status = InternalAllocateBuffer (
AllocateMaxAddress,
MemoryType,
@@ -453,6 +455,7 @@ IoMmuAllocateCommonBuffer (
ASSERT (Status == EFI_SUCCESS);
mReservedMemBitmap |= *ReservedMemBitmap;
+ gBS->RestoreTPL (OldTpl);
if (*ReservedMemBitmap != 0) {
*PhysicalAddress -= SIZE_4KB;
@@ -476,6 +479,8 @@ IoMmuFreeCommonBuffer (
IN UINTN CommonBufferPages
)
{
+ EFI_TPL OldTpl;
+
if (!mReservedSharedMemSupported) {
goto LegacyFreeCommonBuffer;
}
@@ -494,7 +499,10 @@ IoMmuFreeCommonBuffer (
mReservedMemBitmap & ((UINT32)(~CommonBufferHeader->ReservedMemBitmap))
));
+ OldTpl = gBS->RaiseTPL (TPL_NOTIFY);
mReservedMemBitmap &= (UINT32)(~CommonBufferHeader->ReservedMemBitmap);
+ gBS->RestoreTPL (OldTpl);
+
return EFI_SUCCESS;
LegacyFreeCommonBuffer:
--
2.41.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107088): https://edk2.groups.io/g/devel/message/107088
Mute This Topic: https://groups.io/mt/100251949/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
