[edk2-devel] [PATCH v5 0/3] Support FDT library.

2023-04-28 Thread Benny Lin
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) and refer to LibcLib implementation by Pedro. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: S

[edk2-devel] [PATCH v5 1/3] Tianocore: Support FDT library.

2023-04-28 Thread Benny Lin
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) Add submodule libfdt and update ReadMe for the licence. Reviewed-by: Leif Lindholm Reviewed-by: Michael D

[edk2-devel] [PATCH v5 3/3] .pytool: Support FDT library.

2023-04-28 Thread Benny Lin
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) Add RequiredSubmodule object for CI setting. Reviewed-by: Michael D Kinney Cc: Sean Brogan Cc: Michael K

[edk2-devel] [PATCH v5 2/3] MdePkg: Support FDT library.

2023-04-28 Thread Benny Lin
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) and refer to LibcLib implementation by Pedro. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Acked

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-04-28 Thread Gerd Hoffmann
Hi, > I'd have to dig much deeper to see if there's a way to identify whether a > VARS file was specified on the Qemu command line. I *think* (please correct > me if I'm missing something) for SEV and SEV-ES it would be straight forward > to try and access the memory as shared and check the head

Re: [edk2-devel] [PATCH 1/2] MdePkg/IndustryStandard: Adds definitions for IPMI SSIF

2023-04-28 Thread Tinh Nguyen via groups.io
Hi Gao, Thanks for your feedback. I will separate it in v2. Thanks, Tinh From: gaoliming Sent: Friday, April 28, 2023 12:17 PM To: Tinh Nguyen OS ; devel@edk2.groups.io Cc: Open Source Submission ; michael.d.kin...@intel.com ; zhiguang@intel.com ; abner.c

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/ResetVector: Rename macros about page table.

2023-04-28 Thread Ni, Ray
> -Original Message- > From: Liu, Zhiguang > Sent: Friday, April 28, 2023 2:42 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Gerd Hoffmann ; De, > Debkumar ; West, Catharine > > Subject: [PATCH v3 1/5] UefiCpuPkg/ResetVector: Rename mac

Re: [edk2-devel] [PATCH v3 2/5] UefiCpuPkg/ResetVector: Simplify page table creation in ResetVector

2023-04-28 Thread Ni, Ray
The changes look good to me. Please change the macro per comments to patch #1, then update this patch accordingly. > -Original Message- > From: Liu, Zhiguang > Sent: Friday, April 28, 2023 2:42 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R >

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/ResetVector: Rename macros about page table.

2023-04-28 Thread Ni, Ray
6. PDP_1G -> PDPTE_1GB > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Friday, April 28, 2023 5:03 PM > To: Liu, Zhiguang ; devel@edk2.groups.io > Cc: Dong, Eric ; Kumar, Rahul R > ; Gerd Hoffmann ; De, > Debkumar ; West, Catharine > > Subject: Re: [edk2-de

Re: [edk2-devel] [PATCH v3 3/5] UefiCpuPkg/ResetVector: Combine PageTables1G.asm and PageTables2M.asm

2023-04-28 Thread Ni, Ray
The changes look good to me. Please change the macro per comments to patch #1, then update this patch accordingly. > -Original Message- > From: Liu, Zhiguang > Sent: Friday, April 28, 2023 2:42 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R >

[edk2-devel] [PATCH 1/1] OvmfPkg/NestedInterruptTplLib: replace ASSERT() with a warning logged.

2023-04-28 Thread Gerd Hoffmann
OVMF can't guarantee that the ASSERT() doesn't happen. Misbehaving EFI applications can trigger this. So log a warning instead and try to continue. Reproducer: Fetch windows 11 22H2 iso image, boot it in qemu with OVMF. Traced to BootServices->Stall() being called with IPL=TPL_HIGH_LEVEL and In

Re: [edk2-devel] [PATCH v3 4/5] UefiCpuPkg/ResetVector: Modify Page Table in ResetVector

2023-04-28 Thread Ni, Ray
The changes look good to me. Please change the macro per comments to patch #1, then update this patch accordingly. > -Original Message- > From: Liu, Zhiguang > Sent: Friday, April 28, 2023 2:42 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R >

Re: [edk2-devel] [PATCH v3 5/5] UefiCpuPkg/ResetVector: Support 5 level page table in ResetVector

2023-04-28 Thread Ni, Ray
The changes look good to me. Please change the macro per comments to patch #1, then update this patch accordingly. > -Original Message- > From: Liu, Zhiguang > Sent: Friday, April 28, 2023 2:42 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R >

Re: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug entry read error after it is found

2023-04-28 Thread Ard Biesheuvel
On Fri, 28 Apr 2023 at 07:02, gaoliming via groups.io wrote: > > Ard: > > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Ard > > Biesheuvel > > 发送时间: 2023年4月27日 22:47 > > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > > 抄送: Michael Kubacki > > 主题: Re: [edk2-devel] [PATCH] MdePkg BasePe

Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Add AUTH_SIG_NOT_FOUND Action

2023-04-28 Thread Yao, Jiewen
Sure. This patch is merged https://github.com/tianocore/edk2/pull/4321. Thanks for the contribution. Look forward to your investigation result. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nhi > Pham via groups.io > Sent: Friday, April 28, 2023 11:14 AM > To: Yao, Jiew

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/NestedInterruptTplLib: replace ASSERT() with a warning logged.

2023-04-28 Thread Michael Brown
On 28/04/2023 10:10, Gerd Hoffmann wrote: OVMF can't guarantee that the ASSERT() doesn't happen. Misbehaving EFI applications can trigger this. So log a warning instead and try to continue. Reproducer: Fetch windows 11 22H2 iso image, boot it in qemu with OVMF. Traced to BootServices->Stall()

Re: [edk2-devel] [PATCH v3] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true

2023-04-28 Thread Guo, Gua
Thanks for follow up that. Reviewed-by: Gua Guo -Original Message- From: Hsieh, PaytonX Sent: Friday, April 28, 2023 7:41 PM To: devel@edk2.groups.io Cc: Hsieh, PaytonX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH v3] UefiPayloadPkg: Fix issues when MU

Re: [edk2-devel] [edk2-docs] edk2-docs.gitbook.io offline

2023-04-28 Thread Rebecca Cran
On 4/27/23 10:31, Michael D Kinney wrote: Hello, All docs were migrated to github tianocore-docs organization about 3 years ago. https://github.com/tianocore-docs The following 2 wiki page has links to all the documents https://tianocore-docs.github.io/ https://github.com/tianocore/tianoc

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/NestedInterruptTplLib: replace ASSERT() with a warning logged.

2023-04-28 Thread Gerd Hoffmann
On Fri, Apr 28, 2023 at 11:26:32AM +, Michael Brown wrote: > On 28/04/2023 10:10, Gerd Hoffmann wrote: > > OVMF can't guarantee that the ASSERT() doesn't happen. Misbehaving > > EFI applications can trigger this. So log a warning instead and try > > to continue. > > > > Reproducer: Fetch win

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true

2023-04-28 Thread Benjamin Doron
Hi Payton, Thanks for responding. I understand the idea of the patch, Gua described my idea better. I was thinking that there would be two library instances, BaseSerialPortLibHob.inf and DxeSerialPortLibHob.inf. BASE compiles only BaseSerialPortLibHob.c, and DXE compiles the BaseSerialPortLibHob

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/NestedInterruptTplLib: replace ASSERT() with a warning logged.

2023-04-28 Thread Michael Brown
On 28/04/2023 14:38, Gerd Hoffmann wrote: I suspect the windows boot loader does something fishy here, but I can't proof it, I have not yet pinned down the exact location where interrupts get enabled while running at IPL=TPL_HIGH_LEVEL (which is what I suspect is happening, but of course this is

Re: [edk2-devel] [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table based on PCD values

2023-04-28 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[Public] Hi Maintainers, Please review the patch. Thanks AbduL -Original Message- From: Abdul Lateef Attar Sent: 10 April 2023 15:56 To: devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, Abner ; Sai Chaganty ; Isaac Oram ; Nate DeSimone ; Liming Gao Subject:

[edk2-devel] [PATCH v2] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true

2023-04-28 Thread paytonx . hsieh
From: PaytonX Hsieh REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4427 1. Since UART speed is slower than CPU, BIOS need to check the write buffer is empty, to avoid overwrite the buffer content. 2. LPSS UART might disable MMIO space for Windows debug usage during ExitBootServices ev

[edk2-devel] [PATCH v3] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true

2023-04-28 Thread paytonx . hsieh
From: PaytonX Hsieh REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4427 1. Since UART speed is slower than CPU, BIOS need to check the write buffer is empty, to avoid overwrite the buffer content. 2. LPSS UART might disable MMIO space for Windows debug usage during ExitBootServices ev

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true

2023-04-28 Thread Hsieh, PaytonX
Hi Benjamin, Due to some platform will disable the MMIO access of UART in ExitBootServices event. So we register an ExitBootServices event to avoid access the invalid MMIO space, it will cause the system hang when boot to windows OS. And the serial port library is also used in SEC and PEI phas

[edk2-devel] [PATCH 1/2] MdePkg/IndustryStandard: Add SMBIOS anchor string & length defines.

2023-04-28 Thread Giri Mudusuru via groups.io
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103786): https://edk2.groups.io/g/devel/message/103786 Mute This Topic: https://groups.io/mt/98566052/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/deve

Re: [edk2-devel] [PATCH 1/2] MdePkg/IndustryStandard: Adds definitions for IPMI SSIF

2023-04-28 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Tinh, Below is my comments, > -Original Message- > From: Tinh Nguyen > Sent: Friday, April 28, 2023 12:00 PM > To: devel@edk2.groups.io > Cc: patc...@amperecomputing.com; michael.d.kin...@intel.com; > gaolim...@byosoft.com.cn; zhiguang@intel.com;

Re: [edk2-devel] [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions

2023-04-28 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Tinh Nguyen > Sent: Friday, April 28, 2023 12:00 PM > To: devel@edk2.groups.io > Cc: patc...@amperecomputing.com; michael.d.kin...@intel.com; > gaolim...@byosoft.com.cn; zhiguang@intel.com; Chang

Re: [edk2-devel] [PATCH 0/2] Add IPMI SSIF definitions

2023-04-28 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Tinh, Could you please also create a BZ ticket for tracking this? Thus this information will be also covered by edk2 stable release note. Thanks Abner > -Original Message- > From: Tinh Nguyen > Sent: Friday, April 28, 2023 12:00 PM > To: devel@edk2.