Not easy, I have tried to update, but blocked at the RSA and MAC part, there
will be many strange problems such as:
the context generated by RsaNew and RsaSetKey cannot be used for sign/verify,
the hmac_duplicate (*src,*dst) function needs to expose the openssl structure
details...
https://githu
Thanks. That means we need revisit the API in crypto library.
The original idea of crypt API is suitable for all crypto implementation.
But if they cannot be implemented with opensssl 3.0 mode, the crypto API
design is problematic... Sigh...
> -Original Message-
> From: Li, Yi1
> Sen
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 24, 2023 2:00 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 08/22] UefiCpuPkg/CpuPageTableLib:Add check for Mask
> and Attr
>
> For differe
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 24, 2023 2:00 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 09/22] UefiCpuPkg/CpuPageTableLib: Add manual test to
> check Mask and Attr
>
>
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 24, 2023 2:00 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 11/22] UefiCpuPkg/CpuPageTableLib: Add LastMapEntry
> pointer
>
> Add LastMapEn
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 24, 2023 2:00 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann ;
> Liu, Zhiguang
> Subject: [Patch V5 12/22] UefiCpuPkg/CpuPageTableLib:Modify RandomTest
> to check
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 24, 2023 2:00 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 14/22] UefiCpuPkg/CpuPageTableLib: Add OUTPUT
> IsModified parameter.
>
> Add O
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 24, 2023 2:00 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 20/22] UefiCpuPkg/CpuPageTableLib: Enable PAE paging
>
> Modify CpuPageTableLib
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 24, 2023 2:00 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V5 19/22] UefiCpuPkg: Combine branch for non-present and
> leaf ParentEntry
>
> Co
Python/Python3.6.8: migration of edk2module from chipsec repo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161
This patch merges the enhancements done by chipsec
tool to edk2 module into edk2-libc repo.
The chipsec enhancements can be used for various
other Python based tools to access pl
Cc: Rebecca Cran
Cc: Michael D Kinney
Cc: Jayaprakash N
Signed-off-by: Ajay Kadapathri
---
.../Python-3.6.8/PyMod-3.6.8/Modules/cpu.nasm | 17 -
.../Python-3.6.8/PyMod-3.6.8/Modules/cpu_gcc.s | 17 -
.../PyMod-3.6.8/Modules/cpu_ia32.nasm | 17 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161
This patch merges the enhancements done by chipsec
tool to edk2 module into edk2-libc repo.
The chipsec enhancements can be used for various
other Python based tools to access platform registers.
These enhancements providing a set of APIs to
In the V6 atch set
In 'Fix the non-1:1 mapping issue', use MultU64x32 to avoid IA32 build failure.
In 'Fix issue when splitting leaf entry', add more precise comments to explain
why IA32_PE_BASE_ADDRESS_MASK_40 is used.
Other patches are Reviewed-by Ray.
Dun Tan (20):
UefiCpuPkg/CpuPageTableLi
In previous code logic, when splitting a leaf parent entry to
smaller granularity child page table, if the parent entry
Attribute&Mask(without PageTableBaseAddress field) is equal to the
input attribute&mask(without PageTableBaseAddress field), the split
process won't happen. This may lead to failu
When splitting leaf parent entry to smaller granularity, create
child page table before modifing parent entry. In previous code
logic, when splitting a leaf parent entry, parent entry will
point to a null 4k memory before child page table is created in
this 4k memory. When the page table to be modi
Thanks Liming. Sorry for missing the email.
Here is the PR for the two patches: https://github.com/tianocore/edk2/pull/4169
Thanks,
Dun
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming via
groups.io
Sent: Thursday, March 23, 2023 9:17 AM
To: Tan, Dun ; devel@edk2.grou
[AMD Official Use Only - General]
> -Original Message-
> From: Tinh Nguyen
> Sent: Friday, March 24, 2023 11:43 AM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Nickle
> Wang ; Igor Kulchytskyy ; Isaac
> Oram ; Attar, AbdulLateef (Abdul
From: Abner Chang
BZ #4354
This change adds definitions for IPMI KCS.
Spec ref:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Nickle Wang
C
[AMD Official Use Only - General]
Hi Tinh,
V5 was sent to correct typo.
Thanks
Abner
> -Original Message-
> From: Tinh Nguyen
> Sent: Friday, March 24, 2023 11:43 AM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Nickle
> Wang ; Igor Kulc
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Wednesday, March 22, 2023 10:49 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Isaac Oram
> ; Nate DeSimone ;
> Nickle Wang ; Igor Kulchytskyy ; Abdul
> Lateef Attar
> Subject: [PATCH v4
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Wednesday, March 22, 2023 10:49 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Isaac Oram
> ; Nate DeSimone ;
> Nickle Wang ; Igor Kulchytskyy ; Abdul
> Lateef Attar
> Subject: [PATCH v4
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Wednesday, March 22, 2023 10:49 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Isaac Oram
> ; Nate DeSimone ;
> Nickle Wang ; Igor Kulchytskyy ; Abdul
> Lateef Attar
> Subject: [PATCH v4
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Wednesday, March 22, 2023 10:49 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Isaac Oram
> ; Nate DeSimone ;
> Abdul Lateef Attar ; Nickle Wang ;
> Igor Kulchytskyy
> Subject: [PATCH v4
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Wednesday, March 22, 2023 10:49 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Isaac Oram
> ; Nate DeSimone ;
> Abdul Lateef Attar ; Nickle Wang ;
> Igor Kulchytskyy
> Subject: [PATCH v4
Arm reference design Fixed Virtual Platforms (FVPs) such as the RD-N2
platform variants have multiple IO virtualization blocks that allow
connecting PCIe root bus or non-PCIe SoC peripherals to the system.
Each of these IO virtualization blocks consists of an Arm SMMUv3, a
GIC-ITS and a NCI (networ
Some of the Arm reference design FVP platforms support the Virtio-p9
device as part of the RoS subsystem. Add an entry for this device in
the SSDT acpi table.
The device entry is listed in a new SSDT file as only some of the
reference design FVP platforms support it and so this file is included
in
Enable the virtio-p9 device that is present as part of the RoS
peripherals on RD-N2 platform variants. This will allow filesystem
sharing between the Host PC and target platform.
Signed-off-by: Vivek Gautam
Reviewed-by: Pierre Gondois
---
Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf |
Arm reference design platforms have multiple IO virtualization blocks
that allow connecting PCIe root bus or non-PCIe SoC peripherals to the
system. Each of these IO virtualization blocks consists of an instance
of SMMUv3, a GIC-ITS and a NCI (network chip interconnect) to support
traffic flow and
From: Shriram K
The IO virtualization block on reference design platforms allow
connecting SoC expansion devices such as PL011 UART. On platforms
that support this, initialize the UART controller connected to the
IO virtualization block.
Signed-off-by: Shriram K
Signed-off-by: Vivek Gautam
---
For all the RD-N2 platform variants, include the SSDT ACPI table that
describes the devices present in SoC expansion block that is connected
to the IO virtualization block.
Signed-off-by: Vivek Gautam
---
Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 5 +
Platform/ARM/SgiPkg/AcpiTa
Hi Nainar,
1. Snp->StationAddress() calls UNDI->StationAddress(). Is there a guarantee
that the UNDI driver you are using will persist the configuration across driver
reloads / platform reboots? If there is no such guarantee, you should not
reconnect UNDI driver - else the setting is lost.
On Fri, Mar 24, 2023 at 01:42:17AM +, Jeff Brasen wrote:
> Nothing to do here for virtio 1.0 devices
>
> Signed-off-by: Jeff Brasen
> ---
> .../Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Libra
BufferPages is UINTN, so we need "%Lu" when printing it.
Fixes: 4f441d024bee ("UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling")
Reported-by: Laszlo Ersek
Signed-off-by: Gerd Hoffmann
---
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi Liming,
Thank you for the review.
Best regards,
Pawel
On Fri, Mar 10, 2023 at 3:31 AM gaoliming via groups.io wrote:
> Pawel:
> The change in MdeModulePkg looks good to me. Reviewed-by: Liming Gao <
> gaolim...@byosoft.com.cn>
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.gro
Hi all,
If someone had a chance to take a look at this patchset already and would
like to share thoughts?
The 1st patch from this series has been already successfully reviewed.
Best regards,
Pawel
On Fri, Feb 17, 2023 at 2:03 PM Paweł Poławski wrote:
> From: Laszlo Ersek
>
> This patch enable
Gerd,
"%d" tells "int" type value is in the stack.
This actually works in both 32bit and 64bit case assuming the BufferPages is
less than MAX_UINT32.
But if using "%Lu", it tells that "uint_64" type value is in the stack.
This precisely describes the stack content in 64bit mode.
But it may print
Hi all,
If someone had a chance to take a look at this patchset already and would
like to share thoughts?
The 1st patch from this series has been already successfully reviewed.
Best regards,
Pawel
On Fri, Feb 17, 2023 at 2:03 PM Paweł Poławski wrote:
> From: Laszlo Ersek
>
> This patch enable
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 24, 2023 4:52 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V6 04/22] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1
> mapping issue
>
> In previ
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 24, 2023 4:52 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Gerd Hoffmann
> Subject: [Patch V6 06/22] UefiCpuPkg/CpuPageTableLib: Fix issue when
> splitting leaf entry
>
> Wh
Hi Michael,
Sorry for the delay in my response. I just opened PR against EDK2 repo to
trigger CI:
https://github.com/tianocore/edk2/pull/4174
Best regards,
Pawel
On Thu, Mar 23, 2023 at 11:10 PM Kinney, Michael D <
michael.d.kin...@intel.com> wrote:
> Hi Pawel,
>
> Any updates on this task?
>
>
Hi Gerd,
On 3/24/23 14:41, Gerd Hoffmann wrote:
> BufferPages is UINTN, so we need "%Lu" when printing it.
>
> Fixes: 4f441d024bee ("UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling")
> Reported-by: Laszlo Ersek
> Signed-off-by: Gerd Hoffmann
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2
On 3/24/23 15:56, Laszlo Ersek wrote:
> Hi Gerd,
>
> On 3/24/23 14:41, Gerd Hoffmann wrote:
>> BufferPages is UINTN, so we need "%Lu" when printing it.
>>
>> Fixes: 4f441d024bee ("UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling")
>> Reported-by: Laszlo Ersek
>> Signed-off-by: Gerd Hoffmann
>> ---
Can you combine with this patch #1?
Thanks,
Mike
> -Original Message-
> From: Kadapathri, Ajay
> Sent: Friday, March 24, 2023 1:27 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Kinney, Michael D
> ; Jayaprakash, N
>
> Subject: [edk2-libc Patch 2/2] Added file header with copyrigh
1) Keep %d and change BufferPages to type UINT32.
2) Change to %Ld and change BufferPages to type UINT64.
Mike
> -Original Message-
> From: Ni, Ray
> Sent: Friday, March 24, 2023 7:00 AM
> To: Gerd Hoffmann ; devel@edk2.groups.io; Kinney, Michael
> D
> Cc: Dong, Eric ; Oliver Steffen ;
On Thu, Mar 23, 2023 at 12:17:28PM +0100, Gerd Hoffmann wrote:
> Use the MdePkg version instead of maintaining a copy in BaseTools.
>
> Signed-off-by: Gerd Hoffmann
> ---
Acked-by: Sunil V L
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
And from Laszlo's responses, 3 total options.
1) Keep %d and change BufferPages to type UINT32.
2) Change to %Ld and change BufferPages to type UINT64.
3) Change to %Ld and typecast BufferPages to UINT64 in DEBUG().
All 3 will work. Best suggestion is (3) from Laszlo.
Mike
> -Original Mess
Adding code to support Cache Management Operations
(CMO) defined by RV spec https://github.com/riscv/riscv-CMOs
Notes:
1. CMO only supports block based Operations. Meaning complete
cache flush/invd/clean Operations are not available
2. Current implementation uses ifence instructions but it
maybe pl
Current implementation for cache management (instruction/data flush/invd)
depends on ifence instruction. All RV platforms may not use the same
method for cache management. Instead RV defines CMO Cache management
operations specification which consits of cbo.x instructions for cache
management. Howe
Cc: Sunil V L
Cc: Andrei Warkentin
Cc: Daniel Schaefer
Signed-off-by: Dhaval Sharma
Add support for Cache Management Operations
---
OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 9 +
1 file changed, 9 insertions(+)
diff --git a/OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc
b/OvmfPkg/RiscVVirt/RiscVVi
Hi Mike,
Would you like a change here?
Thanks,
Michael
On 3/21/2023 10:25 AM, Michael Kubacki wrote:
I spoke to Erich offline and he mentioned that a previous coding
practice he used specified unsigned integer literals when intended so he
applied that here.
Thanks,
Michael
On 3/10/2023 5:5
I would prefer to follow convention of rest of edk2 sources.
which is to not use the postfix 'u' for small integers.
Mike
> -Original Message-
> From: Michael Kubacki
> Sent: Friday, March 24, 2023 8:51 AM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> Erich McMillan
> Cc: Dong, Eri
From: Michael Kubacki
Purdue Compiler Construction Tool Set (PCCTS) source code was copied/
pasted into BaseTools/Source/C/VfrCompile/Pccts/.
The code contains tab characters instead of spaces.
PatchCheck.py gives an error on modifications to files that
contain tabs.
This change adds that dire
From: Michael Kubacki
While more portable methods exist to handle these cases, this change
does not attempt to do more than fix the immediate problem and
follow the conventions already established in this code.
`snprintf()` is introduced as the minimum improvement apart from
making the buffers l
When checking for Makefiles, in addition to Makefile and GNUmakefile,
also check for *.makefile: this allows {header,footer,app,lib}.makefile
in BaseTools/Source/C/Makefiles to be detected and avoid having
PatchCheck.py complain about tab characters.
Signed-off-by: Rebecca Cran
---
BaseTools/Scr
I think we almost finished POC.
My feeling for the final openssl 3.0 size increasement would be 10% ~ 20%,
based upon how many patch we can upstream to openssl community.
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, March 24, 2023 12:00 AM
> To: devel@edk2.groups.io
Hi Sunil,
Looks reasonable!
Can you please add the IN/OUT annotations to the functions that are missing
them - at least the changed ones, such as:
- GetNumCells (also missing a comment header)
- AddReservedMemoryMap
With that -
Reviewed-by: Andrei Warkentin
-Original Message-
From: S
Pull Request: https://github.com/tianocore/edk2/pull/4176
Branch: https://github.com/bcran/edk2/tree/patchcheck_makefiles
On 3/24/23 10:32 AM, Rebecca Cran wrote:
When checking for Makefiles, in addition to Makefile and GNUmakefile,
also check for *.makefile: this allows {header,footer,app,lib
Hi Tinh,
Sorry, was waiting for a v4 based on your last reply to Oliver.
Yes, from my end (with Oliver's feedback addressed):
Reviewed-by: Leif Lindholm
/
Leif
On Wed, Mar 22, 2023 at 10:38:21 +0700, Tinh Nguyen wrote:
> Hi Leif,
>
> Do you have any concerns? Could I add you to the review
> -Original Message-
> From: Rebecca Cran
> Sent: Friday, March 24, 2023 9:32 AM
> To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> ; Kinney, Michael D
> Cc: Rebecca Cran
> Subject: [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for *.makefile
>
> When ch
When checking for Makefiles, also check for *.makefile: this allows
{header,footer,app,lib}.makefile in BaseTools/Source/C/Makefiles to be
detected and avoid having PatchCheck.py complain about tab characters.
Also, change the check for "Makefile" to be case-insensitive since there
are some Makefi
On 3/24/23 12:46 PM, Kinney, Michael D wrote:
Should is be ".makefile" or perhaps use os.path.splitext() instead?
Good point. I've updated the code to use os.path.splitext() instead, and
change the check for 'Makefile' to be case-insensitive since some are
which are missing the upper-case 'M'
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Rebecca Cran
> Sent: Friday, March 24, 2023 12:17 PM
> To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> ; Kinney, Michael D
> Cc: Rebecca Cran
> Subject: [PATCH v2 1/1] BaseTools/Scripts/PatchCheck.py
Reviewed-by: Michael D Kinney
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Thursday, March 23, 2023 7:47 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ;
> Nickle Wang ; Igor Kulchytskyy ; Oram,
> Isaac W ; Abdul Lateef Attar
>
> Subj
Reviewed-by: Michael D Kinney
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Thursday, March 23, 2023 8:16 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ;
> Nickle Wang ; Igor Kulchytskyy ; Oram,
> Isaac W ; Abdul Lateef Attar
>
> Subj
From: Michael Kubacki
While more portable methods exist to handle these cases, this change
does not attempt to do more than fix the immediate problem and
follow the conventions already established in this code.
`snprintf()` is introduced as the minimum improvement apart from
making the buffers l
From: Michael Kubacki
Purdue Compiler Construction Tool Set (PCCTS) source code was copied/
pasted into BaseTools/Source/C/VfrCompile/Pccts/.
The code contains tab characters instead of spaces.
PatchCheck.py gives an error on modifications to files that
contain tabs.
This change adds that dire
I sent out a patch to fix this same issue earlier today!
I took a slightly different approach: see "[edk2-devel] [PATCH v2 1/1]
BaseTools/Scripts/PatchCheck.py: Improve check for Makefiles"
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
index fcdabfc8acea..2414
Ah, but my patch was only for Makefiles: I didn't realize source files
also contain tabs.
So we probably want a combination of our patches: yours to ignore the
entire directory, and the change I made to also ignore files named
"makefile" as well as "Makefile".
Could you update your patch wit
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Tuesday, March 21, 2023 5:14 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH v3] IntelFsp2Pkg: Fix NASM X64 build warnings.
REF: https://bugzilla.tianocore.org/sho
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Friday, March 24, 2023 1:49 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Erich McMillan
> ; Kinney, Michael D ;
> Michael Kubacki ; Kumar, Rahul R
> ; Ni, Ray
> Subject: [PATCH v6 10/1
Yes, no problem. Thanks for bringing this to my attention.
On 3/24/2023 4:56 PM, Rebecca Cran wrote:
Ah, but my patch was only for Makefiles: I didn't realize source files
also contain tabs.
So we probably want a combination of our patches: yours to ignore the
entire directory, and the change
I see what's going wrong.
First, PatchCheck.py isn't ignoring tabs in files named "*.makefile" or
"makefile".
Michael Kubacki has a patch to fix that (I also submitted a patch, but
I'll let him commit his changes).
Secondly, edk2basetools has a copy of Workspace/DscBuildData.py which is
s
This bit is now available in the PE/COFF spec in the Extended DLL
Characteristics section.
https://learn.microsoft.com/windows/win32/debug/pe-format#extended-dll-characteristics
Name: "IMAGE_DLLCHARACTERISTICS_EX_FORWARD_CFI_COMPAT"
Value: "0x0040"
On 2/2/2023 7:24 PM, Michael Kubacki wrote:
From: Michael Kubacki
While more portable methods exist to handle these cases, this change
does not attempt to do more than fix the immediate problem and
follow the conventions already established in this code.
`snprintf()` is introduced as the minimum improvement apart from
making the buffers l
From: Michael Kubacki
Purdue Compiler Construction Tool Set (PCCTS) source code was copied/
pasted into BaseTools/Source/C/VfrCompile/Pccts/.
The code contains tab characters instead of spaces.
PatchCheck.py gives an error on modifications to files that
contain tabs.
The goal of my upcoming ch
The changes are merged in the v7 series:
https://edk2.groups.io/g/devel/message/101846
On 3/24/2023 5:27 PM, Michael Kubacki wrote:
Yes, no problem. Thanks for bringing this to my attention.
On 3/24/2023 4:56 PM, Rebecca Cran wrote:
Ah, but my patch was only for Makefiles: I didn't realize sou
Reviewed-by: Rebecca Cran
On 3/24/23 4:30 PM, Michael Kubacki wrote:
From: Michael Kubacki
Purdue Compiler Construction Tool Set (PCCTS) source code was copied/
pasted into BaseTools/Source/C/VfrCompile/Pccts/.
The code contains tab characters instead of spaces.
PatchCheck.py gives an erro
Patch merged:
https://github.com/tianocore/edk2/commit/f6bd3286edfbe5eb6b50946cc8bb89e5c60b9388
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Tuesday, March 21, 2023 5:14 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone,
If there are two drivers to produce same resource, it should be a platform
policy decision for which one takes precedent.
Maybe a platform wants to say: The ACPI is there, I want to skip myself,
instead of override.
I feel uncomfortable to include such policy in TCG2 ACPI driver, to enforce the
PR: https://github.com/tianocore/edk2/pull/4173
V6 delta changes:
Addressed review comments for Ray NI,
removed unnecessary EFIAPI.
V5 delta changes:
rebase to master branch.
updated Reviewed-by
V4 delta changes:
rebase to master branch.
added reviewed-by.
V3 delta changes:
Addre
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds an SMM SMRAM save-state map for AMD processors.
SMRAM save state maps for the AMD processor family are now supported.
Save state map structure is added based on
AMD64 Architecture Programmer's Manual, Volume 2, Section 10.2.
The AMD le
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds SmmSmramSaveStateLib Library class in UefiCpuPkg.dec.
Adds function declaration header file.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements SmmSmramSaveStateLib Library class for
AMD cpu family.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Latee
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
moves Intel-specific code to the arch-dependent file.
Other processor families might have different
implementation of these functions.
Hence, moving out of the common file.
Cc: Abner Chang
Cc: Garrett Kirkendall
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds initial defination for AMD's SmmCpuFeaturesLib
library implementation.
All function's body either empty or just returns
value. Its initial skeleton of library implementation.
Cc: Paul Grimes
Cc: Garrett Kirke
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements interfaces to read and write save state
registers of AMD's processor family.
Initializes processor SMMADDR and MASK depends
on PcdSmrrEnable flag.
Program or corrects the IP once control returns from SMM.
86 matches
Mail list logo
