When checking for Makefiles, also check for *.makefile: this allows {header,footer,app,lib}.makefile in BaseTools/Source/C/Makefiles to be detected and avoid having PatchCheck.py complain about tab characters.
Also, change the check for "Makefile" to be case-insensitive since there are some Makefiles named 'makefile' instead of 'Makefile'. Signed-off-by: Rebecca Cran <rebe...@bsdio.com> --- BaseTools/Scripts/PatchCheck.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index fcdabfc8acea..241467f10ea5 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -383,7 +383,8 @@ class GitDiffCheck: self.force_crlf = False self.force_notabs = False if os.path.basename(self.filename) == 'GNUmakefile' or \ - os.path.basename(self.filename) == 'Makefile': + os.path.basename(self.filename).lower() == 'makefile' or \ + os.path.splitext(self.filename)[1] == ".makefile": self.force_notabs = False elif len(line.rstrip()) != 0: self.format_error("didn't find diff command") -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101819): https://edk2.groups.io/g/devel/message/101819 Mute This Topic: https://groups.io/mt/97831148/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-