Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Correct buffer for GenCrc32 tool

2022-10-01 Thread Bob Feng
Yes, I agree that in the case of GenCrc32 we can just set EFI_GUIDED_SECTION_PROCESSING_REQUIRED=0 and point DataOffset to the (EFI_GUID_DEFINED_SECTION + 4 bytes). For this patch, Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Konstantin Aladyshev S

Re: [edk2-devel] [PATCH v2] BaseTools: Add missing spaces for PCD expression values in AutoGenC

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Wednesday, September 21, 2022 9:02 AM To: devel@edk2.groups.io; aladyshe...@gmail.com Cc: Feng, Bob C ; Chen, Christine Subject: 回复: [edk2-devel] [PATCH v2] BaseTools: Add mis

Re: [edk2-devel] [PATCH v2] BaseTools: Correct initialization data size check for array PCDs

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Konstantin Aladyshev Sent: Tuesday, August 30, 2022 6:21 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [PATCH v2] BaseTools: Correct initialization data size check for array

Re: [edk2-devel] [PATCH v2 02/17] BaseTools: Remove duplicated words

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of PierreGondois Sent: Tuesday, September 6, 2022 4:29 PM To: devel@edk2.groups.io Cc: Pierre Gondois ; Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [PATCH v2 02/17] BaseTools: Remove duplicated words Fro

Re: [edk2-devel] [PATCH 1/6] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Konstantin Aladyshev Sent: Tuesday, August 30, 2022 6:15 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [edk2-devel] [PATCH 1/6] BaseTools/Vol

Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Increase GUID base name string

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Konstantin Aladyshev Sent: Thursday, July 21, 2022 9:12 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [PATCH] BaseTools/VolInfo: Increase GUID base name string The current st

Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Update file and section type strings

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Konstantin Aladyshev Sent: Friday, July 22, 2022 9:30 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [edk2-devel] [PATCH] BaseTools/VolInfo: U

Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Parse apriori files

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Konstantin Aladyshev Sent: Friday, July 22, 2022 11:38 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [edk2-devel] [PATCH] BaseTools/VolInfo:

Re: [edk2-devel] [PATCH 0/2] Reconstruction on SmmCpuFeaturesLib

2022-10-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Mike, I think we don't need to git mv for this case. IntelSmmCpuFeaturesLib.c is a new file and the content is moved from SmmCpuFeatureslibCommon.c. SmmCpuFeatureslibCommon.c still has the complete history. Did I miss something? Abner > -Original Message

Re: [edk2-devel] [PATCH] BaseTools: Add support for SUBTYPE_GUID section generation

2022-10-01 Thread Bob Feng
This patch is good to me. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Konstantin Aladyshev Sent: Wednesday, July 20, 2022 10:01 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [edk2-deve

Re: [edk2-devel] [PATCH v2] BaseTools: Support COMPAT16 section generation

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Konstantin Aladyshev Sent: Tuesday, August 30, 2022 6:20 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [PATCH v2] BaseTools: Support COMPAT16 section generation Currently COM

Re: [edk2-devel] [PATCH 2/2] BaseTools/FMMT: Add Shrink Fv function

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Chen, Christine Sent: Friday, September 16, 2022 9:51 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH 2/2] BaseTools/FMMT: Add Shrink Fv function REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3938 This fun

Re: [edk2-devel] [PATCH 1/2] BaseTools/FMMT: Add Extract FV function

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Chen, Christine Sent: Friday, September 16, 2022 9:51 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH 1/2] BaseTools/FMMT: Add Extract FV function REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3938 With th

Re: [edk2-devel] [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Rebecca Cran Sent: Tuesday, September 20, 2022 5:39 AM To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming ; Chen, Christine Cc: Rebecca Cran Subject: [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile When che

Re: [edk2-devel] [PATCH v2 02/17] BaseTools: Remove duplicated words

2022-10-01 Thread Bob Feng
Hi Pierre, Could you split this patch into 2? One is for basetools C tool, the other is for python tool because the python code patch will be merged to edk2-basetools repo also. Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Saturday, October 1,