Reviewed-by: Bob Feng <bob.c.f...@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via
groups.io
Sent: Wednesday, September 21, 2022 9:02 AM
To: devel@edk2.groups.io; aladyshe...@gmail.com
Cc: Feng, Bob C <bob.c.f...@intel.com>; Chen, Christine <yuwei.c...@intel.com>
Subject: 回复: [edk2-devel] [PATCH v2] BaseTools: Add missing spaces for PCD
expression values in AutoGenC
Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Konstantin
> Aladyshev
> 发送时间: 2022年8月30日 18:20
> 收件人: devel@edk2.groups.io
> 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn;
> yuwei.c...@intel.com; Konstantin Aladyshev <aladyshe...@gmail.com>
> 主题: [edk2-devel] [PATCH v2] BaseTools: Add missing spaces for PCD
> expression values in AutoGenC
>
> Currently the PCD values calculated from the expressions have
> different formating from the simple byte arrays in AutoGenC.
>
> Example:
> The following definition in DEC:
> gTokenSpaceGuid.PcdArray|{0x44, 0x33, 0x22, 0x11}|VOID*|0x55555555
> gTokenSpaceGuid.PcdArrayByExpression|{UINT32(0x11223344)}|VOID*|0x6
> 6666666
>
> Produces these strings in AutoGenC:
> <...> _gPcd_<...>_PcdArray[4] = {0x44, 0x33, 0x22, 0x11}; <...>
> _gPcd_<...>_PcdArrayByExpression[4] = {0x44,0x33,0x22,0x11};
>
> Add missing space character between the array elements to unify PCD
> value formatting.
>
> Signed-off-by: Konstantin Aladyshev <aladyshe...@gmail.com>
> ---
> BaseTools/Source/Python/Common/Expression.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/Common/Expression.py
> b/BaseTools/Source/Python/Common/Expression.py
> index 31bf0e4b6c..b62efe6f9b 100644
> --- a/BaseTools/Source/Python/Common/Expression.py
> +++ b/BaseTools/Source/Python/Common/Expression.py
> @@ -1026,7 +1026,7 @@ class ValueExpressionEx(ValueExpression):
> Size += ItemSize
>
>
>
> if Size > 0:
>
> - PcdValue = '{' +
> ','.join(AllPcdValueList) + '}'
>
> + PcdValue = '{' + ',
> '.join(AllPcdValueList) + '}'
>
> else:
>
> raise BadExpression("Type: %s,
> Value: %s, %s"%(self.PcdType, PcdValue, Value))
>
>
>
> --
> 2.25.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#92977):
> https://edk2.groups.io/g/devel/message/92977
> Mute This Topic: https://groups.io/mt/93345721/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94612): https://edk2.groups.io/g/devel/message/94612
Mute This Topic: https://groups.io/mt/94053057/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
