Reviewed-by: Bob Feng <bob.c.f...@intel.com>
-----Original Message-----
From: Rebecca Cran <rebe...@bsdio.com>
Sent: Tuesday, September 20, 2022 5:39 AM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming
<gaolim...@byosoft.com.cn>; Chen, Christine <yuwei.c...@intel.com>
Cc: Rebecca Cran <rebe...@bsdio.com>
Subject: [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in
Tests/GNUmakefile
When checking if $PYTHON_COMMAND exists, curly braces should be used instead of
parentheses.
Also, "1" causes an error on FreeBSD: it's likely supposed to be 2>&1 like
other scripts.
Signed-off-by: Rebecca Cran <rebe...@bsdio.com>
---
BaseTools/Tests/GNUmakefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile index
1cb77f84b1bf..caa4d26c9ba6 100644
--- a/BaseTools/Tests/GNUmakefile
+++ b/BaseTools/Tests/GNUmakefile
@@ -8,7 +8,7 @@
all: test
test:
- @if command -v $(PYTHON_COMMAND) >/dev/null 1; then $(PYTHON_COMMAND)
RunTests.py; else python RunTests.py; fi
+ @if command -v ${PYTHON_COMMAND} >/dev/null 2>&1; then
+${PYTHON_COMMAND} RunTests.py; else python RunTests.py; fi
clean:
find . -name '*.pyc' -exec rm '{}' ';'
--
2.37.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94624): https://edk2.groups.io/g/devel/message/94624
Mute This Topic: https://groups.io/mt/93791493/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
