Re: [edk2-devel] [PATCH] Maintainers.txt: Add new reviewer for UefiPayloadPkg

Reviewed -by: Sean Rhodes -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86957): https://edk2.groups.io/g/devel/message/86957 Mute This Topic: https://groups.io/mt/89353894/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https

[edk2-devel] [PATCH] MdeModulePkg/Usb/Keyboard.c: Don't request protocol before setting

No need to check the interface protocol then conditionally setting, just set it to BOOT_PROTOCOL and check for error. This is what Linux does for HID devices as some don't follow the USB spec. One example is the Aspeed BMC HID keyboard device, which adds a massive boot delay without this patch as

Re: [edk2-devel] [PATCH v2 1/5] OvmfPkg: Make the Xen ELF header generator more flexible

On Wed, Feb 23, 2022 at 05:51:26PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > Adding some flexibility to the program so that other targets can use it > if needed. > > An optional size parameter is added so that we can provide the expected > blob size of the generated bin

Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary

Hi, > -!include OvmfPkg/VarStore.fdf.inc > +!if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > +0x|0xe000 > +!endif > +!if $(FD_SIZE_IN_KB) == 4096 > +0x|0x0004 > +!endif Hmm, VarStore.fdf.inc reduces duplication, and now you revert this. Maybe add this to Va

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hi Vineel, Code is good to me, just some BKM for edk2 upstream: 1. It's a little strange that there are submodule changes in the patch 0004, maybe you forget to run git submodule update: diff --git a/BaseTools/Source/C/BrotliCompress/brotli b/BaseTools/Source/C/BrotliCompress/brotli index

Re: [edk2-devel] [edk2-non-osi][PATCH 1/1] Drivers/Realtek: Including Realtek driver to enable network support

On Wed, 16 Feb 2022 at 16:37, Himanshu Sharma wrote: > > This patch adds the generic Realtek PCIe UNDI Driver version 2.057 > driver binary to edk2-non-osi that can be made available to use for > the platforms that use Realtek's network controller > > This is a Aarch64 binary, available at: > http

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add i801 SMBus controller DXE

Hi Maurice, I agree that edk2-platforms is the right place. How should it be used to build UefiPlayloadPkg? Should it be hooked up as git submodule? Just wondering why you added vendor (or platform) specific code in UefiPayloadPkg/Library/SpiFlashLib/SpiFlashLib.inf ? Please clarify. Regards, Pat

[edk2-devel] [PATCH] MdeModulePkg/Usb/Keyboard.c: Don't request protocol before setting

No need to check the interface protocol then conditionally setting, just set it to BOOT_PROTOCOL and check for error. This is what Linux does for HID devices as some don't follow the USB spec. One example is the Aspeed BMC HID keyboard device, which adds a massive boot delay without this patch as

Re: [edk2-devel] [PATCH] MdeModulePkg: Correct high-memory use in NvmExpressDxe

On Thu, 24 Feb 2022 at 12:48, Tomas Pilar wrote: > > Delay and move the allocation and mapping of memory that backs the DMA > engine in NvmExpress devices to NvmeInit() to ensure that > the allocation only happens after the > EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute is set > on the PciIo

[edk2-devel] [PATCH] MdeModulePkg: Correct high-memory use in NvmExpressDxe

Delay and move the allocation and mapping of memory that backs the DMA engine in NvmExpress devices to NvmeInit() to ensure that the allocation only happens after the EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute is set on the PciIo controller. This ensures that the DMA-backing memory is not f

Re: [edk2-devel] [PATCH] MdeModulePkg: Correct high-memory use in NvmExpressDxe

On Thu, 24 Feb 2022 at 12:58, Ard Biesheuvel wrote: > > On Thu, 24 Feb 2022 at 12:48, Tomas Pilar wrote: > > > > Delay and move the allocation and mapping of memory that backs the DMA > > engine in NvmExpress devices to NvmeInit() to ensure that > > the allocation only happens after the > > EFI_P

Re: [edk2-devel] [PATCH] MdeModulePkg: Correct high-memory use in NvmExpressDxe

On 24/02/2022 12:09, Ard Biesheuvel wrote: On Thu, 24 Feb 2022 at 12:58, Ard Biesheuvel wrote: On Thu, 24 Feb 2022 at 12:48, Tomas Pilar wrote: Delay and move the allocation and mapping of memory that backs the DMA engine in NvmExpress devices to NvmeInit() to ensure that the allocation only

[edk2-devel] [PATCH v2] MdeModulePkg: Correct high-memory use in NvmExpressDxe

Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This ensures that the DMA-backing memory is not forcibly allocated below 4G in system address map. Otherwise the allocation fails on

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Correct high-memory use in NvmExpressDxe

On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar) wrote: > > Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci > > attribute to DriverBindingStart() before the memory that backs the > > DMA engine is allocated. > > > > This ensures that the DMA-backing memory is not forcibly al

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Correct high-memory use in NvmExpressDxe

On 24/02/2022 13:13, Ard Biesheuvel wrote: On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar) wrote: Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This ensures that the DMA

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Correct high-memory use in NvmExpressDxe

On 24/02/2022 13:14, Tomas Pilar (tpilar) wrote: On 24/02/2022 13:13, Ard Biesheuvel wrote: On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar) wrote: Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci attribute to DriverBindingStart() before the memory that backs the D

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Correct high-memory use in NvmExpressDxe

On 24/02/2022 13:19, Tomas Pilar (tpilar) wrote: On 24/02/2022 13:14, Tomas Pilar (tpilar) wrote: On 24/02/2022 13:13, Ard Biesheuvel wrote: On Thu, 24 Feb 2022 at 13:58, Tomas Pilar (tpilar) wrote: Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci attribute to Driv

[edk2-devel] [PATCH v3] MdeModulePkg: Correct high-memory use in NvmExpressDxe

Move the logic that stores starting PCI attributes and sets the EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This ensures that the DMA-backing memory is not forcibly allocated below 4G in system address map. Oth

Re: [edk2-devel] [PATCH] edk2/MdeModulePkg/Debuglib: Add Standalone MM support

Please update the copyright year to 2022 (line 5). With it addressed, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Xiaolu.Jiang > Sent: Tuesday, February 22, 2022 10:21 PM > To: devel@edk2.groups.io > Cc: Jiang, Xiaolu ; Wang, Ji

Re: [edk2-devel] [PATCH v3] MdeModulePkg: Correct high-memory use in NvmExpressDxe

(+ Hao Wu) On Thu, 24 Feb 2022 at 14:29, Tomas Pilar (tpilar) wrote: > > Move the logic that stores starting PCI attributes and sets the > EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute to > DriverBindingStart() before the memory that backs the > DMA engine is allocated. > > This ensures that

[edk2-devel] [PATCH v3 0/7] CloudHv: Rely on PVH boot specification

From: Sebastien Boeuf Cloud Hypervisor aims at emulating the minimal amount of legacy devices and this is why the PVH boot specification is supported. The point is to be able to share some information with the guest without the need for emulating devices that would be present on real hardware. S

[edk2-devel] [PATCH v3 1/7] OvmfPkg: Make the Xen ELF header generator more flexible

From: Sebastien Boeuf Adding some flexibility to the program through optional parameters and global define, so that other targets can use the generator. * A global define is added so that we can choose at build time if we want to use 32-bit or 64-bit base structures. * A first optional paramet

[edk2-devel] [PATCH v3 2/7] OvmfPkg: Xen: Use a new fdf include for the PVH ELF header

From: Sebastien Boeuf Instead of having the PVH ELF header part of the fdf file directly, we move it to a dedicated include file. This is the first step in automating the generation of the header. Signed-off-by: Sebastien Boeuf --- OvmfPkg/OvmfXen.fdf | 57 ++--

[edk2-devel] [PATCH v3 3/7] OvmfPkg: Xen: Generate fdf include file from ELF header generator

From: Sebastien Boeuf Updating the fdf include file based on the run of the ELF header generator. The diff from this patch is the result of: $ gcc -o elf_gen OvmfPkg/OvmfXenElfHeaderGenerator.c $ ./elf_gen 2097152 OvmfPkg/XenElfHeader.fdf.inc Signed-off-by: Sebastien Boeuf --- OvmfPkg/XenElfH

[edk2-devel] [PATCH v3 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary

From: Sebastien Boeuf Following the model from the Xen target, CloudHv is generated as a PVH ELF binary to take advantage of the PVH specification, which requires less emulation from the VMM. The fdf include file CloudHvElfHeader.fdf.inc has been generated from the following commands: $ gcc -D

[edk2-devel] [PATCH v3 5/7] OvmfPkg: CloudHv: Retrieve RSDP address from PVH

From: Sebastien Boeuf Instead of hardcoding the address of the RSDP in the firmware, let's rely on the PVH structure hvm_start_info to retrieve this information. Signed-off-by: Sebastien Boeuf --- OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 ++ OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c

[edk2-devel] [PATCH v3 6/7] OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS

From: Sebastien Boeuf Instead of using the CMOS, the CloudHv platform relies on the list of memmap entries provided through the PVH boot protocol to determine the last RAM address below 4G. Signed-off-by: Sebastien Boeuf --- OvmfPkg/PlatformPei/MemDetect.c | 73

[edk2-devel] [PATCH v3 7/7] OvmfPkg: CloudHv: Add README

From: Sebastien Boeuf Add some documentation to the CloudHv target in order to clarify how to use it and what to expect from it. Signed-off-by: Sebastien Boeuf --- OvmfPkg/CloudHv/README | 66 ++ 1 file changed, 66 insertions(+) create mode 100644 OvmfP

Re: [edk2-devel] [PATCH 1/3] OvmfPkg: Generate CloudHv as a PVH ELF binary

On Thu, 2022-02-24 at 07:27 +0100, Gerd Hoffmann wrote: > > > > +DATA = { > > > > +  # > > > > +  # This hex array have been generated by > > > > OvmfPkg/OvmfXenElfHeaderGenerator.c > > > > +  # and copied manually. > > > > > > How about having the generator write a .fdf.inc file which you > > > c

Re: [edk2-devel] [PATCH 2/3] OvmfPkg: CloudHv: Retrieve RSDP address from PVH

On Wed, 2022-02-23 at 12:31 +0100, Gerd Hoffmann wrote: >   Hi, > > > +  PVHResetVectorData = (VOID *)(UINTN)PcdGet32 > > (PcdXenPvhStartOfDayStructPtr); > > +  pvh_start_info   = (struct hvm_start_info > > *)(UINTN)PVHResetVectorData[0]; > > Ah, I see, here is the xen reset vector dependency

Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary

On Thu, 2022-02-24 at 09:16 +0100, Gerd Hoffmann wrote: >   Hi, > > > -!include OvmfPkg/VarStore.fdf.inc > > +!if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > > +0x|0xe000 > > +!endif > > +!if $(FD_SIZE_IN_KB) == 4096 > > +0x|0x0004 > > +!endif > > Hmm, VarSt

[edk2-devel] [PATCH v3 0/1] MdePkg/Include SMBIOS 3.5.0 changes

Hi Liming, I didnt reliaze that patch v2 was empty. Sending patch v3 after rebase. Thanks AbduL Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Abdul Lateef Attar (1): MdePkg/Include: Smbios Specification 3.5.0 changes MdePkg/Include/IndustryStandard/SmBios.h | 144 +

[edk2-devel] [PATCH v3 1/1] MdePkg/Include: Smbios Specification 3.5.0 changes

Adds following changes 1) Added support for manufacturing mode in BIOS Characteristics Extension Byte 2. 2) Added support for slot height in System Slot Table (type 9). 3) Updated Built-in pointing device interface with USB, I2C and SPI. 4) Updates Onboard Devices Extended Information with

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add i801 SMBus controller DXE

Hi Patrick, UefiPayloadPkg/Library/SpiFlashLib/SpiFlashLib.inf is a common module as the commit message mentioned as below: * UefiPayloadPkg: Add SpiFlashLib This is a common SPI Flash library used for the Intel platform that supports SPI hardware sequence. This library provides actual SPI fla

Re: [edk2-devel] [PATCH v3] MdeModulePkg: Correct high-memory use in NvmExpressDxe

On 2/24/22 06:29, Tomas Pilar (tpilar) wrote: +// +// Enable 64-bit DMA support in the PCI layer. +// +Status = PciIo->Attributes ( + PciIo, + EfiPciIoAttributeOperationEnable, + EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE

[edk2-devel] [PATCH v4] MdeModulePkg: Correct high-memory use in NvmExpressDxe

Move the logic that stores starting PCI attributes and sets the EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This ensures that the DMA-backing memory is not forcibly allocated below 4G in system address map. Oth

[edk2-devel] [PATCH v5] MdeModulePkg: Correct high-memory use in NvmExpressDxe

Move the logic that stores starting PCI attributes and sets the EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This ensures that the DMA-backing memory is not forcibly allocated below 4G in system address map. Oth

[edk2-devel] CI: install qemu failing with timeout connecting to azure.archive.ubuntu.com

I noticed the latest CI job for master failed installing qemu. Is this the same problem we had a couple of weeks ago? Err:1 http://azure.archive.ubuntu.com/ubuntu bionic/main amd64 libiscsi7 amd64 1.17.0-1.1 Could not connect to azure.archive.ubuntu.com

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add i801 SMBus controller DXE

Hi Patrick, You could refer this page https://github.com/tianocore/edk2-platforms on how to build platform with EDK2 and edk2-platform repo. I had thought you added a SMbus driver that could only work on a particular device. I agree with Maurice to put this kind of modules to Edk2-platform re

[edk2-devel][PATCH] edk2/MdeModulePkg/Debuglib: Add Standalone MM support

https://bugzilla.tianocore.org/show_bug.cgi?id=3844 This change added Standalone MM instance of DebugLib. Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Xiaolu.Jiang --- .../PeiDxeDebugLibReportStatusCode.inf| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di