On Thu, 2022-02-24 at 09:16 +0100, Gerd Hoffmann wrote: > Hi, > > > -!include OvmfPkg/VarStore.fdf.inc > > +!if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > > +0x00000000|0x0000e000 > > +!endif > > +!if $(FD_SIZE_IN_KB) == 4096 > > +0x00000000|0x00040000 > > +!endif > > Hmm, VarStore.fdf.inc reduces duplication, and now you revert this. > Maybe add this to VarStore.fdf.inc instead, and add a > PVH_HEADER_ENABLE > option to turn it on and off?
It's quite hard to use VarStore.fdf.inc since I would need to replace only the first DATA section. And I can't include something specific like OvmfPkg/CloudHv/CloudHvElfHeader.fdf.inc inside VarStore.fdf.inc. Should I create something like OvmfPkg/CloudHv/CloudHvVarStore.fdf.inc so that it makes sense to include OvmfPkg/CloudHv/CloudHvElfHeader.fdf.inc based on a PVH_HEADER_ENABLE variable? > > Also: With this in place the start of the vars firmware volume moves > because it's prefixed by the elf header. Does that work without code > changes? TBH, I'm not sure. I've been testing CLOUDHV.fd and it works fine. > > take care, > Gerd > > > > > > --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86987): https://edk2.groups.io/g/devel/message/86987 Mute This Topic: https://groups.io/mt/89345268/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
