Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-11 Thread Chang, Abner via groups.io
.groups.io; quic_llind...@quicinc.com; Attar, AbdulLateef (Abdul Lateef) ; Sunil V L ; Kinney, Michael D Cc: lichao ; Kirkendall, Garrett ; Grimes, Paul ; He, Jiangang ; Andrew Fish Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for archs [AMD Official Use Only - General

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-10 Thread Chang, Abner via groups.io
l, Garrett ; Grimes, Paul ; He, Jiangang ; Andrew Fish Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for archs Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Abner, Mike, Leif, "

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-10 Thread Ni, Ray
Attar, AbdulLateef > (Abdul Lateef) ; Sunil V L > > Cc: lichao ; Kirkendall, Garrett > ; Grimes, Paul ; He, > Jiangang ; Andrew Fish > Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for > archs > > [AMD Official Use Only - General] > > He

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-06 Thread Chang, Abner via groups.io
; Grimes, Paul ; He, > Jiangang ; Andrew Fish > Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for > archs > > [AMD Official Use Only - General] > > PR updated > https://github.com/tianocore-docs/edk2- > CCodingStandardsSpecification/pull/2/commits

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-04 Thread Chang, Abner via groups.io
; devel@edk2.groups.io; > quic_llind...@quicinc.com; Ni, Ray ; Attar, AbdulLateef > (Abdul Lateef) ; Sunil V L > ; Kinney, Michael D > Cc: lichao ; Kirkendall, Garrett > ; Grimes, Paul ; He, > Jiangang ; Andrew Fish > Subject: RE: [edk2-devel] The principles of EDK2 module reconst

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-04 Thread Michael D Kinney
AbdulLateef (Abdul Lateef) ; Sunil V L > > Cc: lichao ; Kirkendall, Garrett > ; Grimes, Paul ; He, > Jiangang ; Andrew Fish > Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for > archs > > [AMD Official Use Only - General] > > > > &g

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-04 Thread Chang, Abner via groups.io
ey, Michael D > > Cc: lichao ; Kirkendall, Garrett > ; Grimes, Paul ; He, > Jiangang ; Andrew Fish > Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for > archs > > Caution: This message originated from an External Source. Use proper > caution when op

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-03 Thread Michael D Kinney
r, AbdulLateef (Abdul Lateef) ; Sunil V L > > Cc: lichao ; Kirkendall, Garrett > ; Grimes, Paul ; He, > Jiangang ; Andrew Fish > Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for > archs > > [AMD Official Use Only - General] > > Mike, > Agr

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-02 Thread Chang, Abner via groups.io
gt; devel@edk2.groups.io; quic_llind...@quicinc.com; Ni, Ray > > ; Attar, AbdulLateef (Abdul Lateef) > > ; Sunil V L > > Cc: lichao ; Kirkendall, Garrett > > ; Grimes, Paul ; > He, > > Jiangang ; Andrew Fish > > Subject: RE: [edk2-devel] The principles of E

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-02 Thread Michael D Kinney
y, Michael D ; devel@edk2.groups.io; > quic_llind...@quicinc.com; Ni, Ray ; > Attar, AbdulLateef (Abdul Lateef) ; Sunil V L > > Cc: lichao ; Kirkendall, Garrett > ; Grimes, Paul ; He, > Jiangang ; Andrew Fish > Subject: RE: [edk2-devel] The principles of EDK2 module reco

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-10-02 Thread Chang, Abner via groups.io
: devel@edk2.groups.io; quic_llind...@quicinc.com; Chang, Abner > ; Ni, Ray ; Attar, AbdulLateef > (Abdul Lateef) ; Sunil V L > ; Kinney, Michael D > Cc: lichao ; Kirkendall, Garrett > ; Grimes, Paul ; He, > Jiangang ; Andrew Fish > Subject: RE: [edk2-devel] The principles of EDK2 module

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-30 Thread Michael D Kinney
ay > ; Attar, AbdulLateef (Abdul Lateef) > ; Sunil V L > Cc: lichao ; Kirkendall, Garrett > ; Grimes, Paul ; He, > Jiangang ; Andrew Fish > Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for > archs > > I agree similar things will certainly ha

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-30 Thread Leif Lindholm
; Grimes, Paul ; He, Jiangang ; Leif Lindholm ; Andrew Fish Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for archs [AMD Official Use Only - General] Thanks Ray, here are my responses. https://github.com/tianocore-docs/edk2-CCodingStandardsSpecification/pull/2 @Kinney, Michae

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-30 Thread Michael D Kinney
y ; Attar, AbdulLateef (Abdul Lateef) > ; Sunil V L > ; devel@edk2.groups.io; Kinney, Michael D > > Cc: lichao ; Kirkendall, Garrett > ; Grimes, Paul ; He, > Jiangang ; Leif Lindholm ; > Andrew Fish > Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-30 Thread Chang, Abner via groups.io
sage- > > From: Attar, AbdulLateef (Abdul Lateef) > > Sent: Thursday, September 29, 2022 3:11 PM > > To: Chang, Abner ; Sunil V L > > ; devel@edk2.groups.io; Ni, Ray > > > > Cc: Kinney, Michael D ; lichao > > ; Kirkendall, Garrett > > ; Grim

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-29 Thread Chang, Abner via groups.io
; ; He, Jiangang ; Attar, > AbdulLateef (Abdul Lateef) ; Leif Lindholm > ; Andrew Fish > Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for > archs > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, click

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-29 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
; Attar, AbdulLateef (Abdul Lateef) ; Leif Lindholm ; Andrew Fish Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for archs [AMD Official Use Only - General] I just had created PR to update edkII C coding standard spec for the file and directory naming. We can review

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-29 Thread Sunil V L
On Thu, Sep 29, 2022 at 02:54:05PM +, Chang, Abner wrote: > [AMD Official Use Only - General] > > Hi Sunil, > One more thing other than the module reconstruction for archs before you > sending patch to edk2: > Not sure how would you do on migrating the RISC-V code from edk2-platforms to > ed

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-29 Thread Chang, Abner via groups.io
com > Cc: Chang, Abner ; Kinney, Michael D > ; lichao ; Kirkendall, > Garrett ; Grimes, Paul > ; He, Jiangang ; Attar, > AbdulLateef (Abdul Lateef) ; Leif Lindholm > ; Andrew Fish > Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for > archs >

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-29 Thread Ni, Ray
y > Cc: abner.ch...@amd.com; Kinney, Michael D > ; lichao ; Kirkendall, > Garrett ; Grimes, Paul > ; He, Jiangang ; Attar, > AbdulLateef (Abdul Lateef) ; Leif Lindholm > ; Andrew Fish > Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for > archs > &g

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-29 Thread Ni, Ray
2 3:11 PM > To: Chang, Abner ; Sunil V L > ; devel@edk2.groups.io; Ni, Ray > > Cc: Kinney, Michael D ; lichao > ; Kirkendall, Garrett ; > Grimes, Paul ; He, Jiangang > ; Leif Lindholm ; > Andrew Fish > Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction fo

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-28 Thread Chang, Abner via groups.io
t; To: devel@edk2.groups.io; ray...@intel.com > Cc: Chang, Abner ; Kinney, Michael D > ; lichao ; Kirkendall, > Garrett ; Grimes, Paul > ; He, Jiangang ; Attar, > AbdulLateef (Abdul Lateef) ; Leif Lindholm > ; Andrew Fish > Subject: Re: [edk2-devel] The principles of EDK2

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-28 Thread Sunil V L
On Wed, Sep 28, 2022 at 03:33:45AM +, Ni, Ray wrote: Hi Ray, > > 1. When a new arch's implementation is introduced to the existing module > which was developed for the specific arch: > > 1. The folder reconstruction: > > * Create arch folder for the existing arch implementation >

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-27 Thread Chang, Abner via groups.io
Fish Subject: RE: [edk2-devel] The principles of EDK2 module reconstruction for archs Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Abner, I think we Mike’s first email regarding the package structure is a

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-27 Thread Ni, Ray
Fish Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for archs [AMD Official Use Only - General] From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> On Behalf Of Ni, Ray via groups.io Sent: Wednesday, September 28, 2022

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-27 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] We had the conversation this morning regarding the proper place for the file/module naming rule. The proposal is the naming rule content would be documented in "edk2 C coding standard spec", and the "The principles of EDK2 module reconstruction for archs" would

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-27 Thread Chang, Abner via groups.io
, AbdulLateef (Abdul Lateef) ; Leif Lindholm ; Andrew Fish Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for archs Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. The [Arch] refers to the

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-27 Thread Ni, Ray
Mike, Has following content already been documented somewhere? It looks good to me. Very good abstraction of existing cases. Maybe there are some lib/modules that don’t follow this rule. But the number should be very small. But I didn’t check how ARM constructs the pkg. So it’s very welcomed to

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-27 Thread Ni, Ray
The [Arch] refers to the Processor Architecture. The [Module] refer to the EDK2 module. The [X86] refers to both IA32 and X64. The principles to create the X86 folder in the module: 1. When X86-vendor's implementation is introduced to the existing module: 1. The folder reconstruction: A-1.

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-27 Thread Chang, Abner via groups.io
gt;; Attar, AbdulLateef (Abdul Lateef) mailto:abdullateef.at...@amd.com>>; Leif Lindholm mailto:quic_llind...@quicinc.com>>; Andrew Fish mailto:af...@apple.com>> Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for archs [AMD Official Use Only - General] Thanks

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

2022-09-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Thanks for the reply Mike, >>> I think it would be good to clarify when a difference in implementation is >>> due to a CPU Arch difference or a Vendor implementation difference. Right, we can have a paragraph to clarify the difference of CPU Arch or a vendor imp