Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

; Stuart Yoder ; gao...@byosoft.com.cn *Subject:* Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up Hi Edhay, Do I need to retest based on the edk2-test-rc2_202405 tag? Thanks, Chao On 2024/5/10 10:43, G Edhaya Chandran wrote

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

: devel@edk2.groups.io; G Edhaya Chandran ; David Wright ; Heinrich Schuchardt Cc: Alex Fox ; Stuart Yoder ; gao...@byosoft.com.cn Subject: Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up Hi Edhay, Do I need to retest based on the

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

Hi Edhay, Do I need to retest based on the edk2-test-rc2_202405 tag? Thanks, Chao On 2024/5/10 10:43, G Edhaya Chandran wrote: Thank you, David. The results are well received. With Warm Regards, Edhay *From:*David Wright *Sent:* Thursday, May 9, 2024 3:23 PM *To:* G Edhaya Chandran ; Hein

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

Thank you, David. The results are well received. With Warm Regards, Edhay From: David Wright Sent: Thursday, May 9, 2024 3:23 PM To: G Edhaya Chandran ; Heinrich Schuchardt Cc: Alex Fox ; lic...@loongson.cn; Stuart Yoder ; devel@edk2.groups.io; gao...@byosoft.com.cn Subject: RE: edk2-test Re

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

Hi all, Phoenix has completed testing on edk2-test-rc2_202405 Results have been uploaded to their respective folders. [cid:image001.png@01DAA213.C980F100] Thanks, David Wright QA Team Leader david_wri...@phoenix.com 503-730-4537 Tel [cid:image002.jpg@01DAA213.C

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

Hi Heinrich, The folder structure for edk2-test-rc2_202405 is created: https://members.uefi.org/wg/utwg/document/folder/128 With Warm Regards, Edhay > -Original Message- > From: Heinrich Schuchardt > Sent: Sunday, May 5, 2024 5:22 PM > To: G Edhaya Chandran > Cc: alex_...@phoenix.c

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

On 5/4/24 01:47, G Edhaya Chandran wrote: Hi All,    A new release candidate is published after upstreaming Stuart's commits on build cleanup. _https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405_ The updates since

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

On 27.02.24 07:37, Chao Li wrote: DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (&IpStr1, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, whic

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

The patch is upstreamed through the commit: https://github.com/tianocore/edk2-test/commit/cabb98d44be94e7547605435a0be7c4946d10f8b -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116022): https://edk2.groups.io/g/devel/message/116022 Mute

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

, 2024 1:34 PM *To:* devel@edk2.groups.io; G Edhaya Chandran *Subject:* Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c Hi Edhaya, Thanks for you review, I have created a PR on Github: https://github.com/tianocore/edk2-test/pull/87 Thanks

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

Hi Li Chao, As per the maintenance process, I will raise a PR on your behalf based on your patch. And will later close your PR. With Warm Regards, Edhay From: Chao Li Sent: Tuesday, February 27, 2024 1:34 PM To: devel@edk2.groups.io; G Edhaya Chandran Subject: Re: [edk2-devel] [edk2

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

Hi Edhaya, Thanks for you review, I have created a PR on Github: https://github.com/tianocore/edk2-test/pull/87 Thanks, Chao On 2024/2/27 15:50, G Edhaya Chandran wrote: Hi Li Chao, Thank you for the solution. Reviewed OK. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.i

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

Hi Li Chao, Thank you for the solution. Reviewed OK. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116007): https://edk2.groups.io/g/devel/message/116007 Mute This Topic: https://groups.io/mt/104598721/21

Re: [edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c

Hello Charles, On 2/24/24 17:01, Charles Hyde wrote: > There is a bug in the following source file: > > uefi-sct\ > SctPkg\ > TestCase\ > UEFI\ >EFI\ > Protocol\ > DevicePathFromText\ > BlackBoxTest\ >

Re: [edk2-devel] [edk2-test][PATCH v1 0/4] uefi-sct/SctPkg: Add SCT Documents

Thank you Samer. The test case spec is consolidated and upstreamed by:  https://github.com/tianocore/edk2-test/commit/f999690054b56780f5efbe0999507d7176bd87f6 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115661): https://edk2.groups.io

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

On Thu, 20 Jul 2023 at 16:30, G Edhaya Chandran wrote: > > The patch is upstreamed by: > https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4 Checking the memory map for memory below 4G only makes sense if the system has no IOMMU and does not use translation for

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

The patch is upstreamed by:  https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107101): https://edk2.groups.io/g/devel/message/107101 Mute This Topic: htt

Re: [edk2-devel] [edk2-test]

John, The UEFI Forum (https://uefi.org/) is the industry trade group that owns the UEFI and ACPI specifications. It also hosts the SCTs: https://uefi.org/testtools Thanks, Andrew Fish > On Jul 17, 2023, at 9:31 AM, Sellock, John via groups.io > wrote: > > Hello, > > I am John Sellock, an

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

Reviewed the patch with Stuart and Edhaya in edk2-test monthly meeting. The patch looks good to me. Thanks, Dimitrije. Reviewed-by: Sunny Wang -Original Message- From: Dimitrije Pavlov Sent: 10 October 2022 03:06 To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Jeff Booher-Kaeding ; S

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

Reviewed-by: G Edhaya Chandran Refactoring suggestion: Can the code for checking of the UsableMemoryBelow4G moved to a function? Since it is used in two places. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96831): https://edk2.groups

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

Hi Dimitrije, For some cases, the above solution may not scale for a system that is capable of allocating 64 bit addresses (> 4 GiB). This may prevent the test from running the full coverage on 64 bit system. A possible case: The UEFI-SCT is executing this test on a 64 bit machine. So far, the m

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

Upstreamed through commit :  https://github.com/tianocore/edk2-test/commit/4a25c3b3c79f63bd9f98b4fffcb21b5c66dd14bb -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91525): https://edk2.groups.io/g/devel/message/91525 Mute This Topic: https

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91524): https://edk2.groups.io/g/devel/message/91524 Mute This Topic: https://groups.io/mt/92068027/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

Looks good to me. Thanks for fixing the issue, Dimitrije. Add Chandni. She has run into this issue as well. Reviewed-by: Sunny Wang -Original Message- From: Dimitrije Pavlov Sent: 29 June 2022 16:59 To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Jeff Booher-Kaeding ; Samer El-Haj-Mah

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

Solution is upstreamed through commit:  https://github.com/tianocore/edk2-test/commit/d919c4a5d9fe2681de4d11a0bbfb07373fe6f9c7 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86356): https://edk2.groups.io/g/devel/message/86356 Mute This T

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow some SNP functions to return EFI_UNSUPPORTED

The solution is upstreamed through commit-id:  https://github.com/tianocore/edk2-test/commit/733a11dceaa043e9e5f95e9e224442f134d0975f -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86355): https://edk2.groups.io/g/devel/message/86355 Mute

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86252): https://edk2.groups.io/g/devel/message/86252 Mute This Topic: https://groups.io/mt/88360183/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow some SNP functions to return EFI_UNSUPPORTED

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86250): https://edk2.groups.io/g/devel/message/86250 Mute This Topic: https://groups.io/mt/88360239/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

I'm just aware that it is difficult to review this patch as it includes white space changes (Trimming the trailing space and transferring TABs to spaces) for edk2 coding-standard compliance. Therefore, please use the link below that hides white spaces changes to review the changes. Thanks for Ed

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

, Supreeth Subject: Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain [CAUTION: External Email] On 10/26/21 13:42, Abdul Lateef Attar via groups.io wrote: > Corrects the function declaration/definition by adding EFIAPI. > Removes duplicate fun

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

On 10/26/21 13:42, Abdul Lateef Attar via groups.io wrote: Corrects the function declaration/definition by adding EFIAPI. Removes duplicate functions. Unfortunately this mail is not a valid patch: $ wget https://patchew.org/EDK2/20211026114226.30761-1-abdat...@amd.com/mbox $ git am mbox --kee

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

This patch is upstreamed through the commit-id: https://github.com/tianocore/edk2-test/commit/f3b3456152dacf26ec0abaa0c21a9432cc176630 > -Original Message- > From: G Edhaya Chandran > Sent: 20 August 2021 12:48 > To: Jeff Brasen ; devel@edk2.groups.io > Cc: gao...@byosoft.com.cn; Samer E

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] uefi-sct: Propose maintainers from AMD

Thanks Supreeth and Carolyn. It is nice to see AMD step up to help with SCT ! Reviewed-By: Samer El-Haj-Mahmoud samer.el-haj-mahm...@arm.com From: devel@edk2.groups.io on behalf of Supreeth Venkatesh via groups.io Sent:

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

Reviewed-by: G Edhaya Chandran > -Original Message- > From: Jeff Brasen > Sent: 12 August 2021 21:43 > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; gao...@byosoft.com.cn; > Samer El-Haj-Mahmoud ; > eric@intel.com; arvinx.c...@intel.com; Jeff Brasen (jbra...@nvidia.com) > > Subj

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

Thanks for the catch Jeff!! Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: Jeff Brasen > Sent: Thursday, August 12, 2021 12:13 PM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; > gao...@byosoft.com.cn; Samer El-Haj-Mahmoud mahm...@arm.com>; eric@intel.com; a

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

Thank you all. The solution is upstream by the commit :  https://github.com/tianocore/edk2-test/commit/e4be30440f081454d5d6f047510f484ee5bb8a88 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78950): https://edk2.groups.io/g/devel/message

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

I tested this patch on Ampere Altra system. Tested-by: Paul Yang -Original Message- From: Sunny Wang Sent: Monday, July 19, 2021 4:08 PM To: devel@edk2.groups.io Cc: Sunny Wang ; Samer El-Haj-Mahmoud ; G Edhaya Chandran ; Barton Gao ; Sunny Wang Subject: [edk2-test][PATCH v1 1/1] ue

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

Reviewed-By: Tuan Phan > On Jul 19, 2021, at 1:07 AM, Sunny Wang via groups.io > wrote: > > This is to fix the SCT BS.AllocatePages failures (not found) with the > case that the Start address is not aligned to 64k. > For example, > The following is available memory region for testing: >00

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

+Heinrich > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunny > Wang via groups.io > Sent: Monday, July 19, 2021 4:08 AM > To: devel@edk2.groups.io > Cc: Sunny Wang ; Samer El-Haj-Mahmoud > ; G Edhaya Chandran > ; Barton Gao ; > Sunny Wang > Subject: [edk2-devel] [edk2-t

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78204): https://edk2.groups.io/g/devel/message/78204 Mute This Topic: https://groups.io/mt/83439673/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: h

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78201): https://edk2.groups.io/g/devel/message/78201 Mute This Topic: https://groups.io/mt/84303611/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: h

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Gao Jie via groups.io Sent: Thursday, June 10, 2021 3:39 PM To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Samer El-Haj-Mahmoud ; Eric Jin ; Arvin Chen Subject: [edk2-devel] [edk2-t

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

Wang 主题: Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL Thanks for the review, Samer. Moreover, I just built it and tested it on my ARM system, and confirmed the issue got fixed by this patch. Without this fix, the result would be 18

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

Thanks for the review, Samer. Moreover, I just built it and tested it on my ARM system, and confirmed the issue got fixed by this patch. Without this fix, the result would be 18 tests, and 4 Errors. CreateEvent_Func: [FAILED] Passes... 14 Warnings. 0 Errors... 4 Wit

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

Reviewed-By: Samer El-Haj-Mahmoud > -Original Message- > From: Heinrich Schuchardt > Sent: Friday, June 11, 2021 5:15 AM > To: Sunny Wang ; devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; G Edhaya > Chandran ; Barton Gao > ; Michael D Kinney > Subject: Re: [edk2-test][PATCH v2 1/1] ue

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

On 11.06.21 10:35, Sunny Wang wrote: > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent failures. > > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for > exclusive use by the firmware. The creation of events by UEFI > applications, UEFI drivers, and UEFI OS Load

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

-Haj-Mahmoud ; G Edhaya Chandran ; Barton Gao ; Michael D Kinney ; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL On 11.06.21 09:07, Sunny Wang wrote: > The commit a9d1fb58 caused SCT BS.CreateEvent failu

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

On 11.06.21 09:07, Sunny Wang wrote: > The commit a9d1fb58 caused SCT BS.CreateEvent failures. > > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for > exclusive use by the firmware. The creation of events by UEFI > applications, UEFI drivers, and UEFI OS Loaders should not use

Re: [edk2-devel] edk2-test: Request for new github repo

; Desimone, Nathaniel L ; Desimone, Ashley E Cc: n...@arm.com Subject: Re: [edk2-devel] edk2-test: Request for new github repo Thanks Mike, I've not come across edkrepo before. I've been using repo becuase it is a common tool used by many projects. How does edkrepo compare? g. O

Re: [edk2-devel] edk2-test: Request for new github repo

Thanks Mike, I've not come across edkrepo before. I've been using repo becuase it is a common tool used by many projects. How does edkrepo compare? g. On 12/05/2021 16:53, Kinney, Michael D wrote: Hi Grant, There is already a repo like this in tianocore: https://github.com/tianocor

Re: [edk2-devel] edk2-test: Request for new github repo

Hi Grant, There is already a repo like this in tianocore: https://github.com/tianocore/edk2-edkrepo-manifest It is focused on manifests used by the edkrepo tool: https://github.com/tianocore/edk2-edkrepo Nate and Ashley are the maintainers. They can help you with using edkrepo

Re: [edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

Upstreamed by commit :  https://github.com/tianocore/edk2-test/commit/da461e14fe86a5f4ee03ab64b412bf5f0bfe08e9 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74844): https://edk2.groups.io/g/devel/message/74844 Mute This Topic: https://gr

Re: [edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74843): https://edk2.groups.io/g/devel/message/74843 Mute This Topic: https://groups.io/mt/81518326/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: h

Re: [edk2-devel] [edk2-test PATCHv3 3/5] SctPkg: Add RISCV64 build support

Looks good to me. Same comment as the patches 1/5 and 2/5. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Daniel Schaefer Sent: Thursday, March 4, 2021 11:21 AM To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Barton Gao ; Samer El-Haj-Mahmoud ; Eric

Re: [edk2-devel] [edk2-test PATCHv3 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

Hi Daniel, If my understanding is correct, the build flags below will be used for all the architectures. However, it looks like the compiler options "-ffreestanding -nostdinc -nostdlib" are not common enough for all the architectures. For ARM, this change is ok. However, this may not be ok for

Re: [edk2-devel] [edk2-test PATCHv3 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

Looks good to me. Same comment as patch 1/5. This only affects RISCV. Therefore, as long as you build and run SCT on the RISCV platform, this change should be fine. Reviewed-by: Sunny Wang -Original Message- From: Schaefer, Daniel Sent: Thursday, March 4, 2021 11:21 AM To: devel@edk2.gr

Re: [edk2-devel] [edk2-test PATCHv3 1/5] SctPkg: Add RISCV64 support by using Aarch64 sources

Looks good to me. This only affects RISCV. Therefore, as long as you build and run SCT on the RISCV platform, this change should be fine. Reviewed-by: Sunny Wang Best Regards, Sunny Wang -Original Message- From: Schaefer, Daniel Sent: Thursday, March 4, 2021 11:21 AM To: devel@edk2.gro

Re: [edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

Reviewed-by: Barton Gao > On 2021/3/22 14:12, Eric Jin wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3272 The goal of the Support Routine: CheckForSupportGetImage is to detect the current FMP instance's capability for supporting GetImage(). In current

Re: [edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64

Abner has reviewed and approved everything now. Other people only reviewed v2 5/5. Does anybody else have any comments? From: devel@edk2.groups.io on behalf of Daniel Schaefer Sent: Thursday, March 4, 2021 11:21 To: devel@edk2.groups.io Cc: G Edhaya Chandran ;

Re: [edk2-devel] [edk2-test PATCHv3 5/5] SctPkg: Remove trailing whitespace

Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Thursday, March 4, 2021 11:21 AM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; Cha

Re: [edk2-devel] [edk2-test PATCHv3 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Thursday, March 4, 2021 11:21 AM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; Cha

Re: [edk2-devel] [edk2-test PATCHv3 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Thursday, March 4, 2021 11:21 AM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; Cha

Re: [edk2-devel] [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

Whoops, you're right! Thanks for checking it. (I had copied the files from RiscV64 to Aarch64...) git show -w on this commit clearly shows that there have been non-whitespace changes. Will send a new series! On 2/25/21 11:07 AM, Chang, Abner (HPS SW/FW Technologist) wrote: Some non-whitespace

Re: [edk2-devel] [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

On 2/25/21 2:56 PM, Chang, Abner (HPS SW/FW Technologist) wrote: We unify build options to GCC:*_*_*_CC_FLAGS, but some options were added or removed to the specific arch e.g. for GCC:*_*_IA32_CC_FLAGS, -ffreestanding, -nostdinc, -nostdlib are added additionally because of GCC:*_*_*_CC_FLAGS?

Re: [edk2-devel] [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

We unify build options to GCC:*_*_*_CC_FLAGS, but some options were added or removed to the specific arch e.g. for GCC:*_*_IA32_CC_FLAGS, -ffreestanding, -nostdinc, -nostdlib are added additionally because of GCC:*_*_*_CC_FLAGS? For GCC:*_*_AARCH64_CC_FLAGS, some options were removed. Are those

Re: [edk2-devel] [edk2-test PATCHv2 3/5] SctPkg: Add RISCV64 build support

Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Tuesday, February 9, 2021 11:44 PM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; C

Re: [edk2-devel] [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

Some non-whitespace changes in this patch, such as SctLibPlt.h, goVirtual.S and maybe others. I think you mixed up the changes by accident? > -Original Message- > From: G Edhaya Chandran [mailto:edhaya.chand...@arm.com] > Sent: Wednesday, February 24, 2021 5:02 PM > To: Schaefer, Daniel ;

Re: [edk2-devel] [edk2-test PATCHv2 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

> -Original Message- > From: Schaefer, Daniel > Sent: Tuesday, February 9, 2021 11:44 PM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; Chang, Abner (HPS SW/FW T

Re: [edk2-devel] [edk2-test PATCHv2 1/5] SctPkg: Add RISCV64 support by using Aarch64 sources

Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Tuesday, February 9, 2021 11:44 PM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; C

Re: [edk2-devel] [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

Reviewed-by: G Edhaya Chandran > -Original Message- > From: Daniel Schaefer > Sent: 09 February 2021 21:14 > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; Abner Ch

Re: [edk2-devel] [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: Daniel Schaefer > Sent: Tuesday, February 9, 2021 10:44 AM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuc

Re: [edk2-devel] [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources

On 2/9/21 10:58 PM, Leif Lindholm wrote: On Tue, Feb 09, 2021 at 14:47:46 +0100, Heinrich Schuchardt wrote: I have no idea why the alignment would be 3 on other platforms, so I don't know how to fix it. If anyone knows more, please let me know. I'll just change the comment to say Riscv64. +.al

Re: [edk2-devel] [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources

On Tue, Feb 09, 2021 at 14:47:46 +0100, Heinrich Schuchardt wrote: > >>> I have no idea why the alignment would be 3 on other platforms, so I > >>> don't know how to fix it. > >>> If anyone knows more, please let me know. I'll just change the comment > >>> to say Riscv64. > >>> > > +.align 3 >

Re: [edk2-devel] [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources

On 09.02.21 13:42, Leif Lindholm wrote: > On Mon, Feb 08, 2021 at 18:04:45 +0100, Heinrich Schuchardt wrote: > diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S > b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S > new file mode 100644 > index ..8bc2c624 > -

Re: [edk2-devel] [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources

On Mon, Feb 08, 2021 at 18:04:45 +0100, Heinrich Schuchardt wrote: > >>> diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S > >>> b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S > >>> new file mode 100644 > >>> index ..8bc2c624 > >>> --- /dev/null > >>> +++ b/uefi-sct/SctPkg/S

Re: [edk2-devel] [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources

On 08.02.21 16:09, Daniel Schaefer wrote: > Hi Leif, > > thanks very much for the review! > I've cleaned up the patchset and addressed the issues. I'll send out > another set soon. > See comments below. > > Thanks, > Daniel > > On 12/2/20 8:04 PM, Leif Lindholm wrote: >> On Wed, Dec 02, 2020 at 00:

Re: [edk2-devel] [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg

On 08.02.21 15:30, Daniel Schaefer wrote: > On 12/2/20 1:37 AM, Heinrich Schuchardt wrote: >> On 12/1/20 6:11 PM, Daniel Schaefer wrote: >>> On 12/2/20 12:59 AM, Heinrich Schuchardt wrote: On 12/1/20 5:17 PM, Daniel Schaefer wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042

Re: [edk2-devel] [edk2-test PATCH v1 1/2] SctPkg: Add RISCV64 support

On 12/2/20 7:44 PM, Leif Lindholm wrote: On Wed, Dec 02, 2020 at 00:17:51 +0800, Daniel Schaefer wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 TODO: Need to check whether we can avoid copying Aarch64 sources. Cc: Leif Lindholm Cc: Heinrich Schuchardt Cc: Abner Chang Cc: Gil

Re: [edk2-devel] [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources

Hi Leif, thanks very much for the review! I've cleaned up the patchset and addressed the issues. I'll send out another set soon. See comments below. Thanks, Daniel On 12/2/20 8:04 PM, Leif Lindholm wrote: On Wed, Dec 02, 2020 at 00:17:52 +0800, Daniel Schaefer wrote: REF:https://bugzilla.tia

Re: [edk2-devel] [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg

On 12/2/20 1:37 AM, Heinrich Schuchardt wrote: On 12/1/20 6:11 PM, Daniel Schaefer wrote: On 12/2/20 12:59 AM, Heinrich Schuchardt wrote: On 12/1/20 5:17 PM, Daniel Schaefer wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 With this patch series we can build the UEFI SCT for RIS

Re: [edk2-devel] [edk2-test] Can't build edk2-test on x64 linux

On 01/28/21 20:10, Adriano Kultzak wrote: > Hello. > > I've been trying to build UEFI-SCT following these instructions > https://github.com/tianocore/edk2-test/blob/master/uefi-sct/HowToBuild/How%20to%20build%20SCT%20in%20UDK2017.txt > on linux Debian 10, using the latest edk2 available, also tr

Re: [edk2-devel] [edk2-test] Contributions.txt still mentions the TianoCore Contribution Agreement

On 09/24/20 23:42, Rebecca Cran wrote: > While working on the SctPkg, I noticed the Contributions.txt file in the > top of the repo still mentions the TianoCore Contribution Agreement. > Does it need updated? > > (CC'ing the other stewards) Most likely so. It's probably best to "replay" (or "p

Re: [edk2-devel] [edk2-test][PATCH v1 2/4] uefi-sct/SctPkg: Add SCT User Guide Word document

Reviewed-by: G Edhaya Chandran Upstreamed by Commit ID: https://github.com/tianocore/edk2-test/commit/9655dc86702804e11d5c233596a2aaf52bbe761e -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65541): https://edk2.groups.io/g/devel/message

Re: [edk2-devel] [edk2-test][PATCH v1 1/4] uefi-sct/SctPkg: Add SCT User Guide PDF

Reviewed-by: G Edhaya Chandran Upstreamed by Commit ID: https://github.com/tianocore/edk2-test/commit/2eaa6232f3258ec802e244018818c9eca0b27711 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65472): https://edk2.groups.io/g/devel/message

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test

Upstreamed by Commit-ID: https://github.com/tianocore/edk2-test/commit/23421e1d8393582545b01d3deee4d26e3a9f9a05 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65230): https://edk2.groups.io/g/devel/message/65230 Mute This Topic: https://g

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: typo Verity in TimeServicesBBTestFunction

Upstreamed by Commit-ID: https://github.com/tianocore/edk2-test/commit/011d3f2939d85c99445fdc5973369dc7cd706e11 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65224): https://edk2.groups.io/g/devel/message/65224 Mute This Topic: https://g

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test

Reviewed-by: G Edhaya Chandran < edhaya.chand...@arm.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65177): https://edk2.groups.io/g/devel/message/65177 Mute This Topic: https://groups.io/mt/75985187/21656 Group Owner: devel+ow...@e

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: typo Verity in TimeServicesBBTestFunction

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65176): https://edk2.groups.io/g/devel/message/65176 Mute This Topic: https://groups.io/mt/67740553/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: EFI_RNG_PROTOCOL.GetInfo check size != 0

Reviewed-by: G Edhaya Chandran Upstreamed by Commit-id: fbff897cbb92a2b41579e549d0e5b7794c48cb7a -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64306): https://edk2.groups.io/g/devel/message/64306 Mute This Topic: https://groups.io/mt/6

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

Reviewed-by: G Edhaya Chandran Upstreamed by the commit-d : 891aed7c4fee9c831812fb2d6fc2aeeac6661884 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64305): https://edk2.groups.io/g/devel/message/64305 Mute This Topic: https://groups.io/

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

@edk2.groups.io; G Edhaya Chandran > Cc: Samer El-Haj-Mahmoud ; Eric Jin > > Subject: Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix > variable > services conformance test > > On 8/4/20 1:13 PM, Samer El-Haj-Mahmoud wrote: > > Reviewed-by: Samer El-H

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

On 8/4/20 1:13 PM, Samer El-Haj-Mahmoud wrote: > Reviewed-by: Samer El-Haj-Mahmoud Dear Edhaya, could you, please, consider these patches https://edk2.groups.io/g/devel/message/63354 https://edk2.groups.io/g/devel/message/52599 for review and merging. Best regards Heinrich -=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-test][PATCH v1 3/3] uefi-sct/SctPkg: Remove obsolete version macros

Reviewed-by: G Edhaya Chandran Upstreamed by Commit: 57280728e277c66d7803592cf071d87a21654d09 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64010): https://edk2.groups.io/g/devel/message/64010 Mute This Topic: https://groups.io/mt/75759

Re: [edk2-devel] [edk2-test][PATCH v1 2/3] uefi-sct/SctPkg: Add build instructions with latest EDK2

Reviewed-by: G Edhaya Chandran Upstreamed by Commit: fd5996f2d060a090c0d4bb0107a8790221539eb9 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64009): https://edk2.groups.io/g/devel/message/64009 Mute This Topic: https://groups.io/mt/75759

Re: [edk2-devel] [edk2-test][PATCH v1 1/3] uefi-sct/SctPkg: Fix build with latest EDK2

Upstreamed by Commit: 5588ebe78620e7ee99bc56a08e964499af52a63b -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64008): https://edk2.groups.io/g/devel/message/64008 Mute This Topic: https://groups.io/mt/75759593/21656 Group Owner: devel+ow.

Re: [edk2-devel] [edk2-test][PATCH v1 0/3] uefi-sct/SctPkg: Build Aarch64 with latest EDK2

Upstreamed by Commits ID 57280728e277c66d7803592cf071d87a21654d09 fd5996f2d060a090c0d4bb0107a8790221539eb9 5588ebe78620e7ee99bc56a08e964499af52a63b -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64007): https://edk2.groups.io/g/devel/mess

Re: [edk2-devel] [edk2-test][PATCH v1 0/3] uefi-sct/SctPkg: Build Aarch64 with latest EDK2

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64006): https://edk2.groups.io/g/devel/message/64006 Mute This Topic: https://groups.io/mt/75759594/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: h

Re: [edk2-devel] [edk2-test][PATCH v1 1/3] uefi-sct/SctPkg: Fix build with latest EDK2

Reviewed-by: G Edhaya Chandran > -Original Message- > From: Samer El-Haj-Mahmoud > Sent: 24 July 2020 07:59 > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Eric Jin > ; Irene Park ; Heinrich Schuchardt > > Subject: [edk2-test][PATCH v1 1/3] uefi-sct/SctPkg: Fix build with latest ED

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: typo Verity in TimeServicesBBTestFunction

Picking up old SCT patches that were missed Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heinrich > Schuchardt via Groups.Io > Sent: Sunday, December 8, 2019 10:51 AM > To: EDK II Development > Cc: Eric Jin ; Supreeth Venkatesh > ; St

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heinrich > Schuchardt via groups.io > Sent: Monday, July 27, 2020 1:53 PM > To: EDK II Development > Cc: Eric Jin ; G Edhaya Chandran > ; Heinrich Schuchardt > Subject: [edk2-devel] [edk2-t

  1   2   3   >