Abner has reviewed and approved everything now. Other people only reviewed v2 5/5.
Does anybody else have any comments? ________________________________ From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Daniel Schaefer <daniel.schae...@hpe.com> Sent: Thursday, March 4, 2021 11:21 To: devel@edk2.groups.io <devel@edk2.groups.io> Cc: G Edhaya Chandran <edhaya.chand...@arm.com>; Barton Gao <gao...@byosoft.com.cn>; Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>; Eric Jin <eric....@intel.com>; Arvin Chen <arvinx.c...@intel.com>; Leif Lindholm <l...@nuviainc.com>; Heinrich Schuchardt <xypron.g...@gmx.de>; Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com> Subject: [edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64 Changes to previous series: - Fixed the commit to remove whitespace to *only* remove whitespace. Had some mixup there... - Added missing HPE copyright in one file I was able to run SCT on my EDK2 port to RISCV64 and I don't see any obvious failures related to this. Additionally Heinrich has tested the first series on the U-Boot implementation of UEFI. If you apply these patches or check out my branch [1] you can easily review the changes with `git diff -w master`. It will hide anything that's copied and any whitespace changes. Cheers, Daniel [1] https://github.com/johnazoidberg/edk2-test/tree/riscv64 Cc: G Edhaya Chandran <edhaya.chand...@arm.com> Cc: Barton Gao <gao...@byosoft.com.cn> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com> Cc: Eric Jin <eric....@intel.com> Cc: Arvin Chen <arvinx.c...@intel.com> Cc: Leif Lindholm <l...@nuviainc.com> Cc: Heinrich Schuchardt <xypron.g...@gmx.de> Cc: Abner Chang <abner.ch...@hpe.com> Daniel Schaefer (5): SctPkg: Add RISCV64 support by using Aarch64 sources SctPkg: Adapt Aarch64 sources for Riscv64 SctPkg: Add RISCV64 build support SctPkg: Unify CC_FLAGS for all GCC platforms SctPkg: Remove trailing whitespace uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h | 4 ++ uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h | 4 +- uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c | 6 +- uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/SctLibPlat.h | 7 ++- uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/initplat.c | 6 +- uefi-sct/SctPkg/Library/SctLib/SctLib.inf | 6 ++ uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S | 6 +- uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c | 6 +- uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/GoVirtual.S | 15 +++-- uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/VirtualMemory.c | 22 +++---- uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf | 5 ++ uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c | 8 +-- uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c | 8 +-- uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c | 8 +-- uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h | 8 +-- uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Debug.c | 28 ++++----- uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Dump.c | 8 +-- uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Io.c | 15 ++--- uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf | 6 ++ uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/DebugSupportBBTestCacheFunction.c | 6 +- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/DebugSupportBBTestExceptionCallbackFunction.c | 7 +-- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/PlatformIsa.c | 6 +- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTest.inf | 6 ++ uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/DebugSupportBBTestCacheFunction.c | 6 +- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/DebugSupportBBTestExceptionCallbackFunction.c | 18 +++--- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/PlatformIsa.c | 10 ++-- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/Usb2Hc/BlackBoxTest/Usb2HcTest.inf | 4 ++ uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/UsbHcTest.inf | 4 ++ uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLibPlat.h | 6 +- uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPlat.c | 6 +- uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf | 5 ++ uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/{Aarch64 => Riscv64}/EntsLibPlat.h | 9 +-- uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/{Aarch64 => Riscv64}/InitPlat.c | 6 +- uefi-sct/SctPkg/Tools/Source/GenBin/GNUmakefile | 4 ++ uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 30 +++++++--- uefi-sct/SctPkg/UEFI/Protocol/DebugSupport.h | 61 +++++++++++++++++++- uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc | 31 +++++++--- uefi-sct/SctPkg/build.sh | 11 +++- 38 files changed, 269 insertions(+), 143 deletions(-) copy uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/SctLibPlat.h (79%) copy uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/initplat.c (92%) copy uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/GoVirtual.S (83%) copy uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/VirtualMemory.c (85%) copy uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Debug.c (65%) copy uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Dump.c (93%) copy uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Io.c (84%) copy uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/DebugSupportBBTestCacheFunction.c (96%) copy uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/DebugSupportBBTestExceptionCallbackFunction.c (92%) copy uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/PlatformIsa.c (76%) copy uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/{Aarch64 => Riscv64}/EntsLibPlat.h (83%) copy uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/{Aarch64 => Riscv64}/InitPlat.c (92%) -- 2.30.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72847): https://edk2.groups.io/g/devel/message/72847 Mute This Topic: https://groups.io/mt/81069864/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
