Looks good to me. Reviewed-by: Sunny Wang <sunny.w...@arm.com> -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao Jie via groups.io Sent: Thursday, June 10, 2021 3:39 PM To: devel@edk2.groups.io Cc: G Edhaya Chandran <edhaya.chand...@arm.com>; Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>; Eric Jin <eric....@intel.com>; Arvin Chen <arvinx.c...@intel.com> Subject: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg, RegisterFilterLibNull which will be consumed by IoLib and BaseLib was added in MdeLibs.dsc.inc. To build UefiSct with edk2-stable202105 and later, this file must be included in dsc file. Cc: G Edhaya Chandran <edhaya.chand...@arm.com> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com> Cc: Eric Jin <eric....@intel.com> Cc: Arvin Chen <arvinx.c...@intel.com> Signed-off-by: Barton Gao <gao...@byosoft.com.cn> --- uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 2 ++ uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc | 2 ++ 2 files changed, 4 insertions(+) diff --git a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc index 3371141f..7a4393e0 100644 --- a/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc +++ b/uefi-sct/SctPkg/UEFI/IHV_SCT.dsc @@ -136,6 +136,8 @@ [Libraries.IA32,Libraries.X64] +!include MdePkg/MdeLibs.dsc.inc + [LibraryClasses.common] UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf diff --git a/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc index 2b4f415f..5b3e5307 100644 --- a/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc +++ b/uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc @@ -138,6 +138,8 @@ [Libraries.RISCV64] ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf +!include MdePkg/MdeLibs.dsc.inc + [LibraryClasses.common] UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf -- 2.31.0.windows.1 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76747): https://edk2.groups.io/g/devel/message/76747 Mute This Topic: https://groups.io/mt/83439673/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
