Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg

2024-04-17 Thread Gerd Hoffmann
On Tue, Apr 16, 2024 at 03:40:08PM +, Yao, Jiewen wrote: > Yeah, I also considered that before. But after look at current code > structure, I give up. > > Since following SEV component are NOT in AmdSev directory (especially the TCG > one), I do not see a strong reason to put them to IntelTd

Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg

2024-04-16 Thread Yao, Jiewen
> -Original Message- > From: Yao, Jiewen > Sent: Tuesday, April 16, 2024 11:40 PM > To: Gerd Hoffmann ; devel@edk2.groups.io; Xu, Min M > > Cc: Ard Biesheuvel > Subject: RE: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from > SecurityPkg > to OvmfPkg >

Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg

2024-04-16 Thread Yao, Jiewen
: Gerd Hoffmann > Sent: Tuesday, April 16, 2024 6:16 PM > To: devel@edk2.groups.io; Xu, Min M > Cc: Ard Biesheuvel ; Yao, Jiewen > > Subject: Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from > SecurityPkg > to OvmfPkg > > On Mon, Apr 15, 2024 at 03:55:49PM +

Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg

2024-04-16 Thread Gerd Hoffmann
On Mon, Apr 15, 2024 at 03:55:49PM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4752 > > HashLibTdx and TdTcg2Dxe are designed for Intel TDX enlightened OVMF. > They're more reasonable to be put in OvmfPkg than in SecurityPkg. > > SecTpmMeasurementLibTdx is not used a

Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg

2024-04-16 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Monday, April 15, 2024 3:59 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Gerd Hoffmann > Subject: RE: [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg > > The code is at: http

Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg

2024-04-15 Thread Min Xu
The code is at: https://github.com/mxu9/edk2/tree/move_tdx.v1 > -Original Message- > From: Xu, Min M > Sent: Monday, April 15, 2024 3:56 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Ard Biesheuvel > ; Yao, Jiewen ; Gerd > Hoffmann > Subject: [PATCH V1 0/5] Move Tdx specific lib from S