Yeah, I also considered that before. But after look at current code structure, I give up.
Since following SEV component are NOT in AmdSev directory (especially the TCG one), I do not see a strong reason to put them to IntelTdx dir. https://github.com/tianocore/edk2/tree/master/OvmfPkg/AmdSevDxe https://github.com/tianocore/edk2/tree/master/OvmfPkg/Tcg/TpmMmioSevDecryptPei https://github.com/tianocore/edk2/tree/master/OvmfPkg/Library/BaseMemEncryptSevLib I think we can follow the existing code structure in this patch set. Thank you Yao, Jiewen > -----Original Message----- > From: Gerd Hoffmann <kra...@redhat.com> > Sent: Tuesday, April 16, 2024 6:16 PM > To: devel@edk2.groups.io; Xu, Min M <min.m...@intel.com> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>; Yao, Jiewen > <jiewen....@intel.com> > Subject: Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from > SecurityPkg > to OvmfPkg > > On Mon, Apr 15, 2024 at 03:55:49PM +0800, Min Xu wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4752 > > > > HashLibTdx and TdTcg2Dxe are designed for Intel TDX enlightened OVMF. > > They're more reasonable to be put in OvmfPkg than in SecurityPkg. > > > > SecTpmMeasurementLibTdx is not used anymore. So it is deleted in this > > patch-set. > > > > > rename {SecurityPkg => OvmfPkg}/Library/HashLibTdx/HashLibTdx.c (100%) > > rename {SecurityPkg => OvmfPkg}/Library/HashLibTdx/HashLibTdx.inf (100%) > > rename {SecurityPkg => OvmfPkg}/Tcg/TdTcg2Dxe/MeasureBootPeCoff.c > (100%) > > rename {SecurityPkg => OvmfPkg}/Tcg/TdTcg2Dxe/TdTcg2Dxe.c (100%) > > rename {SecurityPkg => OvmfPkg}/Tcg/TdTcg2Dxe/TdTcg2Dxe.inf (100%) > > Better place them in OvmfPkg/IntelTdx ? > > Otherwise looks fine to me. > > take care, > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117887): https://edk2.groups.io/g/devel/message/117887 Mute This Topic: https://groups.io/mt/105531957/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
