I have merged this one https://github.com/tianocore/edk2/pull/5566
Hi Gerd If you prefer that we move all TDX / SEV specific component to IntelTdx and AmdSev, I am OK with that. Personally, I like your idea. Please submit Bugzilla and work on it, if you would like to. Thank you Yao, Jiewen > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, April 16, 2024 11:40 PM > To: Gerd Hoffmann <kra...@redhat.com>; devel@edk2.groups.io; Xu, Min M > <min.m...@intel.com> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Subject: RE: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from > SecurityPkg > to OvmfPkg > > Yeah, I also considered that before. But after look at current code > structure, I give > up. > > Since following SEV component are NOT in AmdSev directory (especially the TCG > one), I do not see a strong reason to put them to IntelTdx dir. > https://github.com/tianocore/edk2/tree/master/OvmfPkg/AmdSevDxe > https://github.com/tianocore/edk2/tree/master/OvmfPkg/Tcg/TpmMmioSevDec > ryptPei > https://github.com/tianocore/edk2/tree/master/OvmfPkg/Library/BaseMemEncr > yptSevLib > > I think we can follow the existing code structure in this patch set. > > Thank you > Yao, Jiewen > > > > -----Original Message----- > > From: Gerd Hoffmann <kra...@redhat.com> > > Sent: Tuesday, April 16, 2024 6:16 PM > > To: devel@edk2.groups.io; Xu, Min M <min.m...@intel.com> > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>; Yao, Jiewen > > <jiewen....@intel.com> > > Subject: Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from > > SecurityPkg > > to OvmfPkg > > > > On Mon, Apr 15, 2024 at 03:55:49PM +0800, Min Xu wrote: > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4752 > > > > > > HashLibTdx and TdTcg2Dxe are designed for Intel TDX enlightened OVMF. > > > They're more reasonable to be put in OvmfPkg than in SecurityPkg. > > > > > > SecTpmMeasurementLibTdx is not used anymore. So it is deleted in this > > > patch-set. > > > > > > > > rename {SecurityPkg => OvmfPkg}/Library/HashLibTdx/HashLibTdx.c (100%) > > > rename {SecurityPkg => OvmfPkg}/Library/HashLibTdx/HashLibTdx.inf (100%) > > > rename {SecurityPkg => OvmfPkg}/Tcg/TdTcg2Dxe/MeasureBootPeCoff.c > > (100%) > > > rename {SecurityPkg => OvmfPkg}/Tcg/TdTcg2Dxe/TdTcg2Dxe.c (100%) > > > rename {SecurityPkg => OvmfPkg}/Tcg/TdTcg2Dxe/TdTcg2Dxe.inf (100%) > > > > Better place them in OvmfPkg/IntelTdx ? > > > > Otherwise looks fine to me. > > > > take care, > > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117892): https://edk2.groups.io/g/devel/message/117892 Mute This Topic: https://groups.io/mt/105531957/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
