[edk2-devel] EDK2-TEST/EMS: TimeStamp overflow

2024-09-23 Thread wzssyqa+uefi
In file /edk2-test/uefi-sct/EMS/Src/EmsRpc/EmsRpcEth.c, there are line like: GetSystemTime ( & Time); FillCnlLlFlag (Packet, LastSendSeq, LINK_OPERATION_CLEANUP, 0 , FALSE ); TimeStamp += ((UINT64) Time. wYear * 12 * 31 * 24 * 60 * 60 ); TimeStamp += ((UINT64) Time. wMonth * 31 * 24 * 60 * 60 );

[edk2-devel] edk2-test bug triage meeting MoM - 5th Sept 2024

2024-09-06 Thread G Edhaya Chandran
Hi All, Below is the MoM for edk2-test bug triage meeting, 5th September 2024 Attendees Company Attendees Arm Ann Cheng, Prachotan Bathi, G Edhaya Chandran Lenovo Steve, Zhouyf ID

[edk2-devel] edk2-test-stable202406 release is published

2024-06-17 Thread G Edhaya Chandran
Hi All, edk2-test-stable202406 release is published. Tag: edk2-test-stable202406 New Features: * Added New TCG2 protocol tests based on TCG2 specification prescribe by Arm BBSR specification. * Added New TCG2 MOR tests * SCT case specification documentation is adapted, updated an

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-10 Thread Chao Li
; Stuart Yoder ; gao...@byosoft.com.cn *Subject:* Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up Hi Edhay, Do I need to retest based on the edk2-test-rc2_202405 tag? Thanks, Chao On 2024/5/10 10:43, G Edhaya Chandran wrote

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-10 Thread G Edhaya Chandran
: devel@edk2.groups.io; G Edhaya Chandran ; David Wright ; Heinrich Schuchardt Cc: Alex Fox ; Stuart Yoder ; gao...@byosoft.com.cn Subject: Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up Hi Edhay, Do I need to retest based on the

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-09 Thread Chao Li
Hi Edhay, Do I need to retest based on the edk2-test-rc2_202405 tag? Thanks, Chao On 2024/5/10 10:43, G Edhaya Chandran wrote: Thank you, David. The results are well received. With Warm Regards, Edhay *From:*David Wright *Sent:* Thursday, May 9, 2024 3:23 PM *To:* G Edhaya Chandran ; Hein

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-09 Thread G Edhaya Chandran
Thank you, David. The results are well received. With Warm Regards, Edhay From: David Wright Sent: Thursday, May 9, 2024 3:23 PM To: G Edhaya Chandran ; Heinrich Schuchardt Cc: Alex Fox ; lic...@loongson.cn; Stuart Yoder ; devel@edk2.groups.io; gao...@byosoft.com.cn Subject: RE: edk2-test Re

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-09 Thread David Wright
Hi all, Phoenix has completed testing on edk2-test-rc2_202405 Results have been uploaded to their respective folders. [cid:image001.png@01DAA213.C980F100] Thanks, David Wright QA Team Leader david_wri...@phoenix.com 503-730-4537 Tel [cid:image002.jpg@01DAA213.C

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

2024-05-06 Thread G Edhaya Chandran
Hi Heinrich, The folder structure for edk2-test-rc2_202405 is created: https://members.uefi.org/wg/utwg/document/folder/128 With Warm Regards, Edhay > -Original Message- > From: Heinrich Schuchardt > Sent: Sunday, May 5, 2024 5:22 PM > To: G Edhaya Chandran > Cc: alex_...@phoenix.c

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

2024-05-05 Thread Heinrich Schuchardt
On 5/4/24 01:47, G Edhaya Chandran wrote: Hi All,    A new release candidate is published after upstreaming Stuart's commits on build cleanup. _https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405_ The updates since

[edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-03 Thread G Edhaya Chandran
Hi All, A new release candidate is published after upstreaming Stuart's commits on build cleanup. https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405 The updates since the old tag are the following commits in the patch series: [PATCH v2 0/4] TCG2 protocol clean up (groups.io)

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Heinrich Schuchardt
On 27.02.24 07:37, Chao Li wrote: DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (&IpStr1, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, whic

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread G Edhaya Chandran
The patch is upstreamed through the commit: https://github.com/tianocore/edk2-test/commit/cabb98d44be94e7547605435a0be7c4946d10f8b -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116022): https://edk2.groups.io/g/devel/message/116022 Mute

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Chao Li
, 2024 1:34 PM *To:* devel@edk2.groups.io; G Edhaya Chandran *Subject:* Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c Hi Edhaya, Thanks for you review, I have created a PR on Github: https://github.com/tianocore/edk2-test/pull/87 Thanks

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread G Edhaya Chandran
Hi Li Chao, As per the maintenance process, I will raise a PR on your behalf based on your patch. And will later close your PR. With Warm Regards, Edhay From: Chao Li Sent: Tuesday, February 27, 2024 1:34 PM To: devel@edk2.groups.io; G Edhaya Chandran Subject: Re: [edk2-devel] [edk2

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-27 Thread Chao Li
Hi Edhaya, Thanks for you review, I have created a PR on Github: https://github.com/tianocore/edk2-test/pull/87 Thanks, Chao On 2024/2/27 15:50, G Edhaya Chandran wrote: Hi Li Chao, Thank you for the solution. Reviewed OK. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.i

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread G Edhaya Chandran
Hi Li Chao, Thank you for the solution. Reviewed OK. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116007): https://edk2.groups.io/g/devel/message/116007 Mute This Topic: https://groups.io/mt/104598721/21

[edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread Chao Li
DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (&IpStr1, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, which will point to an unknown address.

Re: [edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c

2024-02-25 Thread Laszlo Ersek
Hello Charles, On 2/24/24 17:01, Charles Hyde wrote: > There is a bug in the following source file: > > uefi-sct\ > SctPkg\ > TestCase\ > UEFI\ >EFI\ > Protocol\ > DevicePathFromText\ > BlackBoxTest\ >

[edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c

2024-02-24 Thread Charles Hyde
There is a bug in the following source file: uefi-sct\ SctPkg\ TestCase\ UEFI\ EFI\ Protocol\ DevicePathFromText\ BlackBoxTest\ DevicePathFromTextBBTestCoverage.c Lines 1737, 1738, 1742, and 1743

Re: [edk2-devel] [edk2-test][PATCH v1 0/4] uefi-sct/SctPkg: Add SCT Documents

2024-02-20 Thread G Edhaya Chandran
Thank you Samer. The test case spec is consolidated and upstreamed by:  https://github.com/tianocore/edk2-test/commit/f999690054b56780f5efbe0999507d7176bd87f6 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115661): https://edk2.groups.io

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2023-07-20 Thread Ard Biesheuvel
On Thu, 20 Jul 2023 at 16:30, G Edhaya Chandran wrote: > > The patch is upstreamed by: > https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4 Checking the memory map for memory below 4G only makes sense if the system has no IOMMU and does not use translation for

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2023-07-20 Thread G Edhaya Chandran
The patch is upstreamed by:  https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107101): https://edk2.groups.io/g/devel/message/107101 Mute This Topic: htt

Re: [edk2-devel] [edk2-test]

2023-07-18 Thread Andrew Fish via groups.io
John, The UEFI Forum (https://uefi.org/) is the industry trade group that owns the UEFI and ACPI specifications. It also hosts the SCTs: https://uefi.org/testtools Thanks, Andrew Fish > On Jul 17, 2023, at 9:31 AM, Sellock, John via groups.io > wrote: > > Hello, > > I am John Sellock, an

[edk2-devel] [edk2-test]

2023-07-18 Thread Sellock, John via groups.io
Hello, I am John Sellock, an Associate Software Engineering Technician at Leonardo DRS. I believe I need Self-Certification Test source code for UEFI 2.5, but I cannot find any saved archive for it available in the tianocore or edk2-test repositories. I would appreciate if someone could point

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2022-12-01 Thread Sunny Wang
Reviewed the patch with Stuart and Edhaya in edk2-test monthly meeting. The patch looks good to me. Thanks, Dimitrije. Reviewed-by: Sunny Wang -Original Message- From: Dimitrije Pavlov Sent: 10 October 2022 03:06 To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Jeff Booher-Kaeding ; S

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2022-12-01 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran Refactoring suggestion: Can the code for checking of the UsableMemoryBelow4G moved to a function? Since it is used in two places. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96831): https://edk2.groups

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2022-11-29 Thread G Edhaya Chandran
Hi Dimitrije, For some cases, the above solution may not scale for a system that is capable of allocating 64 bit addresses (> 4 GiB). This may prevent the test from running the full coverage on 64 bit system. A possible case: The UEFI-SCT is executing this test on a 64 bit machine. So far, the m

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2022-10-09 Thread Dimitrije Pavlov
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4009 Check if there is usable memory below 4 GiB before testing for allocation without the EFI_PCI_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute. Cc: G Edhaya Chandran Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Cc: Sunny Wang Signed-off-by:

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

2022-07-19 Thread G Edhaya Chandran
Upstreamed through commit :  https://github.com/tianocore/edk2-test/commit/4a25c3b3c79f63bd9f98b4fffcb21b5c66dd14bb -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91525): https://edk2.groups.io/g/devel/message/91525 Mute This Topic: https

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

2022-07-19 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91524): https://edk2.groups.io/g/devel/message/91524 Mute This Topic: https://groups.io/mt/92068027/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

2022-07-14 Thread Sunny Wang
Looks good to me. Thanks for fixing the issue, Dimitrije. Add Chandni. She has run into this issue as well. Reviewed-by: Sunny Wang -Original Message- From: Dimitrije Pavlov Sent: 29 June 2022 16:59 To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Jeff Booher-Kaeding ; Samer El-Haj-Mah

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

2022-06-29 Thread Dimitrije Pavlov
According to UEFI 2.9 Section 12.9, the PixelInformation field of the EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure is valid only if PixelFormat is PixelBitMask. The current implementation always checks the contents of PixelInformation field of the EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure re

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

2022-02-02 Thread G Edhaya Chandran
Solution is upstreamed through commit:  https://github.com/tianocore/edk2-test/commit/d919c4a5d9fe2681de4d11a0bbfb07373fe6f9c7 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86356): https://edk2.groups.io/g/devel/message/86356 Mute This T

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow some SNP functions to return EFI_UNSUPPORTED

2022-02-02 Thread G Edhaya Chandran
The solution is upstreamed through commit-id:  https://github.com/tianocore/edk2-test/commit/733a11dceaa043e9e5f95e9e224442f134d0975f -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86355): https://edk2.groups.io/g/devel/message/86355 Mute

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

2022-01-31 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86252): https://edk2.groups.io/g/devel/message/86252 Mute This Topic: https://groups.io/mt/88360183/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow some SNP functions to return EFI_UNSUPPORTED

2022-01-31 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86250): https://edk2.groups.io/g/devel/message/86250 Mute This Topic: https://groups.io/mt/88360239/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

2022-01-31 Thread Sunny Wang
ang ; G Edhaya Chandran ; Barton Gao ; Carolyn Gjertsen ; Heinrich Schuchardt ; Samer El-Haj-Mahmoud ; Sunny Wang Subject: [edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3738 The Simp

[edk2-devel] [edk2-test][PATCH v1] uefi-sct/SctPkg: Allow SimpleTextOut SetMode to return EFI_UNSUPPORTED

2022-01-11 Thread Sunny Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3738 The SimpleTestOut test cases don't allow SetMode to return EFI_UNSUPPORTED, which doesn't comply with UEFI spec. UEFI spec allows EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetMode function to return EFI_UNSUPPORTED for the condition below: if the outpu

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-11-12 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
, Supreeth Subject: Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain [CAUTION: External Email] On 10/26/21 13:42, Abdul Lateef Attar via groups.io wrote: > Corrects the function declaration/definition by adding EFIAPI. > Removes duplicate fun

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-11-11 Thread Heinrich Schuchardt
On 10/26/21 13:42, Abdul Lateef Attar via groups.io wrote: Corrects the function declaration/definition by adding EFIAPI. Removes duplicate functions. Unfortunately this mail is not a valid patch: $ wget https://patchew.org/EDK2/20211026114226.30761-1-abdat...@amd.com/mbox $ git am mbox --kee

[edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-10-26 Thread Abdul Lateef Attar via groups.io
Corrects the function declaration/definition by adding EFIAPI. Removes duplicate functions. Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Signed-off-by: Abdul Lateef Attar --- uefi-sct/SctPkg/TestCase

[edk2-devel] [edk2-test] [PATCH v1 0/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-10-26 Thread Abdul Lateef Attar via groups.io
Resubmitting patch with correct format and email ids. Corrects the function declaration/definition by adding EFIAPI. Removes duplicate functions. Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Signed-off

[edk2-devel] [[edk2-test] PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-10-07 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar From: Your Name Signed-off-by: Abdul Lateef Attar --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTestMain.h | 1 + uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromText/BlackBoxTest/DevicePathFromTex

[edk2-devel] [edk2-test] [PATCH v1 0/1] SctPkg: Fix X64 build errors for GCC toolchain

2021-10-07 Thread Abdul Lateef Attar via groups.io
Removes duplicate function definations. Adds EFIAPI to function definations/declerations. Abdul Lateef Attar (1): SctPkg: Fix X64 build errors for GCC toolchain uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTestMain.h | 1 + uefi-sct/Sc

[edk2-devel] edk2-test-stable202108 is Released

2021-08-25 Thread G Edhaya Chandran
Hello All, edk2-test-stable202108 is now released. Please refer to the link for more details : https://github.com/tianocore/edk2-test/releases/tag/edk2-test-stable202108 Thanking you all for your contributions. Please feel free to contact me or Barton for any clarifications. With Warm Regar

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

2021-08-23 Thread G Edhaya Chandran
This patch is upstreamed through the commit-id: https://github.com/tianocore/edk2-test/commit/f3b3456152dacf26ec0abaa0c21a9432cc176630 > -Original Message- > From: G Edhaya Chandran > Sent: 20 August 2021 12:48 > To: Jeff Brasen ; devel@edk2.groups.io > Cc: gao...@byosoft.com.cn; Samer E

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] uefi-sct: Propose maintainers from AMD

2021-08-20 Thread Samer El-Haj-Mahmoud
Sent: Thursday, August 19, 2021 2:50:42 PM To: devel@edk2.groups.io Cc: carolyn.gjert...@amd.com ; Supreeth Venkatesh Subject: [edk2-devel] [edk2-test] [PATCH v1 1/1] uefi-sct: Propose maintainers from AMD This patch proposes Carolyn Gjertsen as maintainer of edk2-test repository and Su

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

2021-08-20 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran > -Original Message- > From: Jeff Brasen > Sent: 12 August 2021 21:43 > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; gao...@byosoft.com.cn; > Samer El-Haj-Mahmoud ; > eric@intel.com; arvinx.c...@intel.com; Jeff Brasen (jbra...@nvidia.com) > > Subj

[edk2-devel] [edk2-test] [PATCH v1 1/1] uefi-sct: Propose maintainers from AMD

2021-08-19 Thread Supreeth Venkatesh via groups.io
This patch proposes Carolyn Gjertsen as maintainer of edk2-test repository and Supreeth Venkatesh as reviewer from AMD. Signed-off-by: Supreeth Venkatesh --- uefi-sct/Maintainers.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/uefi-sct/Maintainers.txt b/uefi-sct/Maintainers.txt index c

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

2021-08-12 Thread Samer El-Haj-Mahmoud
Thanks for the catch Jeff!! Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: Jeff Brasen > Sent: Thursday, August 12, 2021 12:13 PM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; > gao...@byosoft.com.cn; Samer El-Haj-Mahmoud mahm...@arm.com>; eric@intel.com; a

[edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

2021-08-12 Thread Jeff Brasen via groups.io
SctAPrint uses boot services functions but is called after ExitBootServices. Replace with call to Printf which is safe for use in runtime. Signed-off-by: Jeff Brasen --- .../SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c | 52 +-- uefi-sct/SctPkg/SCRT/SCRTDriver/Arm/Dump.c| 52 +++

[edk2-devel] edk2-test Release Notice

2021-08-10 Thread G Edhaya Chandran
Hello All, This mail is to notify that the edk2-test repository shall be released by end of August 2021 with the tag edk2-test-stable202108. The base-line commit shall be: 814b2af535d977b3967d65de77e42ab18a4f4db4 Please feel free to contact me or Barton for any clarifications. With Warm R

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-08-09 Thread G Edhaya Chandran
Thank you all. The solution is upstream by the commit :  https://github.com/tianocore/edk2-test/commit/e4be30440f081454d5d6f047510f484ee5bb8a88 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78950): https://edk2.groups.io/g/devel/message

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-08-04 Thread Paul Yang
I tested this patch on Ampere Altra system. Tested-by: Paul Yang -Original Message- From: Sunny Wang Sent: Monday, July 19, 2021 4:08 PM To: devel@edk2.groups.io Cc: Sunny Wang ; Samer El-Haj-Mahmoud ; G Edhaya Chandran ; Barton Gao ; Sunny Wang Subject: [edk2-test][PATCH v1 1/1] ue

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-08-03 Thread Tuan Phan via groups.io
Reviewed-By: Tuan Phan > On Jul 19, 2021, at 1:07 AM, Sunny Wang via groups.io > wrote: > > This is to fix the SCT BS.AllocatePages failures (not found) with the > case that the Start address is not aligned to 64k. > For example, > The following is available memory region for testing: >00

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-08-03 Thread Samer El-Haj-Mahmoud
+Heinrich > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunny > Wang via groups.io > Sent: Monday, July 19, 2021 4:08 AM > To: devel@edk2.groups.io > Cc: Sunny Wang ; Samer El-Haj-Mahmoud > ; G Edhaya Chandran > ; Barton Gao ; > Sunny Wang &g

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-07-27 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78204): https://edk2.groups.io/g/devel/message/78204 Mute This Topic: https://groups.io/mt/83439673/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: h

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-07-26 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78201): https://edk2.groups.io/g/devel/message/78201 Mute This Topic: https://groups.io/mt/84303611/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: h

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

2021-07-19 Thread Sunny Wang
This is to fix the SCT BS.AllocatePages failures (not found) with the case that the Start address is not aligned to 64k. For example, The following is available memory region for testing: 82012000-EB6D9FFF 000696C8 With the current page alignment calculation, we will

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-06-18 Thread Sunny Wang
Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Gao Jie via groups.io Sent: Thursday, June 10, 2021 3:39 PM To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Samer El-Haj-Mahmoud ; Eric Jin ; Arvin Chen Subject: [edk2-devel] [edk2

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-15 Thread Sunny Wang
; 'Heinrich Schuchardt' Cc: G Edhaya Chandran ; 'Michael D Kinney' Subject: 回复: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL Hi Sunny, I believe the result with 13 passes should be tested *with* this fix, right? I saw reviewed-by/Ack

回复: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-15 Thread Gao Jie
-Mahmoud ; Heinrich Schuchardt ; devel@edk2.groups.io 抄送: G Edhaya Chandran ; Barton Gao ; Michael D Kinney ; Sunny Wang 主题: Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL Thanks for the review, Samer. Moreover, I just built it and tested it on my ARM

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-14 Thread Sunny Wang
Thanks for the review, Samer. Moreover, I just built it and tested it on my ARM system, and confirmed the issue got fixed by this patch. Without this fix, the result would be 18 tests, and 4 Errors. CreateEvent_Func: [FAILED] Passes... 14 Warnings. 0 Errors... 4 Wit

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-13 Thread Samer El-Haj-Mahmoud
Reviewed-By: Samer El-Haj-Mahmoud > -Original Message- > From: Heinrich Schuchardt > Sent: Friday, June 11, 2021 5:15 AM > To: Sunny Wang ; devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; G Edhaya > Chandran ; Barton Gao > ; Michael D Kinney > Subject: Re: [edk2-test][PATCH v2 1/1] ue

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-11 Thread Heinrich Schuchardt
On 11.06.21 10:35, Sunny Wang wrote: > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent failures. > > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for > exclusive use by the firmware. The creation of events by UEFI > applications, UEFI drivers, and UEFI OS Load

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-11 Thread Sunny Wang
-Haj-Mahmoud ; G Edhaya Chandran ; Barton Gao ; Michael D Kinney ; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL On 11.06.21 09:07, Sunny Wang wrote: > The commit a9d1fb58 caused SCT BS.CreateEvent failu

[edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-11 Thread Sunny Wang
The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent failures. Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for exclusive use by the firmware. The creation of events by UEFI applications, UEFI drivers, and UEFI OS Loaders should not use this TPL level. Therefore,

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-11 Thread Heinrich Schuchardt
On 11.06.21 09:07, Sunny Wang wrote: > The commit a9d1fb58 caused SCT BS.CreateEvent failures. > > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for > exclusive use by the firmware. The creation of events by UEFI > applications, UEFI drivers, and UEFI OS Loaders should not use

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

2021-06-11 Thread Sunny Wang
The commit a9d1fb58 caused SCT BS.CreateEvent failures. Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for exclusive use by the firmware. The creation of events by UEFI applications, UEFI drivers, and UEFI OS Loaders should not use this TPL level. Therefore, revert TPL_HIGH_L

[edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-06-10 Thread Gao Jie
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg, RegisterFilterLibNull which will be consumed by IoLib and BaseLib was added in MdeLibs.dsc.inc. To build UefiSct with edk2-stable202105 and later, this f

Re: [edk2-devel] edk2-test: Request for new github repo

2021-05-27 Thread Nate DeSimone
; Desimone, Nathaniel L ; Desimone, Ashley E Cc: n...@arm.com Subject: Re: [edk2-devel] edk2-test: Request for new github repo Thanks Mike, I've not come across edkrepo before. I've been using repo becuase it is a common tool used by many projects. How does edkrepo compare? g. O

Re: [edk2-devel] edk2-test: Request for new github repo

2021-05-24 Thread Grant Likely
devel@edk2.groups.io On Behalf Of Grant Likely Sent: Wednesday, May 12, 2021 5:32 AM To: devel@edk2.groups.io; G Edhaya Chandran ; Samer El-Haj-Mahmoud Cc: n...@arm.com Subject: [edk2-devel] edk2-test: Request for new github repo Would it be possible to get a new repo under the github.com/tianoco

Re: [edk2-devel] edk2-test: Request for new github repo

2021-05-12 Thread Michael D Kinney
edkrepo for this edk2-test use case. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Grant Likely > Sent: Wednesday, May 12, 2021 5:32 AM > To: devel@edk2.groups.io; G Edhaya Chandran ; Samer > El-Haj-Mahmoud > Cc: n...@arm.com > Subject: [

[edk2-devel] edk2-test: Request for new github repo

2021-05-12 Thread Grant Likely
Would it be possible to get a new repo under the github.com/tianocore project? I've got a repo manifest that I've been using for building the SCT, and is now being used by quite a few people. However it is currently hosted under my personal area here: https://github.com/glikely/edk2-test-manif

Re: [edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

2021-05-08 Thread G Edhaya Chandran
Upstreamed by commit :  https://github.com/tianocore/edk2-test/commit/da461e14fe86a5f4ee03ab64b412bf5f0bfe08e9 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74844): https://edk2.groups.io/g/devel/message/74844 Mute This Topic: https://gr

Re: [edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

2021-05-08 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74843): https://edk2.groups.io/g/devel/message/74843 Mute This Topic: https://groups.io/mt/81518326/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: h

Re: [edk2-devel] [edk2-test PATCHv3 3/5] SctPkg: Add RISCV64 build support

2021-03-30 Thread Sunny Wang
; Eric Jin ; Arvin Chen ; Leif Lindholm ; Heinrich Schuchardt ; Abner Chang Subject: [edk2-devel] [edk2-test PATCHv3 3/5] SctPkg: Add RISCV64 build support REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 Cc: G Edhaya Chandran Cc: Barton Gao Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin

Re: [edk2-devel] [edk2-test PATCHv3 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

2021-03-30 Thread Sunny Wang
y Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Daniel Schaefer Sent: Thursday, March 4, 2021 11:21 AM To: devel@edk2.groups.io Cc: G Edhaya Chandran ; Barton Gao ; Samer El-Haj-Mahmoud ; Eric Jin ; Arvin Chen ; Leif Lindholm ; Heinrich Schuchardt ; Abner Chang Subjec

Re: [edk2-devel] [edk2-test PATCHv3 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

2021-03-30 Thread Sunny Wang
Looks good to me. Same comment as patch 1/5. This only affects RISCV. Therefore, as long as you build and run SCT on the RISCV platform, this change should be fine. Reviewed-by: Sunny Wang -Original Message- From: Schaefer, Daniel Sent: Thursday, March 4, 2021 11:21 AM To: devel@edk2.gr

Re: [edk2-devel] [edk2-test PATCHv3 1/5] SctPkg: Add RISCV64 support by using Aarch64 sources

2021-03-30 Thread Sunny Wang
Looks good to me. This only affects RISCV. Therefore, as long as you build and run SCT on the RISCV platform, this change should be fine. Reviewed-by: Sunny Wang Best Regards, Sunny Wang -Original Message- From: Schaefer, Daniel Sent: Thursday, March 4, 2021 11:21 AM To: devel@edk2.gro

Re: [edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

2021-03-25 Thread Gao Jie
Reviewed-by: Barton Gao > On 2021/3/22 14:12, Eric Jin wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3272 The goal of the Support Routine: CheckForSupportGetImage is to detect the current FMP instance's capability for supporting GetImage(). In current

[edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

2021-03-21 Thread Eric Jin
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3272 The goal of the Support Routine: CheckForSupportGetImage is to detect the current FMP instance's capability for supporting GetImage(). In current code, "ImageIndex = 0" is the input parameter, but it is inconsistent with spec -"A unique numb

Re: [edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64

2021-03-15 Thread Daniel Schaefer
; Barton Gao ; Samer El-Haj-Mahmoud ; Eric Jin ; Arvin Chen ; Leif Lindholm ; Heinrich Schuchardt ; Chang, Abner (HPS SW/FW Technologist) Subject: [edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64 Changes to previous series: - Fixed the commit to remove whitespace to *only* remove

Re: [edk2-devel] [edk2-test PATCHv3 5/5] SctPkg: Remove trailing whitespace

2021-03-03 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Thursday, March 4, 2021 11:21 AM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; Cha

Re: [edk2-devel] [edk2-test PATCHv3 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

2021-03-03 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Thursday, March 4, 2021 11:21 AM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; Cha

Re: [edk2-devel] [edk2-test PATCHv3 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

2021-03-03 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Thursday, March 4, 2021 11:21 AM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; Cha

[edk2-devel] [edk2-test PATCHv3 3/5] SctPkg: Add RISCV64 build support

2021-03-03 Thread Daniel Schaefer
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 Cc: G Edhaya Chandran Cc: Barton Gao Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Leif Lindholm Cc: Heinrich Schuchardt Cc: Abner Chang Signed-off-by: Daniel Schaefer --- uefi-sct/SctPkg/Application/InstallSct/InstallSct

[edk2-devel] [edk2-test PATCHv3 5/5] SctPkg: Remove trailing whitespace

2021-03-03 Thread Daniel Schaefer
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 Cc: G Edhaya Chandran Cc: Barton Gao Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Leif Lindholm Cc: Heinrich Schuchardt Cc: Abner Chang Reviewed-by: Samer El-Haj-Mahmoud Reviewed-by: G Edhaya Chandran Signed-off-by: Dani

[edk2-devel] [edk2-test PATCHv3 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

2021-03-03 Thread Daniel Schaefer
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 Cc: G Edhaya Chandran Cc: Barton Gao Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Leif Lindholm Cc: Heinrich Schuchardt Cc: Abner Chang Signed-off-by: Daniel Schaefer --- uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 15 --

[edk2-devel] [edk2-test PATCHv3 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

2021-03-03 Thread Daniel Schaefer
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 Cc: G Edhaya Chandran Cc: Barton Gao Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Leif Lindholm Cc: Heinrich Schuchardt Cc: Abner Chang Signed-off-by: Daniel Schaefer --- uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat

[edk2-devel] [edk2-test PATCHv3 1/5] SctPkg: Add RISCV64 support by using Aarch64 sources

2021-03-03 Thread Daniel Schaefer
The sources were copied from Aarch64. Follow-up commit will adapt them for Riscv64. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 Cc: G Edhaya Chandran Cc: Barton Gao Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Leif Lindholm Cc: Heinrich Schuchardt Cc: Abner Chang S

[edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64

2021-03-03 Thread Daniel Schaefer
Changes to previous series: - Fixed the commit to remove whitespace to *only* remove whitespace. Had some mixup there... - Added missing HPE copyright in one file I was able to run SCT on my EDK2 port to RISCV64 and I don't see any obvious failures related to this. Additionally Heinrich has tes

Re: [edk2-devel] [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

2021-03-03 Thread Daniel Schaefer
Whoops, you're right! Thanks for checking it. (I had copied the files from RiscV64 to Aarch64...) git show -w on this commit clearly shows that there have been non-whitespace changes. Will send a new series! On 2/25/21 11:07 AM, Chang, Abner (HPS SW/FW Technologist) wrote: Some non-whitespace

Re: [edk2-devel] [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

2021-03-03 Thread Daniel Schaefer
On 2/25/21 2:56 PM, Chang, Abner (HPS SW/FW Technologist) wrote: We unify build options to GCC:*_*_*_CC_FLAGS, but some options were added or removed to the specific arch e.g. for GCC:*_*_IA32_CC_FLAGS, -ffreestanding, -nostdinc, -nostdlib are added additionally because of GCC:*_*_*_CC_FLAGS?

Re: [edk2-devel] [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms

2021-02-24 Thread Abner Chang
We unify build options to GCC:*_*_*_CC_FLAGS, but some options were added or removed to the specific arch e.g. for GCC:*_*_IA32_CC_FLAGS, -ffreestanding, -nostdinc, -nostdlib are added additionally because of GCC:*_*_*_CC_FLAGS? For GCC:*_*_AARCH64_CC_FLAGS, some options were removed. Are those

Re: [edk2-devel] [edk2-test PATCHv2 3/5] SctPkg: Add RISCV64 build support

2021-02-24 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Tuesday, February 9, 2021 11:44 PM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; C

Re: [edk2-devel] [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace

2021-02-24 Thread Abner Chang
Some non-whitespace changes in this patch, such as SctLibPlt.h, goVirtual.S and maybe others. I think you mixed up the changes by accident? > -Original Message- > From: G Edhaya Chandran [mailto:edhaya.chand...@arm.com] > Sent: Wednesday, February 24, 2021 5:02 PM > To: Schaefer, Daniel ;

Re: [edk2-devel] [edk2-test PATCHv2 2/5] SctPkg: Adapt Aarch64 sources for Riscv64

2021-02-24 Thread Abner Chang
> -Original Message- > From: Schaefer, Daniel > Sent: Tuesday, February 9, 2021 11:44 PM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; Chang, Abner (HPS SW/FW T

Re: [edk2-devel] [edk2-test PATCHv2 1/5] SctPkg: Add RISCV64 support by using Aarch64 sources

2021-02-24 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Schaefer, Daniel > Sent: Tuesday, February 9, 2021 11:44 PM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Barton Gao > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Eric Jin ; Arvin Chen > ; Leif Lindholm ; Heinrich > Schuchardt ; C

  1   2   3   4   >