...@hpe.com; Abner Chang
; Gilbert Chen ; Bi, Dandan
; Dong, Eric
Subject: Re: [EXTERNAL] RE: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use
CopyMem instead of GUID assignment
Hi Ray,
On Thu, Mar 12, 2020 at 12:21 PM Ni, Ray
mailto:ray...@intel.com>> wrote:
> Does CompilerIntrinsics
> ; Chen, Gilbert ;
> af...@apple.com; michael.d.kin...@intel.com; p...@akeo.ie; Ard
> Biesheuvel
> Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem
> instead of GUID assignment
>
> On Fri, Mar 13, 2020 at 04:08:12 +, Chang, Abner (HPS SW/FW
> Techno
On 03/12/20 22:19, Leif Lindholm wrote:
> On Thu, Mar 12, 2020 at 20:42:52 +0100, Laszlo Ersek wrote:
>> On 03/12/20 15:44, Leif Lindholm wrote:
>>> And what would you propose we do the next time the RISC-V toolchain
>>> generates a memcpy call based on some other completely valid change to
>>> cor
t; Cc: Chang, Abner (HPS SW/FW Technologist) ;
> > Schaefer, Daniel (DualStudy) ; Chen, Gilbert
> > ; af...@apple.com; michael.d.kin...@intel.com;
> > p...@akeo.ie; Ard Biesheuvel
> > Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem
> > instead of GUID assign
le.com; michael.d.kin...@intel.com;
> p...@akeo.ie; Ard Biesheuvel
> Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem
> instead of GUID assignment
The current NULL instance of CompilerIntrinsicsLib is applied on every modules,
this means it's not flexible for overwr
Chen, Gilbert ;
> af...@apple.com; michael.d.kin...@intel.com; p...@akeo.ie; Ard
> Biesheuvel ; Laszlo Ersek
> Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem
> instead of GUID assignment
>
> For clarity, I'm suggesting *I* take care of moving this into a generi
On Thu, Mar 12, 2020 at 20:42:52 +0100, Laszlo Ersek wrote:
> On 03/12/20 15:44, Leif Lindholm wrote:
> > And what would you propose we do the next time the RISC-V toolchain
> > generates a memcpy call based on some other completely valid change to
> > core code?
>
> We could choose to enable the
On Thu, Mar 12, 2020 at 20:36:04 +0100, Laszlo Ersek wrote:
> On 03/12/20 15:03, Leif Lindholm wrote:
> > +Ard, Laszlo.
> >
> > I think it would make sense to move it to MdeModulePkg (or MdePkg) and
> > rename it BaseCompilerIntrinsicsLib (it *is* a BASE library).
> >
> > As I alluded in my reply
> On Mar 12, 2020, at 12:36 PM, Laszlo Ersek wrote:
>
> On 03/12/20 15:03, Leif Lindholm wrote:
>> +Ard, Laszlo.
>>
>> I think it would make sense to move it to MdeModulePkg (or MdePkg) and
>> rename it BaseCompilerIntrinsicsLib (it *is* a BASE library).
>>
>> As I alluded in my reply to Ray
>>
>>> -Original Message-
>>> From: Leif Lindholm [mailto:l...@nuviainc.com]
>>> Sent: Thursday, March 12, 2020 10:03 PM
>>> To: Schaefer, Daniel (DualStudy)
>>> Cc: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>>> ; Che
On 03/12/20 15:03, Leif Lindholm wrote:
> +Ard, Laszlo.
>
> I think it would make sense to move it to MdeModulePkg (or MdePkg) and
> rename it BaseCompilerIntrinsicsLib (it *is* a BASE library).
>
> As I alluded in my reply to Ray - x86 also have this problem, but to a
> lesser extent, and ended
...@nuviainc.com]
> > > Sent: Thursday, March 12, 2020 10:03 PM
> > > To: Schaefer, Daniel (DualStudy)
> > > Cc: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > > ; Chen, Gilbert ;
> > > af...@apple.com; michael.d.kin...@intel.com; p...@a
Cc: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > ; Chen, Gilbert ;
> > af...@apple.com; michael.d.kin...@intel.com; p...@akeo.ie; Ard
> > Biesheuvel ; Laszlo Ersek
> > Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem
> > instead of GUID
gt; > Sent: Thursday, March 12, 2020 11:55
> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > <mailto:devel@edk2.groups.io>; Schaefer, Daniel
> > (DualStudy)
> <mailto:daniel.schae...@hpe.com>
> > Cc: Chang, Abner (HPS SW/FW Technologist)
&g
(HPS SW/FW Technologist)
> <mailto:abner.ch...@hpe.com>; Chen, Gilbert
> <mailto:gilbert.c...@hpe.com>; Dandan Bi
> <mailto:dandan...@intel.com>; Eric Dong
> <mailto:eric.d...@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of
Hi Ray,
On Thu, Mar 12, 2020 at 12:21 PM Ni, Ray wrote:
> Does CompilerIntrinsicsLib exist because GCC doesn't support to disable
intrinsic?
It is not possible to disable all intrinsics on 32-bit ARM, and it's not
necessarily desirable to do so for AArch64 (so I don't think it's
implemented).
N
)
<mailto:abner.ch...@hpe.com>; Chen, Gilbert
<mailto:gilbert.c...@hpe.com>; Dandan Bi
<mailto:dandan...@intel.com>; Eric Dong
<mailto:eric.d...@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of
GUID assignment
Hi Daniel,
There is nothing wrong
March 12, 2020 6:55 PM
> To: devel@edk2.groups.io; daniel.schae...@hpe.com
> Cc: Abner Chang ; Gilbert Chen
> ; Bi, Dandan ; Dong, Eric
>
> Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem
> instead of GUID assignment
>
> Hi Daniel,
>
> There is
Hi Daniel,
There is nothing wrong with this patch that just went in (and I should
have called out sooner if I wanted to stop it), but I think a better
solution is to implement a RISC-V variant of
ArmPkg/Library/CompilerIntrinsicsLib/.
It is perfectly valid for the compiler to generate memcpy call
ilbert
; Leif Lindholm ; Dong, Eric
Subject: RE: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of
GUID assignment
Pushed @ 64a228f5f89320fd632bb6c55e154961f2410680
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Dandan Bi
> Sent: Thu
dholm ; Dong, Eric
>
> Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem
> instead of GUID assignment
>
> Reviewed-by: Dandan Bi
>
>
> Thanks,
> Dandan
> > -Original Message-
> > From: Daniel Schaefer [mailto:daniel.schae...@hpe.c
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: Daniel Schaefer [mailto:daniel.schae...@hpe.com]
> Sent: Monday, March 2, 2020 6:33 PM
> To: devel@edk2.groups.io
> Cc: Abner Chang ; Gilbert Chen
> ; Leif Lindholm ; Bi, Dandan
> ; Dong, Eric
> Subject: [PATCH v2 3/3] M
6:33 PM
> To: devel@edk2.groups.io
> Cc: Abner Chang ; Gilbert Chen ;
> Leif Lindholm ; Bi, Dandan
> ; Dong, Eric
> Subject: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of
> GUID assignment
>
> GCC translates a simple assignment to memcpy, which EDK
GCC translates a simple assignment to memcpy, which EDKII doesn't provide.
See: https://www.mail-archive.com/edk2-devel@lists.01.org/msg11928.html
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2547
Signed-off-by: Daniel Schaefer
Cc: Abner Chang
Cc: Gilbert Chen
Cc: Leif Lindholm
Cc: Dand
24 matches
Mail list logo
