Appreciated, Jian J. Get Outlook for Android<https://aka.ms/ghei36> ________________________________ From: Wang, Jian J <jian.j.w...@intel.com> Sent: Thursday, March 12, 2020 1:58:05 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; Bi, Dandan <dandan...@intel.com>; Schaefer, Daniel (DualStudy) <daniel.schae...@hpe.com> Cc: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>; Chen, Gilbert <gilbert.c...@hpe.com>; Leif Lindholm <l...@nuviainc.com>; Dong, Eric <eric.d...@intel.com> Subject: RE: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment
Pushed @ 64a228f5f89320fd632bb6c55e154961f2410680 Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dandan Bi > Sent: Thursday, March 05, 2020 8:40 AM > To: Daniel Schaefer <daniel.schae...@hpe.com>; devel@edk2.groups.io > Cc: Abner Chang <abner.ch...@hpe.com>; Gilbert Chen > <gilbert.c...@hpe.com>; Leif Lindholm <l...@nuviainc.com>; Dong, Eric > <eric.d...@intel.com> > Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem > instead of GUID assignment > > Reviewed-by: Dandan Bi <dandan...@intel.com> > > > Thanks, > Dandan > > -----Original Message----- > > From: Daniel Schaefer [mailto:daniel.schae...@hpe.com] > > Sent: Monday, March 2, 2020 6:33 PM > > To: devel@edk2.groups.io > > Cc: Abner Chang <abner.ch...@hpe.com>; Gilbert Chen > > <gilbert.c...@hpe.com>; Leif Lindholm <l...@nuviainc.com>; Bi, Dandan > > <dandan...@intel.com>; Dong, Eric <eric.d...@intel.com> > > Subject: [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID > > assignment > > > > GCC translates a simple assignment to memcpy, which EDKII doesn't provide. > > See: https://www.mail-archive.com/edk2-devel@lists.01.org/msg11928.html > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2547 > > > > Signed-off-by: Daniel Schaefer <daniel.schae...@hpe.com> > > Cc: Abner Chang <abner.ch...@hpe.com> > > Cc: Gilbert Chen <gilbert.c...@hpe.com> > > Cc: Leif Lindholm <l...@nuviainc.com> > > Cc: Dandan Bi <dandan...@intel.com> > > Cc: Eric Dong <eric.d...@intel.com> > > --- > > > > Notes: > > v2: > > - Use CopyMem instead of CopyGuid [Dandan] > > > > MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > index 5cc527679a78..0540e6fa8a44 100644 > > --- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > +++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > @@ -619,7 +619,7 @@ CreateDeviceManagerForm( > > TokenHelp = HiiSetString (HiiHandle, 0, String, NULL); > > > > FreePool (String); > > > > > > > > - FormSetGuid = ((EFI_IFR_FORM_SET *)Ptr)->Guid; > > > > + CopyMem (&FormSetGuid, &((EFI_IFR_FORM_SET *) Ptr)->Guid, sizeof > > (EFI_GUID)); > > > > > > > > // > > > > // Network device process > > > > -- > > 2.25.0 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55791): https://edk2.groups.io/g/devel/message/55791 Mute This Topic: https://groups.io/mt/71671270/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
