Pushed @ 64a228f5f89320fd632bb6c55e154961f2410680 Regards, Jian
> -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Dandan Bi > Sent: Thursday, March 05, 2020 8:40 AM > To: Daniel Schaefer <[email protected]>; [email protected] > Cc: Abner Chang <[email protected]>; Gilbert Chen > <[email protected]>; Leif Lindholm <[email protected]>; Dong, Eric > <[email protected]> > Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem > instead of GUID assignment > > Reviewed-by: Dandan Bi <[email protected]> > > > Thanks, > Dandan > > -----Original Message----- > > From: Daniel Schaefer [mailto:[email protected]] > > Sent: Monday, March 2, 2020 6:33 PM > > To: [email protected] > > Cc: Abner Chang <[email protected]>; Gilbert Chen > > <[email protected]>; Leif Lindholm <[email protected]>; Bi, Dandan > > <[email protected]>; Dong, Eric <[email protected]> > > Subject: [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID > > assignment > > > > GCC translates a simple assignment to memcpy, which EDKII doesn't provide. > > See: https://www.mail-archive.com/[email protected]/msg11928.html > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2547 > > > > Signed-off-by: Daniel Schaefer <[email protected]> > > Cc: Abner Chang <[email protected]> > > Cc: Gilbert Chen <[email protected]> > > Cc: Leif Lindholm <[email protected]> > > Cc: Dandan Bi <[email protected]> > > Cc: Eric Dong <[email protected]> > > --- > > > > Notes: > > v2: > > - Use CopyMem instead of CopyGuid [Dandan] > > > > MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > index 5cc527679a78..0540e6fa8a44 100644 > > --- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > +++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > @@ -619,7 +619,7 @@ CreateDeviceManagerForm( > > TokenHelp = HiiSetString (HiiHandle, 0, String, NULL); > > > > FreePool (String); > > > > > > > > - FormSetGuid = ((EFI_IFR_FORM_SET *)Ptr)->Guid; > > > > + CopyMem (&FormSetGuid, &((EFI_IFR_FORM_SET *) Ptr)->Guid, sizeof > > (EFI_GUID)); > > > > > > > > // > > > > // Network device process > > > > -- > > 2.25.0 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55790): https://edk2.groups.io/g/devel/message/55790 Mute This Topic: https://groups.io/mt/71671270/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
