Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary

2022-02-25 Thread Boeuf, Sebastien
On Fri, 2022-02-25 at 10:29 +0100, kra...@redhat.com wrote: >   Hi, > > > > Hmm, VarStore.fdf.inc reduces duplication, and now you revert > > > this. > > > Maybe add this to VarStore.fdf.inc instead, and add a > > > PVH_HEADER_ENABLE > > > option to turn it on and off? > > > > It's quite hard to

Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary

2022-02-25 Thread Gerd Hoffmann
Hi, > > Hmm, VarStore.fdf.inc reduces duplication, and now you revert this. > > Maybe add this to VarStore.fdf.inc instead, and add a > > PVH_HEADER_ENABLE > > option to turn it on and off? > > It's quite hard to use VarStore.fdf.inc since I would need to replace > only the first DATA section.

Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary

2022-02-24 Thread Boeuf, Sebastien
On Thu, 2022-02-24 at 09:16 +0100, Gerd Hoffmann wrote: >   Hi, > > > -!include OvmfPkg/VarStore.fdf.inc > > +!if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > > +0x|0xe000 > > +!endif > > +!if $(FD_SIZE_IN_KB) == 4096 > > +0x|0x0004 > > +!endif > > Hmm, VarSt

Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary

2022-02-24 Thread Gerd Hoffmann
Hi, > -!include OvmfPkg/VarStore.fdf.inc > +!if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > +0x|0xe000 > +!endif > +!if $(FD_SIZE_IN_KB) == 4096 > +0x|0x0004 > +!endif Hmm, VarStore.fdf.inc reduces duplication, and now you revert this. Maybe add this to Va

[edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary

2022-02-23 Thread Boeuf, Sebastien
From: Sebastien Boeuf Following the model from the Xen target, CloudHv is generated as a PVH ELF binary to take advantage of the PVH specification. Signed-off-by: Sebastien Boeuf --- OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- OvmfPkg/CloudHv/CloudHvX64.fdf | 94 +-