Hi, > > Hmm, VarStore.fdf.inc reduces duplication, and now you revert this. > > Maybe add this to VarStore.fdf.inc instead, and add a > > PVH_HEADER_ENABLE > > option to turn it on and off? > > It's quite hard to use VarStore.fdf.inc since I would need to replace > only the first DATA section. And I can't include something specific > like OvmfPkg/CloudHv/CloudHvElfHeader.fdf.inc inside VarStore.fdf.inc. > Should I create something like OvmfPkg/CloudHv/CloudHvVarStore.fdf.inc > so that it makes sense to include > OvmfPkg/CloudHv/CloudHvElfHeader.fdf.inc based on a PVH_HEADER_ENABLE > variable?
Yes, that was the idea, only include the file in case PVH_HEADER_ENABLE=TRUE. Maybe name it "PVH_HEADER_CLOUDHW" so the xen guys can add PVH_HEADER_XEN variable for the simliar but not identical xen case. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86998): https://edk2.groups.io/g/devel/message/86998 Mute This Topic: https://groups.io/mt/89345268/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
