Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-06-02 Thread Ard Biesheuvel
as #648 -Original Message- From: Ard Biesheuvel Sent: 2020年5月22日 21:27 To: Leif Lindholm ; Laszlo Ersek Cc: devel@edk2.groups.io; g...@suse.com; Gao, Liming Subject: Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics On 5/22/20 12:54 PM, Leif

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-06-01 Thread Liming Gao
Sent: 2020年5月22日 21:27 To: Leif Lindholm ; Laszlo Ersek Cc: devel@edk2.groups.io; g...@suse.com; Gao, Liming Subject: Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics On 5/22/20 12:54 PM, Leif Lindholm wrote: > On Thu, May 21, 2020 at 22:22:58 +0200, Las

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-28 Thread Liming Gao
: 2020年5月29日 4:09 To: Gao, Liming ; Leif Lindholm ; Gary Lin ; af...@apple.com; Kinney, Michael D Cc: devel@edk2.groups.io; ard.biesheu...@arm.com Subject: Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics On 05/28/20 17:48, Gao, Liming wrote: > Leif: > B

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-28 Thread Laszlo Ersek
lm >> Sent: Thursday, May 28, 2020 5:49 PM >> To: Gary Lin >> Cc: devel@edk2.groups.io; ard.biesheu...@arm.com; ler...@redhat.com; Gao, >> Liming >> Subject: Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide >> atomics intrinsics >> >&g

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-28 Thread Liming Gao
ndholm > Sent: Thursday, May 28, 2020 5:49 PM > To: Gary Lin > Cc: devel@edk2.groups.io; ard.biesheu...@arm.com; ler...@redhat.com; Gao, > Liming > Subject: Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide > atomics intrinsics > > On Thu, May 28, 2020 at

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-28 Thread Leif Lindholm
On Thu, May 28, 2020 at 09:36:33 +0800, Gary Lin wrote: > On Wed, May 20, 2020 at 01:44:48PM +0200, Ard Biesheuvel wrote: > > Gary reports the GCC 10 will emit calls to atomics intrinsics routines > > unless -mno-outline-atomics is specified. This means GCC-10 introduces > > new intrinsics, and eve

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-27 Thread Gary Lin
On Wed, May 20, 2020 at 01:44:48PM +0200, Ard Biesheuvel wrote: > Gary reports the GCC 10 will emit calls to atomics intrinsics routines > unless -mno-outline-atomics is specified. This means GCC-10 introduces > new intrinsics, and even though it would be possible to work around this > by specifyin

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-22 Thread Laszlo Ersek
On 05/22/20 15:27, Ard Biesheuvel wrote: > On 5/22/20 12:54 PM, Leif Lindholm wrote: >> On Thu, May 21, 2020 at 22:22:58 +0200, Laszlo Ersek wrote: >>> On 05/21/20 16:16, Leif Lindholm wrote: >>> OK, then I would vote *for* merging the patch regardless. We know how long some toolchain ver

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-22 Thread Ard Biesheuvel
On 5/22/20 12:54 PM, Leif Lindholm wrote: On Thu, May 21, 2020 at 22:22:58 +0200, Laszlo Ersek wrote: On 05/21/20 16:16, Leif Lindholm wrote: OK, then I would vote *for* merging the patch regardless. We know how long some toolchain versions can stick around simply because they were mentioned i

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-22 Thread Leif Lindholm
On Thu, May 21, 2020 at 22:22:58 +0200, Laszlo Ersek wrote: > On 05/21/20 16:16, Leif Lindholm wrote: > > > OK, then I would vote *for* merging the patch regardless. We know how > > long some toolchain versions can stick around simply because they were > > mentioned in some blog post somewhere tha

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-22 Thread Ard Biesheuvel
On 5/21/20 10:22 PM, Laszlo Ersek wrote: On 05/21/20 16:16, Leif Lindholm wrote: OK, then I would vote *for* merging the patch regardless. We know how long some toolchain versions can stick around simply because they were mentioned in some blog post somewhere that ended up high in search rankin

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Laszlo Ersek
On 05/21/20 16:16, Leif Lindholm wrote: > OK, then I would vote *for* merging the patch regardless. We know how > long some toolchain versions can stick around simply because they were > mentioned in some blog post somewhere that ended up high in search > rankings. > > Once gcc 10.2 is released (

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Philippe Mathieu-Daudé
On 5/21/20 7:02 PM, Ard Biesheuvel wrote: On 5/21/20 6:59 PM, Philippe Mathieu-Daudé wrote: On 5/21/20 6:45 PM, Ard Biesheuvel wrote: On 5/21/20 6:40 PM, Philippe Mathieu-Daudé via groups.io wrote: On 5/20/20 2:37 PM, Philippe Mathieu-Daudé wrote: Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel w

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Ard Biesheuvel
On 5/21/20 6:59 PM, Philippe Mathieu-Daudé wrote: On 5/21/20 6:45 PM, Ard Biesheuvel wrote: On 5/21/20 6:40 PM, Philippe Mathieu-Daudé via groups.io wrote: On 5/20/20 2:37 PM, Philippe Mathieu-Daudé wrote: Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit ca

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Philippe Mathieu-Daudé
On 5/21/20 6:45 PM, Ard Biesheuvel wrote: On 5/21/20 6:40 PM, Philippe Mathieu-Daudé via groups.io wrote: On 5/20/20 2:37 PM, Philippe Mathieu-Daudé wrote: Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outl

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Ard Biesheuvel
On 5/21/20 6:40 PM, Philippe Mathieu-Daudé via groups.io wrote: On 5/20/20 2:37 PM, Philippe Mathieu-Daudé wrote: Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Philippe Mathieu-Daudé
On 5/20/20 2:37 PM, Philippe Mathieu-Daudé wrote: Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10 introduces new intrinsics, and even though it would be possible

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Leif Lindholm
On Thu, May 21, 2020 at 15:31:44 +0200, Ard Biesheuvel wrote: > > > That does mean you would need GCC 10.2 at least, or you get the error, > > > unless we merge this patch as well. That would mean the intrinsics are > > > never > > > used in practice, but using a compiler that does use them will n

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Ard Biesheuvel
On 5/21/20 3:16 PM, Leif Lindholm wrote: On Thu, May 21, 2020 at 14:58:56 +0200, Ard Biesheuvel wrote: Reviewed-by: Leif Lindholm Thanks! Apparently, GCC 10 is getting fixed so that we can set a #pragma in MdePkg/Include/AArch64/ProcessorBind.h, and be done with it. That does mean you would

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Leif Lindholm
On Thu, May 21, 2020 at 14:58:56 +0200, Ard Biesheuvel wrote: > > Reviewed-by: Leif Lindholm > > Thanks! > > > > Apparently, GCC 10 is getting fixed so that we can set a #pragma in > MdePkg/Include/AArch64/ProcessorBind.h, and be done with it. > > That does mean you would need GCC 10.2 at least

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Ard Biesheuvel
On 5/21/20 1:23 PM, Leif Lindholm via groups.io wrote: On Wed, May 20, 2020 at 13:44:48 +0200, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10 introduces new intrinsics, and even though it wo

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-21 Thread Leif Lindholm
On Wed, May 20, 2020 at 13:44:48 +0200, Ard Biesheuvel wrote: > Gary reports the GCC 10 will emit calls to atomics intrinsics routines > unless -mno-outline-atomics is specified. This means GCC-10 introduces > new intrinsics, and even though it would be possible to work around this > by specifying

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-20 Thread Laszlo Ersek
On 05/20/20 13:44, Ard Biesheuvel wrote: > Gary reports the GCC 10 will emit calls to atomics intrinsics routines > unless -mno-outline-atomics is specified. This means GCC-10 introduces > new intrinsics, and even though it would be possible to work around this > by specifying the command line opti

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-20 Thread Philippe Mathieu-Daudé
Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10 introduces new intrinsics, and even though it would be possible to work around this by specifying the command line

[edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

2020-05-20 Thread Ard Biesheuvel
Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10 introduces new intrinsics, and even though it would be possible to work around this by specifying the command line option, this would require a new GCC10 toolchain prof