Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-10-21 Thread Min Xu
On October 14, 2021 1:38 PM, Gerd Hoffmann wrote: > > > Calling CPUID should not be needed, we have a new fancy > > > ConfidentialComputing PCD for that now. > > The gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr is > defined in UefiCpuPkg. While BaseIoLibIntrinsicSev is in MdePkg. > >

Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-10-14 Thread Gerd Hoffmann
Hi, > > Hmm, I guess we should move the pcd then so it cam be used more widely. > > Confidential computing has an impact beyond just cpu, it's also memory, io > > and > > more. > How about define ConfidentialComputingAttr PCD in MdePkg.dec? Looks sensible to me. take care, Gerd -=-=-=-=-

Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-10-13 Thread Min Xu
On October 14, 2021 1:38 PM, Gerd Hoffmann wrote: > Hi, > > > > Calling CPUID should not be needed, we have a new fancy > > > ConfidentialComputing PCD for that now. > > The gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr is > defined in UefiCpuPkg. While BaseIoLibIntrinsicSev is in

Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-10-13 Thread Gerd Hoffmann
Hi, > > Calling CPUID should not be needed, we have a new fancy > > ConfidentialComputing PCD for that now. > The gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr is defined in > UefiCpuPkg. While BaseIoLibIntrinsicSev is in MdePkg. > If the ConfidentialComputing PCD is used, then Ue

Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-10-13 Thread Min Xu
On October 12, 2021 6:06 PM, Gerd Hoffmann wrote: > On Tue, Oct 05, 2021 at 11:39:17AM +0800, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > Intel TDX architecture does not prescribe a specific software > > convention to perform I/O from the guest TD. Guest TD pr

Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-10-12 Thread Gerd Hoffmann
On Tue, Oct 05, 2021 at 11:39:17AM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Intel TDX architecture does not prescribe a specific software convention > to perform I/O from the guest TD. Guest TD providers have many choices to > provide I/O to the guest. Th

[edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-10-04 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel TDX architecture does not prescribe a specific software convention to perform I/O from the guest TD. Guest TD providers have many choices to provide I/O to the guest. The common I/O models are emulated devices, para-virtualized devices