Hi, > > Calling CPUID should not be needed, we have a new fancy > > ConfidentialComputing PCD for that now. > The gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr is defined in > UefiCpuPkg. While BaseIoLibIntrinsicSev is in MdePkg. > If the ConfidentialComputing PCD is used, then UefiCpuPkg has to be included > in BaseIoLibIntrinsicSev.inf. > I check all the *.inf under MdePkg but no one *.inf include UefiCpuPkg. > I am not sure if UefiCpuPkg can be included in BaseIoLibIntrinsicSev.inf.
Hmm, I guess we should move the pcd then so it cam be used more widely. Confidential computing has an impact beyond just cpu, it's also memory, io and more. > > Maybe that's something to cleanup for amd (Brijesh?) beforehand, so the > > structure is there already and the tdx patches just need to add the "case > > tdx:" > > bits. > Tdx patches can first use above structure. AMD can update it later. Either > way is ok. That'll work too, I don't care much about the ordering. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81944): https://edk2.groups.io/g/devel/message/81944 Mute This Topic: https://groups.io/mt/86085732/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-