Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-19 Thread Ni, Ray
sage- > From: Javeed, Ashraf > Sent: Thursday, March 19, 2020 6:00 PM > To: Ni, Ray ; Gao, Liming ; Liu, > Zhiguang ; Kinney, > Michael D > Cc: devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition > missing > >

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-19 Thread Javeed, Ashraf
Thursday, March 19, 2020 2:30 PM > To: Javeed, Ashraf ; Gao, Liming > ; Liu, Zhiguang ; Kinney, > Michael D > Cc: devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC > definition missing > > I am sorry I just noticed t

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-19 Thread Ni, Ray
04 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang > Subject: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition > missing > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598 > > All registers definition of DVSEC are de

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-18 Thread Javeed, Ashraf
Thanks Liming! Ashraf > -Original Message- > From: Gao, Liming > Sent: Thursday, March 19, 2020 7:32 AM > To: devel@edk2.groups.io; Gao, Liming ; Javeed, > Ashraf ; Liu, Zhiguang > Cc: Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-18 Thread Liming Gao
Merge @1b6b4a83e1d85e48837068dfe409f5557b50d71d -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年3月18日 23:52 To: Javeed, Ashraf ; Liu, Zhiguang ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-18 Thread Liming Gao
That's enough. > -Original Message- > From: Javeed, Ashraf > Sent: Wednesday, March 18, 2020 12:51 PM > To: Gao, Liming ; Liu, Zhiguang > ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing > > Yes, I verified the b

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-17 Thread Javeed, Ashraf
Yes, I verified the build with this patch by directly referencing the new data types in a source file. Thanks Ashraf > -Original Message- > From: Gao, Liming > Sent: Wednesday, March 18, 2020 8:11 AM > To: Liu, Zhiguang ; Javeed, Ashraf > ; devel@edk2.groups.io > Cc: Kinney, Michael D >

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-17 Thread Liming Gao
Ashraf: The change is good. Have you verified the build with this patch? Reviewed-by: Liming Gao Thanks Liming -Original Message- From: Liu, Zhiguang Sent: 2020年3月17日 16:08 To: Javeed, Ashraf ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming Subject: RE: [PATCH V2] MdeP

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-17 Thread Zhiguang Liu
Reviewed-by: Zhiguang Liu -Original Message- From: Javeed, Ashraf Sent: Tuesday, March 17, 2020 4:04 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing BZ: https://bugzilla.tianocore.org/

[edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-17 Thread Javeed, Ashraf
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598 All registers definition of DVSEC are defined as per the PCI Express Base Specification 4.0 chapter 7.9.6. Signed-off-by: Ashraf Javeed Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu V2: fixed the comment section description for D

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-17 Thread Javeed, Ashraf
io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang > Subject: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition > missing > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598 > > All registers definition of DVSEC are defined as per the PCI Express

[edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-17 Thread Javeed, Ashraf
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598 All registers definition of DVSEC are defined as per the PCI Express Base Specification 4.0 chapter 7.9.6. Signed-off-by: Ashraf Javeed Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu V2: fixed the comment section description for D