Thanks Liming! Ashraf > -----Original Message----- > From: Gao, Liming <liming....@intel.com> > Sent: Thursday, March 19, 2020 7:32 AM > To: devel@edk2.groups.io; Gao, Liming <liming....@intel.com>; Javeed, > Ashraf <ashraf.jav...@intel.com>; Liu, Zhiguang <zhiguang....@intel.com> > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > Subject: RE: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC > definition missing > > Merge @1b6b4a83e1d85e48837068dfe409f5557b50d71d > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming > Gao > Sent: 2020年3月18日 23:52 > To: Javeed, Ashraf <ashraf.jav...@intel.com>; Liu, Zhiguang > <zhiguang....@intel.com>; devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > Subject: Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC > definition missing > > That's enough. > > > -----Original Message----- > > From: Javeed, Ashraf <ashraf.jav...@intel.com> > > Sent: Wednesday, March 18, 2020 12:51 PM > > To: Gao, Liming <liming....@intel.com>; Liu, Zhiguang > > <zhiguang....@intel.com>; devel@edk2.groups.io > > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition > > missing > > > > Yes, I verified the build with this patch by directly referencing the new > data types in a source file. > > Thanks > > Ashraf > > > > > -----Original Message----- > > > From: Gao, Liming <liming....@intel.com> > > > Sent: Wednesday, March 18, 2020 8:11 AM > > > To: Liu, Zhiguang <zhiguang....@intel.com>; Javeed, Ashraf > > > <ashraf.jav...@intel.com>; devel@edk2.groups.io > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > > > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition > > > missing > > > > > > Ashraf: > > > The change is good. Have you verified the build with this patch? > > > > > > Reviewed-by: Liming Gao <liming....@intel.com> > > > > > > Thanks > > > Liming > > > -----Original Message----- > > > From: Liu, Zhiguang <zhiguang....@intel.com> > > > Sent: 2020年3月17日 16:08 > > > To: Javeed, Ashraf <ashraf.jav...@intel.com>; devel@edk2.groups.io > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > > > <liming....@intel.com> > > > Subject: RE: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition > > > missing > > > > > > Reviewed-by: Zhiguang Liu <zhiguang....@intel.com> > > > > > > -----Original Message----- > > > From: Javeed, Ashraf > > > Sent: Tuesday, March 17, 2020 4:04 PM > > > To: devel@edk2.groups.io > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > > > <liming....@intel.com>; Liu, Zhiguang <zhiguang....@intel.com> > > > Subject: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598 > > > > > > All registers definition of DVSEC are defined as per the PCI Express > > > Base Specification 4.0 chapter 7.9.6. > > > > > > Signed-off-by: Ashraf Javeed <ashraf.jav...@intel.com> > > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > > Cc: Liming Gao <liming....@intel.com> > > > Cc: Zhiguang Liu <zhiguang....@intel.com> > > > > > > V2: fixed the comment section description for DVSEC definitions > > > --- > > > MdePkg/Include/IndustryStandard/PciExpress40.h | 28 > > > ++++++++++++++++++++++++++++ > > > 1 file changed, 28 insertions(+) > > > > > > diff --git a/MdePkg/Include/IndustryStandard/PciExpress40.h > > > b/MdePkg/Include/IndustryStandard/PciExpress40.h > > > index 9d9b272546..0564d72861 100644 > > > --- a/MdePkg/Include/IndustryStandard/PciExpress40.h > > > +++ b/MdePkg/Include/IndustryStandard/PciExpress40.h > > > @@ -4,6 +4,7 @@ Support for the PCI Express 4.0 standard. > > > This header file may not define all structures. Please extend as > required. > > > > > > Copyright (c) 2018, American Megatrends, Inc. All rights > > > reserved.<BR> > > > +Copyright (c) 2020, Intel Corporation. All rights reserved.<BR> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > **/ > > > @@ -78,6 +79,33 @@ typedef struct { > > > } PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0; > > > ///@} > > > > > > +/// The Designated Vendor Specific Capability definitions /// Based > > > +on section 7.9.6 of PCI Express Base Specification 4.0. > > > +///@{ > > > +typedef union { > > > + struct { > > > + UINT32 DvsecVendorId : 16; > > > //bit 0..15 > > > + UINT32 DvsecRevision : 4; > > > //bit 16..19 > > > + UINT32 DvsecLength : 12; > > > //bit 20..31 > > > + }Bits; > > > + UINT32 Uint32; > > > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1; > > > + > > > +typedef union { > > > + struct { > > > + UINT16 DvsecId : 16; > > > //bit 0..15 > > > + }Bits; > > > + UINT16 Uint16; > > > +}PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2; > > > + > > > +typedef struct { > > > + PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header; > > > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1 > > > DesignatedVendorSpecificHeader1; > > > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2 > > > DesignatedVendorSpecificHeader2; > > > + UINT8 > > > DesignatedVendorSpecific[1]; > > > > +}PCI_EXPRESS_EXTENDED_CAPABILITIES_DESIGNATED_VENDOR_SPECIFIC; > > > +///@} > > > + > > > #pragma pack() > > > > > > #endif > > > -- > > > 2.21.0.windows.1 > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55985): https://edk2.groups.io/g/devel/message/55985 Mute This Topic: https://groups.io/mt/72019653/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
