Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-04-11 Thread Pankaj Bansal
> > Leif, > Please understand that the concern of this change is all the platforms that > uses > this serial port lib must be changed otherwise build breaks. > > Ard, > Using Guided HOB sounds a good idea to me: ) > The benefits of using HOB is: > Length field in the HOB header can be used for

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-30 Thread Ni, Ray
: Jiang, Guomin ; devel@edk2.groups.io; > pankaj.ban...@nxp.com; Ni, Ray ; > Wang, Jian J ; Wu, Hao A ; Ma, > Maurice ; Dong, > Guo ; You, Benjamin ; Meenakshi > Aggarwal > ; Varun Sethi ; Samer > El-Haj-Mahmoud mahm...@arm.com> > Subject: Re: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-30 Thread Ard Biesheuvel
On Mon, 30 Mar 2020 at 09:35, Leif Lindholm wrote: > > Hi Jiang, > > It is not a question of effort of copying a driver, it is a question > that copying drivers is something that should be avoided wherever > practically possible. I did not think this topic was still under > debate. > > If the exis

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-30 Thread Leif Lindholm
o > > ; You, Benjamin ; > > Meenakshi Aggarwal ; Varun Sethi > > ; Samer El-Haj-Mahmoud > mahm...@arm.com> > > Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock > > freq Support > > > > Hello Jiang, > > > > > -Ori

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-29 Thread Guomin Jiang
Bansal ; Leif Lindholm ; Ni, > Ray ; Ard Biesheuvel > Cc: Wang, Jian J ; Wu, Hao A > ; Ma, Maurice ; Dong, Guo > ; You, Benjamin ; > Meenakshi Aggarwal ; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com> > Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UAR

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-28 Thread Pankaj Bansal
, Benjamin > ; Meenakshi Aggarwal > ; Varun Sethi > Subject: RE: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq > Support > > It is a good idea, > > I have a question: > 1. When can detect the jumper signal or register? -> This depends on platform.

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-26 Thread Guomin Jiang
t; devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock > freq Support > > Hi Ray, > > I had thought of making PcdSerialClockRate as Dynamic PCD I had made > changes for it too. > But it doesn't work. > SerialPortIn

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-22 Thread Pankaj Bansal
Hi Ray, I had thought of making PcdSerialClockRate as Dynamic PCD I had made changes for it too. But it doesn't work. SerialPortInitalize, which uses PcdSerialClockRate, gets called from DebugLib constructor. DebugLib is used by every module to print any info onto console. For DxeCore and PcdDxe,

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-19 Thread Leif Lindholm
Hi Ray, I agree it would be nice, but if not - this lets us get rid of otherwise needless driver duplication. To me, that makes it worth a little trivial churn. / Leif On Thu, Mar 19, 2020 at 15:09:19 +, Ni, Ray wrote: > It seems this change requires all platforms DSC to include the new

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-19 Thread Ni, Ray
It seems this change requires all platforms DSC to include the new library class/instance. Is there a way that can avoid the platform impact? Thanks, Ray > -Original Message- > From: Pankaj Bansal > Sent: Wednesday, February 19, 2020 9:32 PM > To: Wang, Jian J ; Wu, Hao A ; Ni, > Ray

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-19 Thread Samer El-Haj-Mahmoud
; Benjamin You ; Leif Lindholm ; Meenakshi Aggarwal (meenakshi.aggar...@nxp.com) ; V Sethi (v.se...@nxp.com) Cc: devel@edk2.groups.io; Pankaj Bansal Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support From: Pankaj Bansal Some platform support dynamic clocking, which is

[edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-02-19 Thread Pankaj Bansal
From: Pankaj Bansal Some platform support dynamic clocking, which is controlled by some jumper setting or hardware registers. Result of that is that PCD PcdSerialClockRate would need to be updated for frequency change. This patch implements support for dynamic frequency for Uart. This patch imp