Leif, Please understand that the concern of this change is all the platforms that uses this serial port lib must be changed otherwise build breaks.
Ard, Using Guided HOB sounds a good idea to me: ) The benefits of using HOB is: Length field in the HOB header can be used for extension if more parameters are needed. DXE can have the HOB access as well. EFI_SEC_HOB_DATA_PPI can be used to return the new Guided HOB from SEC phase if needed. Thanks, Ray > -----Original Message----- > From: Ard Biesheuvel <ard.biesheu...@linaro.org> > Sent: Monday, March 30, 2020 3:45 PM > To: Leif Lindholm <l...@nuviainc.com> > Cc: Jiang, Guomin <guomin.ji...@intel.com>; devel@edk2.groups.io; > pankaj.ban...@nxp.com; Ni, Ray <ray...@intel.com>; > Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Ma, > Maurice <maurice...@intel.com>; Dong, > Guo <guo.d...@intel.com>; You, Benjamin <benjamin....@intel.com>; Meenakshi > Aggarwal > <meenakshi.aggar...@nxp.com>; Varun Sethi <v.se...@nxp.com>; Samer > El-Haj-Mahmoud <Samer.El-Haj- > mahm...@arm.com> > Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq > Support > > On Mon, 30 Mar 2020 at 09:35, Leif Lindholm <l...@nuviainc.com> wrote: > > > > Hi Jiang, > > > > It is not a question of effort of copying a driver, it is a question > > that copying drivers is something that should be avoided wherever > > practically possible. I did not think this topic was still under > > debate. > > > > If the existing 16550 SerialPortLib is overspecialised to the point > > where it only works on a subset of 16550 implementations, then it > > should change. There are going to be more non-PC systems turning up > > with 16550 UARTs - should they each copy/modify their drivers? > > > > If there are better ways of solving that problem, please suggest. > > But more duplicated drivers is not the answer. > > > > Could we use a GUIDed HOB? If it exists, we use its contents, and if > it doesn't, we use the default set by the FixedPCD. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56705): https://edk2.groups.io/g/devel/message/56705 Mute This Topic: https://groups.io/mt/71393886/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
