> -Original Message-
> From: Ard Biesheuvel
> Sent: Friday, April 24, 2020 11:38 AM
> To: devel@edk2.groups.io; Wasim Khan ; Ard
> Biesheuvel
> Cc: Varun Sethi ; Wu, Hao A ; Ni, Ray
>
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem
On 4/24/20 6:35 AM, Wasim Khan via groups.io wrote:
-Original Message-
From: Ard Biesheuvel
Sent: Friday, April 24, 2020 12:27 AM
To: Wasim Khan
Cc: edk2-devel-groups-io ; Varun Sethi
; Wu, Hao A ; Ni, Ray
Subject: Re: [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem
Limit Ch
> -Original Message-
> From: Ard Biesheuvel
> Sent: Friday, April 24, 2020 12:27 AM
> To: Wasim Khan
> Cc: edk2-devel-groups-io ; Varun Sethi
> ; Wu, Hao A ; Ni, Ray
>
> Subject: Re: [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem
> Limit Checks
>
> On Thu, 23 Apr 2020 at 12:4
On Thu, 23 Apr 2020 at 12:43, Wasim Khan wrote:
>
> With Address Translation Support, it is possible and
> also correct that Mem and Pmem Limit cross the 4GB boundary.
> Update the checks so that Mem/PMem Limit should not cross 4GB
> from the Mem/PMem Base address.
>
> Signed-off-by: Wasim Khan
>
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, April 23, 2020 8:47 PM
> To: Wasim Khan ; devel@edk2.groups.io
> Cc: ard.biesheu...@linaro.org; Varun Sethi ; Wu, Hao A
>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem
&g
> -Original Message-
> From: Wasim Khan
> Sent: Thursday, April 23, 2020 10:54 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: ard.biesheu...@linaro.org; Varun Sethi ; Wu, Hao A
>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and
iesheu...@linaro.org; Varun Sethi ; Wu, Hao
> > A
> > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update
> > Mem and PMem Limit Checks
> >
> >
> >
> > > -Original Message-
> > > From: Ni, Ray
> > > Sent: T
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wasim Khan
> Sent: Thursday, April 23, 2020 9:52 PM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: ard.biesheu...@linaro.org; Varun Sethi ; Wu, Hao A
>
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciH
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, April 23, 2020 5:07 PM
> To: Wasim Khan ; devel@edk2.groups.io
> Cc: ard.biesheu...@linaro.org; Varun Sethi ; Wu, Hao A
>
> Subject: RE: [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem
> Limit Checks
>
> Thanks for fixing
Thanks for fixing the check.
PCI_ROOT_BRIDGE_APERTURE.Base/Limit are device address while the memory space
in GCD belongs to host domain.
So, host address for Mem/Pmem should be below 4GB while device address can
across
4GB.
Can you enhance the check as below?
ASSERT (TO_HOST_ADDRESS (Bridge->
With Address Translation Support, it is possible and
also correct that Mem and Pmem Limit cross the 4GB boundary.
Update the checks so that Mem/PMem Limit should not cross 4GB
from the Mem/PMem Base address.
Signed-off-by: Wasim Khan
---
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c |
11 matches
Mail list logo
