Should |EFI_FFA_PART_INFO_DESC be packed since its used across an ABI?
Also there are a few immediately actionable TODO's in this commit.
|
|-Chris
|
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
This patch adds support for discovering the presence of the SP using the
EFI_MM_
Might as well use MAKE_FFA_VERSION from ArmFfaSvc.h for consistency.
-Chris
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
This patch adds support for querying whether FF-A v1.1 is supported by the
FF-A impplementation.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
this information when everything else is query-able from the
framework itself.
Thanks,
Chris Fernald
On 7/13/2023 8:24 AM, Girish Mahadevan via groups.io wrote:
I had one comment , in-line.
Thanks
Girish
On 7/11/2023 8:36 AM, Nishant Sharma via groups.io wrote:
External email: Use caution
Would it be possible to make the stack size configurable in a way that
doesn't require an silicon/platform vendor to customize the assembly
code? Perhaps through a fixed PCD if its not problematic to do so with
the .space directive.
Thanks,
Chris
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
On top of Oliver's question, in the changes
to|||StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf,
we should probably leave the .ARM and .AARCH64 specifiers since that is
not an ARM specific INF.
|
-Chris
On 7/12/2023 10:21 AM, Oliver Smith-Denny wrote:
On 7/
Except the context previously mentioned by Mike and Michael, looks good
to me.
Reviewed-by: Chris Fernald
On 4/26/2023 5:34 PM, Guo, Gua wrote:
From: Gua Guo
Azure should install code coverage tool (lcov), it didn't
exist on Fedora and Ubuntu by default.
Cc: Michael D Kinney
Cc:
I apologize as I think I mislead you on this. I think we can only remove
this operation for the builds using the container. I believe Windows
builds will still require this step for the time being. The Windows
pipeline on your PR is currently failing to find cspell. Sorry for not
being clear on
tform level if they need it.
One additional change I would like, but will not hold my review on is to
remove the "gcc__linux" scopes from PlatformBuild.py and
CISettings.py as they will no longer be used once the extdep files are
removed.
Reviewed-by: Chris Fernald
On 9/26/2022
Over-all I think this change is good to go. My only outstanding concern
would be around deleting these yaml files for the compilers. I fear
deleting them may break others work-flows and wonder if instead we
should update the python files to first check for the presence of the
prefix shell varia
There is probably value in having both if we want to support various
flavors of containers in the future, but yes adding a container option
to the template similar to vm_image.
Thanks,
Chris
On 9/21/2022 1:26 AM, Gerd Hoffmann wrote:
On Tue, Sep 20, 2022 at 01:01:04PM -0700, Chris Fernald
('${{ parameters.useIncludedPython }}', 'true'))
Chris Fernald
Microsoft
On 9/20/2022 7:45 AM, Oliver Steffen wrote:
Use the Python supplied by the container image.
Signed-off-by: Oliver Steffen
---
.azurepipelines/templates/platform-build-run-steps.yml | 1 +
.azurepipelines/templat
tool chain. Additionally, this would give consistency between the
platform and PR templates which currently make opposite assumption about
consumer vs template determining the container image.
Chris Fernald
Microsoft
On 9/20/2022 7:45 AM, Oliver Steffen wrote:
Run all Linux based jobs in a
12 matches
Mail list logo
