There is probably value in having both if we want to support various flavors of containers in the future, but yes adding a container option to the template similar to vm_image.

Thanks,
Chris

On 9/21/2022 1:26 AM, Gerd Hoffmann wrote:
On Tue, Sep 20, 2022 at 01:01:04PM -0700, Chris Fernald wrote:
Similar to my comment about the assumption in use of python, I believe the
container should be determined and passed in as a parameter from the top
level pipeline file rather then relying on tool chain tag. This lets the
templates take action on being containerized rather then assuming the tool
chain. Additionally, this would give consistency between the platform and PR
templates which currently make opposite assumption about consumer vs
template determining the container image.

i.e. update .azurepipelines/Ubuntu-GCC5.yml and replace "vm_image: ..."
with "container: ..."?

take care,
   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94095): https://edk2.groups.io/g/devel/message/94095
Mute This Topic: https://groups.io/mt/93805168/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to